3087 Commits (aa5707b8891119741baae98cf7b51a00c0f99438)

Author	SHA1	Message	Date
Benjamin Ford	aa5707b889	ARI: Added new functionality to load a single module. ... An http request can be sent to load an Asterisk module. If the module can not be loaded or is loaded already, an error response will be returned. The command curl -v -u user:pass -X POST 'http://localhost:8088/ari /asterisk/modules/{moduleName}'" (or something similar, depending on configuration) can be run in the terminal to access this new functionality. For more information, see: https://wiki.asterisk.org/wiki.display/~bford/Asterisk+ARI+Resource * Added new ARI functionality * Asterisk modules can be loaded through http requests ASTERISK-25173 Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33	10 years ago
Benjamin Ford	6a764db370	ARI: Added new functionality to get information on a single module. ... An http request can be sent to retrieve information on a single module, including the resource name, description, use count, status, and support level. The command "curl -v -u user:pass -X GET 'http://localhost:8088/ari /asterisk/modules/{moduleName}'" (or something similar, depending on configuration) can be run in the terminal to access this new functionality. For more information, see: https://wiki.asterisk.org/wiki.display/~bford/Asterisk+ARI+Resource * Added new ARI functionality * Information on a single module can now be retrieved ASTERISK-25173 Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463	10 years ago
Joshua Colp	61661f3f7d	Merge "res/res_sorcery_astdb: Add a debugging message for when retrieval by ID fails"	10 years ago
Joshua Colp	677bbeb41e	Merge "res/res_pjsip_outbound_registration: Fix WARNING message"	10 years ago
Matt Jordan	e64e586900	res/res_sorcery_astdb: Add a debugging message for when retrieval by ID fails ... Having a debug message tell us that we attempted to look up an item but failed is nice in circumstances when it isn't clear if the wizard was queried correctly or not. Change-Id: I2600c3bbea87f252196358f62e73f4c7da8632f7	10 years ago
Matt Jordan	7c14dfdc61	res/res_pjsip_outbound_registration: Fix WARNING message ... Newlines are nice. Change-Id: Icf0d915db02882e47cd9077ed9009f5d44140d42	10 years ago
Matt Jordan	3e286e6b51	res_pjsip/configuration: Fix a variety of default value problems ... This patch fixes some bad default value handling in the following settings: * The 'message_context' and 'accountcode' settings are not mandatory. As such, we can allow their stringfield values to be empty. * The 'media_encryption' setting applies a default value of 'none' to the setting, which it then can't parse or understand. Since the value is documented to be 'no', this will now apply that as the default value. Change-Id: Ib9be7f97a7a5b9bc7aee868edf5acf38774cff83	10 years ago
Benjamin Ford	1b7760a8aa	ARI: Added new functionality to get all module information. ... An http request can be sent to retrieve a list of all existing modules, including the resource name, description, use count, status, and support level. The command "curl -v -u user:pass -X GET 'http://localhost:8088/ari/ asterisk/modules" (or something similar, depending on configuration) can be run in the terminal to access this new functionality. For more information, see: https://wiki.asterisk.org/wiki.display/~bford/Asterisk+ARI+Resource * Added new ARI functionality * Information on modules can now be retrieved Change-Id: I63cbbf0ec0c3544cc45ed2a588dceabe91c5e0b0	10 years ago
Joshua Colp	9276415f65	res_rtp_asterisk: Ensure DTLS timeout timer is -1 if DTLS is not used. ... This change fixes a bug where the DTLS timeout timer would be initialized to 0 if DTLS was not used for an RTP session. ASTERISK-25103 Change-Id: If8d26bb054f1d300838850da5b8db9044c2fe2ac	10 years ago
Matt Jordan	70c777146e	Merge "res_pjsip_mwi.c: Use safer loop coding in mwi_subscription_mailboxes_str()."	10 years ago
Matt Jordan	8cd8d87479	Merge "res_pjsip_mwi.c: Fix MWI subscription memory corruption crash."	10 years ago
Joshua Colp	785aa18a23	Merge "PJSIP XML, XPIDF: Fix buffer size overwrite memory corruption error."	10 years ago
Joshua Colp	d173d9692a	Merge topic 'res_pjsip_mwi_cleanups' ... * changes: res_pjsip_mwi.c: Eliminate a simple RAII_VAR. res_pjsip_mwi.c: Fix mid-line log message line breaks.	10 years ago
Joshua Colp	78ff4a2a4a	Merge "PJSIP FAX: Fix T.38 automatic reject timer NULL channel pointer dereferences."	10 years ago
Joshua Colp	ff40a643eb	Merge "res_pjsip_t38.c: Fix always false if test."	10 years ago
Joshua Colp	20297252ed	Merge "res/res_http_websocket: Don't send HTTP response fragmented."	10 years ago
Joshua Colp	5717340ab3	res_rtp_asterisk: Prevent simultaneous access to DTLS SSL context. ... This change moves logic for setting up the DTLS SSL contexts to when the SDP is done being processed instead of when ICE negotiation completes. It also stops handshakes from being initiated when we are acting as a server. Manipulating the SSL context when ICE negotiation has completed is problematic as the SSL context is not protected and if acting as a client the remote side may have started DTLS negotiation already. The retransmission timeout timer code has also been split up and simplified some. Both RTP and RTCP now have their own timers and the points at which the timer is stopped and started is now more specific. When a packet is sent the timer is started. When a response is received but before it is processed the timer is stopped. This provides a guarantee that the timeout is not occurring while the response is processed. ASTERISK-22805 #close ASTERISK-24550 #close ASTERISK-24651 #close ASTERISK-24832 #close ASTERISK-25103 #close ASTERISK-25127 #close Change-Id: Ib75ea2546f29d6efc3d2d37c58df6986c7bd9b91	10 years ago
Richard Mudgett	189841ddb7	res_pjsip_mwi.c: Fix MWI subscription memory corruption crash. ... MWI subscriptions can crash or corrupt memory when using the subscription datastore to access the MWI subscription object because the datastore is not holding a reference to the object. * Give the subscription datastore a ref to the MWI subscription object. It is unfortunate that the ref causes a circular ref chain that must be explicitly broken to allow the memory to get released. The loop is broken when the subscription is shutdown and if the subscription setup fails. ASTERISK-25168 #close Reported by: Carl Fortin Change-Id: Ice4fa823f138ff10a6c74d280699c41a82836d4f	10 years ago
Richard Mudgett	7cd99be534	PJSIP XML, XPIDF: Fix buffer size overwrite memory corruption error. ... When res_pjsip body generator modules were generating XML or XPIDF response bodies, there was a chance that the generated body would be the exact size of the supplied buffer. Adding the nul string terminator would then write beyond the end of the buffer and potentially corrupt memory. * Fix MALLOC_DEBUG high fence violations caused by adding a nul string terminator on the end of a buffer for XML or XPIDF response bodies. * Made calls to pj_xml_print() safer if the XML prolog is requested. Due to a bug in pjproject, the return value could be -1 _or_ AST_PJSIP_XML_PROLOG_LEN if the supplied buffer is not large enough. * Updated the doxygen comment of AST_PJSIP_XML_PROLOG_LEN to describe the return value of pj_xml_print() when the supplied buffer is not large enough. ASTERISK-25168 Reported by: Carl Fortin Change-Id: Id70e1d373a6a2b2bd9e678b5cbc5e55b308981de	10 years ago
Richard Mudgett	792ed7ce93	PJSIP FAX: Fix T.38 automatic reject timer NULL channel pointer dereferences. ... When a caller calls a FAX number and then hangs up right after the call is answered then the T.38 re-INVITE automatic reject timer may still be running after the channel goes away. * Added session NULL channel checks on the code paths that get executed by t38_automatic_reject() to prevent a crash when the T.38 re-INVITE automatic reject timer expires. ASTERISK-25168 Reported by: Carl Fortin Change-Id: I07b6cd23815aedce5044f8f32543779e2f7a2403	10 years ago
Richard Mudgett	030e8339dd	res_pjsip_mwi.c: Use safer loop coding in mwi_subscription_mailboxes_str(). ... Change-Id: I6f39d809a6d1b47b35bb32b298f5a12f35d6f907	10 years ago
Richard Mudgett	453d7b8d69	res_pjsip_mwi.c: Eliminate a simple RAII_VAR. ... Change-Id: Ib1843f81e826a6c760c424c88eb70c350d9d61da	10 years ago
Richard Mudgett	786c6d42ef	res_pjsip_mwi.c: Fix mid-line log message line breaks. ... * Add create_mwi_subscriptions_for_endpoint() doxygen comment. Change-Id: I3c3f921f4ec749fb65b62d2f6fa0d4d1888b94e2	10 years ago
Richard Mudgett	1b91094edd	res_pjsip_t38.c: Fix always false if test. ... Calling t38_change_state() sets the t38 state so it makes little sense to then check the state right after the call for something else. * Made the code in t38_interpret_parameters() reject or exit T.38 mode as intended but not implemented. Change-Id: Ib281263a6ed44da9448132c4e6df1e183b8a3df2	10 years ago
Mark Michelson	3cdbe696a3	Merge "res_pjsip: Failover when server is not available"	10 years ago
Kevin Harwell	74135c8efa	res_pjsip: Failover when server is not available ... Previously Asterisk did not properly failover to the next resolved DNS address when a endpoint could not be reached. With this patch, and while using res_pjsip, SIP requests (both in/out of dialog) now attempt to use the next address in the list of resolved addresses until a proper response is received or no more addresses are left. ASTERISK-25076 #close Reported by: Joshua Colp Change-Id: Ief14f4ebd82474881f72f4538f4577f30af2a764	10 years ago
Joshua Colp	38a3c27a09	res_sorcery_memory_cache: Execute stale unit test last. ... In Jenkins there is currently a sporadic test failure of a variable number of sorcery memory cache unit tests. I have not been able to reproduce this on the build agents themselves or on my development machine. My working theory is that the stale unit test is causing a sorcery instance to persist longer than expected, causing subsequent tests to fail when setting up and initializing the next sorcery instance. To see if this is the case this change moves the stale unit test to execute last so no subsequent unit tests can have issues initializing their sorcery instance. Change-Id: Ifd6550a949613be774b75fa5db12c02110f82c4a	10 years ago
Joshua Colp	f35a4b8525	res/res_http_websocket: Don't send HTTP response fragmented. ... This change makes it so that when accepting a WebSocket connection the HTTP response is sent as one packet instead of fragmented. Browsers don't like it when you send it fragmented. ASTERISK-25103 Change-Id: I9b82c4ec2949b0bce692ad0bf6f7cea9709e7f69	10 years ago
Walter Doekes	3fab8212e3	res_timing: Don't close FD 0 when out of open files. ... This fixes so a failure to get a timer file descriptor does not cascade to closing FD 0. On error, both res_timing_kqueue and res_timing_timerfd would call the destructor before setting the file handle. The file handle had been initialized to 0, causing FD 0 to be closed. This in turn, resulted in floods of "CLI>" messages and an unusable terminal. ASTERISK-19277 #close Reported by: Barry Chern For the master branch, this was already fixed. This patch only ensures that we do not attempt to close a negative file descriptor. Change-Id: I147d7e33726c6e5a2751928d56561494f5800350	10 years ago
Joshua Colp	c12ace3ab3	Merge "res_sorcery_realtime: Fix leak of sorcery object type."	10 years ago
Mark Michelson	58d18324f0	res_sorcery_realtime: Fix leak of sorcery object type. ... This prevents a leak of a sorcery object type when realtime sorcery objects are retrieved by fields or when multiple objects are retrieved. The extent of this leak is that sorcery object types would be leaked. These are allocated whenever an object type is registered with sorcery, meaning that on module shutdown, these objects would be leaked. This could be problematic if many reloads were performed, but it is not as severe as if every sorcery object retrieved from realtime were being leaked. ASTERISK-25165 #close Reported by Corey Farrell Change-Id: I625c3b50eee4576670b7eeb013c81ad043b4b4f8	10 years ago
Matt Jordan	598a5f0d15	Merge "res_pjsip_nat: Adjust when contact should be rewritten."	10 years ago
Matt Jordan	80d97290bb	res/res_corosync: Always decline module load, instead of failing ... Returns a 'failure' from the module load routine indicates to Asterisk that it should abort loading completely. This is rarely - in fact, really, never - a good option. Aborting load of Asterisk from a dynamic module implies that the core, and the rest of the dynamic modules, don't matter: we should abandon all processing. res_corosync is really not that important. This patch updates the module such that, if it fails to load, it politely declines (emitting ERROR messages along the way), and allows Asterisk to continue to function. Note that this issue was keeping Asterisk unit tests from running on certain build agents. Change-Id: I252249e81fb9b1a68e0da873f54f47e21d648f0f	10 years ago
Mark Michelson	e18b22a806	res_pjsip_nat: Adjust when contact should be rewritten. ... A previous change made the contact only get rewritten if the dialog's route set was not marked frozen. Unfortunately, while the intent of this is correct, the dialog's route set actually gets marked as frozen earlier than expected, especially for UAS dialogs. Instead, the idea is that the contact needs to not be rewritten if there is a pre-existing route set on the dialog. This is now accomplished by checking the dialog's route set list instead of checking if the route set is frozen. Doing this causes some broken tests to begin passing again. ASTERISK-25196 Reported by Mark Michelson Change-Id: I525ab251fd40a52ede327a52a2810a56deb0529e	10 years ago
Richard Mudgett	99b1aa6d26	res_pjsip_outbound_registration.c: Add a serializer shutdown group. ... The client_state objects contain a serializer used to send the outbound REGISTER messages. Once all those message transactions are complete then the module can shutdown. ASTERISK-24907 #close Reported by: Kevin Harwell Change-Id: Ibb2fe558f98190f2a06da830e0fadfa25516f547	10 years ago
Matt Jordan	c0194b55b5	Merge "threadpool, res_pjsip: Add serializer group shutdown API calls."	10 years ago
Matt Jordan	8c1161a268	Merge "res_pjsip_outbound_registration.c: Fix handle_client_state_destruction() refs"	10 years ago
Matt Jordan	4208fe6ba7	Merge "res_pjsip_outbound_registration.c: Use ast_sorcery_object_unregister() API"	10 years ago
Matt Jordan	d568177d7d	Merge "res_pjsip_refer: Prevent sending duplicate headers."	10 years ago
Matt Jordan	8a9628dce5	Merge "res_pjsip_outbound_registration.c: Reorder load_module() and unload_module()."	10 years ago
Matt Jordan	05dbfedb43	Merge "res_pjsip_nat: Rewrite route set when required."	10 years ago
Mark Michelson	f536e9b59c	res_pjsip_refer: Prevent sending duplicate headers. ... res_pjsip_refer will attempt to add Referred-By or Replaces headers to outbound INVITEs at times. If the INVITE gets challenged for authentication, then we will resend the INVITE. Prior to this patch, the Referred-By or Replaces header would be re-added to the outbound INVITE, resulting in duplicated headers. ASTERISK-25204 #close Reported by Mark Michelson Change-Id: I59fb5c08b4d253c0dba9ee3d3950b5025358222d	10 years ago
Mark Michelson	700606a659	res_pjsip_nat: Rewrite route set when required. ... When performing some provider testing, the rewrite_contact option was interfering with proper construction of a route set when sending an ACK after receiving a 200 OK response to an INVITE. The initial INVITE was sent to address sip:foo. The 200 OK had a Contact header with URI sip:bar. In addition, the 200 OK had Record-Route headers for sip:baz and sip:foo, in that order. Since the Record-Route headers had the lr parameter, the result should have been: * Set R-URI of the ACK to sip:bar. * Add Route headers for sip:foo and sip:baz, in that order. However, the rewrite_contact option resulted in our rewriting the Contact header on the 200 OK to sip:foo. The result was: * R-URI remained sip:foo. * We added Route headers for sip:foo and sip:baz, in that order. The result was that sip:bar was not indicated in the ACK at all, so the far end never received our ACK. The call eventually dropped. The intention of rewrite_contact is to rewrite the most immediate destination of our SIP request to be the same address on which we received a request or response. In the case of processing a SIP response with Record-Route headers, this means that instead of rewriting the Contact header, we should instead rewrite the bottom-most Record-Route header. In the case of processing a SIP request with Record-Route headers, this means we rewrite the top-most Record-route header. Like when we rewrite the Contact header, we also ensure to update the dialog's route set if it exists. ASTERISK-25196 #close Reported by Mark Michelson Change-Id: I9702157c3603a2d0bd8a8215ac27564d366b666f	10 years ago
Richard Mudgett	af4ae3095e	threadpool, res_pjsip: Add serializer group shutdown API calls. ... A module trying to unload needs to wait for all serializers it creates and uses to complete processing before unloading. ASTERISK-24907 Reported by: Kevin Harwell Change-Id: I8c80b90f2f82754e8dbb02ddf3c9121e5e966059	10 years ago
Richard Mudgett	4c133d81cd	res_pjsip_outbound_registration.c: Fix handle_client_state_destruction() refs ... * handle_client_state_destruction() must always be passed a ref to client_state because it will always unref client_state. handle_registration_response() was not passing a client_state ref. * Made the final un-REGISTER message get sent normally using the pjproject register control structure in handle_client_state_destruction(). The previous code attempted to short circuit the response handling for the module to unload. That doesn't work for a couple reasons. One, pjsip_regc_send() may call the registered callback before it returns and unbalance the client_state ref count. Two, the registered callback handles any authentication for the un-REGISTER message. * Made the distinction between internal registration state and external registration status with sip_outbound_registration_status_str(). This is necessary to avoid altering documented AMI messages with internal changes. * Removed references to client_state->client outside of the serializer thread. When handle_client_state_destruction() destroys the pjproject register control structure that memory is freed and cannot be referenced anymore. These accesses were to provide information for debug and off-nominal warning messages. * In sip_outbound_registration_timer_cb() you should not access entry->id after unrefing client_state because the passed in entry is normally pointing to the timer entry in the client_state object. ASTERISK-24907 Reported by: Kevin Harwell Change-Id: Ia7b446d8644b6b4550ef5bea49527671de65183f	10 years ago
Richard Mudgett	dc63377c60	res_pjsip_outbound_registration.c: Use ast_sorcery_object_unregister() API ... The sorcery pjsip 'registration' config object needs to be destroyed on module unload. Otherwise, a reload of res_pjsip could try to use callbacks for a previously unloaded instance of the module provided by ast_sorcery_object_register() or one of the variants. Also, if res_pjsip_outbound_registration were subsequently reloaded, the sorcery config field objects would be registered in sorcery twice. ASTERISK-24907 Reported by: Kevin Harwell Change-Id: I304fad13dece2604af48353f6c6d9d5c7b064697	10 years ago
Richard Mudgett	77ff7325a2	res_pjsip_outbound_registration.c: Reorder load_module() and unload_module(). ... It is best if the loading code creates and initializes the module's infrastructure before letting the system know of its existence. The unloading code needs to reverse the actions of the loading code and in the reverse order. ASTERISK-24907 Reported by: Kevin Harwell Change-Id: I5d151383e9787b5b60aa5e1627b10f040acdded4	10 years ago
Mark Michelson	3f1fe83633	Merge "res_pjsip_mwi: Set up unsolicited MWI upon registration."	10 years ago
Richard Mudgett	71a4d1a033	Unit tests: Fix more unit test description strings. ... Analyzing the code shows that the unit test summary and description strings should not end with a new-line character. Where these strings are used in the code a new-line is provided for output. Change-Id: I2f4f37988ec363c8d1c5077a2fc8ca841c5cd30c	10 years ago
Richard Mudgett	af66b0f3f7	res_pjsip_outbound_registration.c: Add missing line endings to CLI commands ... Change-Id: I39ae612746d892d2dbe86f3ff2d7027fa1da57f7	10 years ago