asterisk

Commit Graph

Author	SHA1	Message	Date
Jeff Peeler	550b71bbd8	Merged revisions 147146 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r147146 \| jpeeler \| 2008-10-07 11:04:45 -0500 (Tue, 07 Oct 2008) \| 3 lines Explicitly setting these fields to NULL was done because I wasn't sure if they would be NULL otherwise. Since they will be set automatically, removing. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@147147 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	595d37e746	Merged revisions 146923 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146923 \| jpeeler \| 2008-10-06 18:08:21 -0500 (Mon, 06 Oct 2008) \| 3 lines Similar to r143204, masquerade the channel in the case of Park being called from AGI. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146924 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	cd1a30c6c7	Merged revisions 146883 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146883 \| jpeeler \| 2008-10-06 17:26:25 -0500 (Mon, 06 Oct 2008) \| 12 lines This commit squashes together three commits because the wrong approach was originally used. (One of the commits was only one line.) 1) r143204: The main change here was to masquerade the channel if the channel that was to be parked was running a PBX on it. The PBX thread can then maintain full control of the channel (the zombie) as it expects to while allowing the parking thread full control of the real (parked) channel. 2) r143270: Changed park_call_full to hold the parkinglot lock a little longer, which protects the parkeduser struct from being freed out from underneath. Made sure that the parking extension is added to the parking context while holding the lock thereby ensuring that there are no spurious warnings from removal attempts when a hangup occurs while the parking lot is being announced. 3) r143475: (the one liner) compare peer and chan instead of looking at the parked user (pu), which could have possibly already have been freed by the parking thread ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146886 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	2fb8519c52	Merged revisions 146877 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146877 \| jpeeler \| 2008-10-06 17:08:40 -0500 (Mon, 06 Oct 2008) \| 1 line fix some comment placement ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146878 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	2917e91db4	Merged revisions 146875 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146875 \| jpeeler \| 2008-10-06 17:03:01 -0500 (Mon, 06 Oct 2008) \| 5 lines Explicitly set args in park_call_exec NULL so in the case of no options being passed in, there is no garbage attempted to be used. Also, do not set args to unknown value again if there are no options passed in. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146876 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	2e5cc80ba4	Merged revisions 146242 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146242 \| jpeeler \| 2008-10-03 17:40:59 -0500 (Fri, 03 Oct 2008) \| 1 line remove superfluous reference counting operations in manage_parkinglot since ao2_interator_next increments the ref count automatically ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146243 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	c48c50a814	Merged revisions 146198 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146198 \| seanbright \| 2008-10-03 18:10:18 -0400 (Fri, 03 Oct 2008) \| 7 lines Resolve a subtle bug where we would never successfully be able to get the first item in the CLI entry list. This was preventing '!' from showing up in either 'help' or in tab completion. (closes issue #13578) Reported by: mvanbaak ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146200 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	10258dd023	Merged revisions 145606 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145606 \| mmichelson \| 2008-10-01 17:23:50 -0500 (Wed, 01 Oct 2008) \| 11 lines Okay, this should really do it now. While I did manage to fix blind transfers with my last commit here, I also caused an unwanted side-effect. That is, only the first priority of the 'h' extension would be executed when a blind transfer occurred instead of all priorities. Essentially, my last commit corrected the return value of ast_bridge_call. However, the implementation still was not 100% correct. Now it is. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@145609 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	52b6762417	Merged revisions 145579 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145579 \| mmichelson \| 2008-10-01 16:33:11 -0500 (Wed, 01 Oct 2008) \| 4 lines if (!(x) == 0) is the same as if (x). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@145584 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	a7da5b2e76	Merged revisions 145553 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145553 \| mmichelson \| 2008-10-01 16:06:26 -0500 (Wed, 01 Oct 2008) \| 13 lines The logic surrounding the return value of ast_spawn_extension within ast_bridge_call was reversed. This problem was observed when a blind transfer placed from the callee channel of a test call failed. While the problem I am solving here is exactly the same as what was reported in issue #13584, the difference is that this fix I am applying is trunk-only. Issue #13584 was reported against the 1.4 branch, and my tests of 1.4's blind transfers appear to work fine. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@145557 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	bc5b69d250	Merged revisions 144949-144951 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144949 \| kpfleming \| 2008-09-27 10:52:56 -0500 (Sat, 27 Sep 2008) \| 17 lines Merged revisions 144924-144925 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144924 \| kpfleming \| 2008-09-27 10:00:48 -0500 (Sat, 27 Sep 2008) \| 6 lines improve header inclusion process in a few small ways: - it is no longer necessary to forcibly include asterisk/autoconfig.h; every module already includes asterisk.h as its first header (even before system headers), which serves the same purpose - astmm.h is now included by asterisk.h when needed, instead of being forced by the Makefile; this means external modules will build properly against installed headers with MALLOC_DEBUG enabled - simplify the usage of some of these headers in the AEL-related stuff in the utils directory ........ r144925 \| kpfleming \| 2008-09-27 10:13:30 -0500 (Sat, 27 Sep 2008) \| 2 lines fix some minor issues with rev 144924 ........ ................ r144950 \| kpfleming \| 2008-09-27 11:10:33 -0500 (Sat, 27 Sep 2008) \| 2 lines fix bugs caused by r144949 when MALLOC_DEBUG is defined ................ r144951 \| kpfleming \| 2008-09-27 11:17:43 -0500 (Sat, 27 Sep 2008) \| 1 line remove incorrect comment ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@144993 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	59d9a004e9	Merged revisions 144678 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144678 \| murf \| 2008-09-26 11:50:35 -0600 (Fri, 26 Sep 2008) \| 20 lines Merged revisions 144677 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144677 \| murf \| 2008-09-26 11:47:13 -0600 (Fri, 26 Sep 2008) \| 12 lines (closes issue #13563) Reported by: mnicholson Patches: found1.diff uploaded by mnicholson (license 96) This patch was mainly meant to apply to trunk and 1.6.x, but I'm applying it to 1.4 also, which should be a perfectly harmless fix to the vast majority of users who are not using external switches, but the few who might be affected will not have to go to the pain of filing a bug report. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@144680 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	6f1745168e	Merged revisions 144569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r144569 \| murf \| 2008-09-25 16:21:28 -0600 (Thu, 25 Sep 2008) \| 14 lines (closes issue #13557) Reported by: nickpeirson The user attached a patch, but the license is not yet recorded. I took the liberty of finding and replacing ALL index() calls with strchr() calls, and that involves more than just main/pbx.c; chan_oss, app_playback, func_cut also had calls to index(), and I changed them out. 1.4 had no references to index() at all. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@144578 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	98d269e5cd	Merged revisions 144067 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144067 \| murf \| 2008-09-23 10:52:32 -0600 (Tue, 23 Sep 2008) \| 37 lines Merged revisions 144066 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144066 \| murf \| 2008-09-23 10:41:49 -0600 (Tue, 23 Sep 2008) \| 29 lines (closes issue #13489) Reported by: DougUDI Tested by: murf (closes issue #13490) Reported by: seanbright Tested by: murf (closes issue #13467) Reported by: edantie Tested by: murf, edantie, DougUDI This crash happens because we are unsafely handling old pointers. The channel whose cdr is being handled, has been hung up and destroyed already. I reorganized the code a bit, and tried not to lose the fork-cdr-chain concepts of the previous code. I now verify that the 'previous' channel (the channel we had when the bridge was started), still exists, by looking it up by name in the channel list. I also do not try to reset the CDR's of channels involved in bridges. Testing shows it solves the crash problem, and should not negatively impact previous fixes involving CDR's generated during/after blind transfers. (The reason we need to reset the CDR's on the "beginning" channels in the first place). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@144069 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	89de83535b	Merged revisions 143340 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r143340 \| mmichelson \| 2008-09-17 13:26:35 -0500 (Wed, 17 Sep 2008) \| 14 lines Merged revisions 143337 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r143337 \| mmichelson \| 2008-09-17 13:24:15 -0500 (Wed, 17 Sep 2008) \| 6 lines Allow for "G.729" if offered in an SDP even though it is not RFC 3551 compliant. Some Cisco switches will send this in an SDP, and it doesn't hurt to be able to accept this. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@143349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	8e7ad44ba5	Merged revisions 142748 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r142748 \| tilghman \| 2008-09-12 11:54:44 -0500 (Fri, 12 Sep 2008) \| 3 lines When checking for an encoded character, make sure the string isn't blank, first. (Closes issue #13470) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	7aede207ba	Merged revisions 142741 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142741 \| tilghman \| 2008-09-12 11:29:01 -0500 (Fri, 12 Sep 2008) \| 12 lines Merged revisions 142740 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142740 \| tilghman \| 2008-09-12 11:27:32 -0500 (Fri, 12 Sep 2008) \| 4 lines Don't return a free'd pointer, when a file cannot be opened. (closes issue #13462) Reported by: wackysalut ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142743 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	bc73329607	Merged revisions 142676 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142676 \| murf \| 2008-09-11 22:50:48 -0600 (Thu, 11 Sep 2008) \| 40 lines Merged revisions 142675 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142675 \| murf \| 2008-09-11 22:29:34 -0600 (Thu, 11 Sep 2008) \| 29 lines Tested by: sergee, murf, chris-mac, andrew, KNK This is a "second attempt" to restore the previous "endbeforeh" behavior in 1.4 and up. In order to capture information concerning all the legs of transfers in all their infinite combinations, I was forced to this particular solution by a chain of logical necessities, the first being that I was not allowed to rewrite the CDR mechanism from the ground up! This change basically leaves the original machinery alone, which allows IVR and local channel type situations to generate CDR's as normal, but a channel flag can be set to suppress the normal running of the h exten. That flag would be set by the code that runs the h exten from the ast_bridge_call routine, to prevent the h exten from being run twice. Also, a flag in the ast_bridge_config struct passed into ast_bridge_call can be used to suppress the running of the h exten in that routine. This would happen, for instance, if you use the 'g' option in the Dial app. Running this routine 'early' allows not only the CDR() func to be used in the h extension for reading CDR variables, but also allows them to be modified before the CDR is posted to the backends. While I dearly hope that this patch overcomes all problems, and introduces no new problems, reality suggests that surely someone will have problems. In this case, please re-open 13251 (or 13289), and we'll see if we can't fix any remaining issues. ** trunk note: some code to suppress the h exten being run from app_queue was added; for the 'continue' option available only in trunk/1.6.x. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142678 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a026a6583e	Merged revisions 142576 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142576 \| murf \| 2008-09-11 17:12:53 -0600 (Thu, 11 Sep 2008) \| 28 lines Merged revisions 142575 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142575 \| murf \| 2008-09-11 16:55:49 -0600 (Thu, 11 Sep 2008) \| 20 lines (closes issue #13364) Reported by: mdu113 Well, fundamentally, the problems revealed in 13364 are because of the ForkCDR call that is done before the dial. When the bridge is in place, it's dealing with the first (and wrong) cdr in the list. So, I wrote a little func to zip down to the first non-locked cdr in the chain, and thru-out the ast_bridge_call, these results are used instead of raw chan->cdr and peer->cdr pointers. This shouldn't affect anyone who isn't forking cdrs before a dial, and should correct the cdr's of those that do. So, this change ends up correcting the dstchannel and userfield; the disposition was fixed by a previous patch, it was OK coming into this problem. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142632 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	d4f3056049	Merged revisions 142475 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142475 \| murf \| 2008-09-10 16:11:27 -0600 (Wed, 10 Sep 2008) \| 38 lines Merged revisions 142474 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142474 \| murf \| 2008-09-10 15:58:17 -0600 (Wed, 10 Sep 2008) \| 30 lines (closes issue #12318) Reported by: krtorio I made a small change to the code that handles local channel situations. In that code, I copy the answer time from the peer cdr, to the bridge_cdr, but I wasn't also copying the disposition from the peer cdr. So, Now I copy the disposition, and I've tested against these cases: 1. phone 1 never answers the phone; no cdr is generated at all. this should show up as a manager command failure or something. 2. phone 2 never answers. CDR is generated, says NO ANSWER 3. phone 2 is busy. CDR is generated, says BUSY 4. phone 2 answers: CDR is generated, times are correct; disposition is ANSWERED, which is correct. The start time is the time that the manager dialed the first phone. The answer time is the time the second phone picks up. I purposely left the cid and src fields blank; since this call really originates from the manager, there is no 'easy' data to put in these fields. If you feel strongly that these fields should be filled in, re-open this bug and I'll dig further. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142478 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ca6ed07d72	Merged revisions 142355 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142355 \| russell \| 2008-09-10 11:41:55 -0500 (Wed, 10 Sep 2008) \| 15 lines Merged revisions 142354 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142354 \| russell \| 2008-09-10 11:39:53 -0500 (Wed, 10 Sep 2008) \| 7 lines It is a normal situation that a task gets put in the scheduler that should run as soon as possible. Accept "0" as an acceptable time to run, and also treat negative as "run now", and don't print a debug message about it. (inspired by a message asking about the "request to schedule in the past" debug message on the -dev list) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142357 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e13c43f1a6	Merged revisions 142064 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142064 \| russell \| 2008-09-09 10:44:10 -0500 (Tue, 09 Sep 2008) \| 13 lines Merged revisions 142063 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142063 \| russell \| 2008-09-09 10:40:24 -0500 (Tue, 09 Sep 2008) \| 5 lines Ensure that the stored CDR reference is still valid after the bridge before poking at it. Also, keep the channel locked while messing with this CDR. (fixes crashes reported in issue #13409) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@142066 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b55ecb6aea	Merged revisions 141807 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141807 \| russell \| 2008-09-08 16:05:01 -0500 (Mon, 08 Sep 2008) \| 15 lines Merged revisions 141806 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141806 \| russell \| 2008-09-08 16:02:36 -0500 (Mon, 08 Sep 2008) \| 7 lines When doing an async goto, detect if the channel is already in the middle of a masquerade. This can happen when chan_local is trying to optimize itself out. If this happens, fail the async goto instead of bursting into flames. (closes issue #13435) Reported by: geoff2010 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141952 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	50c690fb59	Merged revisions 141949 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r141949 \| russell \| 2008-09-08 20:47:56 -0500 (Mon, 08 Sep 2008) \| 9 lines Modify ast_answer() to not hold the channel lock while calling ast_safe_sleep() or when calling ast_waitfor(). These are inappropriate times to hold the channel lock. This is what has caused "could not get the channel lock" messages from chan_sip and has likely caused a negative impact on performance results of SIP in Asterisk 1.6. Thanks to file for pointing out this section of code. (closes issue #13287) (closes issue #13115) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141951 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	aaff8a2a20	Merged revisions 141157 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141157 \| murf \| 2008-09-05 08:18:43 -0600 (Fri, 05 Sep 2008) \| 9 lines Merged revisions 141156 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141156 \| murf \| 2008-09-05 08:15:43 -0600 (Fri, 05 Sep 2008) \| 1 line A small change to prevent double-posting of CDR's; thanks to Daniel Ferrer for bringing it to our attention ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141159 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	2a02fcceff	Merged revisions 141039 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141039 \| jpeeler \| 2008-09-04 12:27:56 -0500 (Thu, 04 Sep 2008) \| 15 lines Merged revisions 141028 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141028 \| jpeeler \| 2008-09-04 12:00:29 -0500 (Thu, 04 Sep 2008) \| 7 lines (closes issue #11979) Fixes multiple parking problems: Crash when executing a park on an extension dialed by AGI due to not returning the proper return code. Crash when using a builtin feature that was a subset of a enabled dynamic feature. Crash due to always hanging up the peer despite the fact that the peer was supposed to be parked. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141042 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	09fe3752a5	Merged revisions 140824 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r140824 \| murf \| 2008-09-03 08:01:27 -0600 (Wed, 03 Sep 2008) \| 21 lines In these changes, I have added some explanation of changes to the Set and MSet apps, so people aren't so shocked and surprised when they upgrade from 1.4 to 1.6. Also, for the sake of those upgrading from 1.4 to 1.6 with AEL, I provide automatic support for the "old" way of using Set(), that still does the exact same old thing with quotes and backslashes and so on as 1.4 did, by having AEL compile in the use of MSet() instead of Set(), everywhere it inserts this code. But, if the app_set var is set to 1.6 or higher, it uses the "new", non-evaluative Set(). This only usually happens if the user manually inserts this into the asterisk.conf file, or runs the "make samples" command. (closes issue #13249) Reported by: dimas Patches: ael-MSet.diff uploaded by murf (license 17) Tested by: dimas, murf ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140886 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d01749ba43	Merged revisions 140817 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140817 \| russell \| 2008-09-03 08:26:43 -0500 (Wed, 03 Sep 2008) \| 12 lines Merged revisions 140816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140816 \| russell \| 2008-09-03 08:24:35 -0500 (Wed, 03 Sep 2008) \| 4 lines Don't freak out if the poll emulation receives NULL for the pollfds array (closes issue #13307) Reported by: jcovert ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140819 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	9f94f365a7	Merged revisions 140749 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140749 \| murf \| 2008-09-02 17:44:04 -0600 (Tue, 02 Sep 2008) \| 11 lines Merged revisions 140747 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140747 \| murf \| 2008-09-02 17:36:56 -0600 (Tue, 02 Sep 2008) \| 1 line I am turning the warnings generated in ast_cdr_free and post_cdr into verbose level 2 messages. Really, they matter little to end users. You either get the CDR's you wanted, or you don't, and it is a bug. For trunk, I am going one step further. These messages were pretty worthless even for debug, so I'm completely removing them. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	08146f95bc	Merged revisions 140692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140692 \| murf \| 2008-09-02 16:55:12 -0600 (Tue, 02 Sep 2008) \| 13 lines Merged revisions 140690 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140690 \| murf \| 2008-09-02 16:40:13 -0600 (Tue, 02 Sep 2008) \| 1 line After reconsidering, with respect to 13409, ast_cdr_detach should be OK, better in fact, than ast_cdr_free, which generates lots of useless warnings that will undoubtably generate complaints. Hmmm. It doesn't hush the useless warnings, but it does allow control of posting via the detach and post routines, for those possible situations, where you'd want to post single-channel cdrs. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140695 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	0c8172a97c	Merged revisions 140691 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140691 \| murf \| 2008-09-02 16:50:59 -0600 (Tue, 02 Sep 2008) \| 22 lines Merged revisions 140670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140670 \| murf \| 2008-09-02 16:15:57 -0600 (Tue, 02 Sep 2008) \| 14 lines (closes issue #13409) Reported by: tomaso Patches: asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by tomaso (license 564) I basically spent the day, verifying that this patch solves the problem, and doesn't hurt in non-problem cases. Why valgrind did not plainly reveal this leak absolutely mystifies and stuns me. Many, many thanks to tomaso for finding and providing the fix. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140693 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	f86752e905	Merged revisions 140491 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r140491 \| jpeeler \| 2008-08-29 12:53:32 -0500 (Fri, 29 Aug 2008) \| 2 lines Added the option s to the Park application which will silence the announcement of the parking space number. Also, fixes the bug of just clearing the flags instead of actually parsing the arguments to Park. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140492 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6ed6a5ae29	Merged revisions 140489 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140489 \| mmichelson \| 2008-08-29 12:47:17 -0500 (Fri, 29 Aug 2008) \| 30 lines Merged revisions 140488 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140488 \| mmichelson \| 2008-08-29 12:34:17 -0500 (Fri, 29 Aug 2008) \| 22 lines After working on the ao2_containers branch, I noticed something a bit strange. In all cases where we provide a callback function to ao2_container_alloc, the callback function would only return 0 or CMP_MATCH. After inspecting the ao2_callback() code carefully, I found that if you're only looking for one specific item, then you should return CMP_MATCH \| CMP_STOP. Otherwise, astobj2 will continue traversing the current bucket until the end searching for more matches. In cases like chan_iax2 where in 1.4, all the peers are shoved into a single bucket, this makes for potentially terrible performance since the entire bucket will be traversed even if the peer is one of the first ones come across in the bucket. All the changes I have made were for cases where the callback function defined was passed to ao2_container_alloc so that calls to ao2_find could find a unique instance of whatever object was being stored in the container. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140490 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	5b5666c301	Merged revisions 140433 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r140433 \| mmichelson \| 2008-08-29 11:24:37 -0500 (Fri, 29 Aug 2008) \| 10 lines Allow for video files to be opened as well as audio files. (closes issue #13372) Reported by: epicac Patches: 13372.patch uploaded by putnopvut (license 60) Tested by: epicac ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140435 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	f7d3198c30	Merged revisions 139928 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139928 \| jpeeler \| 2008-08-25 16:48:51 -0500 (Mon, 25 Aug 2008) \| 11 lines Merged revisions 139927 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139927 \| jpeeler \| 2008-08-25 16:47:33 -0500 (Mon, 25 Aug 2008) \| 3 lines Fix a typo I made. Lesson learned, apply the patch if one exists. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139929 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	dfe7bf451a	Merged revisions 139770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139770 \| murf \| 2008-08-25 09:54:18 -0600 (Mon, 25 Aug 2008) \| 17 lines Merged revisions 139764 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139764 \| murf \| 2008-08-25 09:33:14 -0600 (Mon, 25 Aug 2008) \| 9 lines This patch reverts the changes made via 139347, and 139635, as users are seeing adverse difference. I will un-close 13251. Back to the drawing board/ concept/ beginning/ whatever! ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139778 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	37d5dcdfa9	Merged revisions 139662 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139662 \| murf \| 2008-08-22 16:32:35 -0600 (Fri, 22 Aug 2008) \| 14 lines Merged revisions 139635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139635 \| murf \| 2008-08-22 16:24:02 -0600 (Fri, 22 Aug 2008) \| 6 lines I found some problems with the code I committed earlier, when I merged them into trunk, so I'm coming back to clean up. And, in the process, I found an error in the code I added to trunk and 1.6.x, that I'll fix using this patch also. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139674 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	41138ad333	Merged revisions 139627 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139627 \| murf \| 2008-08-22 16:03:13 -0600 (Fri, 22 Aug 2008) \| 59 lines Merged revisions 139347 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139347 \| murf \| 2008-08-21 17:03:50 -0600 (Thu, 21 Aug 2008) \| 47 lines (closes issue #13251) Reported by: sergee Tested by: murf THis is a bold move for a static release fix, but I wouldn't have made it if I didn't feel confident (at least a bit confident) that it wouldn't mess everyone up. The reasoning goes something like this: 1. We simply cannot do anything with CDR's at the current point (in pbx.c, after the __ast_pbx_run loop). It's way too late to have any affect on the CDRs. The CDR is already posted and gone, and the remnants have been cleared. 2. I was very much afraid that moving the running of the 'h' extension down into the bridge code (where it would be now practical to do it), would result in a lot more calls to the 'h' exten, so I implemented it as another exten under another name, but found, to my pleasant surprise, that there was a 1:1 correspondence to the running of the 'h' exten in the pbx_run loop, and the new spot at the end of the bridge. So, I ifdef'd out the current 'h' loop, and moved it into the bridge code. The only difference I can see is the stuff about the AST_PBX_KEEPALIVE, and hopefully, if this is still an important decision point, I can replicate it if there are complaints. To be perfectly honest, the KEEPALIVE situation is not totally clear to me, and how it relates to a post-bridge situation is less clear. I suspect the users will point out everything in total clarity if this steps on anyone's toes! 3. I temporarily swap the bridge_cdr into the channel before running the 'h' exten, which makes it possible for users to edit the cdr before it goes out the door. And, of course, with the endbeforehexten config var set, the users can also get at the billsec/duration vals. After the h exten finishes, the cdr is swapped back and processing continues as normal. Please, all who deal with CDR's, please test this version of Asterisk, and file bug reports as appropriate! ........ I also made a little fix to the app_dial's 'e' option, that is related to my updates. ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139629 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	2090a58d2e	Merged revisions 139624 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139624 \| jpeeler \| 2008-08-22 16:57:32 -0500 (Fri, 22 Aug 2008) \| 13 lines Merged revisions 139621 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139621 \| jpeeler \| 2008-08-22 16:36:13 -0500 (Fri, 22 Aug 2008) \| 5 lines (closes issue #13359) Reported by: Laureano Patches: originate_channel_check.patch uploaded by Laureano (license 265) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139625 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	13a4d48c7c	Merged revisions 139622 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r139622 \| jpeeler \| 2008-08-22 16:52:20 -0500 (Fri, 22 Aug 2008) \| 1 line remove extra comma typo ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139623 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	bb9dfd155c	Merged revisions 139558 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r139558 \| mmichelson \| 2008-08-22 15:02:35 -0500 (Fri, 22 Aug 2008) \| 9 lines Add missing unique id to ParkedCallGiveUp and ParkedCallTimeOut manager events (closes issue #13358) Reported by: srt Patches: 13358_parking_events.diff uploaded by srt (license 378) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139560 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	7907def3f4	Merged revisions 139083 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139083 \| murf \| 2008-08-20 11:25:07 -0600 (Wed, 20 Aug 2008) \| 20 lines Merged revisions 139074 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139074 \| murf \| 2008-08-20 11:14:55 -0600 (Wed, 20 Aug 2008) \| 12 lines (closes issue #13263) Reported by: brainy Tested by: murf The specialized reset routine is tromping on the flags field of the CDR. I made a change to not reset the DISABLED bit. This should get rid of this problem. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139106 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	7af40ac1a1	Merged revisions 138815 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138815 \| murf \| 2008-08-19 09:59:12 -0600 (Tue, 19 Aug 2008) \| 19 lines These changes are in regards to bug 13249, where users are being surprised by the changes made to the Set app in trunk/1.6.x, as they come from the 1.4 world. They are only bitten if they write their AEL dialplan in the 1.4 world, and then carry it over to a trunk/1.6.x installation where a "make samples" was executed, or where they hand-edited the asterisk.conf file and added the [compat] category with app_set = 1.6 (or higher). (this commit does not totally solve 13249, at least not yet) The change involves issueing a single warning while the AEL file is loading, if: 1. app_set is present in the config file, and set to 1.6 or higher. 2. there are double quotes in an assignment statement (eg x = "hi there";) 3. the warning was not already issued. The standalone app, aelparse, does not (yet) issue this warning. I'd have to have it read in the asterisk.conf file, and that's a bit of hassle. I'll add it if users request it, tho. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138853 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	c36bdfdf33	Merged revisions 138482 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138482 \| seanbright \| 2008-08-17 10:12:11 -0400 (Sun, 17 Aug 2008) \| 6 lines Move Uniqueid to the end of the event for those that rely on the position of the name/value pairs, pointed out by snuffy-home on #asterisk-commits. For those of you who rely on the position of name/value pairs in manager events... stop... that is why associative arrays were invented. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138498 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	b41cc8891a	Merged revisions 138479 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138479 \| seanbright \| 2008-08-17 09:51:08 -0400 (Sun, 17 Aug 2008) \| 7 lines Add Uniqueid header to ParkedCall manager event. (closes issue #13323) Reported by: srt Patches: 13323_unique_id_for_parkedcalls_event.diff uploaded by srt (license 378) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138481 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	9367e7b916	Merged revisions 138476 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138476 \| seanbright \| 2008-08-17 09:40:36 -0400 (Sun, 17 Aug 2008) \| 7 lines Add missing colons to RTCPReceived and RTCPSent manager events. (closes issue #13319) Reported by: srt Patches: 13319_rtcp_manager_event_headers.diff uploaded by srt (license 378) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138478 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	88d23d712e	Merged revisions 138409 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138409 \| tilghman \| 2008-08-16 07:52:06 -0500 (Sat, 16 Aug 2008) \| 3 lines Also make sure hinting won't crash on reload. (Closes issue #13312) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138411 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	cd60aadb5e	Merged revisions 138028 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r138028 \| russell \| 2008-08-15 10:09:46 -0500 (Fri, 15 Aug 2008) \| 17 lines Merged revisions 138027 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r138027 \| russell \| 2008-08-15 10:07:16 -0500 (Fri, 15 Aug 2008) \| 9 lines Ensure that when a hangup occurs in autoservice, that a hangup frame gets properly deferred to be read from the channel owner when it gets taken out of autoservice. (closes issue #12874) Reported by: dimas Patches: v1-12874.patch uploaded by dimas (license 88) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	f42b756512	Merged revisions 138148 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138148 \| tilghman \| 2008-08-15 14:36:11 -0500 (Fri, 15 Aug 2008) \| 2 lines Change free to ast_free_ptr, too ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138150 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	0ffc03dffc	Merged revisions 138124 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r138124 \| tilghman \| 2008-08-15 14:22:48 -0500 (Fri, 15 Aug 2008) \| 4 lines e->data can be NULL, so use the safe version of ast_strdup() (closes issue #13312) Reported by: pj ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138133 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

1 2 3 4 5 ...

1881 Commits (550b71bbd8009848124414520de2a75521bb5575)