asterisk

Commit Graph

Author	SHA1	Message	Date
Sean Bright	124fb94de6	Merged revisions 160170-160172 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r160170 \| seanbright \| 2008-12-01 18:08:24 -0500 (Mon, 01 Dec 2008) \| 1 line Pay attention to the return value of system(), even if we basically ignore it. ................ r160171 \| seanbright \| 2008-12-01 18:18:48 -0500 (Mon, 01 Dec 2008) \| 1 line Silence a build warning. (chan_phone.c:810: warning: value computed is not used) ................ r160172 \| seanbright \| 2008-12-01 18:37:49 -0500 (Mon, 01 Dec 2008) \| 10 lines Merged revisions 159976 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159976 \| mvanbaak \| 2008-12-01 11:08:36 -0500 (Mon, 01 Dec 2008) \| 3 lines Get rid of the useless format string and argument in the Bogus/ manager channelname. Noted by kpfleming and name Bogus/manager suggested by eliel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@160173 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Michiel van Baak	532d3d5dd2	Merged revisions 159898 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r159898 \| mvanbaak \| 2008-12-01 15:09:59 +0100 (Mon, 01 Dec 2008) \| 11 lines Merged revisions 159897 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159897 \| mvanbaak \| 2008-12-01 15:05:41 +0100 (Mon, 01 Dec 2008) \| 4 lines make manager compile on OpenBSD. The last (10th) argument to ast_channel_alloc here should be a pointer and NULL is not really a pointer. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@159974 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	2eb5c30a3a	Merged revisions 159818 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r159818 \| kpfleming \| 2008-11-29 11:57:39 -0600 (Sat, 29 Nov 2008) \| 18 lines incorporates r159808 from branches/1.4: ------------------------------------------------------------------------ r159808 \| kpfleming \| 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) \| 7 lines update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way ------------------------------------------------------------------------ in addition: move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@159855 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	6af6b67bd9	Merged revisions 159475 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r159475 \| tilghman \| 2008-11-26 12:33:04 -0600 (Wed, 26 Nov 2008) \| 7 lines If the config file does not exist, then the first use crashes Asterisk. (closes issue #13848) Reported by: klaus3000 Patches: udptl.c.patch uploaded by eliel (license 64) Tested by: blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@159478 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	2ff6ba3c9b	Merged revisions 159360 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r159360 \| murf \| 2008-11-25 16:03:01 -0700 (Tue, 25 Nov 2008) \| 23 lines Merged revisions 159316 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159316 \| murf \| 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) \| 15 lines (closes issue #12694) Reported by: yraber Patches: 12694.2nd.diff uploaded by murf (license 17) Tested by: murf, laurav Thanks to file (Joshua Colp) for his IAX fix. the change to cdr.c allows no-answer to percolate up into CDR's, and feels like the right place to locate this fix; if BUSY is done here, no-answer should be, too. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@159374 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	0ecfb8e29e	I don't care what anyone says, this change is going into 1.6.0. Otherwise, the simple act of logging an agent in spams the CLI with warning messages about failed reads of the alertpipe. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@159314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	3661324455	Merged revisions 158484 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r158484 \| murf \| 2008-11-21 14:47:16 -0700 (Fri, 21 Nov 2008) \| 19 lines Merged revisions 158483 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r158483 \| murf \| 2008-11-21 14:19:47 -0700 (Fri, 21 Nov 2008) \| 11 lines (closes issue #13871) Reported by: mdu113 This one is totally my fault. The code doesn't even create a bridge CDR if the channel CDR has POST_DISABLED. I didn't check for that at the end of the bridge. Fixed with a few small insertions. Tested. Looks good. No cdr generated, no crash, no unnecc. data objects created either. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@158545 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c74fff5ebc	Merged revisions 158540 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r158540 \| russell \| 2008-11-21 16:12:37 -0600 (Fri, 21 Nov 2008) \| 10 lines Merged revisions 158539 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r158539 \| russell \| 2008-11-21 16:05:55 -0600 (Fri, 21 Nov 2008) \| 2 lines When compiling with DEBUG_THREADS, report the real file/func/line for ao2_lock/ao2_unlock ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@158542 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	ae3b28aa19	Merged revisions 157974 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r157974 \| kpfleming \| 2008-11-19 18:08:12 -0600 (Wed, 19 Nov 2008) \| 13 lines Merged revisions 157859 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r157859 \| kpfleming \| 2008-11-19 15:34:47 -0600 (Wed, 19 Nov 2008) \| 7 lines the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems. with this build system change, if (and only if) --enable-dev-mode was used and DONT_OPTIMIZE is turned on, when a source file is compiled it will actually be preprocessed (into a .i or .ii file), then compiled once with optimization (with the result sent to /dev/null) and again without optimization (but only if the first compile succeeded, of course). while making these changes, i did some cleanup work in Makefile.rules to move commonly-used combinations of flag variables into their own variables, to make the file easier to read and maintain ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@157976 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	35a7e1deca	Merged revisions 157306 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r157306 \| mmichelson \| 2008-11-18 12:31:08 -0600 (Tue, 18 Nov 2008) \| 20 lines Merged revisions 157305 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r157305 \| mmichelson \| 2008-11-18 12:25:55 -0600 (Tue, 18 Nov 2008) \| 12 lines Fix a crash in the end_bridge_callback of app_dial and app_followme which would occur at the end of an attended transfer. The error occurred because we initially stored a pointer to an ast_channel which then was hung up due to a masquerade. This commit adds a "fixup" callback to the bridge_config structure to allow for end_bridge_callback_data to be changed in the case that a new channel pointer is needed for the end_bridge_callback. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@157307 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a3d874c414	Merged revisions 157302 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r157302 \| murf \| 2008-11-18 11:07:55 -0700 (Tue, 18 Nov 2008) \| 18 lines (closes issue #13420) Reported by: alex70 Patches: 13420.13539.patch uploaded by murf (license 17) Tested by: murf, awk This fixes two problems: a spurious linefeed insertion probably left over from pre-precomment times. Only generated when category had no previous comments. The other problem: Insertions could get the line-numbering out of whack and generate negative line numbers, causing chunks of line numbers to be emitted, on the scale of the number of lines up to that point in the file. In such cases, abort the looping, and all is well. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@157303 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	ed02eca8fa	Merged revisions 156911 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r156911 \| tilghman \| 2008-11-14 11:02:00 -0600 (Fri, 14 Nov 2008) \| 4 lines Ping is missing the standard double-newline after the event. (closes issue #13903) Reported by: kebl0155 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@156912 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Brandon Kruse	dbc2ed5e21	Update to Coding Guidelines git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@156653 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Brandon Kruse	f077cc197d	Merged revisions 156017 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r156017 \| pari \| 2008-11-11 17:02:43 -0600 (Tue, 11 Nov 2008) \| 5 lines Patch by Ryan Brindley -- Make sure that manager refuses any duplicate 'new category' requests in updateconfig (closes issue #13539) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@156652 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	6db3b2ff26	Merged revisions 156299 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r156299 \| murf \| 2008-11-12 12:47:29 -0700 (Wed, 12 Nov 2008) \| 26 lines Merged revisions 156297 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r156297 \| murf \| 2008-11-12 12:36:16 -0700 (Wed, 12 Nov 2008) \| 18 lines It turns out that the 0x0XX00 codes being returned for N, X, and Z are off by one, as per conversation with jsmith on #asterisk-dev; he was teaching a class and disconcerted that this published rule was not being followed, with patterns _NXX, _[1-8]22 and _[2-9]22... and NXX was winning, but [1-8] should have been. This change, tested on these 3 patterns now picks the proper one. However, this change may surprise users who set up dialplans based on previous behavior, which has been there for what, 2 and half years or so now. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@156319 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	0591cc3029	Merged revisions 155554 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r155554 \| seanbright \| 2008-11-08 20:27:00 -0500 (Sat, 08 Nov 2008) \| 14 lines Merged revisions 155553 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r155553 \| seanbright \| 2008-11-08 20:08:07 -0500 (Sat, 08 Nov 2008) \| 6 lines Use static functions here instead of nested ones. This requires a small change to the ast_bridge_config struct as well. To understand the reason for this change, see the following post: http://gcc.gnu.org/ml/gcc-help/2008-11/msg00049.html ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@155555 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	c8ebf2045a	Merged revisions 154060 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r154060 \| tilghman \| 2008-11-03 15:48:21 -0600 (Mon, 03 Nov 2008) \| 3 lines Remove the potential for a division by zero error. (Closes issue #13810) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@154062 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	fa635ea4b0	port gcc 4.3.x warning fixes from trunk to this branch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@153743 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	e23be17786	Merged revisions 153181 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r153181 \| twilson \| 2008-10-31 13:55:33 -0500 (Fri, 31 Oct 2008) \| 5 lines Recent CDR fixes moved execution of the 'h' exten into the bridging code, so variables that were set after ast_bridge_call was called would not show up in the 'h' exten. Added a callback function to handle setting variables, etc. from w/in the bridging code. Calls back into a nested function within the function calling ast_bridge_call (closes issue #13793) Reported by: greenfieldtech ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@153265 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	3a6940fe60	Merged revisions 152812 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r152812 \| kpfleming \| 2008-10-30 11:54:29 -0500 (Thu, 30 Oct 2008) \| 9 lines Merged revisions 152811 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r152811 \| kpfleming \| 2008-10-30 11:53:48 -0500 (Thu, 30 Oct 2008) \| 3 lines instead of comparing the string pointer to 0, let's compare the value that was actually parsed out of the string (found by sparse) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@152813 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
BJ Weschke	b15c8d915a	Merged revisions 150817 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r150817 \| bweschke \| 2008-10-17 22:18:33 -0400 (Fri, 17 Oct 2008) \| 8 lines Using the GetVar handler in AMI is potentially dangerous (insta-crash [tm]) when you use a dialplan function that requires a channel and then you don't provide one or provide an invalid one in the Channel: parameter. We'll handle this situation exactly the same way it was handled in pbx.c back on r61766. We'll create a bogus channel for the function call and destroy it when we're done. If we have trouble allocating the bogus channel then we're not going to try executing the function call at all and run the risk of crashing. (closes issue #13715) reported by: makoto patch by: bweschke ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@150854 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	158d6c4b64	Merged revisions 148612 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r148612 \| kpfleming \| 2008-10-14 03:06:45 -0500 (Tue, 14 Oct 2008) \| 9 lines Merged revisions 148611 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r148611 \| kpfleming \| 2008-10-14 02:54:41 -0500 (Tue, 14 Oct 2008) \| 3 lines it would be nice if this message printing code had actually been tested before it was committed... ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@148613 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	eb87d6dac7	Merged revisions 148200 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r148200 \| seanbright \| 2008-10-09 20:42:13 -0400 (Thu, 09 Oct 2008) \| 12 lines Don't include logger.h in asterisk.h by default as it is causing problems building app_voicemail. Instead, include it where it is needed. This turned out to be a relatively minor issue because other headers include logger.h as well. Need to test -addons before merging this back to 1.6.0. (closes issue #13605) Reported by: tomo1657 Patches: 13605_seanbright.diff uploaded by seanbright (license 71) Tested by: mmichelson ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@148204 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	062d3041fe	Merged revisions 147807 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r147807 \| murf \| 2008-10-09 08:17:33 -0600 (Thu, 09 Oct 2008) \| 15 lines (closes issue #13557) Reported by: nickpeirson Patches: pbx.c.patch uploaded by nickpeirson (license 579) replace_bzero+bcopy.patch uploaded by nickpeirson (license 579) Tested by: nickpeirson, murf 1. replaced all refs to bzero and bcopy to memset and memmove instead. 2. added a note to the CODING-GUIDELINES 3. add two macros to asterisk.h to prevent bzero, bcopy from creeping back into the source 4. removed bzero from configure, configure.ac, autoconfig.h.in ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@147809 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	28c515cac5	Merged revisions 146198 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r146198 \| seanbright \| 2008-10-03 18:10:18 -0400 (Fri, 03 Oct 2008) \| 7 lines Resolve a subtle bug where we would never successfully be able to get the first item in the CLI entry list. This was preventing '!' from showing up in either 'help' or in tab completion. (closes issue #13578) Reported by: mvanbaak ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@146199 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4a2c9d25ba	Merged revisions 145606 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145606 \| mmichelson \| 2008-10-01 17:23:50 -0500 (Wed, 01 Oct 2008) \| 11 lines Okay, this should really do it now. While I did manage to fix blind transfers with my last commit here, I also caused an unwanted side-effect. That is, only the first priority of the 'h' extension would be executed when a blind transfer occurred instead of all priorities. Essentially, my last commit corrected the return value of ast_bridge_call. However, the implementation still was not 100% correct. Now it is. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@145607 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	2b6112542e	Merged revisions 145579 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145579 \| mmichelson \| 2008-10-01 16:33:11 -0500 (Wed, 01 Oct 2008) \| 4 lines if (!(x) == 0) is the same as if (x). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@145581 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	64773d186f	Merged revisions 145553 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r145553 \| mmichelson \| 2008-10-01 16:06:26 -0500 (Wed, 01 Oct 2008) \| 13 lines The logic surrounding the return value of ast_spawn_extension within ast_bridge_call was reversed. This problem was observed when a blind transfer placed from the callee channel of a test call failed. While the problem I am solving here is exactly the same as what was reported in issue #13584, the difference is that this fix I am applying is trunk-only. Issue #13584 was reported against the 1.4 branch, and my tests of 1.4's blind transfers appear to work fine. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@145556 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	ccc3bcfb67	Merged revisions 144949-144951 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144949 \| kpfleming \| 2008-09-27 10:52:56 -0500 (Sat, 27 Sep 2008) \| 17 lines Merged revisions 144924-144925 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144924 \| kpfleming \| 2008-09-27 10:00:48 -0500 (Sat, 27 Sep 2008) \| 6 lines improve header inclusion process in a few small ways: - it is no longer necessary to forcibly include asterisk/autoconfig.h; every module already includes asterisk.h as its first header (even before system headers), which serves the same purpose - astmm.h is now included by asterisk.h when needed, instead of being forced by the Makefile; this means external modules will build properly against installed headers with MALLOC_DEBUG enabled - simplify the usage of some of these headers in the AEL-related stuff in the utils directory ........ r144925 \| kpfleming \| 2008-09-27 10:13:30 -0500 (Sat, 27 Sep 2008) \| 2 lines fix some minor issues with rev 144924 ........ ................ r144950 \| kpfleming \| 2008-09-27 11:10:33 -0500 (Sat, 27 Sep 2008) \| 2 lines fix bugs caused by r144949 when MALLOC_DEBUG is defined ................ r144951 \| kpfleming \| 2008-09-27 11:17:43 -0500 (Sat, 27 Sep 2008) \| 1 line remove incorrect comment ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@144991 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	fb1a08e168	Merged revisions 144678 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144678 \| murf \| 2008-09-26 11:50:35 -0600 (Fri, 26 Sep 2008) \| 20 lines Merged revisions 144677 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144677 \| murf \| 2008-09-26 11:47:13 -0600 (Fri, 26 Sep 2008) \| 12 lines (closes issue #13563) Reported by: mnicholson Patches: found1.diff uploaded by mnicholson (license 96) This patch was mainly meant to apply to trunk and 1.6.x, but I'm applying it to 1.4 also, which should be a perfectly harmless fix to the vast majority of users who are not using external switches, but the few who might be affected will not have to go to the pain of filing a bug report. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@144679 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	561fd11a1f	Merged revisions 144569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r144569 \| murf \| 2008-09-25 16:21:28 -0600 (Thu, 25 Sep 2008) \| 14 lines (closes issue #13557) Reported by: nickpeirson The user attached a patch, but the license is not yet recorded. I took the liberty of finding and replacing ALL index() calls with strchr() calls, and that involves more than just main/pbx.c; chan_oss, app_playback, func_cut also had calls to index(), and I changed them out. 1.4 had no references to index() at all. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@144570 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	f1421805ed	Merged revisions 144067 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r144067 \| murf \| 2008-09-23 10:52:32 -0600 (Tue, 23 Sep 2008) \| 37 lines Merged revisions 144066 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r144066 \| murf \| 2008-09-23 10:41:49 -0600 (Tue, 23 Sep 2008) \| 29 lines (closes issue #13489) Reported by: DougUDI Tested by: murf (closes issue #13490) Reported by: seanbright Tested by: murf (closes issue #13467) Reported by: edantie Tested by: murf, edantie, DougUDI This crash happens because we are unsafely handling old pointers. The channel whose cdr is being handled, has been hung up and destroyed already. I reorganized the code a bit, and tried not to lose the fork-cdr-chain concepts of the previous code. I now verify that the 'previous' channel (the channel we had when the bridge was started), still exists, by looking it up by name in the channel list. I also do not try to reset the CDR's of channels involved in bridges. Testing shows it solves the crash problem, and should not negatively impact previous fixes involving CDR's generated during/after blind transfers. (The reason we need to reset the CDR's on the "beginning" channels in the first place). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@144068 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	79ecae6614	Merged revisions 142748 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r142748 \| tilghman \| 2008-09-12 11:54:44 -0500 (Fri, 12 Sep 2008) \| 3 lines When checking for an encoded character, make sure the string isn't blank, first. (Closes issue #13470) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142749 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	6c55eda169	Merged revisions 142741 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142741 \| tilghman \| 2008-09-12 11:29:01 -0500 (Fri, 12 Sep 2008) \| 12 lines Merged revisions 142740 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142740 \| tilghman \| 2008-09-12 11:27:32 -0500 (Fri, 12 Sep 2008) \| 4 lines Don't return a free'd pointer, when a file cannot be opened. (closes issue #13462) Reported by: wackysalut ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142742 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	3c1c24500b	Merged revisions 142676 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142676 \| murf \| 2008-09-11 22:50:48 -0600 (Thu, 11 Sep 2008) \| 40 lines Merged revisions 142675 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142675 \| murf \| 2008-09-11 22:29:34 -0600 (Thu, 11 Sep 2008) \| 29 lines Tested by: sergee, murf, chris-mac, andrew, KNK This is a "second attempt" to restore the previous "endbeforeh" behavior in 1.4 and up. In order to capture information concerning all the legs of transfers in all their infinite combinations, I was forced to this particular solution by a chain of logical necessities, the first being that I was not allowed to rewrite the CDR mechanism from the ground up! This change basically leaves the original machinery alone, which allows IVR and local channel type situations to generate CDR's as normal, but a channel flag can be set to suppress the normal running of the h exten. That flag would be set by the code that runs the h exten from the ast_bridge_call routine, to prevent the h exten from being run twice. Also, a flag in the ast_bridge_config struct passed into ast_bridge_call can be used to suppress the running of the h exten in that routine. This would happen, for instance, if you use the 'g' option in the Dial app. Running this routine 'early' allows not only the CDR() func to be used in the h extension for reading CDR variables, but also allows them to be modified before the CDR is posted to the backends. While I dearly hope that this patch overcomes all problems, and introduces no new problems, reality suggests that surely someone will have problems. In this case, please re-open 13251 (or 13289), and we'll see if we can't fix any remaining issues. ** trunk note: some code to suppress the h exten being run from app_queue was added; for the 'continue' option available only in trunk/1.6.x. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142677 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	d1723e6ae5	Merged revisions 142576 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142576 \| murf \| 2008-09-11 17:12:53 -0600 (Thu, 11 Sep 2008) \| 28 lines Merged revisions 142575 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142575 \| murf \| 2008-09-11 16:55:49 -0600 (Thu, 11 Sep 2008) \| 20 lines (closes issue #13364) Reported by: mdu113 Well, fundamentally, the problems revealed in 13364 are because of the ForkCDR call that is done before the dial. When the bridge is in place, it's dealing with the first (and wrong) cdr in the list. So, I wrote a little func to zip down to the first non-locked cdr in the chain, and thru-out the ast_bridge_call, these results are used instead of raw chan->cdr and peer->cdr pointers. This shouldn't affect anyone who isn't forking cdrs before a dial, and should correct the cdr's of those that do. So, this change ends up correcting the dstchannel and userfield; the disposition was fixed by a previous patch, it was OK coming into this problem. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142631 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	2116207025	Merged revisions 142475 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142475 \| murf \| 2008-09-10 16:11:27 -0600 (Wed, 10 Sep 2008) \| 38 lines Merged revisions 142474 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142474 \| murf \| 2008-09-10 15:58:17 -0600 (Wed, 10 Sep 2008) \| 30 lines (closes issue #12318) Reported by: krtorio I made a small change to the code that handles local channel situations. In that code, I copy the answer time from the peer cdr, to the bridge_cdr, but I wasn't also copying the disposition from the peer cdr. So, Now I copy the disposition, and I've tested against these cases: 1. phone 1 never answers the phone; no cdr is generated at all. this should show up as a manager command failure or something. 2. phone 2 never answers. CDR is generated, says NO ANSWER 3. phone 2 is busy. CDR is generated, says BUSY 4. phone 2 answers: CDR is generated, times are correct; disposition is ANSWERED, which is correct. The start time is the time that the manager dialed the first phone. The answer time is the time the second phone picks up. I purposely left the cid and src fields blank; since this call really originates from the manager, there is no 'easy' data to put in these fields. If you feel strongly that these fields should be filled in, re-open this bug and I'll dig further. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142477 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e6f7951a95	Merged revisions 142355 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142355 \| russell \| 2008-09-10 11:41:55 -0500 (Wed, 10 Sep 2008) \| 15 lines Merged revisions 142354 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142354 \| russell \| 2008-09-10 11:39:53 -0500 (Wed, 10 Sep 2008) \| 7 lines It is a normal situation that a task gets put in the scheduler that should run as soon as possible. Accept "0" as an acceptable time to run, and also treat negative as "run now", and don't print a debug message about it. (inspired by a message asking about the "request to schedule in the past" debug message on the -dev list) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142356 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f573a4785e	Merged revisions 142064 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r142064 \| russell \| 2008-09-09 10:44:10 -0500 (Tue, 09 Sep 2008) \| 13 lines Merged revisions 142063 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r142063 \| russell \| 2008-09-09 10:40:24 -0500 (Tue, 09 Sep 2008) \| 5 lines Ensure that the stored CDR reference is still valid after the bridge before poking at it. Also, keep the channel locked while messing with this CDR. (fixes crashes reported in issue #13409) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@142065 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	449cf2d24a	Merged revisions 141949 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r141949 \| russell \| 2008-09-08 20:47:56 -0500 (Mon, 08 Sep 2008) \| 9 lines Modify ast_answer() to not hold the channel lock while calling ast_safe_sleep() or when calling ast_waitfor(). These are inappropriate times to hold the channel lock. This is what has caused "could not get the channel lock" messages from chan_sip and has likely caused a negative impact on performance results of SIP in Asterisk 1.6. Thanks to file for pointing out this section of code. (closes issue #13287) (closes issue #13115) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@141950 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f86cd6496b	Merged revisions 141807 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141807 \| russell \| 2008-09-08 16:05:01 -0500 (Mon, 08 Sep 2008) \| 15 lines Merged revisions 141806 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141806 \| russell \| 2008-09-08 16:02:36 -0500 (Mon, 08 Sep 2008) \| 7 lines When doing an async goto, detect if the channel is already in the middle of a masquerade. This can happen when chan_local is trying to optimize itself out. If this happens, fail the async goto instead of bursting into flames. (closes issue #13435) Reported by: geoff2010 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@141808 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	90d877b2da	Merged revisions 141157 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141157 \| murf \| 2008-09-05 08:18:43 -0600 (Fri, 05 Sep 2008) \| 9 lines Merged revisions 141156 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141156 \| murf \| 2008-09-05 08:15:43 -0600 (Fri, 05 Sep 2008) \| 1 line A small change to prevent double-posting of CDR's; thanks to Daniel Ferrer for bringing it to our attention ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@141158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	4ee5b75c5c	Merged revisions 141039 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r141039 \| jpeeler \| 2008-09-04 12:27:56 -0500 (Thu, 04 Sep 2008) \| 15 lines Merged revisions 141028 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r141028 \| jpeeler \| 2008-09-04 12:00:29 -0500 (Thu, 04 Sep 2008) \| 7 lines (closes issue #11979) Fixes multiple parking problems: Crash when executing a park on an extension dialed by AGI due to not returning the proper return code. Crash when using a builtin feature that was a subset of a enabled dynamic feature. Crash due to always hanging up the peer despite the fact that the peer was supposed to be parked. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@141086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	fa34fdcb43	Merged revisions 140749 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140749 \| murf \| 2008-09-02 17:44:04 -0600 (Tue, 02 Sep 2008) \| 11 lines Merged revisions 140747 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140747 \| murf \| 2008-09-02 17:36:56 -0600 (Tue, 02 Sep 2008) \| 1 line I am turning the warnings generated in ast_cdr_free and post_cdr into verbose level 2 messages. Really, they matter little to end users. You either get the CDR's you wanted, or you don't, and it is a bug. For trunk, I am going one step further. These messages were pretty worthless even for debug, so I'm completely removing them. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@140827 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a3b41b28b6	Merged revisions 140692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140692 \| murf \| 2008-09-02 16:55:12 -0600 (Tue, 02 Sep 2008) \| 13 lines Merged revisions 140690 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140690 \| murf \| 2008-09-02 16:40:13 -0600 (Tue, 02 Sep 2008) \| 1 line After reconsidering, with respect to 13409, ast_cdr_detach should be OK, better in fact, than ast_cdr_free, which generates lots of useless warnings that will undoubtably generate complaints. Hmmm. It doesn't hush the useless warnings, but it does allow control of posting via the detach and post routines, for those possible situations, where you'd want to post single-channel cdrs. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@140826 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a561485ccf	Merged revisions 140691 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140691 \| murf \| 2008-09-02 16:50:59 -0600 (Tue, 02 Sep 2008) \| 22 lines Merged revisions 140670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140670 \| murf \| 2008-09-02 16:15:57 -0600 (Tue, 02 Sep 2008) \| 14 lines (closes issue #13409) Reported by: tomaso Patches: asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by tomaso (license 564) I basically spent the day, verifying that this patch solves the problem, and doesn't hurt in non-problem cases. Why valgrind did not plainly reveal this leak absolutely mystifies and stuns me. Many, many thanks to tomaso for finding and providing the fix. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@140825 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f6f5ba6adc	Merged revisions 140817 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140817 \| russell \| 2008-09-03 08:26:43 -0500 (Wed, 03 Sep 2008) \| 12 lines Merged revisions 140816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140816 \| russell \| 2008-09-03 08:24:35 -0500 (Wed, 03 Sep 2008) \| 4 lines Don't freak out if the poll emulation receives NULL for the pollfds array (closes issue #13307) Reported by: jcovert ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@140818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ee9f8015b6	Merged revisions 139770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139770 \| murf \| 2008-08-25 09:54:18 -0600 (Mon, 25 Aug 2008) \| 17 lines Merged revisions 139764 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139764 \| murf \| 2008-08-25 09:33:14 -0600 (Mon, 25 Aug 2008) \| 9 lines This patch reverts the changes made via 139347, and 139635, as users are seeing adverse difference. I will un-close 13251. Back to the drawing board/ concept/ beginning/ whatever! ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@139774 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	41ed986072	Merged revisions 139662 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139662 \| murf \| 2008-08-22 16:32:35 -0600 (Fri, 22 Aug 2008) \| 14 lines Merged revisions 139635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139635 \| murf \| 2008-08-22 16:24:02 -0600 (Fri, 22 Aug 2008) \| 6 lines I found some problems with the code I committed earlier, when I merged them into trunk, so I'm coming back to clean up. And, in the process, I found an error in the code I added to trunk and 1.6.x, that I'll fix using this patch also. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@139671 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ee980c4a33	Merged revisions 139627 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r139627 \| murf \| 2008-08-22 16:03:13 -0600 (Fri, 22 Aug 2008) \| 59 lines Merged revisions 139347 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139347 \| murf \| 2008-08-21 17:03:50 -0600 (Thu, 21 Aug 2008) \| 47 lines (closes issue #13251) Reported by: sergee Tested by: murf THis is a bold move for a static release fix, but I wouldn't have made it if I didn't feel confident (at least a bit confident) that it wouldn't mess everyone up. The reasoning goes something like this: 1. We simply cannot do anything with CDR's at the current point (in pbx.c, after the __ast_pbx_run loop). It's way too late to have any affect on the CDRs. The CDR is already posted and gone, and the remnants have been cleared. 2. I was very much afraid that moving the running of the 'h' extension down into the bridge code (where it would be now practical to do it), would result in a lot more calls to the 'h' exten, so I implemented it as another exten under another name, but found, to my pleasant surprise, that there was a 1:1 correspondence to the running of the 'h' exten in the pbx_run loop, and the new spot at the end of the bridge. So, I ifdef'd out the current 'h' loop, and moved it into the bridge code. The only difference I can see is the stuff about the AST_PBX_KEEPALIVE, and hopefully, if this is still an important decision point, I can replicate it if there are complaints. To be perfectly honest, the KEEPALIVE situation is not totally clear to me, and how it relates to a post-bridge situation is less clear. I suspect the users will point out everything in total clarity if this steps on anyone's toes! 3. I temporarily swap the bridge_cdr into the channel before running the 'h' exten, which makes it possible for users to edit the cdr before it goes out the door. And, of course, with the endbeforehexten config var set, the users can also get at the billsec/duration vals. After the h exten finishes, the cdr is swapped back and processing continues as normal. Please, all who deal with CDR's, please test this version of Asterisk, and file bug reports as appropriate! ........ I also made a little fix to the app_dial's 'e' option, that is related to my updates. ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@139628 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

1 2 3 4 5 ...

1737 Commits (124fb94de607c5b4fe0b8e5899a27928ee08e235)