From ff2e267521fd0ff047efaf09f5eff589e321d99a Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Sat, 13 Dec 2008 00:08:17 +0000 Subject: [PATCH] Merged revisions 163873 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r163873 | twilson | 2008-12-12 17:48:26 -0600 (Fri, 12 Dec 2008) | 6 lines When using realtime queues, app_queue wasn't updating the strategy if it was changed in the realtime backend. This patch resolves the issue for almost all situations. It is currently not supported to switch to the linear strategy via realtime since the ao2_container for members will have been set to have multiple buckets and therefore the members would be unordered. (closes issue #14034) Reported by: cristiandimache Tested by: otherwiseguy, cristiandimache ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163875 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_queue.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/apps/app_queue.c b/apps/app_queue.c index 0934e8ca05..c10f85b445 100644 --- a/apps/app_queue.c +++ b/apps/app_queue.c @@ -1263,8 +1263,26 @@ static void queue_set_param(struct call_queue *q, const char *param, const char } else if (!strcasecmp(param, "servicelevel")) { q->servicelevel= atoi(val); } else if (!strcasecmp(param, "strategy")) { - /* We already have set this, no need to do it again */ - return; + int strategy; + + /* We are a static queue and already have set this, no need to do it again */ + if (failunknown) { + return; + } + strategy = strat2int(val); + if (strategy < 0) { + ast_log(LOG_WARNING, "'%s' isn't a valid strategy for queue '%s', using ringall instead\n", + val, q->name); + q->strategy = QUEUE_STRATEGY_RINGALL; + } + if (strategy == q->strategy) { + return; + } + if (strategy == QUEUE_STRATEGY_LINEAR) { + ast_log(LOG_WARNING, "Changing to the linear strategy currently requires asterisk to be restarted.\n"); + return; + } + q->strategy = strategy; } else if (!strcasecmp(param, "joinempty")) { if (!strcasecmp(val, "loose")) q->joinempty = QUEUE_EMPTY_LOOSE;