Update patch set 15

Patch Set 15: (13 comments) Patch-set: 15 Attention: {"person_ident":"Gerrit User 1000337 \u003c1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000250\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000250 \u003c1000250@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000250\u003e replied on the change"}
4 years ago · e9baeec8c2
parent 1496d079dd
commit e9baeec8c2
3 changed files with 234 additions and 0 deletions
--- a/180
+++ b/180
@ -17,6 +17,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "12ec00a8_068980ba",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 14
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "34a389d4_aeae3fef",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -34,6 +52,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "229015af_ba38e1f0",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 28,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "68a0d2e3_7bea1588",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -51,6 +87,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "43dc605c_5fd29c90",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 593,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "7f94e9f4_4d09f565",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -68,6 +122,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "9abeb3a1_89cbf785",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 600,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "ecb12943_c34ed21c",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -85,6 +157,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "d0690f7c_fc0d8b5e",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 783,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "edf0c91f_372f5b87",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -102,6 +192,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8015ff74_bff4d199",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 795,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "I don\u0027t follow this one... are we enforcing alignment on every single variable now?  I didn\u0027t see the need to line up anything here as everything in this little block was so dissimilar.",
+      "parentUuid": "3d8f3f32_f2ac2039",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -119,6 +227,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8d2656c7_c365d3ad",
+        "filename": "include/asterisk/channel.h",
+        "patchSetId": 14
+      },
+      "lineNbr": 2931,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "I don\u0027t think I see an issue here.   The comments are already lined up with tabs.",
+      "parentUuid": "29ac0e3a_bf119274",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -136,6 +262,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "330a0019_f361e5cd",
+        "filename": "include/asterisk/channel.h",
+        "patchSetId": 14
+      },
+      "lineNbr": 3164,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "bfd6a133_6b0e4231",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -153,6 +297,24 @@
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "ce5da971_07e6ec81",
+        "filename": "main/app.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 2433,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "99300a61_37dbb81a",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -169,6 +331,24 @@
      "message": "Use ast_copy_string, not strncpy",
      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "51ab4586_2396cce7",
+        "filename": "main/app.c",
+        "patchSetId": 14
+      },
+      "lineNbr": 2686,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "436fe9ab_2a4d975b",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    }
  ]
 }
--- a/36
+++ b/36
@ -17,6 +17,24 @@
      "revId": "aefe2e50a7f6b75bc2b8f438c8884e68536a38d4",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "e27d01ff_69e7b0d5",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 13
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "e5188031_a6291f65",
+      "revId": "aefe2e50a7f6b75bc2b8f438c8884e68536a38d4",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {
@ -33,6 +51,24 @@
      "message": "This is inaccurate. It should be something like \"active group assignments\". A channel can have more than one group assignment.\n\nYes, I realize the existing code in func_groupcount also says \"active channels\" and that is also wrong, and should be fixed at some point, but for now we should correct it in the new code.",
      "revId": "aefe2e50a7f6b75bc2b8f438c8884e68536a38d4",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "f7331906_63a1d16f",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 13
+      },
+      "lineNbr": 1302,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "1da4ae0e_7ab0dd1e",
+      "revId": "aefe2e50a7f6b75bc2b8f438c8884e68536a38d4",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    }
  ]
 }
--- a/18
+++ b/18
@ -284,6 +284,24 @@
      "revId": "b2d3eec4b3d5352e8ca9e7d5e7a2e7b315f4d357",
      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "7e4ecd10_a2c21be6",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 87,
+      "author": {
+        "id": 1000250
+      },
+      "writtenOn": "2022-09-26T15:26:06Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "419fd192_088b101e",
+      "revId": "b2d3eec4b3d5352e8ca9e7d5e7a2e7b315f4d357",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
    {
      "unresolved": true,
      "key": {