From c8f9d55c915ac6ca3eaf6f9d223b495e2eebc2dc Mon Sep 17 00:00:00 2001 From: Gerrit User 1000337 <1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1> Date: Thu, 22 Dec 2022 06:35:18 -0600 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000337 \u003c1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000337\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000001 \u003c1000001@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000337\u003e replied on the change"} --- c970d636f5fcf7d55817359d1f702aaf155d0e30 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/c970d636f5fcf7d55817359d1f702aaf155d0e30 b/c970d636f5fcf7d55817359d1f702aaf155d0e30 index 2c8941aa1a..7f5ee320c5 100644 --- a/c970d636f5fcf7d55817359d1f702aaf155d0e30 +++ b/c970d636f5fcf7d55817359d1f702aaf155d0e30 @@ -52,6 +52,24 @@ "parentUuid": "1225186f_0ffb20fb", "revId": "c970d636f5fcf7d55817359d1f702aaf155d0e30", "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1" + }, + { + "unresolved": true, + "key": { + "uuid": "d529a043_05694327", + "filename": "res/res_pjsip_logger.c", + "patchSetId": 1 + }, + "lineNbr": 671, + "author": { + "id": 1000337 + }, + "writtenOn": "2022-12-22T12:35:18Z", + "side": 1, + "message": "if debug\u003dno:\nreload: stays off\nCLI disable: stays off\nCLI enable: turns on\nCLI enable, then reload: stays on\nCLI disable, then reload: stays off\nCLI disable: turns off\n\nif debug\u003dyes:\nreload: stays on\nCLI enable: stays on\nCLI disable: stays off\nCLI enable, then reload: stays on\nCLI disable, then reload: turns on again. Maybe should stay off?\n\nIn the latter case, an option is to keep a flag if logging was explicitly disabled via the CLI (as opposed to explicitly enabled via the config file), and if so, then refuse to process a true config value.", + "parentUuid": "4128b75c_e7d34610", + "revId": "c970d636f5fcf7d55817359d1f702aaf155d0e30", + "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1" } ] } \ No newline at end of file