From bd2c55d20926ed85bbf2c3a2f515fb0e5278363d Mon Sep 17 00:00:00 2001
From: Gerrit User 1000337 <1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1>
Date: Tue, 14 Dec 2021 10:48:00 -0600
Subject: [PATCH] Update patch set 1

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000337 <1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1>
Label: Code-Review=-1
---
 7c21c70c50012e8ceec2c8b1cab379869199d3cb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/7c21c70c50012e8ceec2c8b1cab379869199d3cb b/7c21c70c50012e8ceec2c8b1cab379869199d3cb
index 74a265280e..94defade6a 100644
--- a/7c21c70c50012e8ceec2c8b1cab379869199d3cb
+++ b/7c21c70c50012e8ceec2c8b1cab379869199d3cb
@@ -16,6 +16,23 @@
       "message": "Commenting here to add myself to cc, and also wondering about ast_app_group_set_channel. I thought it\u0027s generally desirable to avoid changing existing public API, but it seems like it\u0027s only used in app_dial in the current tree, so probably not a big deal. But maybe someone else has different thoughts about this.",
       "revId": "7c21c70c50012e8ceec2c8b1cab379869199d3cb",
       "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "82cda966_53273aa4",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2021-12-14T16:48:00Z",
+      "side": 1,
+      "message": "Upon further thought, as discussed, I don\u0027t think the ast_app_group_set_channel public API should be modified, since it\u0027s used in more places than I assumed it was. A new function that is called under the hood by ast_app_group_set_channel would preserve existing API, and contain the default value to a single place. Do the inheritance matter for existing function calls, or only the ones that are made within func_groupcount?",
+      "revId": "7c21c70c50012e8ceec2c8b1cab379869199d3cb",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
     }
   ]
 }
\ No newline at end of file