mirror of http://gerrit.asterisk.org/asterisk
Patch Set 7: Code-Review-1
(2 comments)
Patch-set: 7
Reviewer: Gerrit User 1000337 <1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 1000337 \u003c1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"REMOVE","reason":"InterLinked replied on the change"}
changes/55/17655/meta
parent
34d83cdb49
commit
68a4dcdbb8
@ -0,0 +1,38 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3881df62_d20d2999",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000337
|
||||
},
|
||||
"writtenOn": "2022-02-22T01:13:18Z",
|
||||
"side": 1,
|
||||
"message": "You\u0027re probably aware of this, but FYI:\n\n cli.c:1906:2: error: expected specifier-qualifier-list before \u0027AST_DLLIST_ENTRY\u0027\n AST_DLLIST_ENTRY(group_list_entry) entries; /*!\u003c Next group */\n ^\n\nAlso, another quick note on missing documentation:",
|
||||
"revId": "6350c56d904215ecab1b0c982346905d70985302",
|
||||
"serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "12d7c900_a4102807",
|
||||
"filename": "funcs/func_groupcount.c",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 168,
|
||||
"author": {
|
||||
"id": 1000337
|
||||
},
|
||||
"writtenOn": "2022-02-22T01:13:18Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t see the documentation for the GROUP_VAR function itself anywhere - kind of the most important one ;)\nAdditionally, this should be included in the see-also XML documentation for relevant AMI docs, etc., and vice versa.",
|
||||
"revId": "6350c56d904215ecab1b0c982346905d70985302",
|
||||
"serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in new issue