Update patch set 19

Patch Set 19: Code-Review-1

(10 comments)

Patch-set: 19
Reviewer: Gerrit User 1000337 <1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1>
Label: Code-Review=-1, f9140db2b89f72b143a7669150a0a7b02198e9fc
Attention: {"person_ident":"Gerrit User 1000337 \u003c1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000337\u003e replied on the change"}

498fefbc810d25779724bbbca2160d876b8e025f

@@ -33,6 +33,142 @@
       "message": "recheck\n",
       "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
       "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "6df01614_b89dfddf",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 19
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Real close... a few more things",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3168d831_1265190f",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 1041,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "I think ast_str_create can fail... you should check for failure everywhere you call this.",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "52debfcf_426be274",
+        "filename": "main/app.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 2423,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Opening brace should be on a separate line (K\u0026R)",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "ce0a8ab3_9005fd92",
+        "filename": "main/app.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 2487,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Opening brace should be on a separate line (K\u0026R)",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "532753db_1a40008e",
+        "filename": "main/app.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 2668,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Opening brace should be on a separate line (K\u0026R)",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "9b8a8392_3861bf35",
+        "filename": "main/app.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 2716,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Opening brace should be on a separate line (K\u0026R)",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "0fbb96a4_ecc0774a",
+        "filename": "main/app.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 2745,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Opening brace should be on a separate line (K\u0026R)",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b5deb797_a37c20bc",
+        "filename": "main/cli.c",
+        "patchSetId": 19
+      },
+      "lineNbr": 1909,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Why do we need this forward declaration?\nThis should either be in the header file or static?",
+      "revId": "498fefbc810d25779724bbbca2160d876b8e025f",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
     }
   ]
 }

8663985e4da708bbd7257579640561311a727f97

@@ -88,6 +88,24 @@
       "revId": "8663985e4da708bbd7257579640561311a727f97",
       "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "285679f8_b84b0134",
+        "filename": "funcs/func_groupcount.c",
+        "patchSetId": 11
+      },
+      "lineNbr": 1385,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "77eee47e_e2bad76b",
+      "revId": "8663985e4da708bbd7257579640561311a727f97",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
     {
       "unresolved": true,
       "key": {

a6163041dc44deab65cae925d2a9dbf667b1d413

@@ -281,6 +281,24 @@
       "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
       "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "bd7afa0e_13d16dc8",
+        "filename": "include/asterisk/channel.h",
+        "patchSetId": 14
+      },
+      "lineNbr": 2931,
+      "author": {
+        "id": 1000337
+      },
+      "writtenOn": "2022-09-26T21:53:06Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "8d2656c7_c365d3ad",
+      "revId": "a6163041dc44deab65cae925d2a9dbf667b1d413",
+      "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1"
+    },
     {
       "unresolved": true,
       "key": {