From 12e709155fee6c30eb0167596e4f476e6a722f38 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000250 <1000250@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1> Date: Fri, 17 Dec 2021 15:32:41 -0600 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000337 \u003c1000337@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"ADD","reason":"Mark Murawski replied on the change"} Attention: {"person_ident":"Gerrit User 1000250 \u003c1000250@c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1\u003e","operation":"REMOVE","reason":"Mark Murawski replied on the change"} --- 7c21c70c50012e8ceec2c8b1cab379869199d3cb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/7c21c70c50012e8ceec2c8b1cab379869199d3cb b/7c21c70c50012e8ceec2c8b1cab379869199d3cb index 94defade6a..5adae44998 100644 --- a/7c21c70c50012e8ceec2c8b1cab379869199d3cb +++ b/7c21c70c50012e8ceec2c8b1cab379869199d3cb @@ -33,6 +33,24 @@ "message": "Upon further thought, as discussed, I don\u0027t think the ast_app_group_set_channel public API should be modified, since it\u0027s used in more places than I assumed it was. A new function that is called under the hood by ast_app_group_set_channel would preserve existing API, and contain the default value to a single place. Do the inheritance matter for existing function calls, or only the ones that are made within func_groupcount?", "revId": "7c21c70c50012e8ceec2c8b1cab379869199d3cb", "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1" + }, + { + "unresolved": false, + "key": { + "uuid": "94fddc49_529ac284", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1000250 + }, + "writtenOn": "2021-12-17T21:32:41Z", + "side": 1, + "message": "Upon further review, I must have previously refactored to not need to use the inherit option... because the current code does not use it at all.\n\nRemoving for the next upload.", + "parentUuid": "82cda966_53273aa4", + "revId": "7c21c70c50012e8ceec2c8b1cab379869199d3cb", + "serverId": "c8638cca-8a65-4d18-ba9a-ecd43d1ca9c1" } ] } \ No newline at end of file