You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David M. Lee 12c51024c3 Fix XML encoding of 'identity display' in NOTIFY messages. ... XML encoding in chan_sip is accomplished by naively building the XML directly from strings. While this usually works, it fails to take into account escaping the reserved characters in XML. This patch adds an 'ast_xml_escape' function, which works similarly to 'ast_uri_encode'. This is used to properly escape the local_display attribute in XML formatted NOTIFY messages. Several things to note: * The Right Thing(TM) to do would probably be to replace the ast_build_string stuff with building an ast_xml_doc. That's a much bigger change, and out of scope for the original ticket, so I refrained myself. * It is with great sadness that I wrote my own ast_xml_escape function. There's one in libxml2, but it's knee-deep in libxml2-ness, and not easily used to one-off escape a string. * I only escaped the string we know is causing problems (local_display). At least some of the other strings are URI-encoded, which should be XML safe. Rather than figuring out what's safe and escaping what's not, it would be much cleaner to simply build an ast_xml_doc for the messages and let the XML library do the XML escaping. Like I said, that's out of scope. (closes issue ABE-2902) Reported by: Guenther Kelleter Tested by: Guenther Kelleter Review: http://reviewboard.digium.internal/r/365/ ........ Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier ........ Merged revisions 378933 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@378934 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
Makefile	Change the name of the category 'TEST' to match the name of the subdir	15 years ago
test_abstract_jb.c	Unit tests for the Jitter Buffer API; remove unnecessary resync	13 years ago
test_acl.c	Silence a warning message from older versions of GCC.	13 years ago
test_ami_security_events.sh	Add an API for reporting security events, and a security event logging module.	16 years ago
test_amihooks.c	Merged revisions 338556 via svnmerge from	14 years ago
test_aoc.c	Merged revisions 332177 via svnmerge from	14 years ago
test_app.c	Merged revisions 332177 via svnmerge from	14 years ago
test_ast_format_str_reduce.c	Merged revisions 332177 via svnmerge from	14 years ago
test_astobj2.c	Change ao2 global array to ao2 global object holder.	13 years ago
test_astobj2_thrash.c	Migrate hashtest/hashtest2 to be unit tests.	13 years ago
test_config.c	Handle deprecated (aliased) option names with the config options api	13 years ago
test_db.c	app_queue: Support persisting and loading of long member lists.	13 years ago
test_devicestate.c	Make hints for invalid SIP devices return Unavail, not idle	13 years ago
test_dlinklists.c	Merged revisions 338556 via svnmerge from	14 years ago
test_event.c	Fix ast_event_new unit test.	13 years ago
test_expr.c	Merged revisions 332177 via svnmerge from	14 years ago
test_format_api.c	Audit of ao2_iterator_init() usage for v10.	13 years ago
test_func_file.c	Merged revisions 332177 via svnmerge from	14 years ago
test_gosub.c	Enable macros in 1.8 to find the next highest "h" extension in a context, like in 1.4.	13 years ago
test_hashtab_thrash.c	Migrate hashtest/hashtest2 to be unit tests.	13 years ago
test_heap.c	Merged revisions 332177 via svnmerge from	14 years ago
test_jitterbuf.c	Add tests for main/jitterbuf.c	13 years ago
test_linkedlists.c	Clean up and ensure proper usage of alloca()	13 years ago
test_locale.c	Merged revisions 338556 via svnmerge from	14 years ago
test_logger.c	Merged revisions 338556 via svnmerge from	14 years ago
test_netsock2.c	Add a unit test for ast_sockaddr_split_hostport	14 years ago
test_pbx.c	Merged revisions 337062 via svnmerge from	14 years ago
test_poll.c	Add leading and trailing backslashes	13 years ago
test_sched.c	Merged revisions 332177 via svnmerge from	14 years ago
test_security_events.c	Update security events unit tests	13 years ago
test_skel.c	Merged revisions 332177 via svnmerge from	14 years ago
test_stringfields.c	Merged revisions 332177 via svnmerge from	14 years ago
test_strings.c	Merged revisions 332177 via svnmerge from	14 years ago
test_substitution.c	Opaquify ast_channel structs and lists	13 years ago
test_time.c	Merged revisions 332177 via svnmerge from	14 years ago
test_utils.c	Fix some tests that didn't get opaquification changes	13 years ago
test_voicemail_api.c	Multiple revisions 368963,368965	13 years ago
test_xml_escape.c	Fix XML encoding of 'identity display' in NOTIFY messages.	12 years ago