You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Matthew Jordan f3965b2276 app_confbridge: Fix crash caused when waitmarked/marked users leave together ... When waitmarked users join a ConfBridge, the conference state is transitioned from EMPTY -> INACTIVE. In this state, the users are maintined in a waiting users list. When a marked user joins, the ConfBridge conference transitions from INACTIVE -> MULTI_MARKED, and all users are put onto the active list of users. This process works correctly. When the marked user leaves, if they are the last marked user, the MULTI_MARKED state does the following: (1) It plays back a message to the bridge stating that the leader has left the conference. This requires an unlocking of the bridge. (2) It moves waitmarked users back to the waiting list (3) It transitions to the appropriate state: in this case, INACTIVE However, because it plays the prompt back to the bridge before moving the users and before finishing the state transition, this creates a race condition: with the bridge unlocked, waitmarked users who leave the conference (or are kicked from it) can cause a state transition of the bridge to another state before the conference is transitioned to the INACTIVE state. This causes the state machine to get a bit wonky, often leading to a crash when the MULTI_MARKED state attempts to conclude its processing. This patch fixes this problem: (1) It prevents kicked users from being kicked again. That's just a nicety. (2) More importantly, it fixes the race condition by only playing the prompt once the state has transitioned correctly to INACTIVE. If waitmarked users sneak out during the prompt being played, no harm no foul. Review: https://reviewboard.asterisk.org/r/3108/ (closes issue AST-1258) Reported by: Steve Pitts ........ Merged revisions 405215 from http://svn.asterisk.org/svn/asterisk/branches/11 git-svn-id: https://origsvn.digium.com/svn/asterisk/certified/branches/11.6@405233 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
include	app_confbridge: Fix memory leak on reload.	13 years ago
conf_config_parser.c	app_confbridge: Fix memory leak on reload.	13 years ago
conf_state.c	confbridge: Fix MOH on simultaneous user entry to a new conference.	13 years ago
conf_state_empty.c	Prevent exhaustion of system resources through exploitation of event cache	13 years ago
conf_state_inactive.c	Resolve issues in ConfBridge regarding marked, waitmarked, and unmarked users	13 years ago
conf_state_multi.c	Resolve issues in ConfBridge regarding marked, waitmarked, and unmarked users	13 years ago
conf_state_multi_marked.c	app_confbridge: Fix crash caused when waitmarked/marked users leave together	12 years ago
conf_state_single.c	Resolve issues in ConfBridge regarding marked, waitmarked, and unmarked users	13 years ago
conf_state_single_marked.c	Resolve issues in ConfBridge regarding marked, waitmarked, and unmarked users	13 years ago