You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Vossel 12fb1e8bde Merged revisions 225445 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r225445 | dvossel | 2009-10-22 14:55:51 -0500 (Thu, 22 Oct 2009) | 50 lines SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes. What this patch fixes 1.Moves sip TCP/TLS connection setup into the TCP helper thread: Connection setup takes awhile and before this it was being done while holding the monitor lock. 2.Moves TCP/TLS writing to the TCP helper thread: Through the use of a packet queue and an alert pipe, the TCP helper thread can now be woken up to write data as well as read data. 3.Locking error: sip_xmit returned an XMIT_ERROR without giving up the tcptls_session lock. This lock has been completely removed from sip_xmit and placed in the new sip_tcptls_write() function. 4.Memory leak: When creating a tcptls_client the tls_cfg was alloced but never freed unless the tcptls_session failed to start. Now the session_args for a sip client are an ao2 object which frees the tls_cfg on destruction. 5.Pointer to stack variable: During sip_prepare_socket the creation of a client's ast_tcptls_session_args was done on the stack and stored as a pointer in the newly created tcptls_session. Depending on the events that followed, there was a slight possibility that pointer could have been accessed after the stack returned. Given the new changes, it is always accessed after the stack returns which is why I found it. Notable code changes 1.I broke tcptls.c's ast_tcptls_client_start() function into two functions. One for creating and allocating the new tcptls_session, and a separate one for starting and handling the new connection. This allowed me to create the tcptls_session, launch the helper thread, and then establish the connection within the helper thread. 2.Writes to a tcptls_session are now done within the helper thread. This is done by using an alert pipe to wake up the thread if new data needs to be sent. The thread's sip_threadinfo object contains the alert pipe as well as the packet queue. 3.Since the threadinfo object contains the alert pipe, it must now be accessed outside of the helper thread for every write (queuing of a packet). For easy lookup, I moved the threadinfo objects from a linked list to an ao2_container. (closes issue #13136) Reported by: pabelanger Tested by: dvossel, whys (closes issue #15894) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/380/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@225489 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
db1-ast	Merged revisions 209887 via svnmerge from	17 years ago
editline	Merged revisions 179395 via svnmerge from	17 years ago
stdtime	Merged revisions 189539 via svnmerge from	17 years ago
Makefile	Merged revisions 215567 via svnmerge from	17 years ago
abstract_jb.c	Spacing changes only	17 years ago
acl.c	Merged revisions 215955 via svnmerge from	17 years ago
adsistub.c	…
aescrypt.c	Spacing changes only	17 years ago
aeskey.c	…
aesopt.h	…
aestab.c	…
alaw.c	Merged revisions 213179 via svnmerge from	17 years ago
app.c	Merged revisions 215567 via svnmerge from	17 years ago
ast_expr2.c	Merged revisions 203444 via svnmerge from	17 years ago
ast_expr2.fl	Merged revisions 203444 via svnmerge from	17 years ago
ast_expr2.h	Merged revisions 179807 via svnmerge from	17 years ago
ast_expr2.y	Merged revisions 179807 via svnmerge from	17 years ago
ast_expr2f.c	Merged revisions 201678 via svnmerge from	17 years ago
asterisk.c	Merged revisions 221777 via svnmerge from	17 years ago
astfd.c	Merged revisions 211275 via svnmerge from	17 years ago
astmm.c	Janitor, use ARRAY_LEN() when possible.	17 years ago
astobj2.c	Merged revisions 222176 via svnmerge from	17 years ago
audiohook.c	Merged revisions 224856 via svnmerge from	17 years ago
autoservice.c	Merged revisions 223487 via svnmerge from	17 years ago
bridging.c	Merged revisions 193502 via svnmerge from	17 years ago
buildinfo.c	…
callerid.c	Merged revisions 206868 via svnmerge from	17 years ago
cdr.c	AST-2009-005	17 years ago
channel.c	Merged revisions 223273 via svnmerge from	17 years ago
chanvars.c	…
cli.c	AST-2009-005	17 years ago
config.c	Merged revisions 219061 via svnmerge from	17 years ago
cryptostub.c	…
cygload.c	…
datastore.c	Merged revisions 192318 via svnmerge from	17 years ago
db.c	Merged revisions 182450 via svnmerge from	17 years ago
devicestate.c	Merged revisions 205412 via svnmerge from	17 years ago
dial.c	* Fixed timeout logic in the dialing API as setting timeouts	18 years ago
dns.c	incorporates r159808 from branches/1.4:	18 years ago
dnsmgr.c	AST-2009-005	17 years ago
dsp.c	AST-2009-005	17 years ago
ecdisa.h	…
enum.c	AST-2009-005	17 years ago
event.c	Merged revisions 209835 via svnmerge from	17 years ago
features.c	Merged revisions 224774 via svnmerge from	17 years ago
file.c	Merged revisions 222880 via svnmerge from	17 years ago
fixedjitterbuf.c	…
fixedjitterbuf.h	…
frame.c	Merged revisions 222880 via svnmerge from	17 years ago
fskmodem.c	…
fskmodem_float.c	…
fskmodem_int.c	…
global_datastores.c	Merged revisions 172517 via svnmerge from	17 years ago
hashtab.c	Add MALLOC_DEBUG to various utility APIs, so that memory leaks can be tracked back to their source.	17 years ago
heap.c	Merged revisions 184512 via svnmerge from	17 years ago
http.c	AST-2009-005	17 years ago
image.c	…
indications.c	AST-2009-005	17 years ago
io.c	Merged revisions 182847 via svnmerge from	17 years ago
jitterbuf.c	Merged revisions 174583 via svnmerge from	17 years ago
loader.c	Merged revisions 213450 via svnmerge from	17 years ago
logger.c	Merged revisions 221920 via svnmerge from	17 years ago
manager.c	Merged revisions 214514 via svnmerge from	17 years ago
md5.c	…
netsock.c	Merged revisions 222873 via svnmerge from	17 years ago
pbx.c	Merged revisions 225360 via svnmerge from	17 years ago
plc.c	…
poll.c	Merged revisions 182847 via svnmerge from	17 years ago
privacy.c	…
rtp.c	Merged revisions 224671 via svnmerge from	17 years ago
say.c	Merged revisions 221777 via svnmerge from	17 years ago
sched.c	Fix a regression in scheduler entry ordering, and add a regression test for it.	17 years ago
sha1.c	…
slinfactory.c	Merged revisions 201056 via svnmerge from	17 years ago
srv.c	bump the verbosity of a message in srv.c up by one. It used to be	17 years ago
ssl.c	Merged revisions 205532 via svnmerge from	17 years ago
strcompat.c	…
strings.c	Merged revisions 186021 via svnmerge from	17 years ago
taskprocessor.c	Merged revisions 185912 via svnmerge from	17 years ago
tcptls.c	Merged revisions 225445 via svnmerge from	17 years ago
tdd.c	Merged revisions 185912 via svnmerge from	17 years ago
term.c	Merge changes from team/group/appdocsxml	18 years ago
threadstorage.c	Merged revisions 164736 via svnmerge from	17 years ago
timing.c	AST-2009-005	17 years ago
translate.c	Merged revisions 208924 via svnmerge from	17 years ago
udptl.c	Merged revisions 222110 via svnmerge from	17 years ago
ulaw.c	Merged revisions 213179 via svnmerge from	17 years ago
utils.c	Merged revisions 216506 via svnmerge from	17 years ago
xml.c	Merged revisions 197374 via svnmerge from	17 years ago
xmldoc.c	Merged revisions 196948 via svnmerge from	17 years ago