You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David M. Lee 2de42c2a25 Multiple revisions 399887,400138,400178,400180-400181 ... ........ r399887 | dlee | 2013-09-26 10:41:47 -0500 (Thu, 26 Sep 2013) | 1 line Minor performance bump by not allocate manager variable struct if we don't need it ........ r400138 | dlee | 2013-09-30 10:24:00 -0500 (Mon, 30 Sep 2013) | 23 lines Stasis performance improvements This patch addresses several performance problems that were found in the initial performance testing of Asterisk 12. The Stasis dispatch object was allocated as an AO2 object, even though it has a very confined lifecycle. This was replaced with a straight ast_malloc(). The Stasis message router was spending an inordinate amount of time searching hash tables. In this case, most of our routers had 6 or fewer routes in them to begin with. This was replaced with an array that's searched linearly for the route. We more heavily rely on AO2 objects in Asterisk 12, and the memset() in ao2_ref() actually became noticeable on the profile. This was #ifdef'ed to only run when AO2_DEBUG was enabled. After being misled by an erroneous comment in taskprocessor.c during profiling, the wrong comment was removed. Review: https://reviewboard.asterisk.org/r/2873/ ........ r400178 | dlee | 2013-09-30 13:26:27 -0500 (Mon, 30 Sep 2013) | 24 lines Taskprocessor optimization; switch Stasis to use taskprocessors This patch optimizes taskprocessor to use a semaphore for signaling, which the OS can do a better job at managing contention and waiting that we can with a mutex and condition. The taskprocessor execution was also slightly optimized to reduce the number of locks taken. The only observable difference in the taskprocessor implementation is that when the final reference to the taskprocessor goes away, it will execute all tasks to completion instead of discarding the unexecuted tasks. For systems where unnamed semaphores are not supported, a really simple semaphore implementation is provided. (Which gives identical performance as the original taskprocessor implementation). The way we ended up implementing Stasis caused the threadpool to be a burden instead of a boost to performance. This was switched to just use taskprocessors directly for subscriptions. Review: https://reviewboard.asterisk.org/r/2881/ ........ r400180 | dlee | 2013-09-30 13:39:34 -0500 (Mon, 30 Sep 2013) | 28 lines Optimize how Stasis forwards are dispatched This patch optimizes how forwards are dispatched in Stasis. Originally, forwards were dispatched as subscriptions that are invoked on the publishing thread. This did not account for the vast number of forwards we would end up having in the system, and the amount of work it would take to walk though the forward subscriptions. This patch modifies Stasis so that rather than walking the tree of forwards on every dispatch, when forwards and subscriptions are changed, the subscriber list for every topic in the tree is changed. This has a couple of benefits. First, this reduces the workload of dispatching messages. It also reduces contention when dispatching to different topics that happen to forward to the same aggregation topic (as happens with all of the channel, bridge and endpoint topics). Since forwards are no longer subscriptions, the bulk of this patch is simply changing stasis_subscription objects to stasis_forward objects (which, admittedly, I should have done in the first place.) Since this required me to yet again put in a growing array, I finally abstracted that out into a set of ast_vector macros in asterisk/vector.h. Review: https://reviewboard.asterisk.org/r/2883/ ........ r400181 | dlee | 2013-09-30 13:48:57 -0500 (Mon, 30 Sep 2013) | 28 lines Remove dispatch object allocation from Stasis publishing While looking for areas for performance improvement, I realized that an unused feature in Stasis was negatively impacting performance. When a message is sent to a subscriber, a dispatch object is allocated for the dispatch, containing the topic the message was published to, the subscriber the message is being sent to, and the message itself. The topic is actually unused by any subscriber in Asterisk today. And the subscriber is associated with the taskprocessor the message is being dispatched to. First, this patch removes the unused topic parameter from Stasis subscription callbacks. Second, this patch introduces the concept of taskprocessor local data, data that may be set on a taskprocessor and provided along with the data pointer when a task is pushed using the ast_taskprocessor_push_local() call. This allows the task to have both data specific to that taskprocessor, in addition to data specific to that invocation. With those two changes, the dispatch object can be removed completely, and the message is simply refcounted and sent directly to the taskprocessor. Review: https://reviewboard.asterisk.org/r/2884/ ........ Merged revisions 399887,400138,400178,400180-400181 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400186 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
confbridge	Multiple revisions 399887,400138,400178,400180-400181	12 years ago
Makefile	Moved core logic from app_stasis to res_stasis	12 years ago
app_adsiprog.c	Doxygen Updates - Title update	13 years ago
app_agent_pool.c	Restore Dial, Queue, and FollowMe 'I' option support.	12 years ago
app_alarmreceiver.c	Fix XML Document Validation Failure	13 years ago
app_amd.c	Doxygen Updates - Title update	13 years ago
app_authenticate.c	Update Asterisk's CDRs for the new bridging framework	12 years ago
app_bridgewait.c	Bridge API: Set a cause code on a channel when it is ejected from a bridge.	12 years ago
app_cdr.c	app_cdr and res_parking: Fix some resource leaks.	12 years ago
app_celgenuserevent.c	Add transfer support to CEL	12 years ago
app_chanisavail.c	app_chanisavail: Fix use of uninitialized variable.	13 years ago
app_channelredirect.c	Merge in the bridge_construction branch to make the system use the Bridging API.	12 years ago
app_chanspy.c	Add SayAlphaCase and similar functionality for AGI	12 years ago
app_confbridge.c	Bridge API: Set a cause code on a channel when it is ejected from a bridge.	12 years ago
app_controlplayback.c	Add ControlPlayback manager action	13 years ago
app_dahdibarge.c	Opaquify ast_channel typedefs, fd arrays, and softhangup flag	13 years ago
app_dahdiras.c	Opaquify ast_channel typedefs, fd arrays, and softhangup flag	13 years ago
app_db.c	Don't throw a spurious error when using DBdeltree	12 years ago
app_dial.c	Adding a few words to the Dial option 'r' help text to clarify its tone argument description	12 years ago
app_dictate.c	Clean up and ensure proper usage of alloca()	13 years ago
app_directed_pickup.c	Remove dead code from features.c; refactor pickup code into pickup.c	12 years ago
app_directory.c	Add SayAlphaCase and similar functionality for AGI	12 years ago
app_disa.c	Update Asterisk's CDRs for the new bridging framework	12 years ago
app_dumpchan.c	Verbose logging discrepancies	12 years ago
app_echo.c	Prevent Echo() from relaying control, null, and modem frames	13 years ago
app_exec.c	Merged revisions 328247 via svnmerge from	14 years ago
app_externalivr.c	Remove declaration of eivr_connect_socket because it no longer exists.	13 years ago
app_fax.c	Resolve a merge conflict	12 years ago
app_festival.c	Doxygen Updates - Title update	13 years ago
app_flash.c	Opaquify ast_channel typedefs, fd arrays, and softhangup flag	13 years ago
app_followme.c	Minor tweaks with ast_moh_start() callers.	12 years ago
app_forkcdr.c	Update Asterisk's CDRs for the new bridging framework	12 years ago
app_getcpeid.c	Clean up and ensure proper usage of alloca()	13 years ago
app_ices.c	Doxygen Updates - janitor work	13 years ago
app_image.c	Merged revisions 328247 via svnmerge from	14 years ago
app_ivrdemo.c	ast_channel opaquification of pointers and integral types	13 years ago
app_jack.c	Multiple revisions 375993-375994	13 years ago
app_macro.c	Clean up and ensure proper usage of alloca()	13 years ago
app_meetme.c	Multiple revisions 399887,400138,400178,400180-400181	12 years ago
app_milliwatt.c	Replace GNU old-style field designator extensions to fix clang warnings	13 years ago
app_minivm.c	ARI: Add recording controls	12 years ago
app_mixmonitor.c	Fix memory leaks	12 years ago
app_morsecode.c	Merged revisions 336717 via svnmerge from	14 years ago
app_mp3.c	Opaquification for ast_format structs in struct ast_channel	13 years ago
app_nbscat.c	Opaquification for ast_format structs in struct ast_channel	13 years ago
app_originate.c	Allow support for early media on AMI originates and call files.	13 years ago
app_osplookup.c	Update Asterisk's CDRs for the new bridging framework	12 years ago
app_page.c	app_page and app_confbridge: Fix custom announcement on entering conference.	12 years ago
app_playback.c	Check result of ast_var_assign() calls for memory allocation failure.	12 years ago
app_playtones.c	ast_channel opaquification of pointers and integral types	13 years ago
app_privacy.c	Opaquify ast_channel structs and lists	13 years ago
app_queue.c	Multiple revisions 399887,400138,400178,400180-400181	12 years ago
app_read.c	ast_channel opaquification of pointers and integral types	13 years ago
app_readexten.c	Opaquify ast_channel structs and lists	13 years ago
app_readfile.c	Merged revisions 328247 via svnmerge from	14 years ago
app_record.c	Multiple revisions 375993-375994	13 years ago
app_saycounted.c	Merged revisions 336717 via svnmerge from	14 years ago
app_sayunixtime.c	ast_channel opaquification of pointers and integral types	13 years ago
app_senddtmf.c	Add pause one second W dial modifier.	13 years ago
app_sendtext.c	ast_channel opaquification of pointers and integral types	13 years ago
app_setcallerid.c	Opaquify ast_channel structs and lists	13 years ago
app_skel.c	Add CLI configuration documentation	12 years ago
app_sms.c	Clean up and ensure proper usage of alloca()	13 years ago
app_softhangup.c	ast_channel opaquification of pointers and integral types	13 years ago
app_speech_utils.c	app_speech_utils: Fix unresolved symbol ast_speech_get_setting().	12 years ago
app_stack.c	Check result of ast_var_assign() calls for memory allocation failure.	12 years ago
app_stasis.c	Fix menuselect display for stasis modules.	12 years ago
app_system.c	Multiple revisions 369001-369002	13 years ago
app_talkdetect.c	Finalize ast_channel opaquification	13 years ago
app_test.c	Opaquification for ast_format structs in struct ast_channel	13 years ago
app_transfer.c	Fix the display of documentation for Transfer	13 years ago
app_url.c	Merged revisions 339777 via svnmerge from	14 years ago
app_userevent.c	Refactor code and fix a reference leak	12 years ago
app_verbose.c	Verbose logging discrepancies	12 years ago
app_voicemail.c	Multiple revisions 399887,400138,400178,400180-400181	12 years ago
app_voicemail.exports.in	Remove some symbol exports that got missed in the removal of global symbols.	13 years ago
app_waitforring.c	Multiple revisions 375993-375994	13 years ago
app_waitforsilence.c	Opaquification for ast_format structs in struct ast_channel	13 years ago
app_waituntil.c	Merged revisions 328247 via svnmerge from	14 years ago
app_while.c	Clean up and ensure proper usage of alloca()	13 years ago
app_zapateller.c	Opaquify ast_channel structs and lists	13 years ago
enter.h	remove extraneous svn:executable properties	20 years ago
leave.h	remove extraneous svn:executable properties	20 years ago