You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Steve Murphy 1985be224e This patch is relevant to: ... ABE-1628 and RYM-150398 and AST-103 in internal Digium bug trackers. These fixes address a really subtle memory corruption problem that would happen in machines heavily loaded in production environments. The corruption would always take the form of the STMT object getting nulled out and one of the unixODBC calls would crash trying to access statement->connection. It isn't fully proven yet, but the server has now been running 2.5 days without appreciable memory growth, or any gain of %cpu, and no crashes. Whether this is the problem or not on that server, these fixes are still warranted. As it turns out, **I** introduced these errors unwittingly, when I corrected another crash earlier. I had formed the build_query routine, and failed to remove mutex_unlock calls in 3 places in the transplanted code. These unlocks would only happen in error situations, but unlocking the mutex early set the code up for a catastrophic failure, it appears. It would happen only once every 100K-200K or more calls, under heavy load... but that is enough. If another crash occurs, with the same MO, I'll come back and remove my confession from the log, and we'll keep searching, but the fact that we have Asterisk dying from an asynchronous wiping of the STMT object, only on some connection error, and that the server has lived for 2.5 days on this code without a crash, sure make it look like this was the problem! Also, in several points, Statement handles are set to NULL after SQLFreeHandle. This was mainly for insurance, to guarantee a crash. As it turns out, the code does not appear to be attempting to use these freed pointers. Asterisk owes a debt of gratitude to Federico Alves and Frediano Ziglio for their untiring efforts in finding this bug, among others. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@150056 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
Makefile	fix some copy-and-paste leftovers	18 years ago
cdr_csv.c	a whole pile of Zaptel/DAHDI compatibility work, with lots more to come... this tree is not yet ready for users to be easily upgrading or switching, but it needs to be :-)	17 years ago
cdr_custom.c	Make file access in cdr_custom similar to cdr_csv.	17 years ago
cdr_manager.c	use ast_localtime() in every place localtime_r() was being used	18 years ago
cdr_odbc.c	This patch is relevant to:	17 years ago
cdr_pgsql.c	Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping	18 years ago
cdr_radius.c	use ast_localtime() in every place localtime_r() was being used	18 years ago
cdr_sqlite.c	use ast_localtime() in every place localtime_r() was being used	18 years ago
cdr_tds.c	Bring cdr_tds in line with the other CDR backends and have it try to store	17 years ago