asterisk

History

David Brooks a2933fefef Fix incorrect parsing in chan_gtalk when xmpp contains extra whitespaces To drill into the xmpp to find the capabilities between channels, chan_gtalk calls iks_child() and iks_next(). iks_child() and iks_next() are functions in the iksemel xml parsing library that traverse xml nodes. The bug here is that both iks_child() and iks_next() will return the next iks_struct node regardless of type. chan_gtalk expects the next node to be of type IKS_TAG, which in most cases, it is, but in this case (a call being made from the Empathy IM client), there exists iks_struct nodes which are not IKS_TAG data (they are extraneous whitespaces), and chan_gtalk doesn't handle that case, so capabilities don't match, and a call cannot be made. iks_first_tag() and iks_next_tag(), on the other hand, will not return the very next iks_struct, but will check to see if the next iks_struct is of type IKS_TAG. If it isn't, it will be skipped, and the next struct of type IKS_TAG it finds will be returned. This assures that chan_gtalk will find the iks_struct it is looking for. This fix simply changes all calls to iks_child() and iks_next() to become calls to iks_first_tag() and iks_next_tag(), which resolves the capability matching. The following is a payload listing from Empathy, which, due to the extraneous whitespace, will not be parsed correctly by iksemel: <iq from='dbrooksjab@235-22-24-10/Telepathy' to='astjab@235-22-24-10/asterisk' type='set' id='542757715704'> <session xmlns='http://www.google.com/session' initiator='dbrooksjab@235-22-24-10/Telepathy' type='initiate' id='1837267342'> <description xmlns='http://www.google.com/session/phone'> <payload-type clockrate='16000' name='speex' id='96'/> <payload-type clockrate='8000' name='PCMA' id='8'/> <payload-type clockrate='8000' name='PCMU' id='0'/> <payload-type clockrate='90000' name='MPA' id='97'/> <payload-type clockrate='16000' name='SIREN' id='98'/> <payload-type clockrate='8000' name='telephone-event' id='99'/> </description> </session> </iq> git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@185362 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
h323	Allow H.323 Plus library to be used in addition to the OpenH323 library	17 years ago
misdn	Make chan_misdn BRI TE side normally defer channel selection to the NT side.	17 years ago
DialTone.h	remove extraneous svn:executable properties	20 years ago
Makefile	rename these files so as to avoid conflicts when users update their working copies and have unversioned files already in place	17 years ago
answer.h	remove extraneous svn:executable properties	20 years ago
busy_tone.h	rename these files so as to avoid conflicts when users update their working copies and have unversioned files already in place	17 years ago
chan_agent.c	Fix devicestate problems for "always-on" agent channels	17 years ago
chan_alsa.c	Fix cases where the internal poll() was not being used when it needed to be.	17 years ago
chan_dahdi.c	Reordering, to change prior to unlocking	17 years ago
chan_features.c	Disable chan_features by default in menuselect	19 years ago
chan_gtalk.c	Fix incorrect parsing in chan_gtalk when xmpp contains extra whitespaces	17 years ago
chan_h323.c	Allow H.323 Plus library to be used in addition to the OpenH323 library	17 years ago
chan_iax2.c	Fix a crash in IAX2 registration handling found during load testing with dvossel.	17 years ago
chan_local.c	Fixup glare detection, to fix a memory leak of a local pvt structure.	17 years ago
chan_mgcp.c	Port "hasvoicemail" change from SIP to other channel drivers	18 years ago
chan_misdn.c	Revert unnecessary indications API change from rev 122314	17 years ago
chan_nbs.c	This is a big improvement over the current CDR fixes. It may still need refinement, but this won't have as many folks bothered.	19 years ago
chan_oss.c	Correctly track the hookstate	17 years ago
chan_phone.c	For some reason, after a distclean, gcc started returning	17 years ago
chan_sip.c	Improve our handling of T38 in the initial INVITE from a device.	17 years ago
chan_skinny.c	Fix cases where the internal poll() was not being used when it needed to be.	17 years ago
chan_vpb.cc	update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors	17 years ago
gentone-ulaw.c	remove extraneous svn:executable properties	20 years ago
gentone.c	remove extraneous svn:executable properties	20 years ago
iax2-parser.c	In case we have some processing threads that free more frames than they allocate,	18 years ago
iax2-parser.h	encrypted IAX2 during packet loss causes decryption to fail on retransmitted frames	17 years ago
iax2-provision.c	Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)	20 years ago
iax2-provision.h	useless 'extern' and trailing whitespace removal	20 years ago
iax2.h	use the ARRAY_LEN macro for indexing through the iaxs/iaxsl arrays so that the size of the arrays can be adjusted in one place, and change the size of the arrays from 32768 calls to 2048 calls when LOW_MEMORY is defined	18 years ago
misdn_config.c	Update the channel allocation method documentation.	17 years ago
ring10.h	remove extraneous svn:executable properties	20 years ago
ring_tone.h	rename these files so as to avoid conflicts when users update their working copies and have unversioned files already in place	17 years ago