You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Richard Mudgett 25de01f301 SIP diversion: Fix REDIRECTING(reason) value inconsistencies. ... Previous chan_sip behavior: Before this patch chan_sip would always strip any quotes from an incoming reason and pass that value up as the REDIRECTING(reason). For an outgoing reason value, chan_sip would check the value against known values and quote any it didn't recognize. Incoming 480 response message reason text was just assigned to the REDIRECTING(reason). Previous chan_pjsip behavior: Before this patch chan_pjsip would always pass the incoming reason value up as the REDIRECTING(reason). For an outgoing reason value, chan_pjsip would send the reason value as passed down. With this patch: Both channel drivers match incoming reason values with values documented by REDIRECTING(reason) and values documented by RFC5806 regardless of whether they are quoted or not. RFC5806 values are mapped to the equivalent REDIRECTING(reason) documented value and is set in REDIRECTING(reason). e.g., an incoming RFC5806 'unconditional' value or a quoted string version ('"unconditional"') is converted to REDIRECTING(reason)'s 'cfu' value. The user's dialplan only needs to deal with 'cfu' instead of any of the aliases. The incoming 480 response reason text supported by chan_sip checks for known reason values and if not matched then puts quotes around the reason string and assigns that to REDIRECTING(reason). Both channel drivers send outgoing known REDIRECTING(reason) values as the unquoted RFC5806 equivalent. User custom values are either sent as is or with added quotes if SIP doesn't allow a character within the value as part of a RFC3261 Section 25.1 token. Note that there are still limitations on what characters can be put in a custom user value. e.g., embedding quotes in the middle of the reason string is silly and just going to cause you grief. * Setting a REDIRECTING(reason) value now recognizes RFC5806 aliases. e.g., Setting REDIRECTING(reason) to 'unconditional' is converted to the 'cfu' value. * Added missing malloc() NULL return check in res_pjsip_diversion.c set_redirecting_reason(). * Fixed potential read from a stale pointer in res_pjsip_diversion.c add_diversion_header(). The reason string needed to be copied into the tdata memory pool to ensure that the string would always be available. Otherwise, if the reason string returned by reason_code_to_str() was a user's reason string then the string could be freed later by another thread. Change-Id: Ifba83d23a195a9f64d55b9c681d2e62476b68a87		9 years ago
..
dahdi	Modules: Make ast_module_info->self available to auxiliary sources.	10 years ago
iax2	git migration: Refactor the ASTERISK_FILE_VERSION macro	10 years ago
misdn	Makefile: Remove coverage files on 'make clean'	10 years ago
pjsip	channels/pjsip/dialplan_functions: Add an option for extracting the SIP call-id	10 years ago
sip	Merge "chan_sip: option 'notifyringing' change and doc fix"	10 years ago
Makefile	Makefile: Remove coverage files on 'make clean'	10 years ago
chan_alsa.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_bridge_media.c	AST_MODULE_INFO: Format corrections to the usages of AST_MODULE_INFO macro.	10 years ago
chan_console.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_dahdi.c	build_system: Fix some warnings highlighted by clang	9 years ago
chan_dahdi.h	chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.	10 years ago
chan_iax2.c	Audit improper usage of scheduler exposed by 5c713fdf18.	10 years ago
chan_mgcp.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_misdn.c	chan_misdn: Fix a few issues causing compile errors	9 years ago
chan_motif.c	build_system: Fix some warnings highlighted by clang	9 years ago
chan_nbs.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_oss.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_phone.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_phone.h	rename DialTone.h to chan_phone.h because chan_phone.c is the only file using it	17 years ago
chan_pjsip.c	chan_pjsip: Handle T.38 faxes with direct media bridges	10 years ago
chan_rtp.c	git migration: Refactor the ASTERISK_FILE_VERSION macro	10 years ago
chan_sip.c	SIP diversion: Fix REDIRECTING(reason) value inconsistencies.	9 years ago
chan_skinny.c	Audit improper usage of scheduler exposed by 5c713fdf18. (v13 additions)	10 years ago
chan_unistim.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
chan_vpb.cc	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
console_board.c	git migration: Refactor the ASTERISK_FILE_VERSION macro	10 years ago
console_gui.c	Multiple revisions 369001-369002	13 years ago
console_video.c	git migration: Refactor the ASTERISK_FILE_VERSION macro	10 years ago
console_video.h	implement the 'freeze' function for incoming frames;	17 years ago
misdn_config.c	chan_misdn: Fix a few issues causing compile errors	9 years ago
sig_analog.c	build_system: Fix some warnings highlighted by clang	9 years ago
sig_analog.h	chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.	10 years ago
sig_pri.c	build: GCC 5.1.x catches some new const, array bounds and missing paren issues	10 years ago
sig_pri.h	sig_pri.h: force_restart_unavailable_chans in wrong scope	10 years ago
sig_ss7.c	Logger: Convert 'struct ast_callid' to unsigned int.	10 years ago
sig_ss7.h	chan_dahdi: Adds support for major update to libss7.	11 years ago
vcodecs.c	Fix printf problems with high ascii characters after r413586 (1.8).	11 years ago
vgrabbers.c	git migration: Refactor the ASTERISK_FILE_VERSION macro	10 years ago