You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Mark Michelson 52752df83c Check the DYNAMIC_FEATURES of both the chan and peer when interpreting DTMF. ... Dynamic features defined in the applicationmap section of features.conf allow one to specify whether the caller, callee, or both have the ability to use the feature. The documentation in the features.conf.sample file could be interpreted to mean that one only needs to set the DYNAMIC_FEATURES channel variable on the calling channel in order to allow for the callee to be able to use the features which he should have permission to use. However, the DYNAMIC_FEATURES variable would only be read from the channel of the participant that pressed the DTMF sequence to activate the feature. The result of this was that the callee was unable to use dynamic features unless the dialplan writer had taken measures to be sure that the DYNAMIC_FEATURES variable was set on the callee's channel. This commit changes the behavior of ast_feature_interpret to concatenate the values of DYNAMIC_FEATURES from both parties involved in the bridge. The features themselves determine who has permission to use them, so there is no reason to believe that one side of the bridge could gain the ability to perform an action that they should not have the ability to perform. Kevin Fleming pointed out on the asterisk-users list that the typical way that this was worked around in the past was by setting _DYNAMIC_FEATURES on the calling channel so that the value would be inherited by the called channel. While this works, the documentation alone is not enough to figure out why this is necessary for the callee to be able to use dynamic features. In this particular case, changing the code to match the documentation is safe, easy, and will generally make things easier for people for future installations. This bug was originally reported on the asterisk-users list by David Ruggles. (closes issue #14657) Reported by: mmichelson Patches: 14657.patch uploaded by mmichelson (license 60) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@181990 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
snmp	Fix a race condition that could cause a crash.	17 years ago
Makefile	the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.	18 years ago
res_adsi.c	Free some frames that would otherwise leak on error.	19 years ago
res_agi.c	Lose the CAP_NET_ADMIN at every fork, instead of at startup. Otherwise, if	17 years ago
res_clioriginate.c	Perform dialing asynchronously when using the originate CLI command so the CLI does not appear to block.	18 years ago
res_config_odbc.c	Oops	18 years ago
res_config_pgsql.c	Change warning message to debug, since there are cases where 0 results is perfectly fine.	18 years ago
res_convert.c	(closes issue #10246)	19 years ago
res_crypto.c	fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends	18 years ago
res_features.c	Check the DYNAMIC_FEATURES of both the chan and peer when interpreting DTMF.	17 years ago
res_indications.c	Revert unnecessary indications API change from rev 122314	17 years ago
res_jabber.c	somehow missed a bunch of gcc 4.3.x warnings in this branch on the first pass	18 years ago
res_monitor.c	1. Prevent the addition of an extra '/' to the beginning of an absolute pathname.	18 years ago
res_musiconhold.c	Fix incorrect usage of strncasecmp... I really meant to use strcasecmp.	17 years ago
res_odbc.c	Some sanity checks that may have led to prior crashes, found by codefreeze-lap	18 years ago
res_smdi.c	Dialplan functions should not actually return 0, unless they have modified the	18 years ago
res_snmp.c	Disable reload functionality in res_snmp. It is not possible to initialize the	19 years ago
res_speech.c	Make it the engine's responsible to check for the presence of results.	19 years ago