asterisk

History

David M. Lee c5aee60db5 Fix XML encoding of 'identity display' in NOTIFY messages. XML encoding in chan_sip is accomplished by naively building the XML directly from strings. While this usually works, it fails to take into account escaping the reserved characters in XML. This patch adds an 'ast_xml_escape' function, which works similarly to 'ast_uri_encode'. This is used to properly escape the local_display attribute in XML formatted NOTIFY messages. Several things to note: * The Right Thing(TM) to do would probably be to replace the ast_build_string stuff with building an ast_xml_doc. That's a much bigger change, and out of scope for the original ticket, so I refrained myself. * It is with great sadness that I wrote my own ast_xml_escape function. There's one in libxml2, but it's knee-deep in libxml2-ness, and not easily used to one-off escape a string. * I only escaped the string we know is causing problems (local_display). At least some of the other strings are URI-encoded, which should be XML safe. Rather than figuring out what's safe and escaping what's not, it would be much cleaner to simply build an ast_xml_doc for the messages and let the XML library do the XML escaping. Like I said, that's out of scope. (closes issue ABE-2902) Reported by: Guenther Kelleter Tested by: Guenther Kelleter Review: http://reviewboard.digium.internal/r/365/ ........ Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@378933 65c4cc65-6c06-0410-ace0-fbb531ad65f3		13 years ago
..
Makefile	Change the name of the category 'TEST' to match the name of the subdir	15 years ago
test_acl.c	Flag test modules as 'core'	14 years ago
test_ami_security_events.sh	Add an API for reporting security events, and a security event logging module.	16 years ago
test_amihooks.c	Test modules should depend on the TEST_FRAMEWORK flag	14 years ago
test_aoc.c	Flag test modules as 'core'	14 years ago
test_app.c	Flag test modules as 'core'	14 years ago
test_ast_format_str_reduce.c	Flag test modules as 'core'	14 years ago
test_astobj2.c	Flag test modules as 'core'	14 years ago
test_astobj2_thrash.c	Migrate hashtest/hashtest2 to be unit tests.	13 years ago
test_config.c	Fix type punned compiler warning in test_config.c	13 years ago
test_db.c	app_queue: Support persisting and loading of long member lists.	13 years ago
test_devicestate.c	Make hints for invalid SIP devices return Unavail, not idle	13 years ago
test_dlinklists.c	Test modules should depend on the TEST_FRAMEWORK flag	14 years ago
test_event.c	Fix case-sensitivity for device-specific event subscriptions and CCSS	13 years ago
test_expr.c	Flag test modules as 'core'	14 years ago
test_func_file.c	Flag test modules as 'core'	14 years ago
test_gosub.c	Enable macros in 1.8 to find the next highest "h" extension in a context, like in 1.4.	13 years ago
test_hashtab_thrash.c	Migrate hashtest/hashtest2 to be unit tests.	13 years ago
test_heap.c	Flag test modules as 'core'	14 years ago
test_linkedlists.c	Clean up and ensure proper usage of alloca()	13 years ago
test_locale.c	Test modules should depend on the TEST_FRAMEWORK flag	14 years ago
test_logger.c	Test modules should depend on the TEST_FRAMEWORK flag	14 years ago
test_netsock2.c	Add a unit test for ast_sockaddr_split_hostport	14 years ago
test_pbx.c	Make CANMATCH with the new pattern match engine behave more like the old one	14 years ago
test_poll.c	Add leading and trailing backslashes	13 years ago
test_sched.c	Flag test modules as 'core'	14 years ago
test_security_events.c	Test modules should depend on the TEST_FRAMEWORK flag	14 years ago
test_skel.c	Flag test modules as 'core'	14 years ago
test_stringfields.c	Flag test modules as 'core'	14 years ago
test_strings.c	Flag test modules as 'core'	14 years ago
test_substitution.c	Flag test modules as 'core'	14 years ago
test_time.c	Flag test modules as 'core'	14 years ago
test_utils.c	Flag test modules as 'core'	14 years ago
test_xml_escape.c	Fix XML encoding of 'identity display' in NOTIFY messages.	13 years ago