You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Matthew Jordan 9cc1a8e893 stasis: Reduce creation of channel snapshots to improve performance ... During some performance testing of Asterisk with AGI, ARI, and lots of Local channels, we noticed that there's quite a hit in performance during channel creation and releasing to the dialplan (ARI continue). After investigating the performance spike that occurs during channel creation, we discovered that we create a lot of channel snapshots that are technically unnecessary. This includes creating snapshots during: * AGI execution * Returning objects for ARI commands * During some Local channel operations * During some dialling operations * During variable setting * During some bridging operations And more. This patch does the following: - It removes a number of fields from channel snapshots. These fields were rarely used, were expensive to have on the snapshot, and hurt performance. This included formats, translation paths, Log Call ID, callgroup, pickup group, and all channel variables. As a result, AMI Status, "core show channel", "core show channelvar", and "pjsip show channel" were modified to either hit the live channel or not show certain pieces of data. While this is unfortunate, the performance gain from this patch is worth the loss in behaviour. - It adds a mechanism to publish a cached snapshot + blob. A large number of publications were changed to use this, including: - During Dial begin - During Variable assignment (if no AMI variables are emitted - if AMI variables are set, we have to make snapshots when a variable is changed) - During channel pickup - When a channel is put on hold/unhold - When a DTMF digit is begun/ended - When creating a bridge snapshot - When an AOC event is raised - During Local channel optimization/Local bridging - When endpoint snapshots are generated - All AGI events - All ARI responses that return a channel - Events in the AgentPool, MeetMe, and some in Queue - Additionally, some extraneous channel snapshots were being made that were unnecessary. These were removed. - The result of ast_hashtab_hash_string is now cached in stasis_cache. This reduces a large number of calls to ast_hashtab_hash_string, which reduced the amount of time spent in this function in gprof by around 50%. #ASTERISK-23811 #close Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/3568/ ........ Merged revisions 416211 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@416216 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
confbridge	app_confbridge: Correct verification of conference name length	12 years ago
Makefile	Moved core logic from app_stasis to res_stasis	13 years ago
app_adsiprog.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_agent_pool.c	stasis: Reduce creation of channel snapshots to improve performance	12 years ago
app_alarmreceiver.c	…
app_amd.c	…
app_authenticate.c	Update Asterisk's CDRs for the new bridging framework	13 years ago
app_bridgewait.c	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
app_cdr.c	CDRs: Synchronize dialplan applications that manipulate CDRs with the engine	12 years ago
app_celgenuserevent.c	CELGenUserEvent: Fix error message from ast_json_pack	12 years ago
app_chanisavail.c	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
app_channelredirect.c	Merge in the bridge_construction branch to make the system use the Bridging API.	13 years ago
app_chanspy.c	app_chanspy: Fix a test that was failing on account of r413551	12 years ago
app_confbridge.c	app_confbridge: Allow muting of users waiting to enter a ConfBridge	12 years ago
app_controlplayback.c	Add ControlPlayback manager action	13 years ago
app_dahdibarge.c	…
app_dahdiras.c	app_dahdiras: Use waitpid instead of wait4.	12 years ago
app_db.c	Don't throw a spurious error when using DBdeltree	13 years ago
app_dial.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_dictate.c	…
app_directed_pickup.c	PickupChan: Add ability to specify channel uniqueids as well as channel names.	12 years ago
app_directory.c	app_directory: Set variable indicating reason directory exited	12 years ago
app_disa.c	app_cdr,app_forkcdr,func_cdr: Synchronize with engine when manipulating state	12 years ago
app_dumpchan.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_echo.c	…
app_exec.c	…
app_externalivr.c	…
app_fax.c	Resolve a merge conflict	13 years ago
app_festival.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_flash.c	…
app_followme.c	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
app_forkcdr.c	CDRs: Synchronize dialplan applications that manipulate CDRs with the engine	12 years ago
app_getcpeid.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_ices.c	…
app_image.c	…
app_ivrdemo.c	…
app_jack.c	Fix dialplan function NULL channel safety issues	12 years ago
app_macro.c	…
app_meetme.c	stasis: Reduce creation of channel snapshots to improve performance	12 years ago
app_milliwatt.c	…
app_minivm.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_mixmonitor.c	MixMontior: Add class authorization requirements to MixMonitor AMI commands	12 years ago
app_morsecode.c	…
app_mp3.c	…
app_nbscat.c	…
app_originate.c	Originated calls: Fix several originate call problems.	12 years ago
app_osplookup.c	Update Asterisk's CDRs for the new bridging framework	13 years ago
app_page.c	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
app_playback.c	Check result of ast_var_assign() calls for memory allocation failure.	12 years ago
app_playtones.c	…
app_privacy.c	…
app_queue.c	stasis: Reduce creation of channel snapshots to improve performance	12 years ago
app_read.c	…
app_readexten.c	…
app_readfile.c	…
app_record.c	app_record: Add an option that allows DTMF '0' to act as an additional terminator	12 years ago
app_saycounted.c	…
app_sayunixtime.c	Say: If SAY_DTMF_INTERRUPT is set to an ast_true value, jump on DTMF	12 years ago
app_senddtmf.c	…
app_sendtext.c	…
app_setcallerid.c	…
app_skel.c	Add CLI configuration documentation	13 years ago
app_sms.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_softhangup.c	…
app_speech_utils.c	Fix dialplan function NULL channel safety issues	12 years ago
app_stack.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_stasis.c	Fix menuselect display for stasis modules.	13 years ago
app_system.c	…
app_talkdetect.c	…
app_test.c	…
app_transfer.c	Documentation: doc fixes across various parts of the code for ASTERISK issues 23061,23028,23046,23027	12 years ago
app_url.c	…
app_userevent.c	ARI: Add ability to raise arbitrary User Events	12 years ago
app_verbose.c	Allow Asterisk to compile under GCC 4.10	12 years ago
app_voicemail.c	Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages	12 years ago
app_voicemail.exports.in	…
app_waitforring.c	…
app_waitforsilence.c	Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages	12 years ago
app_waituntil.c	…
app_while.c	…
app_zapateller.c	…
enter.h	…
leave.h	…