You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Mark Michelson 2d9471ab1f Fix race condition that could result in ARI transfer messages not being sent. ... From reviewboard: "During blind transfer testing, it was noticed that tests were failing occasionally because the ARI blind transfer event was not being sent. After investigating, I detected a race condition in the blind transfer code. When blind transferring a single channel, the actual transfer operation (i.e. removing the transferee from the bridge and directing them to the proper dialplan location) is queued onto the transferee bridge channel. After queuing the transfer operation, the blind transfer Stasis message is published. At the time of publication, snapshots of the channels and bridge involved are created. The ARI subscriber to the blind transfer Stasis message then attempts to determine if the bridge or any of the involved channels are subscribed to by ARI applications. If so, then the blind transfer message is sent to the applications. The way that the ARI blind transfer message handler works is to first see if the transferer channel is subscribed to. If not, then iterate over all the channel IDs in the bridge snapshot and determine if any of those are subscribed to. In the test we were running, the lone transferee channel was subscribed to, so an ARI event should have been sent to our application. Occasionally, though, the bridge snapshot did not have any channels IDs on it at all. Why? The problem is that since the blind transfer operation is handled by a separate thread, it is possible that the transfer will have completed and the channels removed from the bridge before we publish the blind transfer Stasis message. Since the blind transfer has completed, the bridge on which the transfer occurred no longer has any channels on it, so the resulting bridge snapshot has no channels on it. Through investigation of the code, I found that attended transfers can have this issue too for the case where a transferee is transferred to an application." The fix employed here is to decouple the creation of snapshots for the transfer messages from the publication of the transfer messages. This way, snapshots can be created to reflect what they are at the time of the transfer operation. Review: https://reviewboard.asterisk.org/r/4135 ........ Merged revisions 427848 from http://svn.asterisk.org/svn/asterisk/branches/12 ........ Merged revisions 427870 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@427873 65c4cc65-6c06-0410-ace0-fbb531ad65f3		11 years ago
..
doxygen	Fix some doxygen bridging file references.	12 years ago
_private.h	media formats: re-architect handling of media for performance improvements	11 years ago
abstract_jb.h	media formats: re-architect handling of media for performance improvements	11 years ago
acl.h	pjsip cli: Change Identify to show CIDR notation instead of netmasks.	11 years ago
adsi.h	Multiple revisions 369323-369324	13 years ago
ael_structs.h	…
agi.h	Remove the old stub files, preferring the optional_api method.	15 years ago
alaw.h	…
aoc.h	channel locking: Add locking for channel snapshot creation	12 years ago
app.h	voicemail API callbacks: Extract the sayname API call to its own registerd callback.	11 years ago
ari.h	res_ari: Fix various memory leaks.	12 years ago
ast_expr.h	…
ast_version.h	…
astdb.h	core/db: Revert Patch Added In Attempt To Improve I/O Performance	11 years ago
astmm.h	core: Don't allow free to mean ast_free (and malloc, etc..).	11 years ago
astobj.h	Deprecate astobj.h	11 years ago
astobj2.h	astobj2: assert on invalid ref and backtrace cleanup	11 years ago
astosp.h	…
audiohook.h	media formats: re-architect handling of media for performance improvements	11 years ago
autochan.h	Fix a deadlock that occurred due to a conflict of masquerades.	12 years ago
autoconfig.h.in	configure: Add autoconf check for libopus.	11 years ago
backtrace.h	Fix memory corruption when trying to get "core show locks".	12 years ago
beep.h	(mix)monitor: Add options to enable a periodic beep	12 years ago
bridge.h	bridge.h: Remove redundant struct ast_bridge_channel forward declaration.	11 years ago
bridge_after.h	A great big renaming patch	12 years ago
bridge_basic.h	Massively clean up app_queue.	12 years ago
bridge_channel.h	Bridge DTMF hooks: Made audio pass from the bridge while waiting for more matching digits.	11 years ago
bridge_channel_internal.h	Bridging: Fix orphaned bridge if neither of the joining channels can join.	12 years ago
bridge_features.h	Stasis: Convey transfer information to applications	11 years ago
bridge_internal.h	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
bridge_roles.h	ARI: bridges/{bridgeID}/addChannel: add roles parameter	12 years ago
bridge_technology.h	Fix assumption in bridge_native_rtp.c regarding number of participants in a bridge.	12 years ago
bucket.h	sorcery, bucket: Change observer remove calls to take const callbacks struct.	12 years ago
buildinfo.h	…
calendar.h	Track module use count for res_calendar	14 years ago
callerid.h	media formats: re-architect handling of media for performance improvements	11 years ago
causes.h	Merged revisions 378735,378748 via svnmerge from	13 years ago
ccss.h	Merge in the bridge_construction branch to make the system use the Bridging API.	13 years ago
cdr.h	CDRs: Synchronize dialplan applications that manipulate CDRs with the engine	12 years ago
cel.h	Restore usefulness of the CEL Peer field	12 years ago
celt.h	I think reviewboard broke this. The whole file was doubled.	14 years ago
channel.h	main/cdrs: Preserve context/extension when executing a Macro or GoSub	11 years ago
channel_internal.h	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
channelstate.h	channel locking: Add locking for channel snapshot creation	12 years ago
chanvars.h	res_phoneprov: Refactor phoneprov to allow pluggable config providers	11 years ago
cli.h	DTMF events are now published on a channel's stasis_topic. AMI was	13 years ago
codec.h	media formats: re-architect handling of media for performance improvements	11 years ago
compat.h	res_pjsip,compat: INFINITY and NAN undefined	12 years ago
compiler.h	optional_api: Fix linking problems between modules that export global symbols	12 years ago
config.h	config: Fix inf loop using ast_category_browse and ast_variable_retrieve	11 years ago
config_options.h	media formats: re-architect handling of media for performance improvements	11 years ago
core_local.h	Create Local channel messages on the Stasis message bus and produce AMI events	12 years ago
core_unreal.h	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
crypto.h	Clean up doxygen warnings	13 years ago
data.h	media formats: re-architect handling of media for performance improvements	11 years ago
datastore.h	Stasis: Convey transfer information to applications	11 years ago
devicestate.h	res_corosync: Update module to work with Stasis (and compile)	12 years ago
dial.h	Dial API: Add a dial option to indicate the dialed channel will replace dialer	11 years ago
dlinkedlists.h	Doubly linked lists unit test and update to implementation.	14 years ago
dns.h	res_pjsip: Enable PJSIP DNS client support.	12 years ago
dnsmgr.h	Re-link peers by IP when dnsmgr changes the IP	14 years ago
doxyref.h	app_voicemail: Voicemail callback registration/unregistration function improvements.	12 years ago
dsp.h	Improve T.38 gateway V.21 preamble detection.	14 years ago
dundi.h	…
endian.h	…
endpoints.h	ARI: Fix endpoint/channel subscription issues; allow for subscriptions to tech	11 years ago
enum.h	…
event.h	res_corosync: Update module to work with Stasis (and compile)	12 years ago
event_defs.h	res_corosync: Update module to work with Stasis (and compile)	12 years ago
extconf.h	Merged revisions 328329 via svnmerge from	14 years ago
features.h	Restore Dial, Queue, and FollowMe 'I' option support.	12 years ago
features_config.h	Fix doxygen to use correct units of features.conf options.	12 years ago
file.h	Voicemail: get correct duration when copying file to vm	11 years ago
format.h	media formats: re-architect handling of media for performance improvements	11 years ago
format_cache.h	Remove duplicate definitions of ast_format_vp8.	11 years ago
format_cap.h	Add API call to determine if format capability structure is "empty".	11 years ago
format_compatibility.h	chan_iax2: Several media format fixes.	11 years ago
frame.h	chan_pjsip: Fix deadlock when masquerading PJSIP channels.	11 years ago
framehook.h	PJSIP: Prevent T38 framehook being put on wrong channel	11 years ago
fskmodem.h	…
fskmodem_float.h	…
fskmodem_int.h	…
global_datastores.h	Add SRTP support for Asterisk	16 years ago
hashtab.h	Merged revisions 376341,376344-376345 via svnmerge from	13 years ago
heap.h	Clean up doxygen warnings	13 years ago
http.h	HTTP: Add persistent connection support.	11 years ago
http_websocket.h	res_http_websocket: Close websocket correctly and use careful fwrite	11 years ago
image.h	media formats: re-architect handling of media for performance improvements	11 years ago
indications.h	Audit of ao2_iterator_init() usage for v1.8.	14 years ago
inline_api.h	Add development flag to disable the inline API.	13 years ago
io.h	…
json.h	Multiple revisions 420089-420090,420097	11 years ago
linkedlists.h	Merged revisions 376630 via svnmerge from	13 years ago
localtime.h	Stasis application WebSocket support	13 years ago
lock.h	vector: Update API to be more flexible.	12 years ago
logger.h	logger.h: Extract DEBUG_ATLEAST() to complement VERBOSITY_ATLEAST().	11 years ago
manager.h	AMI/ARI: Update version to 2.5.0/1.5.0 respectively	11 years ago
md5.h	Ensure alignment of in[] field in MD5Context struct.	13 years ago
media_index.h	Index installed sounds and implement ARI sounds queries	12 years ago
message.h	Multiple revisions 420089-420090,420097	11 years ago
mixmonitor.h	bridge_features: Support One touch Monitor/MixMonitor	12 years ago
mod_format.h	media formats: re-architect handling of media for performance improvements	11 years ago
module.h	Add module support level to ast_module_info structure. Print it in CLI "module show" .	11 years ago
monitor.h	(mix)monitor: Add options to enable a periodic beep	12 years ago
musiconhold.h	Update MOH start/stop routine doxygen.	12 years ago
netsock.h	Move eid functions to utils.c, mark netsock.h deprecated	11 years ago
netsock2.h	pjsip cli: Change Identify to show CIDR notation instead of netmasks.	11 years ago
network.h	…
optional_api.h	Fix graceful shutdown crash.	12 years ago
options.h	Remove many deprecated modules	11 years ago
opus.h	Add pass through support for Opus and VP8; Opus format attribute negotiation	12 years ago
parking.h	res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers	12 years ago
paths.h	ARI - channel recording support	12 years ago
pbx.h	Originated calls: Fix several originate call problems.	12 years ago
phoneprov.h	res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup	11 years ago
pickup.h	Make sure that pickup.h does not use an include guard name used elsewhere.	12 years ago
pktccops.h	…
plc.h	…
poll-compat.h	Merged revisions 284597 via svnmerge from	15 years ago
presencestate.h	Split caching out from the stasis_caching_topic.	12 years ago
privacy.h	…
pval.h	Merged revisions 271399 via svnmerge from	16 years ago
res_fax.h	Channels: Masquerades to automatically move frame/audio hooks	11 years ago
res_hep.h	res_hep/res_hep_pjsip: Add a HEPv3 capture agent module and a logger for PJSIP	12 years ago
res_mwi_external.h	External MWI core support.	12 years ago
res_odbc.h	Doxygen Updates - janitor work	13 years ago
res_pjsip.h	Fix race condition where duplicated requests may be handled by multiple threads.	11 years ago
res_pjsip_body_generator_types.h	res_pjsip_dialog_info_body_generator: Add dialog-info+xml support for presence.	11 years ago
res_pjsip_cli.h	pjsip_cli: Create pjsip show channel and contact, and general cli code cleanup.	12 years ago
res_pjsip_outbound_publish.h	res_pjsip_outbound_publish: Add module which provides outbound PUBLISH support.	11 years ago
res_pjsip_presence_xml.h	Add support for RFC 4662 resource list subscriptions.	11 years ago
res_pjsip_pubsub.h	PJSIP: Enforce module load dependencies	11 years ago
res_pjsip_session.h	chan_pjsip: Add support for passing hold and unhold requests through.	11 years ago
res_srtp.h	Allow SRTP policies to be reloaded	14 years ago
rtp_engine.h	res_rtp_asterisk: Fix a myriad of TURN client issues.	11 years ago
say.h	Add SayAlphaCase and similar functionality for AGI	12 years ago
sched.h	sched: Fix typo and whitespace change.	11 years ago
sdp_srtp.h	Recorded merge of revisions 417677 from http://svn.asterisk.org/svn/asterisk/branches/11	11 years ago
security_events.h	Avoid unnecessary cleanups during immediate shutdown	13 years ago
security_events_defs.h	Strip down the old event system	12 years ago
select.h	Merged revisions 315503 via svnmerge from	15 years ago
sem.h	Multiple revisions 399887,400138,400178,400180-400181	12 years ago
sha1.h	Update SHA1 code to RFC 6234	14 years ago
silk.h	Media Project Phase2: SILK 8khz-24khz, SLINEAR 8khz-192khz, SPEEX 32khz, hd audio ConfBridge, and other stuff	15 years ago
sip_api.h	Don't make chan_sip export global symbols.	13 years ago
slin.h	media formats: re-architect handling of media for performance improvements	11 years ago
slinfactory.h	media formats: re-architect handling of media for performance improvements	11 years ago
smdi.h	res_smdi: convert to astobj2	11 years ago
smoother.h	media formats: re-architect handling of media for performance improvements	11 years ago
sorcery.h	Prevent duplicate sorcery wizards from being applied to sorcery object types.	12 years ago
sounds_index.h	Index installed sounds and implement ARI sounds queries	12 years ago
speech.h	media formats: re-architect handling of media for performance improvements	11 years ago
spinlock.h	Add "destroy" implementation for spinlock.	12 years ago
srv.h	Doxygen - Markup Guidelines	13 years ago
stasis.h	Stasis: Fix StasisEnd message ordering	11 years ago
stasis_app.h	Stasis: Fix StasisEnd message ordering	11 years ago
stasis_app_device_state.h	ARI: Implement device state API	12 years ago
stasis_app_impl.h	ARI: Fix a crash caused by hanging during playback to a channel in a bridge	11 years ago
stasis_app_mailbox.h	ARI: Add mailboxes resource for controlling and polling external MWI	12 years ago
stasis_app_playback.h	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
stasis_app_recording.h	ari: Add a copy operation for stored recordings	11 years ago
stasis_app_snoop.h	uniqueid: channel linkedid, ami, ari object creation with id's	12 years ago
stasis_bridges.h	Fix race condition that could result in ARI transfer messages not being sent.	11 years ago
stasis_cache_pattern.h	Split caching out from the stasis_caching_topic.	12 years ago
stasis_channels.h	stasis: Reduce creation of channel snapshots to improve performance	11 years ago
stasis_endpoints.h	ARI: Don't leak implementation details	12 years ago
stasis_internal.h	stasis: Made internal_stasis_subscribe() prototype and definition match exactly.	12 years ago
stasis_message_router.h	stasis: Add methods to allow for synchronous publishing to subscriber	12 years ago
stasis_system.h	Convert CCSS manager events to stasis.	12 years ago
stasis_test.h	Initial support for endpoints.	13 years ago
statsd.h	Example of how to use the Stasis message bus	13 years ago
stringfields.h	Fix unintential memory retention in stringfields.	11 years ago
strings.h	utils: Create ast_strsep function that ignores separators inside quotes	11 years ago
stun.h	Re-resolve the STUN address if a STUN poll fails for res_stun_monitor.	14 years ago
syslog.h	…
taskprocessor.h	chan_pjsip: Fix deadlock when masquerading PJSIP channels.	11 years ago
tcptls.h	HTTP: Add persistent connection support.	11 years ago
tdd.h	…
term.h	Revamp of terminal color codes	13 years ago
test.h	Several components: fixing Typos in comments and code, "avaliable" instead of "available"	12 years ago
threadpool.h	Merge the pimp_my_sip branch into trunk.	13 years ago
threadstorage.h	Match use of ast_free() with ast_calloc() and add some curly braces.	12 years ago
time.h	Update Asterisk's CDRs for the new bridging framework	12 years ago
timing.h	timing: Improve performance for most timing implementations.	12 years ago
transcap.h	…
translate.h	media formats: re-architect handling of media for performance improvements	11 years ago
udptl.h	udptl: Dead code elimination. ast_udptl_bridge was not used.	12 years ago
ulaw.h	…
unaligned.h	Merged revisions 282543 via svnmerge from	15 years ago
uri.h	uri: Quiet warning about type qualifiers ignored on function return type	11 years ago
utils.h	config: Make text_file_save and 'dialplan save' escape semicolons in values.	11 years ago
uuid.h	Add uuid wrapper API call ast_uuid_generate_str().	13 years ago
vector.h	media formats: re-architect handling of media for performance improvements	11 years ago
version.h	Remove "asterisk/version.h" in favor of "asterisk/ast_version.h".	14 years ago
xml.h	Add CLI configuration documentation	13 years ago
xmldoc.h	AMI: Allow for command response documentation	11 years ago
xmpp.h	ARI: Fix endpoint/channel subscription issues; allow for subscriptions to tech	11 years ago