You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Neuhauser e8c2ce2873 pjproject: clone sdp to protect against (nat) modifications ... PJSIP, UDP transport with external_media_address and session timers enabled. Connected to SIP server that is not in local net. Asterisk initiated the connection and is refreshing the session after 150s (timeout 300s). The 2nd refresh-INVITE triggered by the pjsip timer has a malformed IP address in its SDP (garbage string). This only happens when the SDP is modified by the nat-code to replace the local IP address with the configured external_media_address. Analysis: the code to modify the SDP (in res_pjsip_session.c:session_outgoing_nat_hook() and also (redundantly?) in res_pjsip_sdp_rtp.c:change_outgoing_sdp_stream_media_address()) uses the tdata->pool to allocate the replacement string. But the same pjmedia_sdp_stream that was modified for the 1st refresh-INVITE is also used for the 2nd refresh-INVITE (because it is stored in pjmedia's pjmedia_sdp_neg structure). The problem is, that at that moment, the tdata->pool that holds the stringified external_media_address from the 1. refresh-INVITE has long been reused for something else. Fix by Sauw Ming of pjproject (see https://github.com/pjsip/pjproject/pull/2476): the local, potentially modified pjmedia_sdp_stream is cloned in pjproject/source/pjsip/src/pjmedia/sip_neg.c:process_answer() and the clone is stored, thereby detaching from the tdata->pool (which is only released *after* process_answer()) ASTERISK-28973 Reported-by: Michael Neuhauser Change-Id: I272ac22436076596e06aa51b9fa23fd1c7734a0e		5 years ago
..
jansson	build: Pass --fno-partial-inlining to third-party when appropriate	6 years ago
pjproject	pjproject: clone sdp to protect against (nat) modifications	5 years ago
Makefile	Enable bundling of jansson, require 2.11.	7 years ago
Makefile.rules	Enable bundling of jansson, require 2.11.	7 years ago
apply_patches	Enable bundling of jansson, require 2.11.	7 years ago
configure.m4	Enable bundling of jansson, require 2.11.	7 years ago
versions.mak	pjproject: Upgrade bundled version to pjproject 2.10	5 years ago