You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Vossel 776a14386a SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes. ... What this patch fixes 1.Moves sip TCP/TLS connection setup into the TCP helper thread: Connection setup takes awhile and before this it was being done while holding the monitor lock. 2.Moves TCP/TLS writing to the TCP helper thread: Through the use of a packet queue and an alert pipe, the TCP helper thread can now be woken up to write data as well as read data. 3.Locking error: sip_xmit returned an XMIT_ERROR without giving up the tcptls_session lock. This lock has been completely removed from sip_xmit and placed in the new sip_tcptls_write() function. 4.Memory leak: When creating a tcptls_client the tls_cfg was alloced but never freed unless the tcptls_session failed to start. Now the session_args for a sip client are an ao2 object which frees the tls_cfg on destruction. 5.Pointer to stack variable: During sip_prepare_socket the creation of a client's ast_tcptls_session_args was done on the stack and stored as a pointer in the newly created tcptls_session. Depending on the events that followed, there was a slight possibility that pointer could have been accessed after the stack returned. Given the new changes, it is always accessed after the stack returns which is why I found it. Notable code changes 1.I broke tcptls.c's ast_tcptls_client_start() function into two functions. One for creating and allocating the new tcptls_session, and a separate one for starting and handling the new connection. This allowed me to create the tcptls_session, launch the helper thread, and then establish the connection within the helper thread. 2.Writes to a tcptls_session are now done within the helper thread. This is done by using an alert pipe to wake up the thread if new data needs to be sent. The thread's sip_threadinfo object contains the alert pipe as well as the packet queue. 3.Since the threadinfo object contains the alert pipe, it must now be accessed outside of the helper thread for every write (queuing of a packet). For easy lookup, I moved the threadinfo objects from a linked list to an ao2_container. (closes issue #13136) Reported by: pabelanger Tested by: dvossel, whys (closes issue #15894) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/380/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@225445 65c4cc65-6c06-0410-ace0-fbb531ad65f3		16 years ago
..
db1-ast	Merged revisions 209879 via svnmerge from	16 years ago
editline	Merged revisions 179395 via svnmerge from	16 years ago
stdtime	Use nanosleep instead of poll.	16 years ago
Makefile	Close up to the soft open file limit (same on Linux, but varies drastically on OS X).	16 years ago
abstract_jb.c	Const-ify the world (or at least a good part of it)	16 years ago
acl.c	Merge code associated with AST-2009-006	16 years ago
adsistub.c	remove a bunch of useless #include "options.h"	18 years ago
aescrypt.c	Spacing changes only	16 years ago
aeskey.c	use the OpenSSL AES implementation if it's available (unless configured not to)	18 years ago
aesopt.h	…
aestab.c	use the OpenSSL AES implementation if it's available (unless configured not to)	18 years ago
alaw.c	Fix compile when certain G711 menuselect options are enabled.	16 years ago
app.c	Remove unnecessary typedef	16 years ago
ast_expr2.c	fixes a few redundant conditions	16 years ago
ast_expr2.fl	fixes a few redundant conditions	16 years ago
ast_expr2.h	Merged revisions 179807 via svnmerge from	16 years ago
ast_expr2.y	Merged revisions 179807 via svnmerge from	16 years ago
ast_expr2f.c	fixes some memory leaks and redundant conditions	16 years ago
asterisk.c	Merged revisions 221776 via svnmerge from	16 years ago
asterisk.exports	Merged revisions 208083 via svnmerge from	16 years ago
astfd.c	Merged revisions 211274 via svnmerge from	16 years ago
astmm.c	Two more minor fixes due to constification	16 years ago
astobj2.c	Fix a refcount error introduced by yesterday's OBJ_MULTIPLE commit.	16 years ago
audiohook.c	Merged revisions 224855 via svnmerge from	16 years ago
autochan.c	Convert the ast_channel data structure over to the astobj2 framework.	16 years ago
autoservice.c	Merged revisions 223485-223486 via svnmerge from	16 years ago
bridging.c	Fix a bug where receiving a control frame of subclass -1 would cause certain channels to get hung up.	16 years ago
buildinfo.c	fix a few small things found by using sparse	17 years ago
callerid.c	Merged revisions 206867 via svnmerge from	16 years ago
cdr.c	AST-2009-005	16 years ago
cel.c	Fix channel reference leak.	16 years ago
channel.c	Add support for calling and called subaddress. Partial support for COLP subaddress.	16 years ago
chanvars.c	Add additional memory debugging to several core APIs, and fix several memory	17 years ago
cli.c	Finish implementaton of astobj2 OBJ_MULTIPLE, and convert ast_channel_iterator to use it.	16 years ago
config.c	Merged revisions 219023 via svnmerge from	16 years ago
cryptostub.c	Don't include logger.h in asterisk.h by default as it is causing problems building	17 years ago
cygload.c	Doxygen updates, formatting.	18 years ago
datastore.c	Properly account for memory allocated for channels and datastores	16 years ago
db.c	More 'static' qualifiers on module global variables.	16 years ago
devicestate.c	Merged revisions 205409 via svnmerge from	16 years ago
dial.c	Merge the new Channel Event Logging (CEL) subsystem.	16 years ago
dns.c	Fix a few compilation problems found when building Asterisk against uClibc.	16 years ago
dnsmgr.c	AST-2009-005	16 years ago
dsp.c	Merged revisions 224931 via svnmerge from	16 years ago
ecdisa.h	…
enum.c	AST-2009-005	16 years ago
event.c	Fix ast_event_queue_and_cache() to actually do the cache() part.	16 years ago
features.c	Merged revisions 224773 via svnmerge from	16 years ago
file.c	Merged revisions 222878 via svnmerge from	16 years ago
fixedjitterbuf.c	Start untangling header inclusion in a way that does not affect	18 years ago
fixedjitterbuf.h	Merged revisions 135841,135847,135850 via svnmerge from	17 years ago
frame.c	Merged revisions 224931 via svnmerge from	16 years ago
fskmodem.c	(Step 2 of 2)	17 years ago
fskmodem_float.c	Optionally build integer-based routines for FSK tone decoding (but default	17 years ago
fskmodem_int.c	Optionally build integer-based routines for FSK tone decoding (but default	17 years ago
global_datastores.c	Merged revisions 172517 via svnmerge from	17 years ago
hashtab.c	Add MALLOC_DEBUG to various utility APIs, so that memory leaks can be tracked back to their source.	16 years ago
heap.c	Pass more useful information through to lock tracking when DEBUG_THREADS is on.	16 years ago
http.c	Fix a trunk compilation warning.	16 years ago
image.c	More 'static' qualifiers on module global variables.	16 years ago
indications.c	AST-2009-005	16 years ago
io.c	Merged revisions 182810 via svnmerge from	16 years ago
jitterbuf.c	Merged revisions 174583 via svnmerge from	17 years ago
loader.c	Make LOAD_ORDER actually work	16 years ago
logger.c	Initialize a variable that we check immediately upon startup.	16 years ago
manager.c	Finish implementaton of astobj2 OBJ_MULTIPLE, and convert ast_channel_iterator to use it.	16 years ago
md5.c	Start untangling header inclusion in a way that does not affect	18 years ago
netsock.c	fixes an ast_netsock_list memory leak.	16 years ago
pbx.c	Merged revisions 225105 via svnmerge from	16 years ago
plc.c	Start untangling header inclusion in a way that does not affect	18 years ago
poll.c	Various patches, to enable Asterisk to once again compile on Mac OS X.	16 years ago
privacy.c	remove a bunch of useless #include "options.h"	18 years ago
rtp_engine.c	Merged revisions 221776 via svnmerge from	16 years ago
say.c	One more off-by-one in trunk	16 years ago
sched.c	Fix a regression in scheduler entry ordering, and add a regression test for it.	17 years ago
security_events.c	Add an API for reporting security events, and a security event logging module.	16 years ago
sha1.c	more header removal/normalization	18 years ago
slinfactory.c	Merged revisions 200991 via svnmerge from	16 years ago
srv.c	bump the verbosity of a message in srv.c up by one. It used to be	17 years ago
ssl.c	pthread_self returns a pthread_t which is not an unsigned int on all	16 years ago
strcompat.c	Merged revisions 208083 via svnmerge from	16 years ago
strings.c	Merge str_substitution branch.	16 years ago
stun.c	This commit introduces COLP/CONP and Redirecting party information into Asterisk.	16 years ago
syslog.c	Add functions to map syslog facilities and priorities constants to strings.	16 years ago
taskprocessor.c	Const-ify the world (or at least a good part of it)	16 years ago
tcptls.c	SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes.	16 years ago
tdd.c	Merge changes from str_substitution that are unrelated to that branch.	16 years ago
term.c	add 'const' qualifiers in various places where they should have been	16 years ago
threadstorage.c	Fixed an issue in the threadstorage cli functions resulting from the constification of struct ast_cli_args in r196072.	16 years ago
timing.c	AST-2009-005	16 years ago
translate.c	Merged revisions 225171 via svnmerge from	16 years ago
udptl.c	Allow non-compliant T.38 endpoints to be supportable via configuration option.	16 years ago
ulaw.c	Fix compile when certain G711 menuselect options are enabled.	16 years ago
utils.c	Merged revisions 216435 via svnmerge from	16 years ago
xml.c	Define our desires for POSIX and X/OPEN API features properly.	16 years ago
xmldoc.c	Add an empty line after each option when printing the	16 years ago