asterisk

Commit Graph

Author	SHA1	Message	Date
Tilghman Lesher	98b11ad0ee	When listing the manager users, managers in users.conf are not shown, even though they are allowed to connect. (closes issue #12594) Reported by: bkruse Patches: 12594-managerusers-2.diff uploaded by qwell (license 4) Tested by: bkruse git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@120061 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	8a9d52bc7f	Improve CLI command blacklist checking for the command manager action. Previously, it did not handle case or whitespace properly. This made it possible for blacklisted commands to get executed anyway. (closes issue #12765) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@119742 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f8848a7fe8	Store the manager session ID explicitly as 4 byte ID instead of a ulong. The mansession_id cookie is coded to be limited to 8 characters of hex, and this could break logins from 64-bit machines in some cases. (inspired by AST-20) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114591 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c8c2c33550	Don't destroy a manager session if poll() returns an error of EAGAIN. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114284 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	b4cf033072	Fix a race condition in the manager. It is possible that a new manager event could be appended during a brief time when the manager is not waiting for input. If an event comes during this period, we need to set an indicator that there is an event pending so that the manager doesn't attempt to wait forever for an event that already happened. (closes issue #12354) Reported by: bamby Patches: manager_race_condition.diff uploaded by bamby (license 430) (comments added by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@112468 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	56e908b787	Safely use the strncat() function. (closes issue #11958) Reported by: norman Patches: 20080209__bug11958.diff.txt uploaded by Corydon76 (license 14) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106552 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	11550c7be6	Ensure the session ID can't be 0. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104704 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	d105ba22fa	reduce the likelihood that HTTP Manager session ids will consist of primarily '1' bits git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104015 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Pari Nannapaneni	f7eae72a2e	missed that one while reverting git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99010 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Pari Nannapaneni	0fed0a955f	reverting 99001 - We need the Max-Age for extending the life of cookie mansession_id git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99007 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	af7670bca8	we should only send the Set-Cookie header to the browser on the first response after creating a manager session, not on every response (doing so causes the browser to clear any local cookies it may have associated with the session) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99001 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	eb4d447b78	make this comment explain the situation in an even more explicit fashion git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94824 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	3c3eb75062	Workaround for what is probably a glibc bug (but we'll see this crop up again and again, if we don't add the workaround). Reported by: rolek Patch by: tilghman (Closes issue #11601, closes issue #11426) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94808 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1f8caa100d	Change the behavior of ao2_link(). Previously, in inherited a reference. Now, it automatically increases the reference count to reflect the reference that is now held by the container. This was done to be more consistent with ao2_unlink(), which automatically releases the reference held by the container. It also makes it so it is no longer possible for a pointer to be invalid after ao2_link() returns. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90348 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	fc5429da7c	it is impossible to set permissions for manager accounts created by users.conf (reported internally, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90098 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	540a2c7098	Up until this point, the XML output of the manager has been technically invalid, due to the repetition of certain parameters in a single event. This caused various issues for XML parsers, some of which refused to parse at all, given the invalidity of the rendered XML. So this commit fixes the XML output, ensuring that each entity parameter has a unique name, thus ensuring valid XML. Reported by: msetim Patch by: tilghman (Closes issue #10220) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89536 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	1fece3bb67	Undoing previous commit since I realize it was wrong git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89288 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	88f847869d	Adding a missing mutex unlock. (closes issue 11256, reported and patched by ys) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89286 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	63f6e6b023	Fixing a segfault in the manager "core show channels concise" command. (closes issue #11183, reported by arnd and patched by ys) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89085 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	2c757f0747	Fix a copy/paste error in the description of UpdateConfig that was pointed out by JerJer on #asterisk-dev git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84742 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	bae4135759	moved get_base_channel() code from action_redirect to ast_channel_masquerade() for issue 7706 and BE-160 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84274 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	7c4e477fde	if an Agent is redirected, the base channel should actually be redirected. This was causing multiple issues, especially issue 7706 and BE-160 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84018 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	df5599d598	Fix up another potential race condition. Do the loop decrementing use count on events with the eventq protected from being changed. (reported on IRC by Ivan) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83121 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Doug Bailey	8ac8d79a5d	Corrected patch applied in revision r82887. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82913 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Doug Bailey	33a1011c51	Fixed a bug where http manager sessions prevented the eventq from being cleaned out because http manager sessions do not have a valid file descriptor. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82887 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4668601f9c	Fix a memory leak that can occur on systems under higher load. The issue is that when events are appended to the master event queue, they use the number of active sessions as a use count so it will know when all active sessions at the time the event happened have consumed it. However, the handling of the number of sessions was not properly synchronized, so the use count was not always correct, causing an event to disappear early, or get stuck in the event queue for forever. (closes issue #9238, reported by bweschke, patch from Ivan, modified by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82867 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	24f0e6a947	Eliminate a compiler warning with gcc 4.2 by constifying a char * git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@76176 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	76164559c9	Remove a bogus comment and add proper locking to the handler function for the CLI command to show information on manager actions. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72926 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	6ffbaa32f3	Issue 10055 - Change memory allocation to use the heap for a command, since the output has the potential to overflow the stack (as it did here) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72556 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	2e702c85eb	Merged revisions 71288 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r71288 \| tilghman \| 2007-06-24 12:32:21 -0500 (Sun, 24 Jun 2007) \| 2 lines Issue 10043 - There is a legitimate need to be able to set variables to the empty string. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71289 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	533144b170	Add the ability to blacklist certain commands from being executed using the Command AMI action. (issue #9240 reported by junky) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65902 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Jason Parker	e0cac0c477	Hide manager password from "manager show user foo". I realize that there are other ways to get this, but we really don't need to just show it in plain text so easily. Issue 9273, patch by junky git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63982 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	7d478ee342	When MD5 authentication is not possible because there is no challenge present, either because the Challenge action was never issued, or some other reason, give a proper error message and return an error instead of claiming that the user wasn't found. (reported by jsmith on IRC) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63886 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	2465ea2cfa	Strip terminal escape sequences from CLI command output that is going to be sent out over the manager interface. (issue #9659, reported by pari, fixed by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63804 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	ae7a38d87b	Backport the change that only went in to trunk that fixes the command manager action over http. (reported internally by pari and bkruse) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62739 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Olle Johansson	b0121ca8a3	Issue #9608 - fix some annoying DEBUG messages not controlled by option_debug (DEA). Thanks! git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62095 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	5bee74171d	Merged revisions 61786 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61786 \| russell \| 2007-04-24 16:33:59 -0500 (Tue, 24 Apr 2007) \| 4 lines Don't crash if a manager connection provides a username that exists in manager.conf but does not have a password, and also requests MD5 authentication. (ASA-2007-012) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61787 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	70eb19121e	Fix the UpdateConfig manager action to properly treat "variables" and "objects" differently (a=b versus a=>b). (issue #9568, reported by pari, patch by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61690 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	6db075dd98	Bug 9557 - simple reason why reading a function always returned NULL git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61683 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	06ff84b549	To be able to achieve the things that we would like to achieve with the Asterisk GUI project, we need a fully functional HTTP interface with access to the Asterisk manager interface. One of the things that was intended to be a part of this system, but was never actually implemented, was the ability for the GUI to be able to upload files to Asterisk. So, this commit adds this in the most minimally invasive way that we could come up with. A lot of work on minimime was done by Steve Murphy. He fixed a lot of bugs in the parser, and updated it to be thread-safe. The ability to check permissions of active manager sessions was added by Dwayne Hubbard. Then, hacking this all together and do doing the modifications necessary to the HTTP interface was done by me. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60603 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	ab5c3cd84e	Merged revisions 60134 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r60134 \| russell \| 2007-04-04 12:38:47 -0500 (Wed, 04 Apr 2007) \| 6 lines It is valid to redirect channels via the manager interface that are not in the UP state. Instead of checking for that to prevent to ensure a dead channel doesn't get redirected, just use the ast_check_hangup() API call. (issue #9457, reported by Callmewind, patch by me) (related to issue #8977) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60137 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	97fe798e7e	Merged revisions 58164 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r58164 \| russell \| 2007-03-06 18:20:13 -0600 (Tue, 06 Mar 2007) \| 4 lines If the channels acquired using the manager Redirect action are not up, then don't attempt to do anything with them. It could lead to weird behavior, including crashes. (issue #8977) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58165 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	f2decd2446	Merged revisions 53245 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53245 \| tilghman \| 2007-02-06 00:58:28 -0600 (Tue, 06 Feb 2007) \| 2 lines Issue 8987 - Status could return two responses (mnicholson) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53246 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	9aab046002	Merged revisions 53045 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53045 \| russell \| 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) \| 3 lines Fix a bunch of places where pthread_attr_init() was called, but pthread_attr_destroy() was not. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53046 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	771be23a9c	Remove a recursive lock of the manager session. This was pointed out by zandbelt in issue #8711. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52688 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	ce753cf0d9	The session lock can not be held while calling action callbacks. If so, then when the WaitEvent callback gets called, then no event can happen because the session can't be locked by another thread. Also, the session needs to be locked in the HTTP callback when it reads out the output string. This fixes the deadlock reported in both 8711 and 8934. Regarding issue 8711, there still may be an issue. If there is a second action requested before the processing of the first action is finished, there could still be some corruption of the output string buffer used to build the result. (issue #8711, #8934) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52611 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	9c289fe01b	Have the manager interface send back an "Already logged in" message instead of "Invalid/Unknown Command" when the client authenticates for a second time. (issue #8509 reported by pari) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52373 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	2a37a53c57	Fix some bugs in process_message(). The manager session lock needs to be held when sending some sort of response, or calling one of the manager action callbacks. This resolves an issue where people using the GUI would get random crashes when they start clicking around a lot. (issue #8711, reported and debugged by zandbelt) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51781 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	3d5e9fa43c	When traversing the list of manager actions, the iterator needs to be initialized to the list head after locking the list. Also, lock the actions list in one place it is being accessed where it was not being done. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	c5a3194042	Make the "hasmanager" option in users.conf actually have an effect. (issue #8740, LnxPrgr3) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51233 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago

1 2

72 Commits (1.4.21.2)