64 Commits (f95e212afcb51ee2d69eb9c5c9d1a3a8fce60f9d)

Author	SHA1	Message	Date
Dwayne M. Hubbard	4f19fa6fd0	Make the mixmonitor thread process audio frames faster ... Mantis issue 17078 reports MixMonitor recordings have shorter durations than the call duration. This was because the mixmonitor thread was not processing frames from the audiohook fast enough. The mixmonitor thread would slowly fall behind the most recent audio frame and when the channel hangs up, the mixmonitor thread would exit without processing the same number of frames as the channel; leaving the mixmonitor recording shorter than actual call duration. This revision fixes this issue by moving the ast_audiohook_trigger_wait() and the subsequent audiohook.status check into the block where the ast_audiohook_read_frame() function returns NULL. (closes issue #17078) Reported by: geoff2010 Patches: dw-M17078.patch uploaded by dhubbard (license 733) Tested by: dhubbard, geoff2010 Review: https://reviewboard.asterisk.org/r/611/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@257686 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	182c57ce17	fixes MixMonitor thread not exiting when StopMixMonitor is used ... (closes issue #16152) Reported by: AlexMS Patches: stopmixmonitor_1.4.diff uploaded by dvossel (license 671) Tested by: dvossel, AlexMS Review: https://reviewboard.asterisk.org/r/424/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230508 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	941ed1b2fe	Fixes memory leak caused by incorrectly freeing mixmonitor ... (closes issue #15699) Reported by: edantie Patches: mixmonitor.patch uploaded by edantie (license 862) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@213103 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	63cc189747	AST-2009-005 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@211528 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	a3848ec74c	Place unlock of mutex in an else block so that it does not get unlocked twice. ... (closes issue #15400) Reported by: aragon git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@204012 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	86c204f34c	StopMixMonitor race condition (not giving up file immediately) ... StopMixMonitor only indicates to the MixMonitor thread to stop writing to the file. It does not guarantee that the recording's file handle is available to the dialplan immediately after execution. This results in a race condition. To resolve this, the filestream pointer is placed in a datastore on the channel. When StopMixMonitor is called, the datastore is retrieved from the channel and the filestream is closed immediately before returning to the dialplan. Documentation indicating the use of StopMixMonitor to free files has been updated as well. (closes issue #15259) Reported by: travisghansen Tested by: dvossel Review: https://reviewboard.asterisk.org/r/283/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@201423 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	94fa4d11b5	Improve support for media paths that can generate multiple frames at once. ... There are various media paths in Asterisk (codec translators and UDPTL, primarily) that can generate more than one frame to be generated when the application calling them expects only a single frame. This patch addresses a number of those cases, at least the primary ones to solve the known problems. In addition it removes the broken TRACE_FRAMES support, fixes a number of bugs in various frame-related API functions, and cleans up various code paths affected by these changes. https://reviewboard.asterisk.org/r/175/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@200991 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	ad5f20b94b	Update MixMonitor documentation. ... Updated the MixMonitor documentation for the 'b' option so that it is more obvious that you must not optimize awat the Local channel when using this option. (issue #14829) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@197895 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	59f867a5cb	revert commit that included extranous changes ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@182807 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	f1f417a9d8	Improve the build system to *properly* remove unnecessary symbols from the runtime global namespace. Along the way, change the prefixes on some internal-only API calls to use a common prefix. ... With these changes, for a module to export symbols into the global namespace, it must have *both* the AST_MODFLAG_GLOBAL_SYMBOLS flag and a linker script that allows the linker to leave the symbols exposed in the module's .so file (see res_odbc.exports for an example). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@182802 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	d914df762a	Add some missing cleanup to app_mixmonitor ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@173592 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	8e764c583d	Fix a problem where a channel pointer becomes invalid due to masquerading or hanging up. ... app_mixmonitor runs its own thread to monitor the channel's activity and write the mixed audio to a file. Since this thread runs independently of the channel, it is possible that the mixmonitor thread's channel pointer will point to freed memory when the channel either is masqueraded or hangs up (technically, both cases are hangups, but we need to handle the cases slightly differently). The solution for this is to employ a datastore, which has the nice benefit of allowing us to hook into channel masquerades and hangups and update our pointer as necessary. If this looks familiar, this same technique is employed in app_chanspy. app_chanspy is a bit more involved since it does a lot more operations on the channel that is being spied upon. app_mixmonitor does have an extra touch that app_chanspy doesn't have, though. Since there is a thread race between the channel's thread and the mixmonitor thread on a hangup, we em- ploy a condition-and-boolean combination to ensure that the channel thread finishes with our structure before the mixmonitor thread attempts to free it. No crashes! (closes issue #14374) Reported by: aragon Patches: 14374.patch uploaded by putnopvut (license 60) Tested by: aragon, putnopvut git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@173559 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	4a8d87fe98	Add a trigger mode that triggers on both read and write. The actual function that returns the combined audio frame though will wait until both sides have fed in audio, or until one side stops (such as the case when you call Wait). ... (closes issue #11945) Reported by: xheliox git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108083 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	f665fa0556	Don't forget to record the channel so we know whether it is bridged or not later. ... (closes issue #11811) Reported by: slavon git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100934 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	fa640604de	Replace current spy architecture with backport of audiohooks. This should take care of current known spy issues. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@98972 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	19fc56c14d	Close the audio file before sending it to the post processing application. ... (closes issue #11357) Reported by: reformed Patches: mixmonitor.patch uploaded by reformed (license 330) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89587 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	dc6e3e9d5d	Reverting commit made in revision 89205 since it is unnecessary. ... Thanks to Kevin for pointing this out git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89241 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4155b5f984	Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options ... and args.post_process strings are uninitialized and could contain garbage. This change handles this situation properly by only using arguments that we have parsed. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89205 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	6c1076bd45	Merged revisions 72378 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72378 | file | 2007-06-27 19:24:01 -0400 (Wed, 27 Jun 2007) | 2 lines Update documentation to clarify variable usage with MixMonitor. (issue #9494 reported by netoguy) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72381 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	f92505eec1	Merged revisions 52716 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r52716 | file | 2007-01-29 18:39:39 -0500 (Mon, 29 Jan 2007) | 2 lines Now that filename is part of the structure and since it comes before postprocess... we have to add it to our postprocess line. (reported on asterisk-dev by Boris Bakchiev) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52717 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	6124ace110	Merged revisions 52162 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r52162 | file | 2007-01-24 20:48:52 -0500 (Wed, 24 Jan 2007) | 2 lines Add another note about audio files being played back to each bridged party. (issue #8718 reported by ppyy) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52163 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	c60c2b5ffc	Merged revisions 51406 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r51406 | file | 2007-01-22 14:08:52 -0500 (Mon, 22 Jan 2007) | 2 lines Move filestream creation to Mixmonitor loop. This will prevent a blank file from being created if no frames ever pass through to be recorded. (issue #7589 reported by steve_mcneil) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51407 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	ff05bf15c8	update thread creation code a bit ... reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44378 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	fcb999c01c	merge qwell's CLI verbification work ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43212 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	55d594e9da	Make the difference clear about what the responsibilities of the core and a spy are when it comes to spying on a channel. The core is responsible for adding a spy to a channel, feeding frames into the spy, removing the spy from the channel, and notifying the spy that is has been detached. The spy is responsible for reading frames in, and cleaning itself up. Each side will not try to do the other's job. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41959 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	f7e7161607	Merge team/russell/frame_caching ... There are some situations in Asterisk where ast_frame and/or iax_frame structures are rapidly allocatted and freed (at least 50 times per second for one call). This code significantly improves the performance of ast_frame_header_new(), ast_frdup(), ast_frfree(), iax_frame_new(), and iax_frame_free() by keeping a thread-local cache of these structures and using frames from the cache whenever possible instead of calling malloc/free every time. This commit also converts the ast_frame and iax_frame structures to use the linked list macros. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41278 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	0a27d8bfe5	merge new_loader_completion branch, including (at least): ... - restructured build tree and makefiles to eliminate recursion problems - support for embedded modules - support for static builds - simpler cross-compilation support - simpler module/loader interface (no exported symbols) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	0af1edefb6	Merged revisions 33841 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r33841 | kpfleming | 2006-06-13 08:30:06 -0500 (Tue, 13 Jun 2006) | 2 lines memory allocation optimizations ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33842 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	c311827dc9	Merged revisions 33724 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r33724 | file | 2006-06-12 18:34:38 -0300 (Mon, 12 Jun 2006) | 2 lines Greatly simply the mixmonitor thread, and move channel reference directly to spy structure so that the core can modify it. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33725 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	472c1ca282	simplify autoconfig include mechanism (make tholo happy he can use lint again :-) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	04ecb29d03	remove almost all of the checks of the result from ast_strdupa() or alloca(). ... As it turns out, all of these checks were useless, because alloca will never return NULL. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26451 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	03120e00ad	use ast_channel_(un)lock ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25450 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	fb7757440f	remove a check of the result from ast_mutex_lock ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25446 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Luigi Rizzo	e43bc6634d	This rather large commit changes the way modules are loaded. ... As partly documented in loader.c and include/asterisk/module.h, modules are now expected to return all of their methods and flags into a structure 'mod_data', and are normally loaded with RTLD_NOW | RTLD_LOCAL, so symbols are resolved immediately and conflicts should be less likely. Only in a small number of cases (res_*, typically) modules are loaded RTLD_GLOBAL, so they can export symbols. The core of the change is only the two files loader.c and include/asterisk/module.h, all the rest is simply adaptation of the existing modules to the new API, a rather mechanical (but believe me, time and finger-consuming!) process whose detail you can figure out by svn diff'ing any single module. Expect some minor compilation issue after this change, please report it on mantis http://bugs.digium.com/view.php?id=6968 so we collect all the feedback in one place. I am just sorry that this change missed SVN version number 20000! git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	f10f427d49	since the module API is changing, it's a good time to const-ify the description() and key() return values ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
BJ Weschke	c88e03113f	Merged revisions 11778 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r11778 | bweschke | 2006-03-04 06:45:37 -0500 (Sat, 04 Mar 2006) | 3 lines Substitute variables in the post_process string (if it exists) before those variables could possibly disappear (channel hangup) #6462 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@11779 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	f369bbdac3	fix up the summary and help text for the mixmonitor cli command ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10392 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	118b277ab1	add StopMixMonitor application (issue #6122, with mods) ... Rename and export ast_complete_channels for use by cli completion functions that want to complete from the list of active channels git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10287 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	a0d438fb6c	remove the uses of the deprecated STANDARD_LOCAL_USER ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10241 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	4414f45393	on this pass, only remove duplicate log messages ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8403 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	9fa6eb5e07	revert my pass through the tree to remove checks of the result of ast_strdupa ... (revisions 8378 through 8381) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8387 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	7ad681adc8	remove lots of useless checks of the result of ast_strdupa ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8379 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
BJ Weschke	f6c5e65266	More memory wrapper cleanup. #6224 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8045 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Kevin P. Fleming	a4f8d466e8	update copyright headers for files changed this year ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7751 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Kevin P. Fleming	cdf0303465	Merged revisions 7740 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines revert incorrect fix for bug #6048 from revision 7709 put in correct (simpler) fix add doxygen docs for channel spy 'state' values ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7741 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Tilghman Lesher	b5d18c50b9	Merged revisions 7709 via svnmerge from ... /branches/1.2 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7710 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	a725468381	update doxygen docs to specify authors ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7682 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Kevin P. Fleming	2c65582b66	remove extraneous svn:executable properties ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Kevin P. Fleming	c6e7b2a333	issue #5590 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7068 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago
Russell Bryant	987b87662c	make app_queue 1.2 jump compliant (issue #5580) ... add missing includes of stdio.h remove some unused and duplicate headers git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7026 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago