878 Commits (f8538620abe30795d88e604713ac39eb6d22c42b)

Author	SHA1	Message	Date
David Vossel	f8538620ab	Merged revisions 194833 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r194833 | dvossel | 2009-05-15 15:52:12 -0500 (Fri, 15 May 2009) | 24 lines Merged revisions 194557,194685 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194557 | dvossel | 2009-05-14 17:59:43 -0500 (Thu, 14 May 2009) | 10 lines IAX2 "Ghost" Channels There is a bug tracker issue where people are reporting "Ghost" channels in their 'iax2 show channels' output. The confusion is caused by channels being listed as "(NONE)" with format "unknown". These are not channels of coarse. They are usually just pending registration or poke requests, but it is confusing output. To help make sense of this I have added two columns to 'iax2 show channels'. One shows the first message which started the transaction, and the second shows the last message sent by either side of the call. This helps diagnose why the entry exists and why it may not go away. (closes issue #14207) Reported by: clive18 Review: https://reviewboard.asterisk.org/r/246/ ........ r194685 | dvossel | 2009-05-15 10:40:37 -0500 (Fri, 15 May 2009) | 6 lines Update to previous IAX2 "Ghost" Channels patch. Fixed some comments made on reviewboard for the previous patch. (issue #14207) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@194835 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Joshua Colp	0b8f27066a	Merged revisions 192808 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r192808 | file | 2009-05-06 14:38:51 -0300 (Wed, 06 May 2009) | 10 lines Fix a bug where a timer would be created but not acknowledged. This scenario crept up if chan_iax2 was loaded with no configuration file present. It would create a timer and tell it to go at an interval but the thread that normally acknowledges it would not be created because no configuration file was present. The timer will now be closed if no configuration file is present. (closes issue #15014) Reported by: madkins ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@192809 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	ed00c79ed0	Merged revisions 192214 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r192214 | dvossel | 2009-05-04 17:44:51 -0500 (Mon, 04 May 2009) | 17 lines Merged revisions 192213 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192213 | dvossel | 2009-05-04 17:37:31 -0500 (Mon, 04 May 2009) | 11 lines global mohinterpret setting is ignored mohinterpret and mohsuggest global variables were not copied over during build_users and build_peers. (closes issue #14728) Reported by: dimas Patches: v1-14728.patch uploaded by dimas (license 88) Tested by: dimas, dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@192216 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	bd33e2b9f3	Merged revisions 191494 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r191494 | tilghman | 2009-05-01 13:18:00 -0500 (Fri, 01 May 2009) | 4 lines Set debug message back to DEBUG level. (closes issue #15007) Reported by: hulber ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@191553 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Doug Bailey	2b41886194	Merged revisions 189419 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r189419 | dbailey | 2009-04-20 14:28:16 -0500 (Mon, 20 Apr 2009) | 11 lines Merged revisions 189391 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r189391 | dbailey | 2009-04-20 14:10:56 -0500 (Mon, 20 Apr 2009) | 4 lines Clean up problem with manager implementation of mmap where it was not testing against MAP_FAILED response. Got rid of shadowed variable used in processign the mmap results. Change test of mmap results to compare against MAP_FAILED ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@189422 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	ad618c6c4f	Merged revisions 184762 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r184762 | kpfleming | 2009-03-27 14:10:32 -0500 (Fri, 27 Mar 2009) | 12 lines Improve timing interface to remember which provider provided a timer The ability to load/unload timing interfaces is nice, but it means that when a timer is allocated, it may come from provider A, but later provider B becomes the 'preferred' provider. If this happens, all timer API calls on the timer that was provided by provider A will actually be handed to provider B, which will say WTF and return an error. This patch changes the timer API to include a pointer to the provider of the timer handle so that future operations on the timer will be forwarded to the proper provider. (closes issue #14697) Reported by: moy Review: http://reviewboard.digium.com/r/211/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184765 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	429e148ebf	Merged revisions 184339 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r184339 | russell | 2009-03-25 16:57:19 -0500 (Wed, 25 Mar 2009) | 35 lines Improve performance of the ast_event cache functionality. This code comes from svn/asterisk/team/russell/event_performance/. Here is a summary of the changes that have been made, in order of both invasiveness and performance impact, from smallest to largest. 1) Asterisk 1.6.1 introduces some additional logic to be able to handle distributed device state. This functionality comes at a cost. One relatively minor change in this patch is that the extra processing required for distributed device state is now completely bypassed if it's not needed. 2) One of the things that I noticed when profiling this code was that a _lot_ of time was spent doing string comparisons. I changed the way strings are represented in an event to include a hash value at the front. So, before doing a string comparison, we do an integer comparison on the hash. 3) Finally, the code that handles the event cache has been re-written. I tried to do this in a such a way that it had minimal impact on the API. I did have to change one API call, though - ast_event_queue_and_cache(). However, the way it works now is nicer, IMO. Each type of event that can be cached (MWI, device state) has its own hash table and rules for hashing and comparing objects. This by far made the biggest impact on performance. For additional details regarding this code and how it was tested, please see the review request. (closes issue #14738) Reported by: russell Review: http://reviewboard.digium.com/r/205/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184342 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	e68ef0befb	Merged revisions 184037 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r184037 | russell | 2009-03-24 16:40:44 -0500 (Tue, 24 Mar 2009) | 6 lines Exclude slin16, siren7, and siren14 from bandwidth=low and =medium The default codec configuration for chan_iax2 is bandwidth=low. I noticed slin16 being negotiated as the codec in some test calls, but that no longer happens after this change. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184039 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	1b4c0390a6	Merged revisions 183560 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r183560 | russell | 2009-03-20 12:00:58 -0500 (Fri, 20 Mar 2009) | 10 lines Merged revisions 183559 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r183559 | russell | 2009-03-20 11:53:25 -0500 (Fri, 20 Mar 2009) | 2 lines Fix a crash in IAX2 registration handling found during load testing with dvossel. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@183563 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	0267ce94e5	Merged revisions 182282 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r182282 | dvossel | 2009-03-16 12:49:58 -0500 (Mon, 16 Mar 2009) | 13 lines Merged revisions 182281 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r182281 | dvossel | 2009-03-16 12:47:42 -0500 (Mon, 16 Mar 2009) | 7 lines Randomize IAX2 encryption padding The 16-32 byte random padding at the beginning of an encrypted IAX2 frame turns out to not be all that random at all. This patch calls ast_random to fill the padding buffer with random data. The padding is randomized at the beginning of every encrypted call and for every encrypted retransmit frame. Review: http://reviewboard.digium.com/r/193/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@182284 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	cb9f721fcd	Merged revisions 181371 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r181371 | dvossel | 2009-03-11 12:34:57 -0500 (Wed, 11 Mar 2009) | 17 lines Merged revisions 181340 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r181340 | dvossel | 2009-03-11 12:25:31 -0500 (Wed, 11 Mar 2009) | 11 lines encrypted IAX2 during packet loss causes decryption to fail on retransmitted frames If an iax channel is encrypted, and a retransmit frame is sent, that packet's iseqno is updated while it is encrypted. This causes the entire frame to be corrupted. When the corrupted frame is sent, the other side decrypts it and sends a VNAK back because the decrypted frame doesn't make any sense. When we get the VNAK, we look through the sent queue and send the same corrupted frame causing a loop. To fix this, encrypted frames requiring retransmission are decrypted, updated, then re-encrypted. Since key-rotation may change the key held by the pvt struct, the keys used for encryption/decryption are held within the iax_frame to guarantee they remain correct. (closes issue #14607) Reported by: stevenla Tested by: dvossel Review: http://reviewboard.digium.com/r/192/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@181373 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	7a3aaf4f7e	Merged revisions 178871 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r178871 | dvossel | 2009-02-26 11:46:12 -0600 (Thu, 26 Feb 2009) | 6 lines IAX2 prune realtime, minor tweak to last fix A return statement was missing which caused unexpected cli output. issue #14479 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@178875 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	44cbe73882	Merged revisions 178767 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r178767 | dvossel | 2009-02-26 09:50:22 -0600 (Thu, 26 Feb 2009) | 8 lines IAX2 prune realtime fix Iax2 prune realtime had issues. If "iax2 prune realtime all" was called, it would appear like the command was successful, but in reality nothing happened. This is because the reload that was supposed to take place checks the config files, sees no changes, and does nothing. If there had been a change in the the config file, the realtime users would have been marked for deletion and everything would have been fine. Now prune_users() and prune_peers() are called instead of reload_config() to prune all users/peers that are realtime. These functions remove all users/peers with the rtfriend and delme flags set. iax2_prune_realtime() also lacked the code to properly delete a single friend. For example. if iax2 prune realtime <friend> was called, only the peer instance would be removed. The user would still remain. (closes issue #14479) Reported by: mousepad99 Review: http://reviewboard.digium.com/r/176/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@178769 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	f9fa2e07ab	Fixes issue with undefined audio codecs in chan_iax2 ... During iax2 call negotiation, supported codecs are passed in an Information Element containing a 2 byte field where each bit correlates to a specific codec. In 1.6 only audio codec bits 0-12 are defined, leaving bits 13-14 undefined. By default all bits are enabled unless specified otherwise. Since its a 2 byte field and 13-14 are not defined, these bits are never turned off. In trunk, bits 13-14 are defined, which means 1.6 is advertising support for codecs it does not have when talking to trunk. I fixed this by adding #define for undefined audio codec bits. These bits are then removed from iax2's full bandwidth capabilities. (closes issue #14283) Reported by: jcovert git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@177700 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	1ed4960ea5	Merged revisions 176355 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r176355 | dvossel | 2009-02-16 17:33:55 -0600 (Mon, 16 Feb 2009) | 13 lines Merged revisions 176354 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r176354 | dvossel | 2009-02-16 17:30:52 -0600 (Mon, 16 Feb 2009) | 8 lines Fixes issue with AST_CONTROL_SRCUPDATE not being relayed correctly during bridging This should have been committed with rev176247, but I missed it. srcupdate frames no longer break out of the native bridge, but are not being sent to the other call leg either. This fixs that. issue #13749 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@176362 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	d9d35e070b	Merged revisions 176248 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r176248 | dvossel | 2009-02-16 15:30:17 -0600 (Mon, 16 Feb 2009) | 11 lines Merged revisions 175597 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r175597 | dvossel | 2009-02-13 14:11:55 -0600 (Fri, 13 Feb 2009) | 4 lines Fixed iax2 key rotation backwards compatibility Turns key rotation back on by default. Added bit into encryption IE to indicate whether or not key rotation is supported or not. If it is not supported then it is not enabled, which insures backwards compatibility. This eliminates the need for the keyrotate option in iax.conf, so it has been removed. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@176251 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	972e704692	Merged revisions 175597 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r175597 | dvossel | 2009-02-13 14:11:55 -0600 (Fri, 13 Feb 2009) | 4 lines Fixed iax2 key rotation backwards compatibility Turns key rotation back on by default. Added bit into encryption IE to indicate whether or not key rotation is supported or not. If it is not supported then it is not enabled, which insures backwards compatibility. This eliminates the need for the keyrotate option in iax.conf, so it has been removed. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@175662 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	63b7cfb593	Merged revisions 175250 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r175250 | kpfleming | 2009-02-12 12:48:52 -0600 (Thu, 12 Feb 2009) | 1 line correct warning message to not refer specifically to DAHDI ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@175251 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	7827a31bfe	Merged revisions 175127 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r175127 | dvossel | 2009-02-12 11:07:17 -0600 (Thu, 12 Feb 2009) | 4 lines Setting key rotation to be off by default Key rotation breaks compatibility between (trunk/1.6.1) and (1.2/1.4/1.6.0). As a follow up to this, I am investigating possible ways to allow key rotation to be on by default and not affect the other branches, but for now it must be turned off. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@175130 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	914cb3409a	Merged revisions 173502 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r173502 | dvossel | 2009-02-04 15:25:14 -0600 (Wed, 04 Feb 2009) | 9 lines Fixes issue with IAX2 transfer not handing off calls. Reverts changes in 116884 Fixes issue with IAX2 transfers not taking place. As it was, a call that was being transfered would never be handed off correctly to the call ends because of how call numbers were stored in a hash table. The hash table, "iax_peercallno_pvt", storing all the current call numbers did not take into account the complications associated with transferring a call, so a separate hash table was required. This second hash table "iax_transfercallno_pvt" handles calls being transfered, once the call transfer is complete the call is removed from the transfer hash table and added to the peer hash table resuming normal operations. Addition functions were created to handle storing, removing, and comparing items in the iax_transfercallno_pvt table. The changes reverted in 116884 caused backwards compatibility issues involving iax2 transfer with 1.6.0, 1.4, and 1.2. (closes issue #13468) Reported by: nicox Tested by: dvossel ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@173506 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	e0ee168b6b	Merged revisions 170608 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r170608 | tilghman | 2009-01-23 13:25:10 -0600 (Fri, 23 Jan 2009) | 9 lines Merged revisions 170588 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r170588 | tilghman | 2009-01-23 13:20:44 -0600 (Fri, 23 Jan 2009) | 2 lines Additions to AST-2009-001 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@170637 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	c7add836c6	Merged revisions 167265 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r167265 | tilghman | 2009-01-06 15:02:33 -0600 (Tue, 06 Jan 2009) | 16 lines Merged revisions 167260 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r167260 | tilghman | 2009-01-06 14:48:05 -0600 (Tue, 06 Jan 2009) | 9 lines Merged revisions 167259 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r167259 | tilghman | 2009-01-06 14:44:03 -0600 (Tue, 06 Jan 2009) | 2 lines Security fix AST-2009-001. ........ ................ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167268 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	791523697d	Merged revisions 164525 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r164525 | russell | 2008-12-15 16:25:46 -0600 (Mon, 15 Dec 2008) | 6 lines Open a timer before loading configuration so that the trunking configuration option will take effect. (closes issue #14082) Reported by: seandarcy ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164527 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	a0258d8f1b	Merged revisions 164522 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r164522 | russell | 2008-12-15 16:22:43 -0600 (Mon, 15 Dec 2008) | 4 lines Fix log message to refer to the generic timing interface, not DAHDI specifically (inspired by issue #14082) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164524 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	343c549980	Merged revisions 160004 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r160004 | russell | 2008-12-01 11:34:31 -0600 (Mon, 01 Dec 2008) | 14 lines Merged revisions 160003 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they both have the potential to send control frames in the middle of call setup. We have to wait until we have received a message back from the remote end before we try to send any more frames. Otherwise, the remote end will consider it invalid, and we'll get stuck in an INVAL/VNAK storm. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@160006 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	c3347e79a5	Merged revisions 159818 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r159818 | kpfleming | 2008-11-29 11:57:39 -0600 (Sat, 29 Nov 2008) | 18 lines incorporates r159808 from branches/1.4: ------------------------------------------------------------------------ r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way ------------------------------------------------------------------------ in addition: move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159851 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	95fb6bb29c	Merged revisions 159360 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r159360 | murf | 2008-11-25 16:03:01 -0700 (Tue, 25 Nov 2008) | 23 lines Merged revisions 159316 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines (closes issue #12694) Reported by: yraber Patches: 12694.2nd.diff uploaded by murf (license 17) Tested by: murf, laurav Thanks to file (Joshua Colp) for his IAX fix. the change to cdr.c allows no-answer to percolate up into CDR's, and feels like the right place to locate this fix; if BUSY is done here, no-answer should be, too. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159375 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	ae28cf2d91	Merged revisions 159276 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r159276 | tilghman | 2008-11-25 15:57:59 -0600 (Tue, 25 Nov 2008) | 14 lines Merged revisions 159269 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159269 | tilghman | 2008-11-25 15:56:48 -0600 (Tue, 25 Nov 2008) | 7 lines Don't try to send a response on a NULL pvt. (closes issue #13919) Reported by: barthpbx Patches: chan_iax2.c.patch uploaded by eliel (license 64) Tested by: barthpbx ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159280 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	debfcf4ed6	Merged revisions 159247 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r159247 | tilghman | 2008-11-25 15:42:42 -0600 (Tue, 25 Nov 2008) | 21 lines Merged revisions 159246 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r159246 | tilghman | 2008-11-25 15:40:28 -0600 (Tue, 25 Nov 2008) | 14 lines Merged revisions 159245 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines Regression fix for last security fix. Set the iseqno correctly. (closes issue #13918) Reported by: ffloimair Patches: 20081119__bug13918.diff.txt uploaded by Corydon76 (license 14) Tested by: ffloimair ........ ................ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159249 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	21ff7585a5	Merged revisions 156243 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r156243 | tilghman | 2008-11-12 12:55:18 -0600 (Wed, 12 Nov 2008) | 18 lines Merged revisions 156229 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r156229 | tilghman | 2008-11-12 12:39:21 -0600 (Wed, 12 Nov 2008) | 11 lines Revert revision 132506, since it occasionally caused IAX2 HANGUP packets not to be sent, and instead, schedule a task to destroy the iax2 pvt structure 10 seconds later. This allows the IAX2 HANGUP packet to be queued, transmitted, and ACKed before the pvt is destroyed. (closes issue #13645) Reported by: dzajro Patches: 20081111__bug13645__3.diff.txt uploaded by Corydon76 (license 14) Tested by: vazir Reviewed: http://reviewboard.digium.com/r/51/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@156288 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	5a2f0feb1c	Merged revisions 154428 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r154428 | tilghman | 2008-11-04 17:03:00 -0600 (Tue, 04 Nov 2008) | 7 lines Switch to using a thread condition to signal that a child thread is ready for work, rather than a busy wait. (closes issue #13011) Reported by: jpgrayson Patches: chan_iax2_find_idle.patch uploaded by jpgrayson (license 492) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@154917 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	5b82a5c9b2	Merged revisions 154366 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r154366 | tilghman | 2008-11-04 14:51:18 -0600 (Tue, 04 Nov 2008) | 16 lines Merged revisions 154365 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r154365 | tilghman | 2008-11-04 14:49:33 -0600 (Tue, 04 Nov 2008) | 9 lines On busy systems, it's possible for the values checked within a single line of code to change, unless the structure is locked to ensure a consistent state. (closes issue #13717) Reported by: kowalma Patches: 20081102__bug13717.diff.txt uploaded by Corydon76 (license 14) Tested by: kowalma ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@154367 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	1036849a42	import gcc 4.3.2 warning fixes from trunk, with a few changes specific to this branch ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@153710 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	7c7a915e95	Merged revisions 150635 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r150635 | tilghman | 2008-10-17 12:09:03 -0500 (Fri, 17 Oct 2008) | 2 lines Make helper call a little safer (suggested by Russell on IRC) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@150636 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	2f69e7a63c	Merged revisions 150580 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r150580 | tilghman | 2008-10-17 11:34:29 -0500 (Fri, 17 Oct 2008) | 2 lines Fix the FRACK! warnings in chan_iax2 when POKE/LAGRQ packets are not answered. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@150606 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	2c1bfe7643	Merged revisions 147807 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r147807 | murf | 2008-10-09 08:17:33 -0600 (Thu, 09 Oct 2008) | 15 lines (closes issue #13557) Reported by: nickpeirson Patches: pbx.c.patch uploaded by nickpeirson (license 579) replace_bzero+bcopy.patch uploaded by nickpeirson (license 579) Tested by: nickpeirson, murf 1. replaced all refs to bzero and bcopy to memset and memmove instead. 2. added a note to the CODING-GUIDELINES 3. add two macros to asterisk.h to prevent bzero, bcopy from creeping back into the source 4. removed bzero from configure, configure.ac, autoconfig.h.in ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@147811 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	deb3c05634	Merged revisions 146802 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r146802 | tilghman | 2008-10-06 16:09:05 -0500 (Mon, 06 Oct 2008) | 15 lines Merged revisions 146799 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r146799 | tilghman | 2008-10-06 15:52:04 -0500 (Mon, 06 Oct 2008) | 8 lines Dialplan functions should not actually return 0, unless they have modified the workspace. To signal an error (and no change to the workspace), -1 should be returned instead. (closes issue #13340) Reported by: kryptolus Patches: 20080827__bug13340__2.diff.txt uploaded by Corydon76 (license 14) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@146838 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	0caaf043f3	Merged revisions 143141 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r143141 | tilghman | 2008-09-15 16:31:36 -0500 (Mon, 15 Sep 2008) | 13 lines Merged revisions 143140 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r143140 | tilghman | 2008-09-15 16:29:32 -0500 (Mon, 15 Sep 2008) | 6 lines Set the raw formats at the same time as the other formats. (closes issue #13240) Reported by: jvandal Patches: 20080813__bug13240.diff.txt uploaded by Corydon76 (license 14) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@143143 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	25dd2fa2f3	Merged revisions 143031 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r143031 | tilghman | 2008-09-13 08:54:15 -0500 (Sat, 13 Sep 2008) | 8 lines Repair IAXVAR implementation so that it works again (regression?) (closes issue #13354) Reported by: adomjan Patches: 20080828__bug13354.diff.txt uploaded by Corydon76 (license 14) 20080829__bug13354__1.6.0.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, adomjan ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@143033 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	b354d1ce51	Merged revisions 140606 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r140606 | seanbright | 2008-09-02 14:15:54 -0400 (Tue, 02 Sep 2008) | 16 lines Merged revisions 140605 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140605 | seanbright | 2008-09-02 14:14:57 -0400 (Tue, 02 Sep 2008) | 8 lines Make sure to use the correct length of the mohinterpret and mohsuggest buffers when copying configuration values. (closes issue #13336) Reported by: decryptus_proformatique Patches: chan_iax2_mohinterpret_mohsuggest_general_settings.patch uploaded by decryptus (license 555) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140608 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	6ed6a5ae29	Merged revisions 140489 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r140489 | mmichelson | 2008-08-29 12:47:17 -0500 (Fri, 29 Aug 2008) | 30 lines Merged revisions 140488 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140488 | mmichelson | 2008-08-29 12:34:17 -0500 (Fri, 29 Aug 2008) | 22 lines After working on the ao2_containers branch, I noticed something a bit strange. In all cases where we provide a callback function to ao2_container_alloc, the callback function would only return 0 or CMP_MATCH. After inspecting the ao2_callback() code carefully, I found that if you're only looking for one specific item, then you should return CMP_MATCH | CMP_STOP. Otherwise, astobj2 will continue traversing the current bucket until the end searching for more matches. In cases like chan_iax2 where in 1.4, all the peers are shoved into a single bucket, this makes for potentially terrible performance since the entire bucket will be traversed even if the peer is one of the first ones come across in the bucket. All the changes I have made were for cases where the callback function defined was passed to ao2_container_alloc so that calls to ao2_find could find a unique instance of whatever object was being stored in the container. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140490 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	192e6166df	Merged revisions 140053 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r140053 | russell | 2008-08-26 10:29:25 -0500 (Tue, 26 Aug 2008) | 23 lines Merged revisions 140051 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140051 | russell | 2008-08-26 10:27:23 -0500 (Tue, 26 Aug 2008) | 15 lines Fix a race condition with the IAX scheduler thread. A lock and condition are used here to allow newly scheduled tasks to wake up the scheduler just in case the new task needs to run sooner than the current wakeup time when the thread is sleeping. However, there was a race condition such that a newly scheduled task would not properly wake up the scheduler or affect the wake up period. The order of execution would have been: 1) Scheduler thread determines wake up time of N ms. 2) Another thread schedules a task and signals the condition, with an execution time of < N ms. 3) Scheduler thread locks and goes to sleep for N ms. By moving the sleep time determination to inside the critical section, this possibility is avoided. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140055 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	2b05a594fa	Merged revisions 139469 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r139469 | mmichelson | 2008-08-22 12:25:12 -0500 (Fri, 22 Aug 2008) | 11 lines Merged revisions 139466 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139466 | mmichelson | 2008-08-22 12:24:47 -0500 (Fri, 22 Aug 2008) | 3 lines Fix the build. Thanks, mvanbaak! ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139474 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	9a3fe578f5	Merged revisions 139457 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r139457 | mmichelson | 2008-08-22 11:58:21 -0500 (Fri, 22 Aug 2008) | 15 lines Merged revisions 139456 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139456 | mmichelson | 2008-08-22 11:57:38 -0500 (Fri, 22 Aug 2008) | 7 lines Prevent a deadlock in chan_iax2 resulting from incorrect locking order between iax2_pvt and ast_channel structures. AST-13 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139459 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	9fb19a971f	Merged revisions 138473 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r138473 | seanbright | 2008-08-17 09:31:54 -0400 (Sun, 17 Aug 2008) | 7 lines Fix the output of the JitterBufStats manager event. (closes issue #13324) Reported by: srt Patches: 13324_missing_nl_in_jitterbufstats_event_2.diff uploaded by srt (license 378) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@138475 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	db1ed285c4	More RSW merges. This should do it for the channels/ dir. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136917 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	de582e1eb2	Merged revisions 135747 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r135747 | tilghman | 2008-08-05 16:34:46 -0500 (Tue, 05 Aug 2008) | 9 lines In a conversion to use ast_strlen_zero, the meaning of the flag IAX_HASCALLERID was perverted. This change reverts IAX2 to the original meaning, which was, that the callerid set on the client should be overridden on the server, even if that means the resulting callerid is blank. In other words, if you set "callerid=" in the IAX config, then the callerid should be overridden to blank, even if set on the client. Note that there's a distinction, even on realtime, between the field not existing (NULL in databases) and the field existing, but set to blank (override callerid to blank). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135748 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	7df8b8b848	make datastore creation and destruction a generic API since it is not really channel related, and add the ability to add/find/remove datastores to manager sessions ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135680 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	58291bcec9	Merge changes from team/bbryant/keyrotation ... This set of changes enhances IAX2 encryption support by adding key rotation to provide enhanced security. The key used for encryption is rotated right after the call gets set up, and then again every few minutes. This was discussed at the last AstriDevCon. For interoperability with older versions of Asterisk, there is an option that disables key rotation. (closes issue #13018) Reported by: bbryant Patches: 07072008__iax2_key_rotation.diff uploaded by bbryant (license 36) Tested by: russell, bbryant git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	0c23159464	Deprecate *_device_state_* APIs in favor of *_devstate_* APIs ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@133860 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago