26500 Commits (f45833c9ade260f8cf866e65cd29eb146bdd559e)

 

All Branches   

Search

Author	SHA1	Message	Date
Corey Farrell	881844297a	res_pjsip: Remove incorrect MODULEINFO from presence_xml.c. ... Remove incorrect MODULEINFO block and unneeded header includes from presence_xml.c. ASTERISK-25027 Reported by: Corey Farrell Change-Id: I977c609ab9d1fe05373027c4138900f6985990eb	11 years ago
Corey Farrell	c232ff3af0	Git Migration: Create doc/rest-api when needed. ... Create the directory './doc/rest-api' at the start of 'make ari-stubs' to prevent an error when documentation is generated. The directory is also added to git ignores. ASTERISK-25027 Reported by: Corey Farrell Change-Id: Iaccc7f0138501c23aa78feaca2f3cce9e68cbc1b	11 years ago
Joshua Colp	78ff328b0b	Merge "chan_iax2: Ensure that IAX flags are 64 bits."	11 years ago
Corey Farrell	5d997ecc83	Build System: Prevent unneeded changes to asterisk/buildopts.h. ... * Add AST_DEVMODE to BUILDOPTS * Use BUILDOPTS to generate AST_BUILDOPT_SUM. * Remove loop that defined AST_MODULE_* These changes ensure that only ABI effecting options are considered for AST_BUILDOPT_SUM. This also reduces unneeded full system rebuilds caused by enabling or disabling one module that another is dependent on. ASTERISK-25028 #close Reported by: Corey Farrell Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2	11 years ago
Corey Farrell	55a780d211	Git Conversion: Switch Non-C files to ASTERISK_REGISTER_FILE. ... This switches files used to generate other sources to use the new ASTERISK_REGISTER_FILE macro. ASTERISK-25026 #close Reported by: Corey Farrell Change-Id: Ieb2537b83421cad07c8955e5f90c405ccf079740	11 years ago
Joshua Colp	2415e94b07	Merge "res_pjsip_outbound_registration: Add debugging messages."	11 years ago
Mark Michelson	36a9bd994b	Merge "CHANGES: Add missing spaces."	11 years ago
Yousf Ateya	5ebfed8ef3	chan_iax2: Ensure that IAX flags are 64 bits. ... Flags are 64 bits. Without LLU suffix the value of 1<<31 is negative. Although it doesn't have an effect on the current implementation, it will be problem if more flags are added. Change-Id: Ic290c81cfbbbf062872392d99d3322932cc49487	11 years ago
Ashley Sanders	46cf643c75	chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR ... Sections Exist in pjsip.conf This patch modifies the current loading strategy of the pjsip configuration. If duplicate sections (e.g. sections containing the same [id/type]) are defined in [pjsip.conf], the loader will consider the configuration for the given type as invalid when the duplicate section is encountered. The entire configuration (including what was previously loaded) for the duplicate [id/type] sections will be rejected and destroyed, an error message is logged and the load processing for the given stops. ASTERISK-24996 Reported By: Ashley Sanders Change-Id: I35090ca4cd40f1f34881dfe701a329145c347aef	11 years ago
Richard Mudgett	0bbe2c35cf	chan_vpb: Fix compile error due to use of ASTERISK_FILE_VERSION. ... Change-Id: I51179e2a83937423676da522b766f1126de4059e	11 years ago
Mark Michelson	f47fed2e12	res_pjsip_outbound_registration: Add debugging messages. ... When problems occur regarding outbound registrations, it currently is difficult to debug. Most off-nominal paths had warning messages, but sometimes we want to know what's going on before hitting the off-nominal path. This patch adds lots of debugging output that should give a clearer picture of what is happening with regards to outbound registrations. ASTERISK-25020 Reported by Mark Michelson Change-Id: I577bde7860be0a6c872b5bcb4d5047340bf45d45	11 years ago
Joshua Colp	7c18edaa10	Merge "Example script for scan-build (the llvm static analyzer)"	11 years ago
Steve Davies	5e96584829	res_rtp_asterisk: Resolve 2 discrete memory leaks in DTLS ... ao2 ref leak in res_rtp_asterisk.c when a DTLS policy is created. The resources are linked into a table, but the original alloc refs are never released. ast_strdup leak in rtp_engine.c. If ast_rtp_dtls_cfg_copy() is called twice on the same destination struct, a pointer to an alloc'd string is overwritten before the string is free'd. ASTERISK-25022 Reported by: one47 Change-Id: I62a8ceb8679709f6c3769136dc6aa9a68202ff9b	11 years ago
Joshua Colp	b2153f1f49	Merge "cdr/cdr_odbc.c: Added to record new columns add on CDR 1.8 Asterisk Version"	11 years ago
Matt Jordan	e43fa9868b	Merge "Astobj2: Allow reference debugging to be enabled/disabled by config."	11 years ago
Rodrigo Ramírez Norambuena	d6a2d92353	cdr/cdr_csv.c: Add missing space after comma. ... Change-Id: I3866a20019b1a3a2f10fe36640053929330b0fcb	11 years ago
Rodrigo Ramírez Norambuena	542bfee881	CHANGES: Add missing spaces. ... Change-Id: I534ea0f22759e3633585dfa9b145b4a284efe67f	11 years ago
Corey Farrell	5c1d07baf0	Astobj2: Allow reference debugging to be enabled/disabled by config. ... * The REF_DEBUG compiler flag no longer has any effect on code that uses Astobj2. It is used to determine if reference debugging is enabled by default. Reference debugging can be enabled or disabled in asterisk.conf. * Caller information is provided in logger errors for ao2 bad magic numbers. * Optimizes AO2 by merging internal functions with the public counterpart. This was possible now that we no longer require a dual ABI. ASTERISK-24974 #close Reported by: Corey Farrell Change-Id: Icf3552721fe999365ba8a8cf00a965aa6b897cc1	11 years ago
George Joseph	356568dc7f	res_pjsip: Fix SEGV on pending-qualify contacts ... Permanent contacts that hadn't been qualified yet were missing their contact_status entries causing SEGVs when running CLI commands. This patch makes sure that contact_statuses are created for both dynamic and permanent contacts when they are created. It also adds checks in the CLI code to make sure there's a contact_status, just in case. ASTERISK-25018 #close Reported-by: Ivan Poddubny Tested-by: Ivan Poddubny Tested-by: George Joseph Change-Id: I3cc13e5cedcafb24c400368b515b02d7fb81e029	11 years ago
Rodrigo Ramírez Norambuena	358080e86e	cdr/cdr_odbc.c: Added to record new columns add on CDR 1.8 Asterisk Version ... Add new column to INSERT new columns added in cdr 1.8 version. The columns are: * peeraccount * linkedid * sequence This feature is configurable in cdr_odbc.conf using a new configuration option, 'newcdrcolumns'. ASTERISK-24976 #close Change-Id: Ibe0c7540a88305c6012786f438a0813ad8b19127	11 years ago
Matt Jordan	d7f4788341	channels/chan_skinny: Fix compilation error introduced in f8e21a1adf ... A typo in commit f8e21a1adf resulted in a compilation error in chan_skinny. This patch fixes the typo. ASTERISK-24917 Change-Id: Id7f4ad1fe948eb2408622e80c27936ce4516c33c	11 years ago
Matt Jordan	0c92a85aee	Merge "Clang: Fix some more tautological-compare warnings."	11 years ago
Matt Jordan	835cf04706	Merge "app_confbridge: Default the template option to a compatible default profile."	11 years ago
Matt Jordan	3646ce0cb5	Merge "res_pjsip_outbound_authenticator: Increase CSeq on authed requests."	11 years ago
Kevin Harwell	9f65ea482e	app_confbridge: Default the template option to a compatible default profile. ... Confbridge dynamic profiles did not have a default profile unless you explicitly used Set(CONFBRIDGE(bridge,template)=default_bridge). If a template was not set prior to the bridge being created then some options were left with no default values set. This patch makes it so the default templates are set to the default bridge and user profiles. ASTERISK-24749 #close Reported by: philippebolduc Change-Id: I1bd6e94b38701ac2112d842db68de63d46f60e0a	11 years ago
Joshua Colp	1ec829a74b	Merge "CHANGES remove tab space"	11 years ago
Joshua Colp	b9514a17ba	Merge "CREDITS: Update credits for Olle Johansson"	11 years ago
Olle E. Johansson	cafdb7a049	CREDITS: Update credits for Olle Johansson ... Change-Id: I8f3d0a6c3f1075a1f7d8308593394611a96749de	11 years ago
Mark Michelson	bd61c9300c	res_pjsip_outbound_authenticator: Increase CSeq on authed requests. ... The way PJSIP generates an authenticated request is to use a previous request as a template. This means that the authenticated request will have the same Call-ID, From header (including tag), and CSeq as the original request. PJSIP generates a new branch on the Via header to indicate that this is a new transaction, though. There are some SIP implementations, though, that do not notice the change in the branch and therefore will match the authed request to the original request's transaction. Since the CSeq is the same, the server will repeat the response it sent to the original request. This patch aids interoperability by increasing the CSeq of the authed request by one. ASTERISK-24845 #close Reported by: Carl Fortin Tested by: Carl Fortin Change-Id: I39c4ca52e688a9f83bcc1878371334becdc5be01	11 years ago
Diederik de Groot	f8e21a1adf	Clang: Fix some more tautological-compare warnings. ... clang can warn about a so called tautological-compare, when it finds comparisons which are logically always true, and are therefor deemed unnecessary. Exanple: unsigned int x = 4; if (x > 0) // x is always going to be bigger than 0 Enum Case: Each enumeration is its own type. Enums are an integer type but they do not have to be *signed*. C leaves it up to the compiler as an implementation option what to consider the integer type of a particu- lar enumeration is. Gcc treats an enum without negative values as an int while clang treats this enum as an unsigned int. rmudgett & mmichelson: cast the enum to (unsigned int) in assert. The cast does have an effect. For gcc, which seems to treat all enums as int, the cast to unsigned int will eliminate the possibility of negative values being allowed. For clang, which seems to treat enums without any negative members as unsigned int, the cast will have no effect. If for some reason in the future a negative value is ever added to the enum the assert will still catch the negative value. ASTERISK-24917 Change-Id: Ief23ef68916192b9b72dabe702b543ecfeca0b62	11 years ago
Diederik de Groot	1e74793061	Example script for scan-build (the llvm static analyzer) ... - Added Pre-amble (Options / Flags / Usage Example / GNU License) - Extended Configurability - Made Executable ASTERISK-24917 Change-Id: I70405fe54e4be7dbfbcb62e291690069b88617a8	11 years ago
Matt Jordan	61c8ae548a	Merge "res_pjsip_t38: Don't crash on authenticated reinvite after originated T.38 FAX."	11 years ago
Mark Michelson	1a8355622d	Merge "Clang: change previous tautological-compare fixes."	11 years ago
Mark Michelson	89a3fc0572	res_pjsip_t38: Don't crash on authenticated reinvite after originated T.38 FAX. ... When Asterisk originates a channel to an application, the channel is hung up once the application finishes executing. When the application in question is SendFax, the Asterisk PJSIP code will attempt to reinvite the T.38 session to audio after the FAX completes. The hangup of the channel happens in the midst of this reinvite transaction. In most circumstances, this works out okay because the BYE is delayed until the reinvite transaction can complete. However, if the reinvite that Asterisk sends receives a 401/407 response, then Asterisk's attempt to re-send the reinvite with authentication will fail. This is because the session supplement in res_pjsip_t38 makes the assumption that the channel on the session will always be non-NULL. Since the channel has been hung up, though, the channel is now NULL. Attempting to operate on the channel causes a crash. This patch fixes the issue by ensuring that the channel on the session is not NULL before attempting to mess with the T.38 framehook. This patch also contains some corrections for comments that were incorrect and really confused me when I first started looking at the code. ASTERISK-25004 #close Reported by Mark Michelson Change-Id: Ic5a1230668369dda4bb13524098aed9306ab45a0	11 years ago
George Joseph	75666ad7c6	res_pjsip: Validate that contact uris start with sip: or sips: ... Currently we use pjsip_parse_hdr to validate contact uris but it appears that it allows uris without a scheme if there's a port supplied. I.E myexample.com will fail but myexample.com:5060 will pass even though it has no scheme. This causes SEGVs later on whenever the uri is used. To prevent this, permanent_contact_validate has been updated to check that the scheme is either 'sip' or 'sips'. 2 uses of possibly-null endpoint have also been fixed in create_out_of_dialog_request. ASTERISK-24999 Change-Id: Ifc17d16a4923e1045d37fe51e43bbe29fa556ca2 Reported-by: Brad Latus	11 years ago
Diederik de Groot	ca7193167e	Clang: change previous tautological-compare fixes. ... clang can warn about a so called tautological-compare, when it finds comparisons which are logically always true, and are therefor deemed unnecessary. Exanple: unsigned int x = 4; if (x > 0) // x is always going to be bigger than 0 Enum Case: Each enumeration is its own type. Enums are an integer type but they do not have to be *signed*. C leaves it up to the compiler as an implementation option what to consider the integer type of a particu- lar enumeration is. Gcc treats an enum without negative values as an int while clang treats this enum as an unsigned int. rmudgett & mmichelson: cast the enum to (unsigned int) in assert. The cast does have an effect. For gcc, which seems to treat all enums as int, the cast to unsigned int will eliminate the possibility of negative values being allowed. For clang, which seems to treat enums without any negative members as unsigned int, the cast will have no effect. If for some reason in the future a negative value is ever added to the enum the assert will still catch the negative value. ASTERISK-24917 Change-Id: I0557ae0154a0b7de68883848a609309cdf0aee6a	11 years ago
Matt Jordan	7ccaf8aa46	Merge "Astobj2: Ensure all calls to __adjust_lock pass a valid object."	11 years ago
Matt Jordan	5ae61cf1eb	Merge "New AMI Command Output Format"	11 years ago
George Joseph	cc77440deb	res_corosync: Add check for config file before calling corosync apis ... On some systems, res_corosync isn't compatible with the installed version of corosync so corosync_cfg_initialize fails, load_module returns LOAD_FAILURE, and Asterisk terminates. The work around has been to remember to add res_corosync as a noload in modules.conf. A better solution though is to have res_corosync check for its config file before attempting to call corosync apis and return LOAD_DECLINE if there's no config file. This lets Asterisk loading continue. If you have a res_corosync.conf file and res_corosync fails, you get the same behavior as today and the fatal error tells you something is wrong with the install. ASTERISK-24998 Change-Id: Iaf94a9431a4922ec4ec994003f02135acfdd3889	11 years ago
Corey Farrell	c231c85ea4	Astobj2: Ensure all calls to __adjust_lock pass a valid object. ... __adjust_lock doesn't check for invalid objects, and doesn't have an appropriate return value for invalid objects. Most callers of __adjust_lock pass objects that have already been confirmed valid, this change adds checks before the remaining calls. ASTERISK-24997 #close Reported by: Corey Farrell Change-Id: I669100f87937cc3f867cec56a27ae9c01292908f	11 years ago
George Joseph	0722e11f26	.gitignore: Add .gcno and .gcda ... Products of --enable-coverage Change-Id: Ie20882d64b60692e2c941ea8872ab82a86ce77a3	11 years ago
Matt Jordan	d5f09fca98	Merge "dns: Make query sets hold on to queries for their lifetime."	11 years ago
Matt Jordan	86d5556b66	Merge "Fix/Update clang-RAII macro implementation"	11 years ago
Mark Michelson	10b36298b2	Merge "res_pjsip_mwi: Send unsolicited MWI NOTIFY on startup and when endpoint registers."	11 years ago
Joshua Colp	7216e3c608	dns: Make query sets hold on to queries for their lifetime. ... The query set documentation states that upon completion queries can be retrieved for the lifetime of the query set. This is a reasonable expectation but does not currently occur. This was originally done to resolve a circular reference between queries and query sets, but in practice the query can be kept. This change makes it so a query does not have a reference to the query set until it begins resolving. It also makes it so that the reference is given up upon the query being completed. This allows the queries to remain for the lifetime of the query set. As the query set on the query is only useful to the query set functionality and only for the lifetime that the query is resolving this is safe to do. ASTERISK-24994 #close Reported by: Joshua Colp Change-Id: I54e09c0cb45475896654e7835394524e816d1aa0	11 years ago
Matt Jordan	46950d6901	Merge "cdr/cdr_adaptive_odbc.c: Refactor concatenate columns name."	11 years ago
Diederik de Groot	09c7c678a3	Fix/Update clang-RAII macro implementation ... - When you need to refer to 'variable XXX' outside a block, it needs to be declared as '__block XXX', otherwise it will not be available with- in the block, making updating that variable hard to do, and ast_free lead to issues. - Removed the #error message because it creates complications when compiling external projects against asterisk For example when using a different compiler than the one used to compile asterisk. The warning/error should be generated during the configure process not the compilation process ASTERISK-24917 Change-Id: I12091228090e90831bf2b498293858f46ea7a8c2	11 years ago
Joshua Colp	84a30a4ad3	Merge "Check for ao2_alloc failure in __ast_channel_internal_alloc."	11 years ago
Joshua Colp	190fa4f333	res_pjsip_mwi: Send unsolicited MWI NOTIFY on startup and when endpoint registers. ... Currently the res_pjsip_mwi module only sends an unsolicited MWI NOTIFY upon a mailbox state change (such as a new message being left, or one being deleted). In practice this is not sufficient to keep clients aware of the current MWI status. This change makes the module send unsolicited MWI NOTIFY on startup so that clients are guaranteed to have the most up to date MWI information. It also makes clients receive an unsolicited MWI NOTIFY upon registration so if they are unaware of the current MWI status they receive it. ASTERISK-24982 #close Reported by: Joshua Colp Change-Id: I043f20230227e91218f18a82c7d5bb2aa62b1d58	11 years ago
Joshua Colp	bfdc766bf6	Merge "res_pjsip_pubsub: Set the endpoint on SUBSCRIBE dialogs."	11 years ago