6663 Commits (f107e4fd87b700a7db17b0179b40cf8d06b4ab5f)

Author	SHA1	Message	Date
Mike Bradeen	f107e4fd87	audiohook: add directional awareness ... Add enum to allow setting optional direction. If set to only one direction, only feed matching-direction frames to the associated slin factory. This prevents mangling the transcoder on non-mixed frames when the READ and WRITE frames would have otherwise required it. Also removes the need to mute or discard the un-wanted frames as they are no longer added in the first place. res_stasis_snoop is changed to use this addition to set direction on audiohook based on spy direction. If no direction is set, the ast_audiohook_init will init this enum to BOTH which maintains existing functionality. ASTERISK-30252 Change-Id: If8716bad334562a5d812be4eeb2a92e4f3be28eb	3 years ago
George Joseph	3196ba7fcb	res_geolocation: Fix segfault when there's an empty element ... Fixed a segfault caused by var_list_from_loc_info() encountering an empty location info element. Fixed an issue in ast_strsep() where a value with only whitespace wasn't being preserved. Fixed an issue in ast_variable_list_from_quoted_string() where an empty value was considered a failure. ASTERISK-30215 Reported by: Dan Cropp Change-Id: Ieca64e061a6d9298f0196c694b60d986ef82613a	3 years ago
George Joseph	1bb1d3b5ef	res_geolocation: Address user issues, remove complexity, plug leaks ... * Added processing for the 'confidence' element. * Added documentation to some APIs. * removed a lot of complex code related to the very-off-nominal case of needing to process multiple location info sources. * Create a new 'ast_geoloc_eprofile_to_pidf' API that just takes one eprofile instead of a datastore of multiples. * Plugged a huge leak in XML processing that arose from insufficient documentation by the libxml/libxslt authors. * Refactored stylesheets to be more efficient. * Renamed 'profile_action' to 'profile_precedence' to better reflect it's purpose. * Added the config option for 'allow_routing_use' which sets the value of the 'Geolocation-Routing' header. * Removed the GeolocProfileCreate and GeolocProfileDelete dialplan apps. * Changed the GEOLOC_PROFILE dialplan function as follows: * Removed the 'profile' argument. * Automatically create a profile if it doesn't exist. * Delete a profile if 'inheritable' is set to no. * Fixed various bugs and leaks * Updated Asterisk WiKi documentation. ASTERISK-30167 Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0	3 years ago
George Joseph	cc26b1d52b	Geolocation: Base Asterisk Prereqs ... * Added ast_variable_list_from_quoted_string() Parse a quoted string into an ast_variable list. * Added ast_str_substitute_variables_full2() Perform variable/function/expression substitution on an ast_str. * Added ast_strsep_quoted() Like ast_strsep except you can specify a specific quote character. Also added unit test. * Added ast_xml_find_child_element() Find a direct child element by name. * Added ast_xml_doc_dump_memory() Dump the specified document to a buffer * ast_datastore_free() now checks for a NULL datastore before attempting to destroy it. Change-Id: I5dcefed2f5f93a109e8b489e18d80d42e45244ec	3 years ago
George Joseph	4e604f03a7	xml.c, config,c: Add stylesheets and variable list string parsing ... Added functions to open, close, and apply XML Stylesheets to XML documents. Although the presence of libxslt was already being checked by configure, it was only happening if xmldoc was enabled. Now it's checked regardless. Added ability to parse a string consisting of comma separated name/value pairs into an ast_variable list. The reverse of ast_variable_list_join(). Change-Id: I1e1d149be22165a1fb8e88e2903a36bba1a6cf2e	3 years ago
George Joseph	157a9e64c1	core: Config and XML tweaks needed for geolocation ... Added: Replace a variable in a list: int ast_variable_list_replace_variable(struct ast_variable **head, struct ast_variable *old, struct ast_variable *new); Added test as well. Create a "name=value" string from a variable list: 'name1="val1",name2="val2"', etc. struct ast_str *ast_variable_list_join( const struct ast_variable *head, const char *item_separator, const char *name_value_separator, const char *quote_char, struct ast_str **str); Added test as well. Allow the name of an XML element to be changed. void ast_xml_set_name(struct ast_xml_node *node, const char *name); Change-Id: I330a5f63dc0c218e0d8dfc0745948d2812141ccb	3 years ago
Naveen Albert	bdcaf87bf2	documentation: Adds missing default attributes. ... The configObject tag contains a default attribute which allows the default value to be specified, if applicable. This allows for the default value to show up specially on the wiki in a way that is clear to users. There are a couple places in the tree where default values are included in the description as opposed to as attributes, which means these can't be parsed specially for the wiki. These are changed to use the attribute instead of being included in the text description. ASTERISK-29898 #close Change-Id: I9d7ea08f50075f41459ea7b76654906b674ec755	3 years ago
George Joseph	8d4a298cd4	GCC12: Fixes for 18+. state_id_by_topic comparing wrong value ... GCC 12 caught an issue in state_id_by_topic where we were checking a pointer for NULL instead of the contents of the pointer for '\0'. ASTERISK-30044 Change-Id: Ia0b04d4fff45c92acb7f07132a33622fa341148e	4 years ago
George Joseph	c0612ccc28	GCC12: Fixes for 16+ ... Most issues were in stringfields and had to do with comparing a pointer to an constant/interned string with NULL. Since the string was a constant, a pointer to it could never be NULL so the comparison was always "true". gcc now complains about that. There were also a few issues where determining if there was enough space for a memcpy or s(n)printf which were fixed by defining some of the involved variables as "volatile". There were also a few other miscellaneous fixes. ASTERISK-30044 Change-Id: Ia081ca1bcfb329df6487c4660aaf1944309eb570	4 years ago
Sean Bright	059eca1546	say.c: Prevent erroneous failures with 'say' family of functions. ... A regression was introduced in ASTERISK~29531 that caused 'say' functions to fail with file lists that would previously have succeeded. This caused affected channels to hang up where previously they would have continued. We now explicitly check for the empty string to restore the previous behavior. ASTERISK-29859 #close Change-Id: Ia2e5769868e2792313c2d7c07996efe009c6f8d5 (cherry picked from commit 3fd47840c9)	4 years ago
Sean Bright	5274bfdc07	say.c: Honor requests for DTMF interruption. ... SayAlpha, SayAlphaCase, SayDigits, SayMoney, SayNumber, SayOrdinal, and SayPhonetic all claim to allow DTMF interruption if the SAY_DTMF_INTERRUPT channel variable is set to a truthy value, but we are failing to break out of a given 'say' application if DTMF actually occurs. ASTERISK-29816 #close Change-Id: I6a96e0130560831d2cb45164919862b9bcb6287e (cherry picked from commit 4fe94bab09)	4 years ago
Joshua C. Colp	c1129fdd8c	bridge: Unlock channel during Local peer check. ... It's not safe to keep the channel locked while locking the peer Local channel, as it can result in a deadlock. This change unlocks it during this time but keeps the bridge locked to ensure nothing changes about the bridge. ASTERISK-29821 Change-Id: Ib68eb7037e5a479bcc2aceee77337cdde1fbdde6 (cherry picked from commit d83a46869e)	4 years ago
Alexander Traud	f946b92553	progdocs: Fix for Doxygen, the hidden parts. ... ASTERISK-29779 Change-Id: If338163488498f65fa7248b60e80299c0a928e4b	4 years ago
Alexander Traud	751bbf4b97	progdocs: Fix grouping for latest Doxygen. ... Since Doxygen 1.8.16, a special comment block is required. Otherwise (pure C comment), the group command is ignored. Additionally, several unbalanced group commands were fixed. ASTERISK-29732 Change-Id: I4687857b9d56e6f44fd440b73af156691660202e	4 years ago
Sean Bright	04ac4fe509	config.c: Prevent UB in ast_realtime_require_field. ... A backend's implementation of the realtime 'require' function may call va_arg() and then fail, leaving the va_list in an undefined state. Pass a copy of the va_list instead. ASTERISK-29771 #close Change-Id: I555565a72af84e96d49f62fe8cb66ba5a78461f4	4 years ago
Naveen Albert	70cdb0f9a8	app_voicemail: Refactor email generation functions ... Refactors generic functions used for email generation into utils.c so that they can be used by multiple modules, including app_voicemail and app_minivm, to avoid code duplication. ASTERISK-29715 #close Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee	4 years ago
Alexander Traud	31e385bebb	xmldoc: Fix for Doxygen. ... ASTERISK-29765 Change-Id: I654ba0debe8351038d4433716434a09370f04c9d	4 years ago
Mike Bradeen	ea941032ff	astobj2.c: Fix core when ref_log enabled ... In the AO2_ALLOC_OPT_LOCK_NOLOCK case the referenced obj structure is freed, but is then referenced later if ref_log is enabled. The change is to store the obj->priv_data.options value locally and reference it instead of the value from the freed obj ASTERISK-29730 Change-Id: I60cc5dc1f5a4330e7ad56976fc38a42de0ab6072	4 years ago
Joshua C. Colp	7d4e37a180	bridge: Deny full Local channel pair in bridge. ... Local channels are made up of two pairs - the 1 and 2 sides. When a frame goes in one side, it comes out the other. Back and forth. When both halves are in a bridge this creates an infinite loop of frames. This change makes it so that bridging no longer allows both of these sides to exist in the same bridge. ASTERISK-29748 Change-Id: I29928b6de87cd9be996a77daccefd7c360fef651	4 years ago
Boris P. Korzun	70b14f3eda	rtp_engine: Add type field for JSON RTCP Report stasis messages ... ASTERISK-29727 #close Change-Id: I2eca8aeb591cb63ac2238d08eab662367453cb82	4 years ago
Alexander Traud	b5962fe528	frame: Fix for Doxygen. ... ASTERISK-29755 Change-Id: I8240013ec3db0669c0acf67e26bf6c9cbb5b72af	4 years ago
Alexander Traud	e27b91d542	channel: Fix for Doxygen. ... ASTERISK-29751 Change-Id: Ie04da5029c57ebee44733bdf05013156abe80176	4 years ago
Alexander Traud	6988386234	stasis: Fix for Doxygen. ... ASTERISK-29750 Change-Id: Iea50173e785b2e9d49bc24c0af7111cfd96d44a9	4 years ago
Alexander Traud	e7d5db1471	app: Fix for Doxygen. ... ASTERISK-29752 Change-Id: If40cbd01d47a6cfd620b18206dedb8460216c8af	4 years ago
Alexander Traud	44a9c16e9c	progdocs: Avoid 'name' with Doxygen \file. ... Fixes four misuses of the parameter 'name'. Additionally, for consistency and to avoid such an issue in future, those few other places, which used '\file name', were changed just to '\file'. Then, Doxygen uses the name of the current file. ASTERISK-29733 Change-Id: I0c18b4c863c6988b138c77448057349a9ee7052d	4 years ago
Alexander Traud	d08792ceba	bridge_channel: Fix for Doxygen. ... ASTERISK-29736 Change-Id: Ia5370289e6526001a6b52754b533bcea1a9d7e5c	4 years ago
Alexander Traud	23b16c5372	progdocs: Use Doxygen \example correctly. ... ASTERISK-29734 Change-Id: I83b51e85cd71867645ab3a8a820f8fd1f065abd2	4 years ago
Naveen Albert	3c4b7cef64	app_read: Fix custom terminator functionality regression ... Currently, when the t option is specified with no arguments, the # character is still treated as a terminator, even though no character should be treated as a terminator. This is because a previous regression fix was modified to remove the use of NULL as a default altogether. However, NULL and an empty string actually refer to different arrangements and should be treated differently. NULL is the default terminator (#), while an empty string removes the terminator altogether. This is the behavior being used by the rest of the core. Additionally, since S_OR catches empty strings as well as NULL (not intended), this is changed to a ternary operator instead, which fixes the behavior. ASTERISK-29705 #close Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086	4 years ago
Josh Soref	4019a93edf	main: Spelling fixes ... Correct typos of the following word families: analysis nuisance converting although transaction desctitle acquire update evaluate thousand this dissolved management integrity reconstructed decrement further on irrelevant currently constancy anyway unconstrained featuregroups right larger evaluated encumbered languages digits authoritative framing blindxfer tolerate traverser exclamation perform permissions rearrangement performing processing declension happily duplicate compound hundred returns elicit allocate actually paths inheritance atxferdropcall earlier synchronization multiplier acknowledge across against thousands joyous manipulators guaranteed emulating soundfile ASTERISK-29714 Change-Id: I926ba4b11e9f6dd3fdd93170ab1f9b997910be70	4 years ago
Sean Bright	e63461b008	pbx.c: Don't remove dashes from hints on reload. ... When reloading dialplan, hints created dynamically would lose any dash characters. Now we ignore those dashes if we are dealing with a hint during a reload. ASTERISK-28040 #close Change-Id: I95e48f5a268efa3c6840ab69798525d3dce91636	4 years ago
Alexander Traud	8b76a3cd3b	stasis: Avoid 'dispatched' as unused variable in normal mode. ... ASTERISK-29710 Change-Id: Ia849f1172e4e694c5d5d7f0cad449f936ee12216	4 years ago
Sean Bright	2c03f73016	various: Fix GCC 11.2 compilation issues. ... * Initialize some variables that are never used anyway. * Use valid pointers instead of integers cast to void pointers when calling pthread_setspecific(). ASTERISK-29711 #close ASTERISK-29713 #close Change-Id: I8728cd6f2f4b28e0e48113c5da450b768c2a6683	4 years ago
Kevin Harwell	ae97aaedb0	strings/json: Add string delimter match, and object create with vars methods ... Add a function to check if there is an exact match a one string between delimiters in another string. Add a function that will create an ast_json object out of a list of Asterisk variables. An excludes string can also optionally be passed in. Also, add a macro to make it easier to get object integers. Change-Id: I5f34f18e102126aef3997f19a553a266d70d6226	4 years ago
Sebastien Duthil	e3466893e9	main/stun.c: fix crash upon STUN request timeout ... Some ast_stun_request users do not provide a destination address when sending to a connection-mode socket. ASTERISK-29691 Change-Id: Idd9114c3380216ba48abfc3c68619e79ad37defc	4 years ago
Shloime Rosenblum	29c44caecb	main/say.c: Support future dates with Q and q format params ... The current versions do not support future dates in all say application when using the 'Q' or 'q' format parameter and says "today" for everything that is greater than today ASTERISK-29637 Change-Id: I1fb1cef0ce3c18d87b1fc94ea309d13bc344af02	4 years ago
Sean Bright	e98839b73c	message.c: Support 'To' header override with AMI's MessageSend. ... The MessageSend AMI action has been updated to allow the Destination and the To addresses to be provided separately. This brings the MessageSend manager command in line with the capabilities of the MessageSend dialplan application. ASTERISK-29663 #close Change-Id: I8513168d3e189a9fed88aaab6f5547ccb50d332c	4 years ago
Naveen Albert	a65bb134f5	logger: Add custom logging capabilities ... Adds the ability for users to log to custom log levels by providing custom log level names in logger.conf. Also adds a logger show levels CLI command. ASTERISK-29529 Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702	4 years ago
Naveen Albert	b6b7b1490b	func_sayfiles: Retrieve say file names ... Up until now, all of the logic used to translate arguments to the Say applications has been directly coupled to playback, preventing other modules from using this logic. This refactors code in say.c and adds a SAYFILES function that can be used to retrieve the file names that would be played. These can then be used in other applications or for other purposes. Additionally, a SayMoney application and a SayOrdinal application are added. Both SayOrdinal and SayNumber are also expanded to support integers greater than one billion. ASTERISK-29531 Change-Id: If9718c89353b8e153d84add3cc4637b79585db19	4 years ago
Naveen Albert	a6eb1b6f95	res_tonedetect: Tone detection module ... dsp.c contains arbitrary tone detection functionality which is currently only used for fax tone recognition. This change makes this functionality publicly accessible so that other modules can take advantage of this. Additionally, a WaitForTone and TONE_DETECT app and function are included to allow users to do their own tone detection operations in the dialplan. ASTERISK-29546 Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26	4 years ago
Sean Bright	858cb386fd	term.c: Add support for extended number format terminfo files. ... ncurses 6.1 introduced an extended number format for terminfo files which the terminfo parsing in Asterisk is not able to parse. This results in some TERM values that do support color (screen-256color on Ubuntu 20.04 for example) to not get a color console. ASTERISK-29630 #close Change-Id: I27a4fcfab502219924af2d6b1c46feba92903cb3	4 years ago
Sean Bright	689c703b2c	dns.c: Load IPv6 DNS resolvers if configured. ... IPv6 nameserver addresses are stored in different part of the __res_state structure, so look there if we appear to have support for it. ASTERISK-28004 #close Change-Id: I67067077d8a406ee996664518d9c8fbf11f6977d	4 years ago
Sean Bright	5c836c8e36	config_options: Handle ACO arrays correctly in generated XML docs. ... There are 3 separate changes here but they are all closely related: * Only try to set matchfield attributes on 'field' nodes * We need to adjust how we treat the category pointer based on the value of the category_match, to avoid memory corruption. We now generate a regex-like string when match types other than ACO_WHITELIST and ACO_BLACKLIST are used. * Switch app_agent_pool from ACO_BLACKLIST_ARRAY to ACO_BLACKLIST_EXACT since we only have one category we need to ignore, not two. ASTERISK-29614 #close Change-Id: I7be7bdb1bb9814f942bc6bb4fdd0a55a7b7efe1e	4 years ago
Naveen Albert	dd980e00b4	app_read: Allow reading # as a digit ... Allows for the digit # to be read as a digit, just like any other DTMF digit, as opposed to forcing it to be used as an end of input indicator. The default behavior remains unchanged. ASTERISK-18454 #close Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b	4 years ago
Sebastien Duthil	ac492f2ff8	res_rtp_asterisk: Automatically refresh stunaddr from DNS ... This allows the STUN server to change its IP address without having to reload the res_rtp_asterisk module. The refresh of the name resolution occurs first when the module is loaded, then recurringly, slightly after the previous DNS answer TTL expires. ASTERISK-29508 #close Change-Id: I7955a046293f913ba121bbd82153b04439e3465f	4 years ago
Naveen Albert	e660a2c03b	bridge_basic: Change warning to verbose if transfer cancelled ... The attended transfer feature will emit a warning if the user cancels the transfer or the attended transfer doesn't complete for any reason. Changes the warning to a verbose message, since nothing is actually wrong here. ASTERISK-29612 #close Change-Id: I64c93cdb21360a0a8d45e9cb6db3af8168f66e6d	4 years ago
Andre Barbosa	eb486db3af	media_cache: Don't lock when curl the remote file ... When playing a remote sound file, which is not in cache, first we need to download it with ast_bucket_file_retrieve. This can take a while if the remote host is slow. The current CURL timeout is 180secs, so in extreme situations, it can take 3 minutes to return. Because ast_media_cache_retrieve has a lock on all function, while we are waiting for the delayed download, Asterisk is not able to play any more files, even the files already cached locally. ASTERISK-29544 #close Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408	4 years ago
Alexander Traud	0b1a629ecd	aelparse: Accept an included context with timings. ... With Asterisk 1.6.0, in the main parser for the configuration file extensions.conf, the separator was changed from vertical bar to comma. However, the first separator was not changed in aelparse; it still had to be a vertical bar, and no comma was allowed. Additionally, this change allows the vertical bar for the first and last parameter again, even in the main parser, because the vertical bar was still accepted for the other parameters. ASTERISK-29540 Change-Id: I882e17c73adf4bf2f20f9046390860d04a9f8d81	4 years ago
under	feb1e06ac5	codec_builtin.c: G729 audio gets corrupted by Asterisk due to smoother ... If Asterisk gets G.729 6-byte VAD frames inbound, then at outbound Asterisk sends this G.729 stream with non-continuous timestamps. This makes the audio stream not-playable at the receiver side. Linphone isn't able to play such an audio - lots of disruptions are heard. Also I had complains of bad audio from users which use other types of phones. After debugging, I found this is a regression connected with RTP Smoother (main/smoother.c). Smoother has a special code to handle G.729 VAD frames (search for AST_SMOOTHER_FLAG_G729 in smoother.c). However, this flag is never set in Asterisk-12 and newer. Previously it has been set (see Asterisk-11). ASTERISK-29526 #close Change-Id: I6f51ecb1a3ecd9c6d59ec5a6811a27446e17065d	4 years ago
Sebastien Duthil	4bd975f415	stun: Emit warning message when STUN request times out ... Without this message, it is not obvious that the reason is STUN timeout. ASTERISK-29507 #close Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74	4 years ago
Sean Bright	76c09b1cfd	res_http_media_cache.c: Parse media URLs to find extensions. ... Use the URI parsing functions to parse playback URLs in order to find their file extensions. For backwards compatibility, we first look at the full URL, then at any Content-Type header, and finally at just the path portion of the URL. ASTERISK-27871 #close Change-Id: I16d0682f6d794be96539261b3e48f237909139cb	4 years ago