8468 Commits (ef79e583ec2d78ac251ef65bc46cd76a3ba3eab1)

Author	SHA1	Message	Date
Jenkins2	24c72ea286	Merge "chan_unistim: NetBSD has an incompatible struct in_pktinfo."	8 years ago
Alexander Traud	aabbb49e33	chan_unistim: NetBSD has an incompatible struct in_pktinfo. ... ASTERISK-27714 Reported by: John Nemeth Change-Id: I1b84a89315a5f61222123d21bf35c59224da8990	8 years ago
Joshua Colp	259c80675e	chan_sip: Emit a second ringing event to ensure channel is found. ... When constructing a dialog-info+xml NOTIFY message a ringing channel is found if the state is ringing and further information is placed into the message. Due to the migration to the Stasis message bus this did not always work as expected. This change raises a second ringing event in such a way to guarantee that the event is received by chan_sip and another lookup is done to find the ringing channel. ASTERISK-24488 Change-Id: I547a458fc59721c918cb48be060cbfc3c88bcf9c	8 years ago
Richard Mudgett	8372138cce	chan_sip.c: Fix crash processing CANCEL. ... Check if initreq data string exists before using it when processing a CANCEL request. ASTERISK-27666 Change-Id: Id1d0f0fa4ec94e81b332b2973d93e5a14bb4cc97	8 years ago
Oron Peled	5b8fea93d1	chan_console: don't read and write at the same time ... It seems that the ALSA backend of PortAudio doesn't know how to both read and write at the same time by adding a per-device mutex. FIXME: currently only a draft version. Need to either auto-detect we work with the ALSA backend or add an extra configuration option to use this mutex. ASTERISK-27426 #close Change-Id: I635eacee45f5413faa18f5a3b606af03b926dacb	8 years ago
Corey Farrell	527cf5a570	Remove redundant module checks and references. ... This removes references that are no longer needed due to automatic references created by module dependencies. In addition this removes most calls to ast_module_check as they were checking modules which are listed as dependencies. Change-Id: I332a6e8383d4c72c8e89d988a184ab8320c4872e	8 years ago
Igor Goncharovsky	33d5ab3e69	chan_unistim: Fix hold function ability to lock/crash asterisk ... This patch fix chan_unistim hold functions to correctly support hold function in different states possible in case of multiple lines established on the phone ASTERISK-26596 #close Change-Id: Ib1e04e482e7c8939607a42d7fddacc07e26e14d4	8 years ago
Corey Farrell	9cfdb81e91	loader: Add dependency fields to module structures. ... * Declare 'requires' and 'enhances' text fields on module info structure. * Rename 'nonoptreq' to 'optional_modules'. * Update doxygen comments. Still need to investigate dependencies among modules I cannot compile. Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf	8 years ago
Joshua Colp	6d5f4768a4	chan_sip: Check that an iostream exists before accessing. ... Before getting the file descriptor for an iostream check that it is present. ASTERISK-27534 Change-Id: Ie0aa1394007a37c30e337ea1176a6fb3a63bc99c	8 years ago
Sean Bright	15f8b9b8bf	ice: Increase foundation buffer size ... Per RFC 5245, the foundation specified with an ICE candidate can be up to 32 characters but we are only allowing for 31. ASTERISK-27498 #close Reported by: Michele Prà Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf	8 years ago
Corey Farrell	c2529a352c	astobj.h: Remove from Asterisk core. ... This is the old ASTOBJ macro's which are no longer used except by the deprecated netsock.c. Move it to the chan_iax2 include folder so it does not get used elsewhere. Change-Id: I7e4ae96678b36b9f41d3cae14b167f110eb5d349	8 years ago
Sean Bright	fd0ca1c3f9	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Corey Farrell	1b80ffa495	Fix Common Typo's. ... Fix instances of: * Retreive * Recieve * other then * different then * Repeated words ("the the", "an an", "and and", etc). * othterwise, teh ASTERISK-24198 #close Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31	8 years ago
Jenkins2	968993a297	Merge "chan_sip: Fix memory leaks."	8 years ago
Jenkins2	262eda7801	Merge "Remove constant conditionals (dead-code)."	8 years ago
Corey Farrell	3c037ef972	chan_sip: Fix memory leaks. ... In change_redirecting_information variables we use ast_strlen_zero to see if a value should be saved. In the case where the value is not NULL but is a zero length string we leaked. handle_response_subscribe leaked a reference to the ccss monitor instance. Change-Id: Ib11444de69c3d5b2360a88ba2feb54d2c2e9f05f	8 years ago
Corey Farrell	b3e839debd	Remove constant conditionals (dead-code). ... Some variables are set and never changed, making them constant. This means that code in the 'false' block of the conditional is unreachable. In chan_skinny and res_config_ldap I used preprocessor directive `#if 0` as I'm unsure if the unreachable code could be enabled in the future. Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059	8 years ago
Oron Peled	c02e256407	chan_console: Use correct parameter for 'set active' ... chan_console supports multiple devices but the CLI only works on a single device. 'console set active' selects this device. Sadly that CLI picks the wrong command-line parameter and will only work for a device called 'active'. ASTERISK-27490 #close Change-Id: I2f0e5fe63db19845bee862575b739360797dc73d	8 years ago
Jenkins2	11a1e07ad2	Merge "netsock: Remove from Asterisk core."	8 years ago
Joshua Colp	5224fd3ab4	Merge changes from topic 'faster-aco' ... * changes: aco: Minimize use of regex. aco: Create ways to minimize use of regex.	8 years ago
Corey Farrell	064c74e4af	netsock: Remove from Asterisk core. ... This moves netsock.c / netsock.h to the chan_iax2 module. netsock.h has been marked deprecated since 13.0.0, chan_iax2 is the only remaining user. Change-Id: I28c6578043bac18de5ea608e136acec4f83d5dd3	8 years ago
Jenkins2	e79f0c0709	Merge "chan_pjsip.c: Improve ast_request() diagnostic msgs."	8 years ago
Richard Mudgett	4a461bcde4	chan_pjsip.c: Improve ast_request() diagnostic msgs. ... Attempting to dial PJSIP/endpoint when the endpoint doesn't exist and disable_multi_domain=no results in a misleading empty endpoint name message. The message should say the endpoint was not found. * Added missing endpoint not found message. * Added more information to the empty endpoint name msgs if available. * Eliminated RAII_VAR in request(). Change-Id: I21da85ebd62dcc32115b2ffcb5157416ebae51e4	8 years ago
Corey Farrell	6f8b34f9c1	chan_sip: Add security event for calls to invalid extension. ... Log a message to security events when an INVITE is received to an invalid extension. ASTERISK-25869 #close Change-Id: I0da40cd7c2206c825c2f0d4e172275df331fcc8f	8 years ago
Corey Farrell	bf2d35931d	aco: Minimize use of regex. ... Remove nearly all use of regex from ACO users. Still remaining: * app_confbridge has a legitamate use of option name regex. * ast_sorcery_object_fields_register is implemented with regex, all callers use simple prefix based regex. I haven't decided the best way to fix this in both 13/15 and master. Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b	8 years ago
Joshua Colp	e411b7d112	Merge "chan_sip: 3PCC patch for AMI "SIPnotify""	8 years ago
Joshua Colp	c50905756b	Merge "chan_pjsip/res_pjsip: Add CHANNEL(pjsip,request_uri)"	8 years ago
Jenkins2	58514c7442	Merge "chan_sip: Don't crash in Dial on invalid destination"	8 years ago
Yasuhiko Kamata	cb249b2419	chan_sip: 3PCC patch for AMI "SIPnotify" ... A patch for sending in-dialog SIP NOTIFY message with "SIPnotify" AMI action. ASTERISK-27461 Change-Id: I5797ded4752acd966db6b13971284db684cc5ab4	8 years ago
Sean Bright	0c9cc7e975	chan_sip: Don't send trailing \0 on keep alive packets ... This is a partial fix for ASTERISK~25817 but does not address the comments regarding RFC 5626. Change-Id: I227e2d10c0035bbfa1c6e46ae2318fd1122d8420	8 years ago
Sean Bright	5039b5741c	chan_sip: Don't crash in Dial on invalid destination ... Stripping the DNID in a SIP dial string can result in attempting to call the argument parsing macros on an empty string, causing a crash. ASTERISK-26131 #close Reported by: Dwayne Hubbard Patches: dw-asterisk-master-dnid-crash.patch (license #6257) patch uploaded by Dwayne Hubbard Change-Id: Ib84c1f740a9ec0539d582b09d847fc85ddca1c5e	8 years ago
Richard Mudgett	22810fc635	chan_pjsip/res_pjsip: Add CHANNEL(pjsip,request_uri) ... This patch does three things associated with the initial incoming INVITE request URI. 1) Add access to the full initial incoming INVITE request URI. 2) We were not setting DNID on incoming PJSIP channels. The DNID is the user portion of the initial incoming INVITE Request-URI. The value is accessed by reading CALLERID(dnid). 3) Fix CHANNEL(pjsip,target_uri) documentation. * The initial incoming INVITE request URI is now available using CHANNEL(pjsip,request_uri). * Set the DNID on PJSIP channel creation so CALLERID(dnid) can return the initial incoming INVITE request URI user portion. * CHANNEL(pjsip,target_uri) now correctly documents that the target URI is the contact URI. * Refactored print_escaped_uri() out of channel_read_pjsip() to handle pjsip_uri_print() error condition when the buffer is too small. ASTERISK-27478 Change-Id: I512e60d1f162395c946451becb37af3333337b33	8 years ago
Sean Bright	2ffe52a116	utils: Add convenience function for setting fd flags ... There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7	8 years ago
Richard Mudgett	8536a09b86	security-events: Fix SuccessfulAuth using_password declaration. ... The SuccessfulAuth using_password field was declared as a pointer to a uint32_t when the field was later read as a uint32_t value. This resulted in unnecessary casts and a non-portable field value reinterpret in main/security_events.c:add_json_object(). i.e., It would work on a 32 bit architecture but not on a 64 bit big endian architecture. Change-Id: Ia08bc797613a62f07e5473425f9ccd8d77c80935	8 years ago
George Joseph	075faac2fd	AST-2017-013: chan_skinny: Call pthread_detach when sess threads end ... chan_skinny creates a new thread for each new session. In trying to be a good cleanup citizen, the threads are joinable and the unload_module function does a pthread_cancel() and a pthread_join() on any sessions that are active at that time. This has an unintended side effect though. Since you can call pthread_join on a thread that's already terminated, pthreads keeps the thread's storage around until you explicitly call pthread_join (or pthread_detach()). Since only the module_unload function was calling pthread_join, and even then only on the ones active at the tme, the storage for every thread/session ever created sticks around until asterisk exits. * A thread can detach itself so the session_destroy() function now calls pthread_detach() just before it frees the session memory allocation. The module_unload function still takes care of the ones that are still active should the module be unloaded. ASTERISK-27452 Reported by: Juan Sacco Change-Id: I9af7268eba14bf76960566f891320f97b974e6dd (cherry picked from commit 8f5dff543e)	8 years ago
Alexander Traud	491e2eba0d	chan_sip: ICE contained square brackets around IPv6 addresses. ... ASTERISK-27434 Change-Id: Iaeed89b4fa05d94c5f0ec2d3b7cd6e93d2d5a8f7	8 years ago
Richard Mudgett	e793501084	chan_pjsip.c: Improve answer failure log messages. ... * Balanced the session->inv_session refs on answer failure. Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8	8 years ago
Richard Mudgett	90bb0a3e10	core: Add cache_media_frames debugging option. ... The media frame cache gets in the way of finding use after free errors of media frames. Tools like valgrind and MALLOC_DEBUG don't know when a frame is released because it gets put into the cache instead of being freed. * Added the "cache_media_frames" option to asterisk.conf. Disabling the option helps track down media frame mismanagement when using valgrind or MALLOC_DEBUG. The cache gets in the way of determining if the frame is used after free and who freed it. NOTE: This option has no effect when Asterisk is compiled with the LOW_MEMORY compile time option enabled because the cache code does not exist. To disable the media frame cache simply disable the cache_media_frames option in asterisk.conf and restart Asterisk. Sample asterisk.conf setting: [options] cache_media_frames=no ASTERISK-27413 Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00	8 years ago
Richard Mudgett	12010fc5c0	chan_pjsip.c: Fix uninitialized cause value on failure. ... Change-Id: I3f9dd3c31bd582e54a30381500077de2319d8cc3	8 years ago
Joshua Colp	637b37fb98	Merge "dtls: Add support for ephemeral DTLS certificates."	8 years ago
Sean Bright	04d3785a79	dtls: Add support for ephemeral DTLS certificates. ... This mimics the behavior of Chrome and Firefox and creates an ephemeral X.509 certificate for each DTLS session. Currently, the only supported key type is ECDSA because of its faster generation time, but other key types can be added in the future as necessary. ASTERISK-27395 Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4	8 years ago
Corey Farrell	606ae3484a	Add missing menuselect dependencies. ... This adds menuselect dependencies for modules that use symbols of other modules. ASTERISK-27390 Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385	8 years ago
Corey Farrell	6474de5f72	chan_sip: Fix SUBSCRIBE with missing "Expires" header. ... When chan_sip receives a SUBSCRIBE request with no "Expires" header it processes the request as an unsubscribe. This is incorrect, per RFC3264 when the "Expires" header is missing a default expiry should be used. ASTERISK-18140 Change-Id: Ibf6dcd4fdd07a32c2bc38be1dd557981f08188b5	8 years ago
Alexander Traud	840e08716b	chan_sip: Crypto attribute not last but first on SDP media level. ... This matches the behavior of the other SIP channel driver, chan_pjsip. ASTERISK-27365 Change-Id: I8f23a51290a58b75816da2999ed1965441dfc5d6	8 years ago
Corey Farrell	c9e19b31f5	chan_sip: Fix output of 'sip set debug off'. ... When sip.conf contains 'sipdebug=yes' it is impossible to disable it using CLI 'sip set debug off'. This corrects the output of that CLI command to instruct the user to turn sipdebug off in the configuration file. ASTERISK-23462 #close Change-Id: I1cceade9caa9578e1b060feb832e3495ef5ad318	8 years ago
Guido Falsi	c4f40b778a	chan_dahdi: wrap include file which is not present on BSD systems in #ifdef ... The sys/sysmacros.h include file does not exist in BSD systems and is not required to build this module there. Since an "#if defined(__NetBSD__) || defined(__FreeBSD__)" section already exist I moved that include line inside it's #else branch. ASTERISK-27343 #close Change-Id: Ibfb64f4e9a0ce8b6eda7a7695cfe57916f175dc1	8 years ago
George Joseph	ab4d36533c	chan_vpb: Fix a gcc 7 out-of-bounds complaint ... chan_vpb was trying to use sizeof(*p->play_dtmf), where p->play_dtmf is defined as char[16], to get the length of the array but since p->play_dtmf is an actual array, sizeof(*p->play_dtmf) returns the size of the first array element, which is 1. gcc7 validly complains because the context in which it's used could cause an out-of-bounds condition. Change-Id: If9c4bfdb6b02fa72d39e0c09bf88900663c000ba	8 years ago
Daniel Tryba	59b6e8467a	res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy ... Currently privacy requests are only granted if the Privacy header value is exactly "id" (defined in RFC 3325). It ignores any other possible value (or a combination there of). This patch reverses the logic from testing for "id" to grant privacy, to testing for "none" and granting privacy for any other value. "none" must not be used in combination with any other value (RFC 3323 section 4.2). ASTERISK-27284 #close Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56	8 years ago
George Joseph	4275ca16a1	build: A few gcc 7 error fixes ... Change-Id: I7b5300fbf1af7d88d47129db13ad6dbdc9b553ec	8 years ago
Joshua Colp	f2985e3106	bridge: Change participant SFU streams when source streams change. ... Some endpoints do not like a stream being reused for a new media stream. The frame/jitterbuffer can rely on underlying attributes of the media stream in order to order the packets. When a new stream takes its place without any notice the buffer can get confused and the media ends up getting dropped. This change uses the SSRC change to determine that a new source is reusing an existing stream and then bridge_softmix renegotiates each participant such that they see a new media stream. This causes the frame/jitterbuffer to start fresh and work as expected. ASTERISK-27277 Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07	8 years ago