31460 Commits (ef19d69c6b11e77b9fcf70b9be661364bf63516c)

 

All Branches   

Search

Author	SHA1	Message	Date
George Joseph	0e747da168	Merge "chan_unistim: Fix RTP port byte order for big-endian arch" into 13	6 years ago
Igor Goncharovsky	7f1a574ce7	chan_unistim: Fix code, causing all incoming DTMF sent back to asterisk ... Current implementation of ast_channel_tech send_digit_begin hook uses same function for tone playback as key press handler. This cause every incoming dtmf send back to asterisk. In case of two unistim phones connected to each other, it'll cause indefinite DTMF loop. Fix add separate function for dtmf tone phone play. Change-Id: I5795db468df552f0c89c7576b6b3858b26c4eab4	6 years ago
Igor Goncharovsky	b003c9b3ae	chan_unistim: Fix RTP port byte order for big-endian arch ... This patch fixes one-way oudio that users expirienced on big-endian architechtires. RTP port number bytes was stored in improper order and phone sent RTP to wrong RTP port. Reported-by: Andrey Ionov Change-Id: I9a9ca7f26e31a67bbbceff12923baa10dfb8a3be	6 years ago
Sean Bright	5154e7f359	codec_resample: Upgrade speex_resample to fix up-sampling bug ... ASTERISK-28511 #close Change-Id: Idd07bf341e89ac999c7f5701d9b72b8a9cb11e82	6 years ago
Joshua Colp	4d4a430128	Merge "Fix misname 'res_external_mwi' to 'res_mwi_external' in comments." into 13	6 years ago
Joshua Colp	f0bc74a291	Merge "pjproject: Configurable setting for cnonce to include hyphens or not" into 13	6 years ago
Alexei Gradinari	e6a4cca4aa	Fix misname 'res_external_mwi' to 'res_mwi_external' in comments. ... Change-Id: Ic784be8500e5cb75dcb34bae9f03cfd93b6b34fb	6 years ago
George Joseph	b02f53463c	Merge "res_pjsip: Channel variable SIPFROMDOMAIN" into 13	6 years ago
Dan Cropp	1a86b2499a	pjproject: Configurable setting for cnonce to include hyphens or not ... NEC SIP Station interface with authenticated registration only supports cnonce up to 32 characters. In Linux, PJSIP would generate 36 character cnonce which included hyphens. Teluu developed this patch adding a compile time setting to default to not include the hyphens. They felt it best to still generate the UUID and strip the hyphens. They have indicated it will be part of PJSIP 2.10. ASTERISK-28509 Reported-by: Dan Cropp Change-Id: Ibdfcf845d4f8c0a14df09fd983b11f2d72c5f470	6 years ago
Friendly Automation	8bc51928c1	Merge "res_ari.c: Prefer exact handler match over wildcard" into 13	6 years ago
Stas Kobzar	06e5c11589	res_pjsip: Channel variable SIPFROMDOMAIN ... In chan_sip, there was variable SIPFROMDOMAIN that allows to set From header URI domain per channel. This patch introduces res_pjsip variable SIPFROMDOMAIN for backward compatibility with chan_sip. ASTERISK-28489 Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e	6 years ago
George Joseph	22372d5d2b	res_ari.c: Prefer exact handler match over wildcard ... Given the following request path and 2 handler paths... Request: /channels/externalMedia Handler: /channels/{channelId} "wildcard" Handler: /channels/externalmedia "non-wildcard" ...if /channels/externalMedia was registered as a handler after /channels/{channelId} as shown above, the request would automatically match the wildcard handler and attempt to parse "externalMedia" into the channelId variable which isn't what was intended. It'd work if the non-wildard entry was defined in rest-api/api-docs/channels.json before the wildcard entry but that makes the json files order-dependent which isn't a good thing. To combat this issue, the search loop saves any wildcard match but continues looking for exact matches at the same level. If it finds one, it's used. If it hasn't found an exact match at the end of the current level, the wildcard is used. Regardless, after searching the current level, the wildcard is cleared so it won't accidentally match for a different object or a higher level. BTW, it's currently not possible for more than 1 wildcard entry to be defined for a level. For instance, there couldn't be: Handler: /channels/{channelId} Handler: /channels/{channelName} We wouldn't know which one to match. Change-Id: I574aa3cbe4249c92c30f74b9b40e750e9002f925	6 years ago
Sean Bright	ddc64ca059	audiohook.c: Substitute silence for unavailable audio frames ... There are 4 scenarios to consider when capturing audio from a channel with an audiohook: 1. There is no rx and no tx audio, so return nothing. 2. There is rx but no tx audio, so return rx. 3. There is tx but no rx audio, so return tx. 4. There is rx and tx audio, so mix them and return. The file passed as the primary argument to MixMonitor will be written to in scenarios 2, 3, and 4. However, if you pass the r() and t() options to MixMonitor, a frame will only be written to the r() file if there was rx audio and a frame will only be written to the t() file if there was tx audio. If you subsequently take the r() and t() files and try to mix them, the sides of the conversation will 'drift' and be non-representative of the user experience. This patch adds a new 'S' option to MixMonitor that injects a frame of silence on either the r() side or the t() side of the channel so that when later mixed, there is no such drift. Change-Id: Ibf5ed73a811087727bd561a89a59f4447b4ee20e	6 years ago
Alexei Gradinari	16bc4ed93c	app_voicemail/IMAP: check mailstream not NULL in leave_voicemail ... The function leave_voicemail checks if expungeonhangup is set, but does not check if IMAP stream is closed, so it could call imap function with NULL stream. This leads to segfault. ASTERISK-28505 #close Change-Id: Ib66c57c1f1ba97774e447b36349198e2626a8d7c	6 years ago
Sean Bright	8a96746994	menuselect: Fix curses build on Gentoo Linux ... Because keypad() is exported by libtinfo, it needs to be explicitly added to the linker options. ASTERISK-28487 #close Change-Id: I6c2ad5b95f422c263d078b5c0e84c111807dffc6	6 years ago
George Joseph	7251b76c62	Merge "srtp: Fix possible race condition, and add NULL checks" into 13	6 years ago
Friendly Automation	5598dc045b	Merge "cdr / cel: Use event time at event creation instead of processing." into 13	6 years ago
George Joseph	c6558e09af	CI: Escape backslashes in printenv/sort/tr ... Change-Id: I52be64c8f6af2bbe15148a856d1f10cb113e1e94	6 years ago
Kevin Harwell	feaadbd250	srtp: Fix possible race condition, and add NULL checks ... Somehow it's possible for the srtp session object to be NULL even though the Asterisk srtp object itself is valid. When this happened it would cause a crash down in the srtp code when attempting to protect or unprotect data. After looking at the code there is at least one spot that makes this situation possible. If Asterisk fails to unprotect the data, and after several retries it still can't then the srtp->session gets freed, and set to NULL while still leaving the Asterisk srtp object around. However, according to the original issue reporter this does not appear to be their situation since they found no errors logged stating the above happened (which Asterisk does for that situation). An issue was found however, where a possible race condition could occur between the pjsip incoming negotiation, and the receiving of RTP packets. Both places could attempt to create/setup srtp for the same rtp instance at the same time. This potentially could be the cause of the problem as well. Given the above this patch adds locking around srtp setup for a given rtp, or rtcp instance. NULL checks for the session have also been added within the protect and unprotect functions as a precaution. These checks should at least stop Asterisk from crashing if it gets in this situation again. This patch also fixes one other issue noticed during investigation. When doing a replace the old object was freed before creating the replacement. If the new replacement object failed to create then the rtp/rtcp instance would now point to freed srtp data which could potentially cause a crash as well when the next attempt to reference it was made. This is now fixed so the old srtp object is kept upon replacement failure. Lastly, more logging has been added to help diagnose future issues. ASTERISK-28472 Change-Id: I240e11cbb1e9ea8083d59d50db069891228fe5cc	6 years ago
George Joseph	17908cb76e	CI: Add "throttle" label and "skip_gate" capability ... To make throttling by label fully active, the "throttle" option has to be specified with a specific label. You can now specify "skip_gate" in the Gerrit comments when you do a +2 code review to tell Jenkins not to actually run the gate. You'd do this if you plan to manually merge the change. Also updated the "printenv" debug output to better sort multi-line comments. Change-Id: I4c0b1085acec4805f2ca207eebac50aad81f27e2	6 years ago
Friendly Automation	6d174e4ef2	Merge "CI: Make node labels job-specific" into 13	6 years ago
Joshua Colp	1496aef51b	cdr / cel: Use event time at event creation instead of processing. ... When updating times on CDR or CEL records using the time at which it is done can result in times being incorrect if the system is heavily loaded and stasis message processing is delayed. This change instead makes it so CDR and CEL use the time at which the stasis messages that drive the systems are created. This allows them to be backed up while still producing correct records. ASTERISK-28498 Change-Id: I6829227e67aefa318efe5e183a94d4a1b4e8500a	6 years ago
George Joseph	a57b59c959	Merge "various modules: json integer overflow" into 13	6 years ago
George Joseph	018c278c72	Merge "res_musiconhold: Use a vector instead of custom array allocation" into 13	6 years ago
George Joseph	1a051fcf5a	CI: Make node labels job-specific ... Originally, the eligible nodes for a job were labelled only by "swdev-docker". So basically any node could run any job. We had found that allowing a node to run more than 1 gate at a time was problematic so we limited the nodes to processing 1 job at a time. With the creation of the Asterisk 17 branches however, we now have so many active branches that getting checks and gates through in a timely manner is problematic when a node can run only 1 job at a time. Now the nodes are also labelled by the job type they can run. For instance: "asterisk-check", "asterisk-gate", etc. With the "Throttle Concurrent Builds" plugin, we can now allow a node to run more than 1 job BUT throttle by job type. For instance: Allow 2 jobs but only 1 asterisk-gate at a time. Now a node can run 2 checks or 1 check and 1 gate or 1 gate but not 2 gates at a time. Change-Id: I2032bf6afbcec5c341d9b852214c0c812d3d6db5	6 years ago
Torrey Searle	6f77e12f21	main/udptl.c: correctly handle udptl sequence wrap around ... incorrect handling of UDPTL squence number wrap arounds causes loss of packets every time the wrap around occurs ASTERISK-28483 #close Change-Id: I33caeb2bf13c574a1ebb81714b58907091d64234	6 years ago
Kevin Harwell	f145b58542	various modules: json integer overflow ... There were still a few places in the code that could overflow when "packing" a json object with a value outside the base type integer's range. For instance: unsigned int value = INT_MAX + 1 ast_json_pack("{s: i}", value); would result in a negative number being "packed". In those situations this patch alters those values to a ast_json_int_t, which widens the value up to a long or long long. ASTERISK-28480 Change-Id: Ied530780d83e6f1772adba0e28d8938ef30c49a1	6 years ago
Sean Bright	bb74c691ce	res_musiconhold: Use a vector instead of custom array allocation ... Change-Id: Ic476a56608b1820ca93dcf68d10cd76fc0b94141	6 years ago
Joshua Colp	c6a34ddbf4	res_pjsip: Fix multiple of the same contact in "pjsip show contacts". ... The code for gathering contacts could result in the same contact being retrieved and added to the list multiple times. The container which stores the contacts to display will now only allow a contact to be added to it once instead of multiple times. ASTERISK-28228 Change-Id: I805185cfcec03340f57d2b9e6cc43c49401812df	6 years ago
George Joseph	46beb0fa1a	Merge "manager: Send fewer packets" into 13	6 years ago
Sean Bright	5096a5ddf7	manager: Send fewer packets ... The functions that build manager message headers do so in a way that results in a single messages being split across multiple packets. While this doesn't matter to the remote end, it makes network captures noisier and harder to follow, and also means additional system calls. With this patch, we build up more of the message content into the TLS buffer before flushing to the network. This change is completely internal to the manager code and does not affect any of the existing API's consumers. Change-Id: I50128b0769060ca5272dbbb5e60242d131eaddf9	6 years ago
Sean Bright	2982138d2b	res_musiconhold: Use ast_pipe_nonblock() wrapper ... Change-Id: Ib0a4b41e5ececbe633079e2d8c2b66c031d2d1f2	6 years ago
George Joseph	5f020b1825	Merge "CI: Don't enable non-core modules in Certified branches" into 13	6 years ago
George Joseph	16fe80d8da	Merge "res_config_sqlite3: Only join threads that we started" into 13	6 years ago
George Joseph	e51e2cae58	CI: Don't enable non-core modules in Certified branches ... We don't support non-core modules for Certified releases but we were enabling them for CI builds which was causing lots of test failures. Now we don't. Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766	6 years ago
Leonid Fainshtein	8e09fbb4e9	openr2(6/6): Set hangup cause ... Change-Id: I94dc38920e6e77cc73062648f62fdd613d0d1452 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	fdaefbb20a	openr2(5/6): added cli command -- mfcr2 destroy link <index> ... Change-Id: I452d6a853bcd8c6e194455b19e5e017713e9c0fe Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	effca9917d	openr2(4/6): added new cli command -- mfcr2 show links ... * This command show the MFC/R2 links Change-Id: I213822e1b7ef9c05bd89a2ba62df8e0856ce9f84 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	b3de2c0e1e	openr2(3/6): Convert r2links to standard Asterisk AST_LIST* ... Change-Id: Ibcb2401515a58782a1488c0b9efbed201c3f3a17 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	4b779a59e4	openr2(2/6): Stop polling channels when DAHDI returns -ENODEV (e.g: plug-out) ... Otherwise, OpenR2 threads go crazy and consume almost all CPU resources Change-Id: I10a41f617613fe7399c5bdced5c64a2751173f28 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Sean Bright	202fdc88dd	res_config_sqlite3: Only join threads that we started ... ASTERISK-28477 #close Reported by: Dennis ASTERISK-28478 #close Reported by: Dennis Change-Id: I77347ad46a86dc5b35ed68270cee56acefb4f475	6 years ago
George Joseph	0cded803ec	Merge "openr2(1/6): bugfix in configuration saving" into 13	6 years ago
George Joseph	b63425f469	CI: Add cleanWs to cleanup steps in jenkinsfiles ... We're at the point where there are enough Jenkins jobs for Asterisk branches than even cleaned checkouts of Asterisk will add up to more disk space than is available on the in-memory workspace mount. Since we archive all relevent artifacts anyway, there's no need to keep the workspace around after the job finishes, whether it succeeds or fails. Change-Id: I1cd3b73ebb045a987df0f62526d152a510210c39	6 years ago
George Joseph	51b1111eaf	Merge "CI: Add install-headers to the install make targets" into 13	6 years ago
Friendly Automation	7b33cef82a	Merge "README.md: Update year" into 13	6 years ago
George Joseph	8d1acc27d5	Merge "sched: Don't allow ast_sched_del to deadlock ast_sched_runq from same thread" into 13	6 years ago
Rodrigo Ramírez Norambuena	5c87fa6a0e	README.md: Update year ... Change-Id: I746fb94d112c7d797e206bca0fd1e13fcd26bae3	6 years ago
George Joseph	51504432a7	CI: Add install-headers to the install make targets ... The testsuite actually needs the headers installed to run it's self_test. Change-Id: Ice41d331131b876ad4a9c056085fe6aac34b32b2	6 years ago
George Joseph	284b657539	Merge "Build: Add separate header install/uninstall targets" into 13	6 years ago
Friendly Automation	976f884a24	Merge "manager: Log AMI actions" into 13	6 years ago