5668 Commits (e94962ce63c4987f9bf36c6380473d2944b10251)

Author	SHA1	Message	Date
Jenkins2	0097ad91ef	Merge "bridge: Old channel video source not set to NULL after unref." into 13	8 years ago
Corey Farrell	be3800c49d	bridge: Old channel video source not set to NULL after unref. ... The bridge holds onto the old channel video source after it's been released. This can lead to use after free errors. ASTERISK-27229 #close Change-Id: Ib2dab61677dd8a21f7ad53cdc9b8ca93297838b3	8 years ago
Corey Farrell	d05ec48145	core: Fix unused variable error in handle_show_sysinfo. ... Apparently in OSX it's possible for OSX to HAVE_SYSCTL but not HAVE_SYSINFO or HAVE_SWAPCTL. In this case freeswap caused an unused variable error. ASTERISK-26563 #close Change-Id: I8ec5b1897b786cc1abaf62264aa75039eea05510	8 years ago
Joshua Colp	616659d620	Merge "CLI: Address multiple issues." into 13	8 years ago
Jenkins2	b100233801	Merge "bridge: Stop music on hold on adding an arbitrary channel to a bridge" into 13	8 years ago
Joshua Colp	f1d50c0fb0	Merge "core: Fix multiple trivial issues in the core." into 13	8 years ago
Jenkins2	b539ea2a38	Merge "Remove constant conditionals (dead-code)." into 13	8 years ago
Corey Farrell	9adffca9c7	CLI: Address multiple issues. ... * listen uses the variable `s` for the result from ast_poll() then overwrites it with the result of accept(). Create a separate variable poll_result to avoid confusion since ast_poll does not return a file descriptor. * Resolve fd leak that would occur if setsockopt failed in listen. * Reserve an extra byte while processing completion results from remote daemon. This fixes a bug where completion processing used strstr() on a string that was not '\0' terminated. This was no risk to the Asterisk daemon, the bug was only reachable the remote console process. * Resolve leak in handle_showchan when the channel is not found. * Multiple leaks and a deadlock in pbx_config CLI completion. * Fix leaks in "manager show command". Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9	8 years ago
Jenkins2	dba037d422	Merge "main/app: Fix leaks." into 13	8 years ago
Ivan Poddubny	fef23297b7	bridge: Stop music on hold on adding an arbitrary channel to a bridge ... When a channel that is on hold gets added to a bridge by the Bridge AMI action or the dialplan application of the same name, music continues to play, causing "robotic sound". This commit adds a call to ast_moh_stop to stop the music. Also, it makes the AMI Park action use the right MOH class when the channel gets parked. Reported by: Zane Conkle ASTERISK-25079 #close Change-Id: I4b129c5a20c15e63968842460ac5a1a85903cf9f	8 years ago
Jenkins2	bde7c0420a	Merge "rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage." into 13	8 years ago
Corey Farrell	d6b2f457d9	Remove constant conditionals (dead-code). ... Some variables are set and never changed, making them constant. This means that code in the 'false' block of the conditional is unreachable. In chan_skinny and res_config_ldap I used preprocessor directive `#if 0` as I'm unsure if the unreachable code could be enabled in the future. Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059	8 years ago
Corey Farrell	381ed4f1cc	core: Fix multiple trivial issues in the core. ... * Fix small leaks in from error condition in translate.c. * Check new file descriptor is less than 0, not less than or equal. Change-Id: Id7782775486175c739e0c4bf3ea5e17e3f452a99	8 years ago
Corey Farrell	67b5a4e616	main/app: Fix leaks. ... * ast_linear_stream would leak a file descriptor if it failed to allocate lin. * ast_control_tone leaked zone and ts if ast_playtones_start failed. Additionally added whitespace to ast_linear_stream, pulled assignments out of conditionals for improved readability. Change-Id: I6d1a10cf9161b1529d939b9b2d63ea36d395b657	8 years ago
Richard Mudgett	5801917a75	ast_json_pack(): Use safer json ref mechanism. ... Change-Id: I49204db2e57ae96eee43909c18ed007c09ac817e	8 years ago
Richard Mudgett	46ed7afdd9	rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage. ... Change-Id: I58a22c2ca82e91d7537409b7b3af2d735827a54d	8 years ago
Joshua Colp	b14d165927	Merge "CLI: Fix 'core set debug channel' completion bug." into 13	8 years ago
Jenkins2	cbb71df228	Merge "CLI: Remove special handling of 'core set verbose' from rasterisk." into 13	8 years ago
Jenkins2	56a931f64c	Merge "aco: Minimize use of regex." into 13	8 years ago
Jenkins2	b6d03c086b	Merge "aco: Create ways to minimize use of regex." into 13	8 years ago
Corey Farrell	5cdc65cf1e	CLI: Fix 'core set debug channel' completion bug. ... The completion generator is missing a return so typing "core set debug all off <tab>" causes the command to actually execute. Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b	8 years ago
George Joseph	43903f1e83	Merge "loader: Use vector to build apha sorted module lists." into 13	8 years ago
George Joseph	d6ea23d60e	Merge "loader: Replace priority heap with vector." into 13	8 years ago
Jenkins2	d1a68d90b0	Merge "cdr: Minor optimizations." into 13	8 years ago
George Joseph	1b50eb2d9f	Merge "loader: Rework of load_dynamic_module." into 13	8 years ago
Jenkins2	b270d5b5a2	Merge "loader: Minor fix to module registration." into 13	8 years ago
Corey Farrell	b3b7367e6b	cdr: Minor optimizations. ... * bridge_candidate_process: remove SCOPED_AO2LOCK and return value. * handle_standard_bridge_enter_message: replace recursive call with goto statement. ASTERISK-24297 Change-Id: Id2eaa0822fb8dc799f63422bb3aa89de9d4ee2a2	8 years ago
Corey Farrell	8921b2581d	loader: Use vector to build apha sorted module lists. ... Change-Id: I9c519f4dec3cda98b2f34d314255a31d49a6a467	8 years ago
Corey Farrell	d5a7a98528	loader: Replace priority heap with vector. ... This is needed for future changes which will require being able to process the load priority out of order. Change-Id: Ia23421197f09789940510b03ebbbf3bf24d51bea	8 years ago
Corey Farrell	5e9d70ae5d	loader: Rework of load_dynamic_module. ... * Split off load_dlopen to perform actual dlopen, check results and log warnings when needed. * Use flags which minimize number of calls to dlopen required. First attempt always uses RTLD_GLOBAL when global_symbols_only is enabled, RTLD_LOCAL when it is not. This patch significantly reduces the number of dlopen's performed. With 299 modules my system ran dlopen 857 times before this patch, 655 times after this patch. Change-Id: Ib2c9903cfddcc01aed3e01c1e7fe4a3fb9af0f8b	8 years ago
Corey Farrell	4de95d4bf0	loader: Minor fix to module registration. ... This protects the module loader itself against crashing if dlopen is called on a module from outside loader.c. * Expand scope of lock inside ast_module_register to include reading of resource_being_loaded. * NULL check resource_being_loaded. * Set resource_being_loaded NULL as soon as dlopen returns. This fixes some error paths where it was not NULL'ed. * Create module_destroy function to deduplicate code from ast_module_unregister and modules_shutdown. * Resolve leak that occured if a module did not successfully register. * Simplify checking for successful registration. Change-Id: I40f07a315e55b92df4fc7faf525ed6d4f396e7d2	8 years ago
Corey Farrell	501f4dcdd8	aco: Minimize use of regex. ... Remove nearly all use of regex from ACO users. Still remaining: * app_confbridge has a legitamate use of option name regex. * ast_sorcery_object_fields_register is implemented with regex, all callers use simple prefix based regex. I haven't decided the best way to fix this in both 13/15 and master. Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b	8 years ago
Corey Farrell	7413bcbeb5	aco: Create ways to minimize use of regex. ... ACO uses regex in many situations where it is completely unneeded. In some cases this doubles the total processing performed by aco_process_config. * Create ACO_IGNORE category type for use in place of skip_category regex source string. * Create additional aco_category_op values to allow specifying category filter using either a single plain string or a NULL terminated array of plain strings. * Create ACO_PREFIX to allow matching option names to case insensitive prefixes. Change-Id: I66a920dcd8e2b0301f73f968016440a985e72821	8 years ago
Richard Mudgett	61e81338d9	res_rtp_asterisk.c: Disable packet flood detection for video streams. ... We should not do flood detection on video RTP streams. Video RTP streams are very bursty by nature. They send out a burst of packets to update the video frame then wait for the next video frame update. Really only audio streams can be checked for flooding. The others are either bursty or don't have a set rate. * Added code to selectively disable packet flood detection for video RTP streams. ASTERISK-27440 Change-Id: I78031491a6e75c2d4b1e9c2462dc498fe9880a70	8 years ago
Corey Farrell	dd72844e4d	CLI: Remove special handling of 'core set verbose' from rasterisk. ... rasterisk does not need to handle setting verbose levels locally, it should just tell the daemon what it wants and print what it is given. Just max out the verbose level on the local client so all filtering happens on the daemon. ASTERISK-20281 #close Change-Id: Ia305f75f1fc424a9169bfa30ef70d626ace2c8a8	8 years ago
Jenkins2	20ca06b1db	Merge "CLI: Fix 'core show sysinfo' function ordering." into 13	8 years ago
Corey Farrell	4decf4e492	CLI: Fix 'core show sysinfo' function ordering. ... Handle CLI initialization before any processing occurs. Change-Id: I598b911d2e409214bbdfd0ba0882be1d602d221c	8 years ago
Richard Mudgett	28eddc7ea6	stasis_channels.c: Don't set channel snapshot caller_dnid twice. ... Change-Id: Ib8d45bbdfbda81e65045f6dff874d189b74e5471	8 years ago
Jenkins2	3bfddd9e73	Merge "astdb: Improve prefix searches in astdb" into 13	8 years ago
Jenkins2	84fe5f0219	Merge "loader: Refactor resource_name_match." into 13	8 years ago
Sean Bright	a4b291029f	astdb: Improve prefix searches in astdb ... Using the LIKE operator requires a full table scan of 'astdb', whereas a comparison operation is able to use the primary key index. This patch adds a new function to the AstDB API for quick prefix matches and updates res_sorcery_astdb to utilize it. This showed substantial performance improvement in my test environment. Related to ASTERISK~26806, but does not completely resolve it. Change-Id: I7d37f9ba2aea139dabf2ca72d31fbe34bd9b2fa1	8 years ago
Corey Farrell	9fc4f10e0e	loader: Refactor resource_name_match. ... Optimize resource_name_match. This change eliminates use of ast_strdupa, instead verifying that both basename's are the same length, then using strncasecmp. Change-Id: I477275c0e954c99d74be5abfc8bb6545b04e5a3d	8 years ago
Sean Bright	f726f11974	utils: Add convenience function for setting fd flags ... There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7	8 years ago
Jenkins2	54a86779a3	Merge "translate: Skip matrix_rebuild during shutdown." into 13	8 years ago
Jenkins2	ac7501b15c	Merge "CLI: Fix remote console completion." into 13	8 years ago
Jenkins2	9bf73ae1b3	Merge "sounds_index: Avoid repeatedly reindexing." into 13	8 years ago
Jenkins2	58addb1e38	Merge "media_index: Improve startup." into 13	8 years ago
Corey Farrell	5a0dcd9275	CLI: Fix remote console completion. ... Duplicate checking was done incorrectly when parsing completion options from a remote console causing all options to be ignored as duplicates. Once fixed I had to separate processing of the best match to ensure it was not identified as a duplicate when it is the only match. ASTERISK-27465 Change-Id: Ibbdb29f88211742071836c9b3f4d2aa1221cd0f9	8 years ago
Corey Farrell	2691ee68ce	translate: Skip matrix_rebuild during shutdown. ... Change-Id: I1e5eef4029cba56e33d786c5a5ade8091e531a1e	8 years ago
Corey Farrell	db6602f6f7	sounds_index: Avoid repeatedly reindexing. ... The sounds index is rebuilt each time a format is registered or unregistered. This causes the index to be repeatedly rebuilt during startup and shutdown. This patch significantly reduces the work done by delaying sound index initialization until after modules are loaded. This way a reindex only occurs if a format module is loaded after startup. We also skip reindexing when format modules are unloaded during shutdown. Change-Id: I585fd6ee04200612ab1490dc804f76805f89cf0a	8 years ago