5615 Commits (e7201c93ccadbf163ff1b9e51786f550f3ded89b)

Author	SHA1	Message	Date
Jenkins2	7e4bd0cf69	Merge "config: Speed up config template lookup" into 13	8 years ago
Sean Bright	6635ddc819	config: Speed up config template lookup ... ast_category_get() has an (undocumented) implementation detail where it tries to match the category name first by an explicit pointer comparison and if that fails falls back to a normal match. When initially building an ast_config during ast_config_load, this pointer comparison can never succeed, but we will end up iterating all categories twice. As the number of categories using a template increases, this dual looping becomes quite expensive. So we pass a flag to category_get_sep() indicating if a pointer match is even possible before trying to do so, saving us a full pass over the list of current categories. In my tests, loading a file with 3 template categories and 12000 additional categories that use those 3 templates (this file configures 4000 PJSIP endpoints with AOR & Auth) takes 1.2 seconds. After this change, that drops to 22ms. Change-Id: I59b95f288e11eb6bb34f31ce4cc772136b275e4a	8 years ago
Sean Bright	077ceacd48	config: Speed up ACO & sorcery initialization ... When starting Asterisk in the foreground, there is a perceptible delay when loading modules that use the ACO and sorcery config frameworks. For example, a lightly configured res_pjsip took 853ms to load on my VM. I tracked down the slowness to the XPath queries used to associate the relevant documentation with the config options. One improvement was adding a call to xmlXPathOrderDocElems after loading an XML document. From the libxml2 docs: Call this routine to speed up XPath computation on static documents. The second change was to remove recursive descent and wildcard operators from the XPath queries. After these changes, res_pjsip takes 85ms to load on my VM and there is no longer a perceptible delay when starting Asterisk in the foreground. Change-Id: I45d457f1580e26bf5a2b0dab16e8e9ae46dcbd82	8 years ago
Jenkins2	0f4152307a	Merge "translate: Transcode siren14, speex32, silk24, and silk12 via slin16." into 13	8 years ago
Jenkins2	749c544dbb	Merge "translate: Show sample rate for silk, speex, and slin in translation table." into 13	8 years ago
Joshua Colp	759468c45f	Merge "CLI: Finish conversion of completion handling to vectors." into 13	8 years ago
Jenkins2	c3a25ff753	Merge "CLI: Refactor cli_complete." into 13	8 years ago
Jenkins2	efb165a8a8	Merge "CLI: Rewrite ast_el_strtoarr to use vector's internally." into 13	8 years ago
George Joseph	f1f88c40f6	Merge "CLI: Refactor ast_cli_display_match_list." into 13	8 years ago
Jenkins2	2e3f878423	Merge "CLI: Create ast_cli_completion_add function." into 13	8 years ago
George Joseph	635583dabd	Merge "CLI: Remove calls to ast_cli_generator." into 13	8 years ago
Alexander Traud	c46cab49a3	translate: Transcode siren14, speex32, silk24, and silk12 via slin16. ... When a format has no pre-recorded sound files, Asterisk has to transcode between formats. For this, Asterisk has a fixed translation table. If the pre-recorded sound files are not available in the same sample rate, Asterisk has not only to transcode but also to resample. Asterisk has pre-recorded files for SLN (8000 kHz) and SLN16 (16000 kHz). However before this change, Asterisk did not take the sample rate into account, because the translation paths to SLN and SLN16 got the same score/weight in the table. Consequently, you might have got narrow-band audio with siren14, speex32, silk24, and silk12 although those are (ultra) wide-band audio codecs. With this change, the distance in sample-rates is taken into account. Now on the Command-Line interface (CLI) 'core show channels', you should see: (slin@16000)->(slin@32000)->(speex@32000). ASTERISK-23735 Reported by: Richard Kenner Change-Id: I9448295c1978be26f8633b6066395e7bbbe2e213	8 years ago
Alexander Traud	0f719aa051	translate: Show sample rate for silk, speex, and slin in translation table. ... ASTERISK-24662 Change-Id: I3822956984292c99c48bca8e97807e498ccc0e88	8 years ago
Joshua Colp	d2fb0ffb5b	Merge "aoc: Remove silly usage of RAII_VAR." into 13	8 years ago
Joshua Colp	27491c6847	Merge "abstract_jb: Remove silly usage of RAII_VAR." into 13	8 years ago
Joshua Colp	db7a180ce2	Merge "app: Remove silly usage of RAII_VAR." into 13	8 years ago
Corey Farrell	e9ba6a6b88	CLI: Finish conversion of completion handling to vectors. ... Change-Id: Ib81318f4ee52a5e73b003316e13fe9be1dd897a1	8 years ago
Corey Farrell	26a400c67a	CLI: Refactor cli_complete. ... * Stop using "_COMMAND NUMMATCHES" on remote consoles. Using this command had doubled the amount of work needed from the Asterisk daemon for each completion request. * Fix code formatting. * Remove static buffer used to send the command, use the same buffer that will receive the results. * Move sort from ast_cli_display_match_list. Change-Id: Ie2211b519a3d4bec45bf46e0095bdd01d384cb69	8 years ago
Corey Farrell	e723331f4f	CLI: Rewrite ast_el_strtoarr to use vector's internally. ... This rewrites ast_el_strtoarr to use vector's internally, but still return the original NULL terminated array of strings. Change-Id: Ibfe776cbe14f750effa9ca360930acaccc02e957	8 years ago
Corey Farrell	e07d94111d	CLI: Refactor ast_cli_display_match_list. ... * Stop estimating line count, just print until we run out of matches. * Stop freeing entries, the caller does that anyways. * Stop calculating / returning numoutput, it was ignored. Change-Id: I7f92afa8bea92241a95227587367424c8c32a5cb	8 years ago
Corey Farrell	8a63f4e709	CLI: Create ast_cli_completion_add function. ... Some completion generators are very inefficent due to the way CLI requests matches one at a time. ast_cli_completion_add can be called multiple times during one invokation of a CLI generator to add all results without having to reinitialize the search state for each match. Change-Id: I73d26d270bbbe1e3e6390799cfc1b639e39cceec	8 years ago
Corey Farrell	115f53a0fb	CLI: Remove calls to ast_cli_generator. ... The ability to add to localized storage cannot be supported by ast_cli_generator. The only calls to ast_cli_generator should be by functions that need to proxy the CLI generator, for example 'cli check permissions' or 'core show help'. * ast_cli_generatornummatches now retrieves the vector of matches and reports the number of elements (not including 'best' match). * test_substitution retrieves and iterates the vector. Change-Id: I8cd6b93905363cf7a33a2d2b0e2a8f8446d9f248	8 years ago
Joshua Colp	0fd8db7ec2	Merge "ccss: Remove silly usage of RAII_VAR." into 13	8 years ago
Joshua Colp	a8ac9a551d	Merge "cli: Remove silly usage of RAII_VAR." into 13	8 years ago
Joshua Colp	090ce0cd1b	Merge "loader: Fix comments in struct ast_module." into 13	8 years ago
Joshua Colp	29bf57ff2f	Merge "CLI: Create ast_cli_completion_vector." into 13	8 years ago
Joshua Colp	3ce96d2e03	Merge "Build: Fix issues building without SSL." into 13	8 years ago
Corey Farrell	84fd41729e	loader: Fix comments in struct ast_module. ... Make the comments follow doxygen format, move comments to the line before each field they describe. Change-Id: Ic445468398b5e88f13910f7c2f70bd15aad33a27	8 years ago
Joshua Colp	9b34aaddd9	Merge changes from topic 'alloc-check-acl' into 13 ... * changes: acl: Fix allocation related issues. acl: Update logger message to match 15+.	8 years ago
Corey Farrell	df6161b70e	cli: Remove silly usage of RAII_VAR. ... Change-Id: I81aacfee7cd26e4fc5eef07bca582700c2975bd7	8 years ago
Joshua Colp	da89afc2e2	Merge "bridge_basic: Ignore answer from transfer target when they've timed out." into 13	8 years ago
Corey Farrell	1e2b38adf5	ccss: Remove silly usage of RAII_VAR. ... Change-Id: I5ce40035e0a940e4e56f6322c1dcd47fbd509b98	8 years ago
Corey Farrell	ddc86ec664	app: Remove silly usage of RAII_VAR. ... Change-Id: Ideb594f7aae134974fb78d5477ba0853b97b8625	8 years ago
Corey Farrell	0e90d74604	aoc: Remove silly usage of RAII_VAR. ... Change-Id: I07907f833b81aeb0128bc9442a2abb52679c7511	8 years ago
Corey Farrell	746dd80eab	abstract_jb: Remove silly usage of RAII_VAR. ... Change-Id: I9d56175369363d1dc735504cf78a3a5577069f49	8 years ago
Corey Farrell	6a5ab65c88	Build: Fix issues building without SSL. ... * Fix conditional in libasteriskssl. * Use variables produced by configure to link the SSL and uuid libraries into libasteriskpj.so instead of hard-coding them. ASTERISK-27431 Change-Id: I3977931fd3ef8c4e4376349ccddb354eb839b58d	8 years ago
Corey Farrell	549542e50e	acl: Fix allocation related issues. ... Add checks for allocation errors, cleanup and report failure when they occur. * ast_duplicate_acl_list: Replace log warnings with errors, add missing line-feed. * ast_append_acl: Add missing line-feed to logger message. * ast_append_ha: Avoid ast_strdupa in loop by moving debug message to separate function. * ast_ha_join: Use two separate calls to ast_str_append to avoid using ast_strdupa in a loop. Change-Id: Ia19eaaeb0b139ff7ce7b971c7550e85c8b78ab76	8 years ago
Corey Farrell	2852dac480	acl: Update logger message to match 15+. ... This patch causes a logger message to be the same as it is in 15+. This will allow a follow-up patch to be cherry-picked to all 3 branches. Change-Id: Ic0665a3d49987e4eb6df28dcd9e90b1c3ca191e0	8 years ago
Corey Farrell	0b8b153d3c	CLI: Create ast_cli_completion_vector. ... This is a rewrite of ast_cli_completion_matches using a vector to build the list. The original function calls the vector version, NULL terminates the vector and extracts the elements array. One change in behavior the results are now sorted and deduplicated. This will solve bugs where some duplicate checking was done before the list was sorted. Change-Id: Iede20c5b4d965fa5ec71fda136ce9425eeb69519	8 years ago
Joshua Colp	0a7bbb068b	bridge_basic: Ignore answer from transfer target when they've timed out. ... This is a fun one. Given the following attended transfer scenario: 1. Transfer target is called 2. Transferer hangs up 3. Transfer target call attempt reaches timeout 4. Transfer target is told to hang up 5. Transfer target answers before channel is hung up 6. Transferer recall target is called A crash would occur. This is because the transfer target call attempt, despite being told to hang up, would raise a recall target answer before the recall target had been answered. As it had not answered there would be no recall target channel and it would implode. This change makes it so that if the transfer target has been hung up we don't tell the attended transfer code that it has answered. We also clear out the stimulus that the recall target has been answered after telling the transfer target to hang up, in case it was able to raise the information before we told it to hangup. ASTERISK-27361 Change-Id: Ifb8b255a9c4d2c5c1b8ad77bf54f659ed286df99	8 years ago
Corey Farrell	69055724ce	aoc: Fix memory management issues. ... aoc_publish_blob failed to check for msg allocation error and never released msg. Change-Id: Ib31a9ffb81056a0d496a49d7eec795005a44bcd5	8 years ago
Joshua Colp	8d55b132b9	Merge "sorcery: Add ast_sorcery_retrieve_by_prefix()" into 13	8 years ago
Richard Mudgett	7f916d621a	audiohook.c: Fix freeing a frame and still using it. ... Memory corruption happened to the media frame caches when an audio hook freed a frame when it shouldn't. I think the freed frame was because a jitter buffer interpolated a missing frame and the audio hook unconditionally freed it. * Made audiohook.c:audio_audiohook_write_list() not free an interpolated frame if it is the same frame as what was passed into the routine. * Made plc.c:normalise_history() use memmove() instead of memcpy() on a memory block that could overlap. Found by valgrind investigating this issue. ASTERISK-27238 ASTERISK-27412 Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde	8 years ago
Jenkins2	d74b50ecf7	Merge "core: Fix configuration of remote console socket path." into 13	8 years ago
Joshua Colp	f233e421dd	Merge "core: Add cache_media_frames debugging option." into 13	8 years ago
Corey Farrell	9c6d4ec022	core: Fix configuration of remote console socket path. ... The remote console socket path is the combination of asterisk.conf settings astrundir from [directories] and astctl from [files]. Unconditionally combine the two strings after processing all values to ensure we end up with the correct socket path. ASTERISK-27415 Change-Id: Ib1e2805d55d6b0955c6430a1a2a93acbf9b091e8	8 years ago
Sean Bright	cf062303e3	sorcery: Add ast_sorcery_retrieve_by_prefix() ... Some consumers of the sorcery API use ast_sorcery_retrieve_by_regex only so that they can anchor the potential match as a prefix and not because they truly need regular expressions. Rather than using regular expressions for simple prefix lookups, add a new operation - ast_sorcery_retrieve_by_prefix - that does them. Patches against 13 and 15 have a compatibility layer needed to maintain ABI that is not needed in master. Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79	8 years ago
Richard Mudgett	507d9b5f9e	core: Add cache_media_frames debugging option. ... The media frame cache gets in the way of finding use after free errors of media frames. Tools like valgrind and MALLOC_DEBUG don't know when a frame is released because it gets put into the cache instead of being freed. * Added the "cache_media_frames" option to asterisk.conf. Disabling the option helps track down media frame mismanagement when using valgrind or MALLOC_DEBUG. The cache gets in the way of determining if the frame is used after free and who freed it. NOTE: This option has no effect when Asterisk is compiled with the LOW_MEMORY compile time option enabled because the cache code does not exist. To disable the media frame cache simply disable the cache_media_frames option in asterisk.conf and restart Asterisk. Sample asterisk.conf setting: [options] cache_media_frames=no ASTERISK-27413 Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00	8 years ago
Richard Mudgett	bb2173275a	frame.c: Make ast_frame_free()/ast_frfree() NULL tolerant ... Change-Id: Ic49d821ef88ada38a31bdd835b9531443c55d793	8 years ago
Corey Farrell	211f5d8dd4	core: Remove disabled code. ... handle_quit has been disabled since 2003, remove it. Change-Id: Idc3aaa6c81676160547078f9b71e8aa43de2db18	8 years ago