946 Commits (e5e265c8d9b714bdeebb419ec47b899f5ed9ff4e)

Author	SHA1	Message	Date
Alexandre Fournier	e5e265c8d9	func_channel: add NULL checks on channel tech for dummy channels ... A dummy channel allocated with ast_dummy_channel_alloc() never gets a channel technology, so ast_channel_tech() returns NULL for it. func_channel_read() dereferences ast_channel_tech(chan)->type for CHANNEL(channeltype) without checking the tech for NULL, and func_channel_write_real() dereferences it the same way in its fallback branch. Both crash with a SIGSEGV on a dummy channel. This happens when CHANNEL(channeltype) is present in channelvars of ari.conf and the variable is evaluated on a dummy channel, e.g. when a voicemail is deposited for a mailbox that has an email address configured. Guard both dereferences. A dummy channel has no technology, so CHANNEL(channeltype) now reads as an empty string and a write falls through to the "Unknown or unavailable item requested" warning. This is very similar to the issue fixed by https://github.com/asterisk/asterisk/pull/1993 Resolves: #2150 AI disclaimer: Claude Opus 4.8 was used to find the cause of the crash and to find a solution. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	4 days ago
Tinet-mucw	f06a824a59	func_speex: Hold channel lock while updating speex state. ... speex_write() previously unlocked the channel immediately after looking up the speex datastore, then continued to create, modify, or destroy SpeexPreprocessState and related direction data without the lock. speex_callback() runs from the media path with the channel already locked, so concurrent Set(DENOISE)/Set(AGC) could free or mutate that state while preprocess was running and crash inside speex_preprocess_run(). Keep the channel locked for the full configuration update, unlock before ast_audiohook_attach()/detach(), and hold the lock across speex_read() while copying values out of the datastore. Fixes: #2091	4 weeks ago
aabolfazl	09d2619d26	func_strings: Fix misspelling of "occurred" in FIELDNUM documentation. ... The FIELDNUM description misspelled "occurred" as "occured". This text is user-visible: it is rendered on docs.asterisk.org and printed by "core show function FIELDNUM".	2 months ago
Aqeel Abbas	23b95cc4f7	func_strings: Fix syntax error in STRBETWEEN documentation example ... The STRBETWEEN function documentation example was missing a closing brace in the SendDTMF call. Corrected the syntax to ensure the dialplan example is functional.	2 months ago
Sean Bright	56847e454b	func_talkdetect.c: Clarify dsp_talking_threshold documentation. ... Fixes: #1761	5 months ago
Naveen Albert	03bc82ab23	build: Fix unused-but-set-variable warnings with gcc 16. ... Fix or remove a few variables that were being set but not actually used anywhere, causing warnings with gcc 16. Resolves: #1783	7 months ago
Sean Bright	ee1960acaf	func_presencestate.c: Allow `NOT_SET` to be set from CLI. ... Resolves: #1647	8 months ago
Sean Bright	6843091f5f	func_talkdetect.c: Remove reference to non-existent variables.	9 months ago
Sean Bright	60493e6991	res_odbc: Use SQL_SUCCEEDED() macro where applicable. ... This is just a cleanup of some repetitive code.	9 months ago
Sean Bright	f255042167	Revert "func_hangupcause.c: Add access to Reason headers via HANGUPCAUSE()" ... This reverts commit 5177662990. For rationale, see #1621 and #1606	9 months ago
Naveen Albert	2d0ed083ed	func_callerid: Document limitation of DNID fields. ... The Dial() application does not propagate DNID fields, which is counter to the behavior of the other Caller ID fields. This behavior is likely intentional since the use of Dial theoretically suggests a new dialed number, but document this caveat to inform users of it. Resolves: #1519	11 months ago
Naveen Albert	af3da2cfd7	func_channel: Allow R/W of ADSI CPE capability setting. ... Allow retrieving and setting the channel's ADSI capability from the dialplan. Resolves: #1514 UserNote: CHANNEL(adsicpe) can now be read or written to change the channels' ADSI CPE capability setting.	11 months ago
Igor Goncharovsky	4f45f21b71	func_hangupcause.c: Add access to Reason headers via HANGUPCAUSE() ... As soon as SIP call may end with several Reason headers, we want to make all of them available through the HAGUPCAUSE() function. This implementation uses the same ao2 hash for cause codes storage and adds a flag to make difference between last processed sip message and content of reason headers. UserNote: Added a new option to HANGUPCAUSE to access additional information about hangup reason. Reason headers from pjsip could be read using 'tech_extended' cause type.	11 months ago
Naveen Albert	f3eec24088	func_math: Add DIGIT_SUM function. ... Add a function (DIGIT_SUM) which returns the digit sum of a number. Resolves: #1499 UserNote: The DIGIT_SUM function can be used to return the digit sum of a number.	11 months ago
Naveen Albert	e92b068e94	func_scramble: Add example to XML documentation. ... The previous lack of an example made it ambiguous if the arguments went inside the function arguments or were part of the right-hand value. Resolves: #1485	12 months ago
Naveen Albert	95becab186	func_frame_drop: Add debug messages for dropped frames. ... Add debug messages in scenarios where frames that are usually processed are dropped or skipped. Resolves: #1371	1 year ago
Naveen Albert	fad8771123	func_frame_drop: Handle allocation failure properly. ... Handle allocation failure and simplify the allocation using asprintf. Resolves: #1366	1 year ago
Naveen Albert	06e05a41c3	func_curl: Allow auth methods to be set. ... Currently the CURL function only supports Basic Authentication, the default auth method in libcurl. Add an option that also allows enabling digest authentication. Resolves: #1332 UserNote: The httpauth field in CURLOPT now allows the authentication methods to be set.	1 year ago
Naveen Albert	907b1083ad	sig_analog: Add Call Waiting Deluxe support. ... Adds support for Call Waiting Deluxe options to enhance the current call waiting feature. As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function. ASTERISK-30373 #close Resolves: #271 UserNote: Call Waiting Deluxe can now be enabled for FXS channels by enabling its corresponding option.	1 year ago
George Joseph	6574f6532d	func_strings.c: Prevent SEGV in HASH single-argument mode. ... When in single-argument mode (very rarely used), a malformation of a column name (also very rare) could cause a NULL to be returned when retrieving the channel variable for that column. Passing that to strncat causes a SEGV. We now check for the NULL and print a warning message. Resolves: #1101	2 years ago
Sean Bright	67e89b3e77	docs: Indent <since> tags. ... Also updates the 'since' of applications/functions that existed before XML documentation was introduced (1.6.2.0).	2 years ago
George Joseph	f6a193e87e	docs: Add version information to application and function XML elements ... * Do a git blame on the embedded XML application or function element. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The applications and functions defined in the following files were done by hand because the XML was extracted from the C source file relatively recently. * channels/pjsip/dialplan_functions_doc.xml * main/logger_doc.xml * main/manager_doc.xml * res/res_geolocation/geoloc_doc.xml * res/res_stir_shaken/stir_shaken_doc.xml	2 years ago
George Joseph	936e88512e	docs: Add version information to manager event instance XML elements ... * Do a git blame on the embedded XML managerEvent elements. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The events defined in res/res_pjsip/pjsip_manager.xml were done by hand because the XML was extracted from the C source file relatively recently. Two bugs were fixed along the way... * The get_documentation awk script was exiting after it processed the first DOCUMENTATION block it found in a file. We have at least 1 source file with multiple DOCUMENTATION blocks so only the first one in them was being processed. The awk script was changed to continue searching rather than exiting after the first block. * Fixing the awk script revealed an issue in logger.c where the third DOCUMENTATION block contained a XML fragment that consisted only of a managerEventInstance element that wasn't wrapped in a managerEvent element. Since logger_doc.xml already existed, the remaining fragments in logger.c were moved to it and properly organized.	2 years ago
Maksim Nesterov	c50dea93a5	func_uuid: Add a new dialplan function to generate UUIDs ... This function is useful for uniquely identifying calls, recordings, and other entities in distributed environments, as well as for generating an argument for the AudioSocket application.	2 years ago
Mike Pultz	8e289af9de	func_curl.c: Add additional CURL options for SSL requests ... This patch adds additional CURL TLS options / options to support mTLS authenticated requests: * ssl_verifyhost - perform a host verification on the peer certificate (CURLOPT_SSL_VERIFYHOST) * ssl_cainfo - define a CA certificate file (CURLOPT_CAINFO) * ssl_capath - define a CA certificate directory (CURLOPT_CAPATH) * ssl_cert - define a client certificate for the request (CURLOPT_SSLCERT) * ssl_certtype - specify the client certificate type (CURLOPT_SSLCERTTYPE) * ssl_key - define a client private key for the request (CURLOPT_SSLKEY) * ssl_keytype - specify the client private key type (CURLOPT_SSLKEYTYPE) * ssl_keypasswd - set a password for the private key, if required (CURLOPT_KEYPASSWD) UserNote: The following new configuration options are now available in the res_curl.conf file, and the CURL() function: 'ssl_verifyhost' (CURLOPT_SSL_VERIFYHOST), 'ssl_cainfo' (CURLOPT_CAINFO), 'ssl_capath' (CURLOPT_CAPATH), 'ssl_cert' (CURLOPT_SSLCERT), 'ssl_certtype' (CURLOPT_SSLCERTTYPE), 'ssl_key' (CURLOPT_SSLKEY), 'ssl_keytype', (CURLOPT_SSLKEYTYPE) and 'ssl_keypasswd' (CURLOPT_KEYPASSWD). See the libcurl documentation for more details.	2 years ago
George Joseph	aa736dac12	func_pjsip_aor/contact: Fix documentation for contact ID ... Clarified the use of the contact ID returned from PJSIP_AOR. Resolves: #990	2 years ago
Naveen Albert	34662cf0ea	func_evalexten: Add EVAL_SUB function. ... This adds an EVAL_SUB function, which is similar to the existing EVAL_EXTEN function but significantly more powerful, as it allows executing arbitrary dialplan and capturing its return value as the function's output. While EVAL_EXTEN should be preferred if it is possible to use it, EVAL_SUB can be used in a wider variety of cases and allows arbitrary computation to be performed in a dialplan function call, leveraging the dialplan. Resolves: #951	2 years ago
Sean Bright	349db1de3d	func_base64.c: Ensure we set aside enough room for base64 encoded data. ... Reported by SingularTricycle on IRC. Fixes #940	2 years ago
Ben Ford	fb0e46e464	channel: Add multi-tenant identifier. ... This patch introduces a new identifier for channels: tenantid. It's a stringfield on the channel that can be used for general purposes. It will be inherited by other channels the same way that linkedid is. You can set tenantid in a few ways. The first is to set it in the dialplan with the Set and CHANNEL functions: exten => example,1,Set(CHANNEL(tenantid)=My tenant ID) It can also be accessed via CHANNEL: exten => example,2,NoOp(CHANNEL(tenantid)) Another method is to use the new tenantid option for pjsip endpoints in pjsip.conf: [my_endpoint] type=endpoint tenantid=My tenant ID This is considered the best approach since you will be able to see the tenant ID as early as the Newchannel event. It can also be set using set_var in pjsip.conf on the endpoint like setting other channel variable: set_var=CHANNEL(tenantid)=My tenant ID Note that set_var will not show tenant ID on the Newchannel event, however. Tenant ID has also been added to CDR. It's read-only and can be accessed via CDR(tenantid). You can also get the tenant ID of the last channel communicated with via CDR(peertenantid). Tenant ID will also show up in CEL records if it has been set, and the version number has been bumped accordingly. Fixes: #740 UserNote: tenantid has been added to channels. It can be read in dialplan via CHANNEL(tenantid), and it can be set using Set(CHANNEL(tenantid)=My tenant ID). In pjsip.conf, it is recommended to use the new tenantid option for pjsip endpoints (e.g., tenantid=My tenant ID) so that it will show up in Newchannel events. You can set it like any other channel variable using set_var in pjsip.conf as well, but note that this will NOT show up in Newchannel events. Tenant ID is also available in CDR and can be accessed with CDR(tenantid). The peer tenant ID can also be accessed with CDR(peertenantid). CEL includes tenant ID as well if it has been set. UpgradeNote: A new versioned struct (ast_channel_initializers) has been added that gets passed to __ast_channel_alloc_ap. The new function ast_channel_alloc_with_initializers should be used when creating channels that require the use of this struct. Currently the only value in the struct is for tenantid, but now more fields can be added to the struct as necessary rather than the __ast_channel_alloc_ap function. A new option (tenantid) has been added to endpoints in pjsip.conf as well. CEL has had its version bumped to include tenant ID.	2 years ago
Naveen Albert	7cffbabe5c	say.c: Fix cents off-by-one due to floating point rounding. ... Some of the money announcements can be off by one cent, due to the use of floating point in the money calculations, which is bad for obvious reasons. This replaces floating point with simple string parsing to ensure the cents value is converted accurately. Resolves: #525	2 years ago
Naveen Albert	c1b69d460d	callerid.c: Parse previously ignored Caller ID parameters. ... Commit f2f397c1a8 previously made it possible to send Caller ID parameters to FXS stations which, prior to that, could not be sent. This change is complementary in that we now handle receiving all these parameters on FXO lines and provide these up to the dialplan, via chan_dahdi. In particular: * If a redirecting reason is provided, the channel's redirecting reason is set. No redirecting number is set, since there is no parameter for this in the Caller ID protocol, but the reason can be checked to determine if and why a call was forwarded. * If the Call Qualifier parameter is received, the Call Qualifier variable is set. * Some comments have been added to explain why some of the code is the way it is, to assist other people looking at it. With this change, Asterisk's Caller ID implementation is now reasonably complete for both FXS and FXO operation. Resolves: #681	2 years ago
Naveen Albert	bb33925d75	func_callerid: Emit warning if invalid redirecting reason set. ... Emit a warning if REDIRECTING(reason) is set to an invalid reason, consistent with what happens when REDIRECTING(orig-reason) is set to an invalid reason. Resolves: #683	2 years ago
Naveen Albert	5cf75f9b2c	func_frame_trace: Add CLI command to dump frame queue. ... This adds a simple CLI command that can be used for analyzing all frames currently queued to a channel. A couple log messages are also adjusted to be more useful in tracing bridging problems. Resolves: #533	3 years ago
Naveen Albert	c4bf59b781	func_channel: Expose previously unsettable options. ... Certain channel options are not set anywhere or exposed in any way to users, making them unusable. This exposes some of these options which make sense for users to manipulate at runtime. Resolves: #442	3 years ago
Sean Bright	0b744cef15	func_curl.c: Remove CURLOPT() plaintext documentation. ... I assume this was missed when initially converting to XML documentation and we've been kicking the can down the road since.	3 years ago
Naveen Albert	5f115e425c	func_lock: Add missing see-also refs to documentation. ... Resolves: #423	3 years ago
Sean Bright	889b0aa375	func_curl.c: Ensure channel is locked when manipulating datastores.	3 years ago
Bastian Triller	8536ce8c38	func_json: Fix crashes for some types ... This commit fixes crashes in JSON_DECODE() for types null, true, false and real numbers. In addition it ensures that a path is not deeper than 32 levels. Also allow root object to be an array. Add unit tests for above cases.	3 years ago
Mike Bradeen	52472dcdfd	func_periodic_hook: Add hangup step to avoid timeout ... func_periodic_hook does not hangup after playback, relying on hangup which keeps the channel alive longer than necessary. Resolves: #325	3 years ago
George Joseph	55ec8f8dad	func_periodic_hook: Don't truncate channel name ... func_periodic_hook was truncating long channel names which causes issues when you need to run other dialplan functions/apps on the channel. Resolves: #319	3 years ago
Joshua C. Colp	953905b84d	variables: Add additional variable dialplan functions. ... Using the Set dialplan application does not actually delete channel or global variables. Instead the variables are set to an empty value. This change adds two dialplan functions, GLOBAL_DELETE and DELETE which can be used to delete global and channel variables instead of just setting them to empty. There is also no ability within the dialplan to determine if a global or channel variable has actually been set or not. This change also adds two dialplan functions, GLOBAL_EXISTS and VARIABLE_EXISTS which can be used to determine if a global or channel variable has been set or not. Resolves: #289 UserNote: Four new dialplan functions have been added. GLOBAL_DELETE and DELETE have been added which allows the deletion of global and channel variables. GLOBAL_EXISTS and VARIABLE_EXISTS have been added which checks whether a global or channel variable has been set.	3 years ago
phoneben	83dd36ba13	func_cut: Add example to documentation. ... This adds an example to the XML documentation clarifying usage of the CUT function to address a common misusage.	3 years ago
Sean Bright	b22aabe64a	func_export: Use correct function argument as variable name. ... Fixes #208	3 years ago
Naveen Albert	273ad73d99	sig_analog: Add fuller Caller ID support. ... A previous change, ASTERISK_29991, made it possible to send additional Caller ID parameters that were not previously supported. This change adds support for analog DAHDI channels to now be able to receive these parameters for on-hook Caller ID, in order to enhance the usability of CPE that support these parameters. Resolves: #94 ASTERISK-30331 UserNote: Additional Caller ID properties are now supported on incoming calls to FXS stations, namely the redirecting reason and call qualifier.	3 years ago
Mike Bradeen	edd7f1b060	bridge_builtin_features: add beep via touch variable ... Add periodic beep option to one-touch recording by setting the touch variable TOUCH_MONITOR_BEEP or TOUCH_MIXMONITOR_BEEP to the desired interval in seconds. If the interval is less than 5 seconds, a minimum of 5 seconds will be imposed. If the interval is set to an invalid value, it will default to 15 seconds. A new test event PERIODIC_HOOK_ENABLED was added to the func_periodic_hook hook_on function to indicate when a hook is started. This is so we can test that the touch variable starts the hook as expected. ASTERISK-30446 Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661	4 years ago
Naveen Albert	ff6c293ec0	func_json: Fix JSON parsing issues. ... Fix issue with returning empty instead of dumping the JSON string when recursing. Also adds a unit test to capture this fix. ASTERISK-30441 #close Change-Id: If0bde9f3fe84f7af485e0838205cc21e0f752a85	4 years ago
Naveen Albert	055e0a1571	func_json: Enhance parsing capabilities of JSON_DECODE ... Adds support for arrays to JSON_DECODE by allowing the user to print out entire arrays or index a particular key or print the number of keys in a JSON array. Additionally, adds support for recursively iterating a JSON tree in a single function call, making it easier to parse JSON results with multiple levels. A maximum depth is imposed to prevent potentially blowing the stack. Also fixes a bug with the unit tests causing an empty string to be printed instead of the actual test result. ASTERISK-29913 #close Change-Id: I603940b216a3911b498fc6583b18934011ef5d5b	4 years ago
Mike Bradeen	e8f548c155	app_macro: Remove deprecated module. ... For most modules that interacted with app_macro, this change is limited to no longer looking for the current context from the macrocontext when set. Additionally, the following modules are impacted: app_dial - no longer supports M^ connected/redirecting macro app_minivm - samples written using macro will no longer work. The sample needs a re-write app_queue - can no longer a macro on the called party's channel. Use gosub which is currently supported ccss - no callback macro, gosub only app_voicemail - no macro support channel - remove macrocontext and priority, no connected line or redirection macro options options - stdexten is deprecated to gosub as the default and only pbx - removed macrolock pbx_dundi - no longer look for macro snmp - removed macro context, exten, and priority ASTERISK-30304 Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6	4 years ago
Naveen Albert	bc94155ff0	func_frame_trace: Print text for text frames. ... Since text frames contain a text body, make FRAME_TRACE more useful for text frames by actually printing the text. ASTERISK-30353 #close Change-Id: Ia6ce3d15cecd7a673a528d34faac86854a2bab50	4 years ago
Mike Bradeen	4095a382da	chan_sip: Remove deprecated module. ... ASTERISK-30297 Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996	4 years ago