103 Commits (e3de4bc46e0332050f3fd296202abe94d13c20a5)

Author	SHA1	Message	Date
George Joseph	158c0efd4f	pjroject_bundled: Add already-destroyed check to tsx_timer_callback ... There have been cases that when the transaction timer callback is called the tsx is already destroyed. This causes a crash. We now check the tsx state and return if the tsx is already destroyed. Change-Id: If93acd5e48d9ca5bb553f2405d5afc836842fe1c	7 years ago
George Joseph	69c61237cd	pjproject_bundled: timer: Clean up usage of timer heap ... Added a new pj_timer_entry_reset function that resets a timer_entry for re-use. Changed direct settings of timer_entry fields to use pj_timer_entry_init and pj_timer_entry_reset. Fixed issues where timers were being rescheduled incorrectly. Change-Id: I5b624bfbc5c1429117484b9b24567293002148e6	7 years ago
George Joseph	c63a2e28f1	pjproject_bundled: Add patch for pj_atomic crashes ... There have been some crashes in the past where something attempts to use a pj_atomic after it's already been destroyed. This patch tries to prevent it by making sure that pj_atomic_destroy sets its mutex to NULL when it's done. The pj_mutex functions already check for a NULL mutex and just return PJ_EINVAL. Teluu also added some checks to the win32 implementation as well. Change-Id: Id25f70b79fdedf44ead6e6e1763a4417d3b3f825	7 years ago
Alexander Traud	06ba605988	BuildSystem: When no download utility is available, display the explanation. ... ./configure --with-pjproject-bundled did not display an explanation, when no download utility like wget, curl, or fetch was installed beforehand, although an explanation existed in code. This happened because the code expected the variable DOWNLOAD_TO_STDOUT to be empty. However, the script ./configure set that variable always. Change-Id: I64c99b76a03525c69471e5055bf124b36a51bbd4	7 years ago
Richard Mudgett	9ae427c7fd	res_pjproject.c: Upgrade bundled PJPROJECT to 2.7.2 ... Update patches included in bundled PJPROJECT for the new version. ASTERISK-27730 Change-Id: Id3c8c8ad82126846bcd9768bc3d0a18d89be8944	7 years ago
Kevin Harwell	55dc071950	Merge "AST-2018-003: Crash with an invalid SDP fmtp attribute" into 13	7 years ago
Kevin Harwell	05af43b240	AST-2018-003: Crash with an invalid SDP fmtp attribute ... pjproject's fmtp retrieval function failed to catch invalid fmtp attributes. Because of this Asterisk would crash if given an SDP with an invalid fmtp attribute. When retrieving the format this patch now makes sure the fmtp attribute is available. If not available it now returns an error status. ASTERISK-27583 #close Change-Id: I5cebe000ce2d846cae3af33b6d72c416e51caf2f	7 years ago
Kevin Harwell	c5dc2fb4ab	AST-2018-002: Crash with an invalid SDP media format description ... pjproject's media format parsing algorithm failed to catch invalid values. Because of this Asterisk would crash if given an SDP with a invalid media format description. When parsing the media format description this patch now properly parses the value and returns an error status if it can't successfully parse/convert the value. ASTERISK-27582 #close Change-Id: I883b3a4ef85b6972397f7b56bf46c5779c55fdd6	7 years ago
Alexander Traud	0ab97e9774	pjproject_bundled: Disable G.729 from Belledonne Communications. ... When <http://github.com/BelledonneCommunications/bcg729> is installed, PJProject tries to link that. Support for this bcg729 was added with PJProject 2.7. The issue happens, because Teluu enabled that new feature on default. ASTERISK-27584 Reported by: Stuart Henderson Change-Id: I88b6b18ad777bcfe2d8201187b4b90eec0a172a6	7 years ago
George Joseph	fbd0667c84	pjproject_bundled: Prevent crash on bad outgoing header ... We still need to figure out how a bad header is getting into the outgoing message but this patch to pjproject prevents attempting to print that header and causing a crash. For several users, this crash happens when sending 183 progress messages. ASTERISK-26832 Reported by: Ross Beer, Jan Rozhon Change-Id: Ie5c5a921c890c843587763e7f33f987dfe66bd16	7 years ago
Alexander Traud	659c44f5fb	BuildSystem: Really do not pass unknown-warning options to the compiler. ... When an older GCC version is called with a too new warning option, GCC exited with an error and Asterisk was not built. Therefore, the configure script tests the installed compiler whether it supports that warning option. If not, Asterisk does not pass it to the installed compiler. However, some compilers (like clang) do not exit (error) but give just a warning in such a case. Because the compiler did not exit, Asterisk passed the unknown-warning option. ASTERISK-27560 Change-Id: Ia9d148e689c173df4e91699113605dab2de36038	7 years ago
Sean Bright	ce3d56920b	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Joshua Colp	7a68faeb1d	pjsip: Ignore state changes from old transactions. ... When we fail over to a new target we create a new transaction and it becomes the current INVITE transaction. This does not prevent the previous transaction from raising state changes and causing the session to be prematurely disconnected if a transport error occurs immediately. This change backports a fix from PJSIP that eliminates the incorrect state change and reduces when they would be raised in the first place. ASTERISK-27408 Change-Id: Id22d087591782eee31311753d11e7eca4b95ef34	8 years ago
Joshua Colp	41c14fd807	pjproject: Clean up disabling of WebRTC support. ... The definition in config_site.h and the argument to the configure script are not necessary to disable WebRTC support. The correct argument, --disable-libwebrtc, is already passed. ASTERISK-26980 Change-Id: I27da2c894f87914956a72710222e17462d8a44bc	8 years ago
Kevin Harwell	5abab0a34c	pjsip: 183 without To tag does not negotiate media ... If a 183 with sdp response is receive without a To tag the sdp is not negotiated. According to RFC 3261 section 12.1.2 while a To tag is required, the client needs to still be able to handle the missing tag case for backwards compatibility. This patch, accepted by and applied to pjproject, makes it so if an incoming 180/183 with SDP comes in without a To tag it gets appropriately handled. ASTERISK-27442 #close Change-Id: Ic9d6b01e05e8f4874eebbd7adfe05d932025d203	8 years ago
Joshua Colp	3d429a5072	Merge "BuildSystem: pjsip_evsub_set_uas_timeout was not used." into 13	8 years ago
Alexander Traud	50cb5199c1	BuildSystem: pjsip_evsub_set_uas_timeout was not used. ... ASTERISK-27435 Change-Id: Id318a7ae6d7d69b53f911d30bf3eece64852f15c	8 years ago
Corey Farrell	69113388e9	Build: Fix OSX build issues. ... OSX does not support 'readlink -f' or 'sed -r'. Replace readlink with the GNU make macro 'realpath'. Replace sed with grep in one place, cut in the other. ASTERISK-27332 Change-Id: I5d34ecca905384decb22ead45c913ae5e8aff748	8 years ago
Joshua Colp	e25ec49b62	Merge "bundled_pjproject: Update to 2.7.1" into 13	8 years ago
Jenkins2	57fe717471	Merge "bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg" into 13	8 years ago
George Joseph	b5f2779a23	bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg ... The default return code for pjsip_find_msg was PJ_SUCCESS so if a Content-Length header wasn't found at all, pjsip_find_msg was returning PJ_SUCCESS instead of PJSIP_EMISSINGHDR. Also added the volatile keyword to a few variables that are used both inside and outside the PJ_TRY/PJ_CATCH block. Partial fix for ASTERISK_27408 Change-Id: If82ba9de921e3d57df9c68cf96ee45ccc1491f7a	8 years ago
Ben Ford	e6ada55430	bundled_pjproject: Update to 2.7.1 ... Update from 2.7 to 2.7.1 for bundled pjproject. Changed version and removed patch files included in the update. Change-Id: I55cea8e734b318c2df9daf86aa0802c559ec8357	8 years ago
Joshua Colp	360d50d74c	pjsip: Add patch to allow all transports to be destroyed. ... If a transport is created with the same transport type, source IP address, and source port as one that already exists the old transport is moved into a linked list called "tp_list". If this old transport is later shutdown it will not be destroyed as the process checks whether the transport is valid or not. This check does not look at the "tp_list" when making the determination causing the transport to not be destroyed. This change updates the logic to query not just the main storage method for transports but also the "tp_list". Upstream issue https://trac.pjsip.org/repos/ticket/2061 ASTERISK-27411 Change-Id: Ic5c2bb60226df0ef1c8851359ed8d4cd64469429	8 years ago
George Joseph	2faa3e3bab	AST-2017-009: pjproject: Add validation of numeric header values ... Parsing the numeric header fields like cseq, ttl, port, etc. all had the potential to overflow, either causing unintended values to be captured or, if the values were subsequently converted back to strings, a buffer overrun. To address this, new "strto" functions have been created that do range checking and those functions are used wherever possible in the parser. * Created pjlib/include/limits.h and pjlib/include/compat/limits.h to either include the system limits.h or define common numeric limits if there is no system limits.h. * Created strto*_validate functions in sip_parser that take bounds and on failure call the on_str_parse_error function which prints an error message and calls PJ_THROW. * Updated sip_parser to validate the numeric fields. * Fixed an issue in sip_transport that prevented error messages from being properly displayed. * Added "volatile" to some variables referenced in PJ_CATCH blocks as the optimizer was sometimes optimizing them away. * Fixed length calculation in sip_transaction/create_tsx_key_2543 to account for signed ints being 11 characters, not 9. ASTERISK-27319 Reported by: Youngsung Kim at LINE Corporation Change-Id: I48de2e4ccf196990906304e8d7061f4ffdd772ff	8 years ago
Richard Mudgett	b57dcc8d9c	res_pjproject.c: Upgrade bundled PJPROJECT to 2.7 ... Update patches included in bundled PJPROJECT for the new version. ASTERISK-27355 Change-Id: I9ac5dbbffaadca25ad24fac8b9ab615e5ace6083	8 years ago
Sean Bright	f3b1b64d21	pjproject: Patch to correct STUN FINGERPRINT usage ... Change-Id: I0e453253dff1388b0186b36c754457c1d0d12db6	8 years ago
Richard Mudgett	8594f73a81	configure: Check cache for valid pjproject tarball before downloading. ... On a fresh Asterisk source directory, the bundled pjproject tarball is unconditionally downloaded even if the tarball is already in a specified cache directory. * Made check if the pjproject tarball is valid in the cache directory before downloading the tarball on a fresh source directory. Change-Id: Ic7ec842d3c97ecd8dafbad6f056b7fdbce41cae5	8 years ago
George Joseph	363d61ef58	configure: Add --with-download-cache option ... To make building without an internet connection easier, a new ./configure option '--with-download-cache' was added that sets the cache for externals (like pjproject, the codecs and the DPMA), AND the sounds files. It can also be specified as an environment variable named "AST_DOWNLOAD_CACHE". The existing '--with-sounds-cache' option / SOUNDS_CACHE_DIR env variable and '--with-externals-cache' option / EXTERNALS_CACHE_DIR env variable remain and if specified, will override '--with-downloads-cache'. Change-Id: I5c3cf15ee61e8fe191b52732303e969854f8d861	8 years ago
George Joseph	0d58fefa30	bundled_pjproject: Improve SSL/TLS error handling ... OpenSSL has 2 levels or error processing. It's possible for the top layer to return SSL_ERROR_SYSCALL but the lower layer return no error, in which case processing should continue. Only the top layer was being examined though so connections were being torn down when they didn't need to be. This patch adds the examination of the lower level codes, and if they return no errors, allows processing to continue. ASTERISK-27001 Reported-by: Ian Gilmour patches: pjproject-2.6.patch submitted by Ian Gilmour (license 6889) Updated-by: George Joseph and Sauw Ming (Teluu) Merged to upstream pjproject on 7/27/2017 (commit 5631) Change-Id: I23844ca0c68ef1ee550f14d46f6dae57d33b7bd2	8 years ago
Benjamin Keith Ford	9a47dd7113	pjsip: Increase maximum packet size. ... The maximum packet size for PJSIP has been increased to handle the multiple streams being added for WebRTC. Change-Id: I9ea1e8d02668c544acadcb1c6200e1cc1bd588b3	8 years ago
Jenkins2	dc1fc28a4a	Merge "pjproject_bundled: Allow passing configure options to bundled" into 13	8 years ago
George Joseph	bbe68f139d	pjproject_bundled: Allow passing configure options to bundled ... There wasn't any good way to pass options like --host or --build down to the pjproject configure which makes cross-compiling difficult. * Added a new PJPROJECT_CONFIGURE_OPTS environment variable which can be used to pass arbitrary options to pjproject configure. * Automatically set the pjproject configure --host and --build options to match those supplied for the asterisk configure. ASTERISK-27097 #close Reported-by: Kinsey Moore Change-Id: I5fa776e110262851173002a26ffe1172e4c35b2e	8 years ago
George Joseph	6bd7c0f37c	chan_pjsip: Fix ability to send UPDATE on COLP ... When connected_line_method is "invite", we're supposed to determine if the client can support UPDATE and if it can, send UPDATE instead of INVITE to avoid the SDP renegotiation. Not only was pjproject not setting the PJSIP_INV_SUPPORT_UPDATE flag, we were testing that invite_tsx wasn't NULL which isn't always the case. * Updated chan_pjsip/update_connected_line_information to drop the requirement that invite_tsx isn't NULL. * Submitted patch to pjproject sip_inv.c that sets the PJSIP_INV_SUPPORT_UPDATE flag correctly. * Updated pjsip.conf.sample to clarify what happens when "invite" is specified. ASTERISK-27095 Change-Id: Ic2381b3567b8052c616d96fbe79564c530e81560	8 years ago
George Joseph	0bde568669	pjproject_bundled: Use the asterisk github mirror for download ... We now mirror the pjproject tarball and md5 at https://github.com/asterisk/third-party/tree/master/pjproject To improve download reliability, we now get the tarball from our mirror instead of from pjsip.org. ASTERISK-27052 #close Reported-by: 'alex' Change-Id: I60236587a8935bfa71fcc391f4e2ecb31918c08a	8 years ago
Jenkins2	6aa11c4b31	Merge "AST-2017-003: Handle zero-length body parts correctly." into 13	8 years ago
Mark Michelson	919ccdb9ac	AST-2017-002: Ensure transaction key buffer is large enough. ... ASTERISK-26938 #close Change-Id: I266490792fd8896a23be7cb92f316b7e69356413	8 years ago
Mark Michelson	49c032abef	AST-2017-003: Handle zero-length body parts correctly. ... ASTERISK-26939 #close Change-Id: I7ea235ab39833a187db4e078f0788bd0af0a24fd	8 years ago
George Joseph	001dc2ade6	pjproject_bundled: Add --disable-libwebrtc to configure ... Without the disable, pjproject tries to build it's internal webrtc implementation which requires sse2. This fails on platforms without sse2. ASTERISK-26930 #close Reported-by: abelbeck Change-Id: I07231f9160c35cfa42b194d3aad4e7d51fd9a410	8 years ago
Alexander Traud	e0e5a337fd	pjproject_bundled: Crash on pj_ssl_get_info() while ioqueue_on_read_complete(). ... When the Asterisk channel driver res_pjsip offers SIP-over-TLS, sometimes, not reproducible, Asterisk crashed in pj_ssl_sock_get_info() because a NULL pointer was read. This change avoids this crash. ASTERISK-26927 #close Change-Id: I24a6011b44d1426d159742ff4421cf806a52938b	8 years ago
George Joseph	4e6e069491	pjproject_bundled: Add 3 upstream patches ... 0035-r5572-svn-backport-dialog-transaction-deadlock.patch 0036-r5573-svn-backport-ua-pjsua-transaction-deadlock.patch 0037-r5576-svn-backport-session-timer-crash.patch Also removed the progress bar from wget download to stdout. ASTERISK-26905 #close Reported-by: Ross Beer Change-Id: I268fb3cf71a3bb24283ff0d24bd8b03239d81256	8 years ago
Sean Bright	79a2c26c03	core: Remove embedded module support ... This has not worked for some time and is no longer actively maintained. Change-Id: I5110b0db69c152761b58fa025cb0a53b0e544d99	8 years ago
Kevin Harwell	e6aeeabddf	pjproject_bundled: raise timeout value used when downloading ... After configuring Asterisk with '--with-pjproject-bundled' the configure/build process attempts to download pjproject from its download site. Currently, a timeout of 10 seconds is used that will stop the download process if pjproject has not been fully downloaded in that time. For some systems this was not enough time and the process was timing out too early. This patch raises the download timeout value to '60'. Also, this patch fixes another bug where the DOWNLOAD_TIMEOUT variable was not being properly exported due to a naming error. DOWNLOAD_MAX_TIMEOUT is now properly renamed to DOWNLOAD_TIMEOUT. ASTERISK-26814 #close Change-Id: Ia56e4e8a3d39db76bc8a1852b2cf07ec10b39842	8 years ago
zuul	14a9a6fc09	Merge "pjsip: prevent memory corruption on creation of xml bodies" into 13	8 years ago
Joshua Elson	91c97b5da5	pjsip: prevent memory corruption on creation of xml bodies ... ASTERISK-26776 #close Change-Id: I884b6f4e8233a355d0be687ec78d41bc0e4d3fd2	8 years ago
Joshua Colp	86c69ccdf7	Merge "res_pjsip_transport_websocket: Add support for IPv6." into 13	8 years ago
George Joseph	523de8eb8e	pjproject_bundled: Reduce the need for rebuilds ... Bundled pjproject should now only rebuild if one of the menuselect "Compiler Flags" options changes. Change-Id: If114a2e16b9e77af371a600d6a5e197bbf28fe43	8 years ago
Joshua Colp	2a85888262	res_pjsip_transport_websocket: Add support for IPv6. ... This change adds a PJSIP patch (which has been contributed upstream) to allow the registration of IPv6 transport types. Using this the res_pjsip_transport_websocket module now registers an IPv6 Websocket transport and uses it for the corresponding traffic. ASTERISK-26685 Change-Id: Id1f9126f995b31dc38db8fdb58afd289b4ad1647	8 years ago
George Joseph	9c05ddbddd	pjproject_bundled: Update for pjproject 2.6 ... * Removed all 2.5.5 functional patches. * Updated usages of pj_release_pool to be "safe". * Updated configure options to disable webrtc. * Updated config_site.h to disable webrtc in pjmedia. * Added Richard Mudgett's recent resolver patches. Change-Id: Ib400cc4dfca68b3d07ce14d314e829bfddc252c7	8 years ago
Richard Mudgett	473813311b	pjproject: Fixes to resolve DNS SRV crashes. ... * Re #1945 (misc): Don't trigger SRV complete callback when there is a parse error. * srv_resolver.c: Don't try to send query if already considered resolved. ** In resolve_hostnames() don't try to resolve a query that is already considered resolved. ** In resolve_hostnames() fix DNS typo in comments. ** In build_server_entries() move a common expression assigning to cnt earlier. * sip_transport.c: Fix tdata object name to actually contain the pointer. It helps if the logs referencing a tdata object buffer actually have a name that includes the correct pointer as part of the name. Also since the tdata has its own pool it helps if any logs referencing the pool have the same name as the tdata object. This change brings tdata logging in line with how tsx objects are named. ASTERISK-26669 #close ASTERISK-26738 #close Change-Id: I56af2ded25476b3e870ca586ee69ed6954ef75af	8 years ago
Richard Mudgett	57f19d6efb	pjproject: Increase SENDER_WIDTH column size for 64-bit system logs. ... ASTERISK-26669 ASTERISK-26738 Change-Id: Ibae6fc8cae69a1f04df0c577c4c11200499d6fe0	8 years ago