f7e7161607
Merge team/russell/frame_caching
...
There are some situations in Asterisk where ast_frame and/or iax_frame
structures are rapidly allocatted and freed (at least 50 times per second
for one call).
This code significantly improves the performance of ast_frame_header_new(),
ast_frdup(), ast_frfree(), iax_frame_new(), and iax_frame_free() by keeping
a thread-local cache of these structures and using frames from the cache
whenever possible instead of calling malloc/free every time.
This commit also converts the ast_frame and iax_frame structures to use the
linked list macros.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
0a27d8bfe5
merge new_loader_completion branch, including (at least):
...
- restructured build tree and makefiles to eliminate recursion problems
- support for embedded modules
- support for static builds
- simpler cross-compilation support
- simpler module/loader interface (no exported symbols)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
35a2f14d96
Quit early and print a LOG_WARNING if we are trying to check devicestate on a Local channel that's been improperly defined.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
794d0e4d1f
make Local channel return sensible device state values
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
79f5f61474
Merged revisions 33638 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r33638 | kpfleming | 2006-06-12 11:03:29 -0500 (Mon, 12 Jun 2006) | 2 lines
only allow chan_local to masquerade the outbound channel onto its owner, instead of the other way around (this will ensure that group variables on the outbound channel as preserved)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33643 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
472c1ca282
simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a0f95cd526
Merged revisions 29464 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r29464 | file | 2006-05-22 13:33:03 -0300 (Mon, 22 May 2006) | 2 lines
Preserve presentation bit when going through chan_local (issue #7002 reported by acunningham)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
1783cb3a91
Adding send_text capability to chan_local
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
908c153840
First stab at supporting video in chan_local
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a3cc752008
Add simple devicestate for chan_local
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
fdcfd6469b
ensure that control frames with payload can be sent to channel drivers via ->indicate()
...
update iax2_indicate to pass control frame payload to the connected channel
add an API call for sending an indication with payload, and use it for control frames with payload
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
5928df2a48
replace strncpy with ast_copy_string.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
e43bc6634d
This rather large commit changes the way modules are loaded.
...
As partly documented in loader.c and include/asterisk/module.h,
modules are now expected to return all of their methods and flags
into a structure 'mod_data', and are normally loaded with RTLD_NOW
| RTLD_LOCAL, so symbols are resolved immediately and conflicts
should be less likely. Only in a small number of cases (res_*,
typically) modules are loaded RTLD_GLOBAL, so they can export
symbols.
The core of the change is only the two files loader.c and
include/asterisk/module.h, all the rest is simply adaptation of the
existing modules to the new API, a rather mechanical (but believe
me, time and finger-consuming!) process whose detail you can figure
out by svn diff'ing any single module.
Expect some minor compilation issue after this change, please
report it on mantis http://bugs.digium.com/view.php?id=6968
so we collect all the feedback in one place.
I am just sorry that this change missed SVN version number 20000!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
f10f427d49
since the module API is changing, it's a good time to const-ify the description() and key() return values
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
756c7cbb12
Bug 6873 - Finish moving from the non-threadsafe (and poor randomness) rand() to threadsafe ast_random()
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
0b655c3ce9
minor cleanup: localize a variable and replace i++; i++ with i +=2;
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
4f1e5d1aef
Bug 6387 - janitor cleanup for linked lists
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
81125d803e
Don't set a global variable if the channel you're trying to set CHANLOCALSTATUS on has gone away already.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9139 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a16ae226b6
use string fields for some stuff in ast_channel
...
const-ify some more APIs
remove 'type' field from ast_channel, in favor of the one in the channel's tech structure
allow string field module users to specify the 'chunk size' for pool allocations
update chan_alsa to be compatible with recent const-ification patches
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a228af1dd9
remove some more local declarations of null frames
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9004 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
ad5eaa9aca
More doxygen updates
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
242a478023
Fix compiler warning.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8135 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
1874f21ff8
Implement the autologoffunavail option in chan_agent ( #6038 with some minor mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
466a062b09
convert some channels to use the memory allocation wrappers.
...
(This is being added to the janitor projects list.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a725468381
update doxygen docs to specify authors
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
0242a69b3f
Merged revisions 7265-7266,7268-7275 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r7265 | oej | 2005-12-01 17:18:14 -0600 (Thu, 01 Dec 2005) | 2 lines
Changing bug report address to the Asterisk issue tracker
........
r7266 | kpfleming | 2005-12-01 17:18:29 -0600 (Thu, 01 Dec 2005) | 3 lines
Makefile 'update' target now supports updating from Subversion repositories (issue #5875 )
remove support for 'patches' subdirectory, it's no longer useful
........
r7268 | kpfleming | 2005-12-01 17:34:58 -0600 (Thu, 01 Dec 2005) | 2 lines
ensure channel's scheduling context is freed (issue #5788 )
........
r7269 | kpfleming | 2005-12-01 17:49:44 -0600 (Thu, 01 Dec 2005) | 2 lines
don't block waiting for the Festival server forever when it goes away (issue #5882 )
........
r7270 | kpfleming | 2005-12-01 18:26:12 -0600 (Thu, 01 Dec 2005) | 2 lines
allow variables to exist on both 'halves' of the Local channel (issue #5810 )
........
r7271 | kpfleming | 2005-12-01 18:28:48 -0600 (Thu, 01 Dec 2005) | 2 lines
protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue #5879 )
........
r7272 | kpfleming | 2005-12-01 18:39:00 -0600 (Thu, 01 Dec 2005) | 3 lines
properly handle password changes when mailbox is last line of config file and not followed by a newline (issue #5870 )
reformat password changing code to conform to coding guidelines (issue #5870 )
........
r7273 | kpfleming | 2005-12-01 18:42:40 -0600 (Thu, 01 Dec 2005) | 2 lines
allow previous context-searching behavior to be used if desired (issue #5899 )
........
r7274 | kpfleming | 2005-12-01 18:51:15 -0600 (Thu, 01 Dec 2005) | 2 lines
inherit channel variables into channels created by Page() application (issue #5888 )
........
r7275 | oej | 2005-12-01 18:52:13 -0600 (Thu, 01 Dec 2005) | 2 lines
Bug #5907 . Improve SIP INFO DTMF debugging output. (1.2 & Trunk)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
2c65582b66
remove extraneous svn:executable properties
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
15b01f246c
issue #5604
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
31a804b97c
issue #5605
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
3453e3efa5
Doxygen documentation update from oej (issue #5505 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
e603dcedb5
Perform some extra checks before performing masquerades
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
5da915dcfd
update MANY more files with proper copyright/license info (thanks Ian!)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
20 years ago
a953eb06c3
formatting cleanups (bug #4786 , with minor mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6193 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
4c531ca8c0
define an AST_MAX_CONTEXT for use instead of AST_MAX_EXTENSION
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
4803ab0bb2
don't use locks when reading usecounts (reading only, not writing)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
e5e64bfd41
header ordering fixes for FreeBSD (pending a global merge into asterisk.h) (bug #4484 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5876 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
2b8338cb52
more file version tags
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
005e436b57
another round of version tag updates, along with 'show version files' pattern filtering
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
1f9ab2380a
use double-quotes instead of angle-brackets for non-system include files (bug #4058 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
dc9faa21e4
Fix a bunch of const stuff, merge queue changes, add experimental "hybrid" DTMF mode
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5293 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
6b20a0f5db
Inherit variables across local channel (bug #3769 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
0eb1f2ec44
If we're only queueing audio, don't queue when we really want to engage the masquerade
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5145 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
18d9b26cf9
Rework channel structure to eliminate "pvt" portion of channel (bug #3573 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
34e8ed636d
Fix queue URL passing (bug #3543 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
cea4a8e09e
Fix native agent transfer, add UPGRADE.txt for notes about backwards compatibility issues upgrading from Asterisk 1.0 to current CVS head
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
c2d98239d2
Fix use count for agent/local (bug #2996 et al)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4425 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
6cb38ac23a
Add features (incomplete, highly experimental), fix DundiLookup app, debug improvements (bug #2800 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
8a13712e45
Pass concept of status back, permit "leaveempty" to work with static agents who are not loggedon (bug #2719 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4106 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
dcb396b76b
Fix chan_local debug message (bug #2725 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
e21ed1865b
First pass at making transfer work within agent (not tested, shouldn't break anything that currently worked)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4061 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
fce17976e9
Major PBX revamps (including labels, update examples)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
04fc29c8b2
Huge callerid rework (might break H.323, others)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 years ago
dd293ed6fe
First pass at properly handling account codes in forwarding
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
8801247d76
Remove pthread.h from source. We should be using asterisk/lock.h everywhere instead (except in asterisk/lock.h).
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
5546e32355
Merge major BSD mutex and symbol conflict patches (bug #1816 ) (link patch still pending)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3273 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
e66aef0c05
Can't check outbound without having lock (bug #1886 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
727abcdec7
Merge FreeBSD locking fixes (bug #1411 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
d117f2258f
Propagate language properly across chan_local (bug #1663 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
13bca43aa8
Get rid of all that old needlock garbage now that we're using recursive mutexes
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
7132570353
Change 'show locals' into 'local show channels' to follow other channel methods. Bug #1255
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
e7ecf6accb
Populated RDNIS
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
806bb3c63f
Add support for parking with IAX2
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2318 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
32e131862d
Elminate unused code/warnings (bug #934 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
b3e9086d5d
Really fix chan local races (I hope)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1813 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
ea4aeb0c67
Handle without context
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1620 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
55637d3de5
Add "n" option to allow disabling of masq optimization
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1619 65c4cc65-6c06-0410-ace0-fbb531ad65f3
22 years ago
52095246a6
Fix race for fast hanguyp
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1377 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
c21550022e
Make check_bridge back off if it cant get all the locks it wants
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
d91f72fd5f
Add any missing locking calls
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
1bb58646de
Totally revamp thread debugging to support locating and removing deadlocks
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
50af63e1d2
Never release lock when doing a hangup or bad things can happen when masq is taking place
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
0e2190687f
Lock everything that might need to be locked
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1292 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
886cf4f227
Lock masquerading into channel
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1291 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
5a0a0ff8dd
Fix local buglet
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
29802d2ff5
Properly defuse race in chan_local, fix extremely unlikely path for losing lock in chan_agent
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
cbe865df7a
Fix race in local, update queue
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1143 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
878db20a92
Fix case where local is allocated but not actually called on
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1043 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
f3b8441cc7
Copy Caller*ID on local channels
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
907980f17d
Fix tiny typo
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
9cc2aa39d0
Unlink local channels
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@778 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
77b48c0aed
Make call forwarding work properly by using new Local channel
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
864fc0cfce
Complete local channel implementation
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
c35b05dd30
Fix chan_local build, update SIP
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
fbc8fd227c
Add preliminary chan_local, fix chan_sip to delete unknown calls
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
23 years ago
Russell Bryant
Kevin P. Fleming
BJ Weschke
Joshua Colp
Olle Johansson
Luigi Rizzo
Tilghman Lesher
Mark Spencer
James Golovich
Jeremy McNamara