29772 Commits (d7f5421ea42ce18490e36f61e34893b96dc5708e)

 

All Branches   

Search

Author	SHA1	Message	Date
Corey Farrell	4decf4e492	CLI: Fix 'core show sysinfo' function ordering. ... Handle CLI initialization before any processing occurs. Change-Id: I598b911d2e409214bbdfd0ba0882be1d602d221c	8 years ago
Richard Mudgett	28eddc7ea6	stasis_channels.c: Don't set channel snapshot caller_dnid twice. ... Change-Id: Ib8d45bbdfbda81e65045f6dff874d189b74e5471	8 years ago
Jenkins2	60acbeb431	Merge "codec_opus: Make libcurl a dependency in menuselect" into 13	8 years ago
Jenkins2	3bfddd9e73	Merge "astdb: Improve prefix searches in astdb" into 13	8 years ago
Jenkins2	84fe5f0219	Merge "loader: Refactor resource_name_match." into 13	8 years ago
Joshua Colp	8834a8eff9	Merge "res_stasis and res_speech: Fix load order." into 13	8 years ago
Jenkins2	90fe599e45	Merge "utils: Add convenience function for setting fd flags" into 13	8 years ago
Jenkins2	3b6fc78f4e	Merge "pjsip: Improve CLI completion performance" into 13	8 years ago
Sean Bright	028f4320de	codec_opus: Make libcurl a dependency in menuselect ... ASTERISK-27475 #close Change-Id: If7384bc6ed002ef140dec69798d14c52b7cfd800	8 years ago
Joshua Colp	ed089535d4	Merge "CDR: Fix deadlock setting some CDR values." into 13	8 years ago
Sean Bright	4838557132	pjsip: Improve CLI completion performance ... Use the new ast_cli_completion_add() function to improve completion performance for commands like 'pjsip show endpoint.' Change-Id: I76d802294d2ac1766110dc75f7d117c8541ce348	8 years ago
Sean Bright	a4b291029f	astdb: Improve prefix searches in astdb ... Using the LIKE operator requires a full table scan of 'astdb', whereas a comparison operation is able to use the primary key index. This patch adds a new function to the AstDB API for quick prefix matches and updates res_sorcery_astdb to utilize it. This showed substantial performance improvement in my test environment. Related to ASTERISK~26806, but does not completely resolve it. Change-Id: I7d37f9ba2aea139dabf2ca72d31fbe34bd9b2fa1	8 years ago
Corey Farrell	9fc4f10e0e	loader: Refactor resource_name_match. ... Optimize resource_name_match. This change eliminates use of ast_strdupa, instead verifying that both basename's are the same length, then using strncasecmp. Change-Id: I477275c0e954c99d74be5abfc8bb6545b04e5a3d	8 years ago
Sean Bright	c3bc44fa1b	pjsip_configuration: Add correct file header ... Change-Id: I25348c386a222bb704aff07f54375108a6402906	8 years ago
Sean Bright	f726f11974	utils: Add convenience function for setting fd flags ... There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7	8 years ago
Corey Farrell	3d79c34350	res_stasis and res_speech: Fix load order. ... res_stasis was missing AST_MODFLAG_LOAD_ORDER. Set res_stasis and res_speech to start at (AST_MODPRI_APP_DEPEND - 1) so they are ready for dependent modules. Change-Id: I27f4f3810a95b6be8a5bfbf62be2ace6bfab6ff3	8 years ago
Kevin Harwell	ecdccb8071	pjsip_options: contacts sometimes not being updated on reload ... For both dynamic and static contacts it was possible that potential AOR changes were not being applied to all contacts. This was because the qualify and schedule code was only retrieving AOR's, and contacts with frequencies greater than zero. For instance the following could happen: and AOR/contact has a frequency of 5, it then gets set to 0, and then a reload occurs. All scheduled OPTIONS are stopped, a list of AOR's is retrieved with frequency > 0, but none are selected since in this scenario all are 0. The contact for the one previously set to 5 though does not get updated, so it's status remains "AVAILABLE". This patch makes it so all contacts (static and dynamic) are selected, and appropriately updated if need be. ASTERISK-27467 #close Change-Id: I7a920170f89c683af9505d4723a44fc6841decdb	8 years ago
Kevin Harwell	f20ab2b65f	pjsip_options: dynamic contact's fields not updated on reload ... Dynamic contacts were not being properly updated on reload. As a matter of fact any changes to the AOR that a dynamic contact was associated with were not being applied. On reload, this patch makes it so for each dynamic contact, the associated AOR is now retrieved and the AOR's fields are applied to the contact. ASTERISK-27467 Change-Id: I8e3165dc6a745218c1c9db837f77fafa0516985d	8 years ago
Jenkins2	54a86779a3	Merge "translate: Skip matrix_rebuild during shutdown." into 13	8 years ago
Jenkins2	ac7501b15c	Merge "CLI: Fix remote console completion." into 13	8 years ago
Jenkins2	9bf73ae1b3	Merge "sounds_index: Avoid repeatedly reindexing." into 13	8 years ago
Jenkins2	58addb1e38	Merge "media_index: Improve startup." into 13	8 years ago
Corey Farrell	5a0dcd9275	CLI: Fix remote console completion. ... Duplicate checking was done incorrectly when parsing completion options from a remote console causing all options to be ignored as duplicates. Once fixed I had to separate processing of the best match to ensure it was not identified as a duplicate when it is the only match. ASTERISK-27465 Change-Id: Ibbdb29f88211742071836c9b3f4d2aa1221cd0f9	8 years ago
Corey Farrell	2691ee68ce	translate: Skip matrix_rebuild during shutdown. ... Change-Id: I1e5eef4029cba56e33d786c5a5ade8091e531a1e	8 years ago
Corey Farrell	db6602f6f7	sounds_index: Avoid repeatedly reindexing. ... The sounds index is rebuilt each time a format is registered or unregistered. This causes the index to be repeatedly rebuilt during startup and shutdown. This patch significantly reduces the work done by delaying sound index initialization until after modules are loaded. This way a reindex only occurs if a format module is loaded after startup. We also skip reindexing when format modules are unloaded during shutdown. Change-Id: I585fd6ee04200612ab1490dc804f76805f89cf0a	8 years ago
Corey Farrell	289549d659	media_index: Improve startup. ... This eliminates some wasteful operations in media_index startup. * Replace statically set string-fields with char[0]. * Eliminate pointless RAII_VAR's. * alloc_variant: Avoid pointless ao2_find on new info->variant. * Stop trying find_variant before alloc_variant. * process_media_file: replace ast_str with ast_asprintf. This avoids reallocation of file_id_str. Overall sounds_index.c is about 27% of Asterisk startup time when using sample configs. This patch reduces it to 20%. This is a half-fix. The real problem is that the media_index is regenerated repeatedly - 68 times in my test. Change-Id: Ia50b752f8efb356f852b05c4be495a6631af8652	8 years ago
Richard Mudgett	f59a75c6fa	CDR: Fix deadlock setting some CDR values. ... Setting channel variables with the AMI Originate action caused a deadlock when you set CDR(amaflags) or CDR(accountcode). This path has the channel locked when the CDR function is called. The CDR function then synchronously passes the job to a stasis thread. The stasis handling function then attempts to lock the channel. Deadlock results. * Avoid deadlock by making the CDR function handle setting amaflags and accountcode directly on the channel rather than passing it off to the CDR processing code under a stasis thread to do it. * Made the CHANNEL function and the CDR function process amaflags the same way. * Fixed referencing the wrong message type in cdr_prop_write(). ASTERISK-27460 Change-Id: I5eacb47586bc0b8f8ff76a19bd92d1dc38b75e8f	8 years ago
Richard Mudgett	93859f9aca	bridge_basic.c: Update transfer diagnostic messages addendum. ... * Added start DTMF transfer verbose messages. * Made associated transfer messages use a similar message format. * Adjusted message verbose level as requested by initial reporter. ASTERISK-27449 Change-Id: I2045714586414b3c5ef1f3cc56c1c4af4b31f551	8 years ago
Jenkins2	8e6aedbdcd	Merge "bridge_basic.c: Update transfer diagnostic messages." into 13	8 years ago
Jenkins2	0ff3694979	Merge "Add new object for VoicemailUserEntry" into 13	8 years ago
Joshua Colp	c4fe9ff002	Merge "res_rtp_asterisk.c: Increase strictrtp learning timeout time." into 13	8 years ago
Joshua Colp	466f9035f5	Merge "pjproject: Clean up disabling of WebRTC support." into 13	8 years ago
Niklas Larsson	aacdbdcfd2	bridge_basic.c: Update transfer diagnostic messages. ... * Add the channel name to diagnostic messages so you will know which channel failed to transfer. * Promoted some debug messages to verbose 4 messages. ASTERISK-27449 #close Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880	8 years ago
Richard Mudgett	594faa192d	security-events: Fix SuccessfulAuth using_password declaration. ... The SuccessfulAuth using_password field was declared as a pointer to a uint32_t when the field was later read as a uint32_t value. This resulted in unnecessary casts and a non-portable field value reinterpret in main/security_events.c:add_json_object(). i.e., It would work on a 32 bit architecture but not on a 64 bit big endian architecture. Change-Id: Ia08bc797613a62f07e5473425f9ccd8d77c80935	8 years ago
Sungtae Kim	e7201c93cc	Add new object for VoicemailUserEntry ... Currently, when the app_voicemail sending VoicemailUserEntry AMI event, there's no OldMessageCount info for default. To check the OldMessageCount info, it required IMAP_STORAGE define, but this is not correct. Added OldMessageCount item as a default. ASTERISK-27456 Change-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7	8 years ago
Joshua Colp	c80595a852	Merge "res_rtp_asterisk: Correct default in sample configuration file." into 13	8 years ago
Richard Mudgett	9330eacc50	res_rtp_asterisk.c: Increase strictrtp learning timeout time. ... More complicated direct media reinvite negotiations can result in longer delays before direct media flows. The strictrtp learning timeout time was too short. One log showed that the first RTP packet came in just after three seconds. * Increase the strictrtp learning timeout time from 1.5 to 5 seconds. ASTERISK-27453 Change-Id: Ic5e711164cbb91b4d1c1e40c83697755640f138c	8 years ago
Jenkins2	43ffae44c7	Merge "README-SERIOUSLY.bestpractices.txt: Convert to markdown" into 13	8 years ago
Jenkins2	c0d1f447ba	Merge "autoconf: Remove use of m4_ifblank." into 13	8 years ago
Jenkins2	7e4bd0cf69	Merge "config: Speed up config template lookup" into 13	8 years ago
Alexander Traud	e819cf7826	res_rtp_asterisk: Correct default in sample configuration file. ... With Asterisk 12 (commit 866d968), the default of "icesupport" changed to - "yes" in the module "res_rtp_asterisk" and - "no" in the module "chan_sip". The latter was reflected in the sample configuration file for "sip.conf". The former did not make it into "rtp.conf.sample". ASTERISK-20643 Change-Id: I2a2e0a900455d0767a99ea576e30adc6d7608a36	8 years ago
Jenkins2	9e9dccd293	Merge "config: Speed up ACO & sorcery initialization" into 13	8 years ago
Jenkins2	59bb2c1920	Merge "res_http_post: Not all versions of gmime have GMIME_MAJOR_VERSION." into 13	8 years ago
Joshua Colp	41c14fd807	pjproject: Clean up disabling of WebRTC support. ... The definition in config_site.h and the argument to the configure script are not necessary to disable WebRTC support. The correct argument, --disable-libwebrtc, is already passed. ASTERISK-26980 Change-Id: I27da2c894f87914956a72710222e17462d8a44bc	8 years ago
Corey Farrell	f5cfd87c4a	autoconf: Remove use of m4_ifblank. ... The m4_ifblank macro is not available on CentOS 6, reverse conditionals to allow use of m4_ifval instead. ./bootstrap.sh was run but this patch does not result in any difference to the generated configure script. Change-Id: I280785deb872ed8d3339d99cce63a2b54d5f1438	8 years ago
Corey Farrell	ef25628b10	README-SERIOUSLY.bestpractices.txt: Convert to markdown ... Follow-up to conversion of README.md. Change-Id: I17ee7cf25bc027ece844efa2c1dfe613aff1e35b	8 years ago
George Joseph	0cdd31ee10	AST-2017-013: chan_skinny: Call pthread_detach when sess threads end ... chan_skinny creates a new thread for each new session. In trying to be a good cleanup citizen, the threads are joinable and the unload_module function does a pthread_cancel() and a pthread_join() on any sessions that are active at that time. This has an unintended side effect though. Since you can call pthread_join on a thread that's already terminated, pthreads keeps the thread's storage around until you explicitly call pthread_join (or pthread_detach()). Since only the module_unload function was calling pthread_join, and even then only on the ones active at the tme, the storage for every thread/session ever created sticks around until asterisk exits. * A thread can detach itself so the session_destroy() function now calls pthread_detach() just before it frees the session memory allocation. The module_unload function still takes care of the ones that are still active should the module be unloaded. ASTERISK-27452 Reported by: Juan Sacco Change-Id: I9af7268eba14bf76960566f891320f97b974e6dd	8 years ago
Sean Bright	6635ddc819	config: Speed up config template lookup ... ast_category_get() has an (undocumented) implementation detail where it tries to match the category name first by an explicit pointer comparison and if that fails falls back to a normal match. When initially building an ast_config during ast_config_load, this pointer comparison can never succeed, but we will end up iterating all categories twice. As the number of categories using a template increases, this dual looping becomes quite expensive. So we pass a flag to category_get_sep() indicating if a pointer match is even possible before trying to do so, saving us a full pass over the list of current categories. In my tests, loading a file with 3 template categories and 12000 additional categories that use those 3 templates (this file configures 4000 PJSIP endpoints with AOR & Auth) takes 1.2 seconds. After this change, that drops to 22ms. Change-Id: I59b95f288e11eb6bb34f31ce4cc772136b275e4a	8 years ago
Sean Bright	077ceacd48	config: Speed up ACO & sorcery initialization ... When starting Asterisk in the foreground, there is a perceptible delay when loading modules that use the ACO and sorcery config frameworks. For example, a lightly configured res_pjsip took 853ms to load on my VM. I tracked down the slowness to the XPath queries used to associate the relevant documentation with the config options. One improvement was adding a call to xmlXPathOrderDocElems after loading an XML document. From the libxml2 docs: Call this routine to speed up XPath computation on static documents. The second change was to remove recursive descent and wildcard operators from the XPath queries. After these changes, res_pjsip takes 85ms to load on my VM and there is no longer a perceptible delay when starting Asterisk in the foreground. Change-Id: I45d457f1580e26bf5a2b0dab16e8e9ae46dcbd82	8 years ago
Joshua Colp	dac70daf1b	res_http_post: Not all versions of gmime have GMIME_MAJOR_VERSION. ... This change makes the presence of the GMIME_MAJOR_VERSION definition optional, as not all versions of gmime actually define it. ASTERISK-27454 Change-Id: I01d99590045971ed6787899147170a5954077238	8 years ago