5541 Commits (d3cfcc0da6b7e675d6779fa006abd2cc3d77d809)

Author	SHA1	Message	Date
Corey Farrell	d3cfcc0da6	Build System: Fix build failure caused by recent CLI improvements. ... We use the editline library to help with filename completion in our CLI interface. Some systems failed to find the header when included from loader.c. This is fixed by setting the proper CFLAGS for the build of loader.o. ASTERISK-27378 Change-Id: Ib7fd496f1d7ed48141a2eadd5dd61cab2f2308be	8 years ago
Corey Farrell	bfb0f27c87	Modules: Additional improvements to CLI completion. ... Replace 'needsreload' argument with a 'type' argument to specify which type of modules you want completion. This provides more accurate CLI completion for load and unload commands. * 'module unload' now excludes modules that have active references or are not running. * 'module load' now excludes modules that are already running. * 'core set debug [atleast] <level> [module]' shows running modules only. ASTERISK-27378 Change-Id: Iea3e00054461484196c46f688f02635cc886bad1	8 years ago
Kevin Harwell	a7c00707a5	features: Bridge application's BRIDGERESULT not appropriately set ... The dialplan application "Bridge" was not setting the BRIDGERESULT to failure when a failure did occur. Even worse if it did fail to join the bridge it would still report success. This patch now sets the BRIDGERESULT variable to an appropriate value for a given condition state. Also, removed the value INCOMPATIBLE as a valid result type since it is no longer used. ASTERISK-27369 #close Change-Id: I22588e7125a765edf35cff28c98ca143e9927554	8 years ago
Jenkins2	71d3f2cb90	Merge "Build System: Fix --disable-xmldoc option." into 13	8 years ago
Corey Farrell	cee81b3c8b	Modules: Fix issues with CLI completion. ... * Stop using ast_module_helper to check if a module is loaded, use ast_module_check instead (app_confbridge and app_meetme). * Stop ast_module_helper from listing reload classes when needsreload was not requested. ASTERISK-27378 Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239	8 years ago
Richard Mudgett	ca7f3d297b	codec.c: Defensively check the returned samples. ... Earlier versions of the codec_opus samples_count callback can return negative error values on undecodable frames. This resulted in a divide by zero exception. * Added a defensive check in ast_codec_samples_count() for a "negative" samples count return value. Log the event and set the count to zero. ASTERISK-27194 Change-Id: Icf69350307ecbbc80a3d74de46af9bd80ea17819	8 years ago
Joshua Colp	28368b3553	Merge "http.c: Fix http header send content." into 13	8 years ago
Corey Farrell	4772849016	Build System: Fix --disable-xmldoc option. ... The configure option to disable XML documentation does not currently work. This patch makes it effective, but also causes an ABI change by removing the ast_xmldoc_* symbols. Disabling xmldoc also prevents docs from being automatically generated, but they can still be manually generated with 'make doc/core-en_US.xml'. ASTERISK-26639 Change-Id: Ifac562340c09f80c83e0203de098fcac93bf8c44	8 years ago
Ben Ford	dfe00b80e7	http.c: Fix http header send content. ... Currently ast_http_send barricades a portion of the content that needs to be sent in order to establish a connection for things like the ARI client. The conditional and contents have been changed to ensure that everything that needs to be sent, will be sent. ASTERISK-27372 Change-Id: I8816d2d8f80f4fefc6dcae4b5fdfc97f1e46496d	8 years ago
Corey Farrell	23d05ebc49	hashtab: Use ast_free. ... A few places in hashtab use free instead of ast_free. Change-Id: I2ff089bad71640c03c3ce97f1b00fc962ef79427	8 years ago
Corey Farrell	ec278955a3	main/Makefile: Remove rule for non-existant testexpr2. ... Change-Id: Ibb3e47f27a395d74d8c5263db015b05434f5969b	8 years ago
Richard Mudgett	7f8c212e75	cdr.c: Rename the Party A CDR container. ... * Rename the Party A CDR container from active_cdrs_by_channel to active_cdrs_master. * Renamed the support functions associated with active_cdrs_master appropriately. ASTERISK-27335 Change-Id: I6104bb3edc3a0b7243ce502e45e8832b0cff14f7	8 years ago
Richard Mudgett	85723a9e50	cdr.c: Add container to key off of Party B channel names. ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is because of a n*m loop used when processing Party B information. * Added a new CDR container that is keyed to Party B so we don't need such a large loop when processing Party B information. NOTE: To reduce the size of the patch I deferred to another patch the renaming of the Party A active_cdrs_by_channel container to active_cdrs_master and renaming the container's hash and cmp functions appropriately. ASTERISK-27335 Change-Id: I0bf66e8868f8adaa4b5dcf9e682e34951c350249	8 years ago
Tzafrir Cohen	944e500e95	declare optional openssl dependencies in moduleinfo ... Declare optional openssl dependencies in: * res_rtp_asterisk.c * tcptls.c ASTERISK-27328 #close Change-Id: I2636f1c05b8104b4fe6f36cce0ebd9a98b9c78ab	8 years ago
Jenkins2	ce0ef34020	Merge "ast_bt_get_symbols: Prevent double-free." into 13	8 years ago
Jenkins2	3b1324b13e	Merge "tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it." into 13	8 years ago
Jenkins2	6fc88e80e8	Merge "cdr.c: Eliminated many calls to ao2_global_obj_ref()." into 13	8 years ago
Jenkins2	31cbb53a0a	Merge "cdr.c: Defer getting ao2_global_obj_ref() until needed." into 13	8 years ago
Jenkins2	bf21ba9c2d	Merge "cdr.c: Set stringfields only if they are different." into 13	8 years ago
Jenkins2	d0cd6cb1a7	Merge "cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr" into 13	8 years ago
Corey Farrell	89f11364f6	ast_bt_get_symbols: Prevent double-free. ... It's possible for bfdobj to be created but syms not created. If syms was not allocated in the current loop iteration but was allocated in the previous iteration it would crash. ASTERISK-27340 Change-Id: I5b110c609f6dfe91339f782a99a431bca5837363	8 years ago
Alexander Traud	114ed320ea	tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it. ... This avoids a crash on stopping a chan_sip which failed to start its TLS server. ASTERISK-27339 #close Change-Id: I327fc70db68eaaca5b50a15c7fd687fde79263d5	8 years ago
Joshua Colp	7215d07ca2	Merge "features, manager : Add CancelAtxfer AMI action" into 13	8 years ago
Richard Mudgett	a8c6c3bd7d	cdr.c: Eliminated many calls to ao2_global_obj_ref(). ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is we were getting the global config to determine if we needed to log a debugging message. * Many calls to ao2_global_obj_ref() were just so we could determine if debug mode is enabled. Made a global flag to check instead. * Eliminated many RAII_VAR() usages associated with the remaining ao2_global_obj_ref() calls. * Added missing NULL checks for the returned ao2_global_obj_ref() value. ASTERISK-27335 Change-Id: Iceaad93172862f610cad0188956634187bfcc7cd	8 years ago
Richard Mudgett	b56fa63db8	cdr.c: Defer getting ao2_global_obj_ref() until needed. ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is we were getting the global config even if we didn't need it. * Most uses of the global config were only needed on off nominal code paths so it makes sense to not get it until absolutely needed. ASTERISK-27335 Change-Id: I00c63b7ec233e5bfffd5d976f05568613d3c2365	8 years ago
Richard Mudgett	92c5cf3920	cdr.c: Set stringfields only if they are different. ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is we were repeatedly setting string fields to potentially the same string in base_process_party_a(). Setting a string field involves allocating room for the new string out of a memory pool which may have to allocate even more memory. * Check to see if the string field is already set to the desired string. ASTERISK-27335 Change-Id: I3ccb7e23f1488417e08cafe477755033eed65a7c	8 years ago
Richard Mudgett	6393c106ca	cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr ... The string comparisons for setting these CDR variables was inverted. We were repeatedly setting these CDR variables only if the channel snapshots had the same value. ASTERISK-27335 Change-Id: I9482073524411e7ea6c03805b16de200cb1669ea	8 years ago
Thomas Sevestre	6d3ee9fb93	features, manager : Add CancelAtxfer AMI action ... Add action to cancel feature attended transfer with AMI interface ASTERISK-27215 #close Change-Id: Iab8a81362b5a1757e2608f70b014ef863200cb42	8 years ago
Richard Mudgett	5f6bad6733	cdr.c: Defer misc checks. ... Try to defer some checks until needed in case there is an early exit. Change-Id: Ibc6b34c38a4f60ad4f9b67984b7d070a07257064	8 years ago
Richard Mudgett	42fdfffefc	cdr.c: Eliminated simple RAII_VAR usages. ... Change-Id: I150505db307249a962987e7b941bdd369bb91f35	8 years ago
Jenkins2	2f3d3881d4	Merge "tcptls: Do not re-bind to wildcard on client creation." into 13	8 years ago
Joshua Colp	ce26554b51	Merge "cdr.h: Fix doxygen comments." into 13	8 years ago
Jenkins2	dedd5abfe2	Merge "cdr.c: Replace redundant check with an ast_assert()" into 13	8 years ago
Jenkins2	dc524825a9	Merge "cdr.c: Use current ao2 flag names" into 13	8 years ago
Richard Mudgett	128f7ffaa2	cdr.c: Replace redundant check with an ast_assert() ... The only caller of cdr_object_fn_table.process_party_b() explicitly does the check before calling. Change-Id: Ib0c53cdf5048227842846e0df9d2c19117c45618	8 years ago
Richard Mudgett	3525081a7c	cdr.c: Replace inlined code with ao2_t_replace() ... Change-Id: I9f424f5282ca7d833592f958d95f1b2bafb549b0	8 years ago
Richard Mudgett	7366657a9a	cdr.c: Use current ao2 flag names ... Change-Id: Ib59d7d2f2a4a822754628f2c48a308d6791a6e6e	8 years ago
Richard Mudgett	34d55352a5	cdr.h: Fix doxygen comments. ... * Also some misc formatting in cdr.c. Change-Id: Ied89a28802a662c37c43326a1aafdce596e0df4a	8 years ago
Alexander Traud	209916981a	tcptls: Do not re-bind to wildcard on client creation. ... Since ASTERISK-26922, this issue affected only those chan_sip which were * enabled for dual-stack (bindaddr=::), and * enabled for TCP (tcpenable=yes) and/or TLS (tlsenable=yes), and * tried to register and/or invite a IPv4-only service, * via TCP and/or TLS. Now, ast_tcptls_client_create does not re-bind to [::] anymore. ASTERISK-27324 #close Change-Id: I4b242837bdeb1ec7130dc82505c6180a946fd9b5	8 years ago
Corey Farrell	462dd7c2de	main/strings: Fix uninitialized value. ... ast_strings_match uses sscanf and checks for non-zero return to verify a token was parsed. This is incorrect as sscanf returns EOF (-1) for errors. ASTERISK-27318 #close Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1	8 years ago
Richard Mudgett	a433bb38b5	heap.c: No need to calloc heap pointer array. ... Change-Id: I5ae2f316229f336eb90d99c7af7ed07a33097e68	8 years ago
Richard Mudgett	8d2c3effc2	channel.c: Fix invalid reference in conditionaled out code. ... ASTERISK-27289 Change-Id: I7a415948116493050614d9f4fa91ffbe0c21ec4c	8 years ago
Jean Aunis	da40976987	bridge : Fix one-way direct-media when early bridging with native_rtp ... When two channels were early bridged in a native_rtp bridge, the RTP description on one side was not updated when the other side answered. This patch forbids non-answered channels to enter a native_rtp bridge, and triggers a bridge reconfiguration when an ANSWER frame is received. ASTERISK-27257 Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df	8 years ago
Alexander Traud	cfc0ca1fb5	tcptls: Fixed a white space error. ... ASTERISK-26606 Change-Id: I81a7268ef7ba012d4d80d44c70b6276d48e397fa	8 years ago
George Joseph	ed2a4ee81e	res_pjsip: Add handling for incoming unsolicited MWI NOTIFY ... A new endpoint parameter "incoming_mwi_mailbox" allows Asterisk to receive unsolicited MWI NOTIFY requests and make them available to other modules via the stasis message bus. res_pjsip_pubsub has a new handler "pubsub_on_rx_mwi_notify_request" that parses a simple-message-summary body and, if endpoint->incoming_mwi_account is set, calls ast_publish_mwi_state with the voice-message counts from the message. Change-Id: I08bae3d16e77af48fcccc2c936acce8fc0ef0f3c	8 years ago
George Joseph	186ef1a657	stasis/control: Fix possible deadlock with swap channel ... If an error occurs during a bridge impart it's possible that the "bridge_after" callback might try to run before control_swap_channel_in_bridge has been signalled to continue. Since control_swap_channel_in_bridge is holding the control lock and the callback needs it, a deadlock will occur. * control_swap_channel_in_bridge now only holds the control lock while it's actually modifying the control structure and releases it while the bridge impart is running. * bridge_after_cb is now tolerant of impart failures. Change-Id: Ifd239aa93955b3eb475521f61e284fcb0da2c3b3	8 years ago
Walter Doekes	45744fc53d	res/res_pjsip: Standardize/fix localnet checks across pjsip. ... In 2dee95cc (ASTERISK-27024) and 776ffd77 (ASTERISK-26879) there was confusion about whether the transport_state->localnet ACL has ALLOW or DENY semantics. For the record: the localnet has DENY semantics, meaning that "not in the list" means ALLOW, and the local nets are in the list. Therefore, checks like this look wrong, but are right: /* See if where we are sending this request is local or not, and if not that we can get a Contact URI to modify */ if (ast_apply_ha(transport_state->localnet, &addr) != AST_SENSE_ALLOW) { ast_debug(5, "Request is being sent to local address, " "skipping NAT manipulation\n"); (In the list == localnet == DENY == skip NAT manipulation.) And conversely, other checks that looked right, were wrong. This change adds two macro's to reduce the confusion and uses those instead: ast_sip_transport_is_nonlocal(transport_state, addr) ast_sip_transport_is_local(transport_state, addr) ASTERISK-27248 #close Change-Id: Ie7767519eb5a822c4848e531a53c0fd054fae934	8 years ago
Sean Bright	55f30c29fd	rtp_engine: Prevent possible double free with DTLS config ... ASTERISK-27225 #close Reported by: Richard Kenner Change-Id: I097b81734ef730f8603c0b972909d212a3a5cf89	8 years ago
Corey Farrell	04ee3eb774	AST-2017-006: Fix app_minivm application MinivmNotify command injection ... An admin can configure app_minivm with an externnotify program to be run when a voicemail is received. The app_minivm application MinivmNotify uses ast_safe_system() for this purpose which is vulnerable to command injection since the Caller-ID name and number values given to externnotify can come from an external untrusted source. * Add ast_safe_execvp() function. This gives modules the ability to run external commands with greater safety compared to ast_safe_system(). Specifically when some parameters are filled by untrusted sources the new function does not allow malicious input to break argument encoding. This may be of particular concern where CALLERID(name) or CALLERID(num) may be used as a parameter to a script run by ast_safe_system() which could potentially allow arbitrary command execution. * Changed app_minivm.c:run_externnotify() to use the new ast_safe_execvp() instead of ast_safe_system() to avoid command injection. * Document code injection potential from untrusted data sources for other shell commands that are under user control. ASTERISK-27103 Change-Id: I7552472247a84cde24e1358aaf64af160107aef1	8 years ago
Matt Jordan	fff2f68616	main/app: Only look to end of file if ':end' is specified, and not just ':' ... There is a little known feature in app_controlplayback that will cause the specified offset to be used relative to the end of a file if a ':end' is detected within the filename. This feature is pretty bad, but okay. However, a bug exists in this code where a ':' detected in the filename will cause the end pointer to be non-NULL, even if the full ':end' isn't specified. This causes us to treat an unspecified offset (0) as being "start playing from the end of the file", resulting in no file playback occurring. This patch fixes this bug by resetting the end pointer if ':end' is not found in the filename. ASTERISK-23608 #close Reported by: Jonathan White Change-Id: Ib4c7b1b45283e4effd622a970055c51146892f35 (cherry picked from commit 13efea24f7)	8 years ago