asterisk

Commit Graph

Author	SHA1	Message	Date
Richard Mudgett	cef5e9d434	Merged revisions 313188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r313188 \| rmudgett \| 2011-04-11 10:27:52 -0500 (Mon, 11 Apr 2011) \| 25 lines Stuck channel using FEATD_MF if caller hangs up at the right time. The cause was actually a caller hanging up just at the end of the Feature Group D DTMF tones that setup the call. The reason for this is a "guard timer" that's implemented using ast_safe_sleep(100). If the caller happens to hang up AFTER the final tone of the DTMF string but BEFORE the end of that ast_safe_sleep(), then ast_safe_sleep() will return non-zero. This causes the code to bounce to the end of ss_thread(), but it does NOT tear down the call properly. This should be a rare occurrence because the caller has to hang up at EXACTLY the right time. Nonetheless, it was happening quite regularly on the reporter's system. It's not easily reproducible, unless you purposely increase the guard-time to 2000 or more. Once you do that, you can reproduce it every time by watching the DTMF debug and hanging up just as it ends. Simply add an ast_hangup() before goto quit. (closes issue #15671) Reported by: jcromes Patches: issue15671.patch uploaded by pabelanger (license 224) Tested by: jcromes ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@313189 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	389b2a6907	Merged revisions 312573 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r312573 \| rmudgett \| 2011-04-04 10:49:30 -0500 (Mon, 04 Apr 2011) \| 38 lines Issues with ISDN calls changing B channels during call negotiations. The handling of the PROCEEDING message was not using the correct call structure if the B channel was changed. (The same for PROGRESS.) The call was also not hungup if the new B channel is not provisioned or is busy. * Made all call connection messages (SETUP_ACKNOWLEDGE, PROCEEDING, PROGRESS, ALERTING, CONNECT, CONNECT_ACKNOWLEDGE) ensure that they are using the correct structure and B channel. If there is any problem with the operations then the call is now hungup with an appropriate cause code. * Made miscellaneous messages (INFORMATION, FACILITY, NOTIFY) find the correct structure by looking for the call and not using the channel ID. NOTIFY is an exception with versions of libpri before v1.4.11 because a call pointer is not available for Asterisk to use. * Made all hangup messages (DISCONNECT, RELEASE, RELEASE_COMPLETE) find the correct structure by looking for the call and not using the channel ID. (closes issue #18313) Reported by: destiny6628 Tested by: rmudgett JIRA SWP-2620 (closes issue #18231) Reported by: destiny6628 Tested by: rmudgett JIRA SWP-2924 (closes issue #18488) Reported by: jpokorny JIRA SWP-2929 JIRA AST-437 (The issues fixed here are most likely causing this JIRA issue.) JIRA DAHDI-406 JIRA LIBPRI-33 (Stuck resetting flag likely fixed) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@312574 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jason Parker	a31990174b	Fix usage of "hasvoicemail=yes" and "mailbox=" in users.conf for SIP. Since it's a duplicate, nothing is going to be done, so delme doesn't need to be set at all. Strangely, when this was added, this was being set to 1 in 1.6, and 0 in trunk. (issue AST-439) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@309255 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	a3ff344e12	Fixes thread blocking issue in the sip TCP/TLS implementation. (closes issue #18497) Reported by: vois Patches: issues_18497.diff uploaded by dvossel (license 671) Tested by: vois, rossbeer, kowalma, Freddi_Fonet git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@309083 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	7c140ca0b5	Use remotesecret to authenticate with a remote party The remotesecret option was only being used for outbound registration and not for placing calls. This patch uses remotesecret on outbound calls if it is set, otherwise secret is still used. Review: https://reviewboard.asterisk.org/r/1107/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@308678 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	368f8fc4cd	Merged revisions 307623 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r307623 \| rmudgett \| 2011-02-10 18:29:17 -0600 (Thu, 10 Feb 2011) \| 13 lines Reentrancy problem if outgoing call gets different B channel than requested. The chan_dahdi pri_fixup_principle() routine needs to protect the Asterisk channel with the channel lock when it changes the technology private pointer to a new private structure. * Added lock protection while pri_fixup_principle() moves a call from one private structure to another. * Made some pri_fixup_principle() messages more meaningful. Partial backport from v1.8 -r300714. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@307624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	5fd699dad0	Merged revisions 306972 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r306972 \| twilson \| 2011-02-08 12:05:13 -0800 (Tue, 08 Feb 2011) \| 2 lines Fix comparison for REFER Replaces tags with pedantic=yes ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@306973 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	bf7aea5263	Merged revisions 306617 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r306617 \| twilson \| 2011-02-07 13:51:43 -0800 (Mon, 07 Feb 2011) \| 10 lines Don't allow a REFER w/replaces to replace its own dialog Asterisk currently accepts a REFER with a Refer-To with an embedded Replaces header that matches the dialog of the REFER. This would be a situation like A calls B, A calls C, A transfers B to A, which is just silly. This patch makes the transfer fail instead of making Asterisk freak out and forget to hang other channels up. Review: https://reviewboard.asterisk.org/r/1093/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@306618 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	56ec0fc138	Merged revisions 306119 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r306119 \| twilson \| 2011-02-03 12:36:34 -0800 (Thu, 03 Feb 2011) \| 9 lines Set hangup cause in local_hangup When a call involves a local channel (like SIP -> Local -> SIP), the hangup cause was not being set. This resulted in SIP channels sometimes getting a 503 error instead of a 486 when the far side sent a busy. In Asterisk 1.8+ this also can cause issues with CCSS that involve a local channel. This patch sets the hangupcause for one side of the local channel to the other in local_hangup for outbound calls. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@306126 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	050a3c39ec	Merged revisions 305888 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r305888 \| rmudgett \| 2011-02-02 18:02:43 -0600 (Wed, 02 Feb 2011) \| 8 lines Minor AST_FRAME_TEXT related issues. * Include the null terminator in the buffer length. When the frame is queued it is copied. If the null terminator is not part of the frame buffer length, the receiver could see garbage appended onto it. * Add channel lock protection with ast_sendtext(). * Fixed AMI SendText action ast_sendtext() return value check. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@305889 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Andrew Latham	54dcf83e13	Replace link to old doc with new wiki page. Link to https://wiki.asterisk.org/wiki/display/AST/SIP+Retransmissions git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@305752 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	5f6b31daae	Merged revisions 305341 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r305341 \| rmudgett \| 2011-01-31 17:45:58 -0600 (Mon, 31 Jan 2011) \| 7 lines Obtain the pri lock for PRI queue counters. Need to obtain the pri lock when calling pri_dump_info_str() to avoid a reentrancy problem when calculating the Q.921 Q count statistic. JIRA AST-484 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@305342 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jason Parker	1dbde4531e	Merged revisions 305252 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r305252 \| qwell \| 2011-01-31 16:56:54 -0600 (Mon, 31 Jan 2011) \| 10 lines Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/)) chan_iax2 and other channel drivers already had code to prevent this. The attempt that app_dial was making to prevent it was not correct, so I fixed that. (closes issue #18371) Reported by: gbour Patches: 18371.patch uploaded by gbour (license 1162) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@305253 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	afaf018322	Merged revisions 304241 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r304241 \| mnicholson \| 2011-01-26 14:38:22 -0600 (Wed, 26 Jan 2011) \| 6 lines This patch modifies chan_sip to route responses to the address the request came from. It also modifies chan_sip to respect the maddr parameter in the Via header. ABE-2664 Review: https://reviewboard.asterisk.org/r/1059/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@304244 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	48e5b9d57c	Merged revisions 304148 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier .......... r304148 \| rmudgett \| 2011-01-26 13:23:46 -0600 (Wed, 26 Jan 2011) \| 2 lines Update documentation for DAHDISendCallreroutingFacility() application. .......... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@304149 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	11110b1ead	Merged revisions 303906 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r303906 \| twilson \| 2011-01-25 14:50:59 -0600 (Tue, 25 Jan 2011) \| 16 lines Guard against retransmitting BYEs indefinitely In the case of an attended transfer (A calls B, A atxfers to C) where A becomes unreachable before replying to Asterisk's BYE, Asterisk can sometimes retransmit the BYE indefinitely. This is because __sip_autodestruct tests p->refer && !ast_test_flag(&p->flags[0], SIP_ALREADYGONE and will then transmit a BYE. When this BYE times out, it will not ever be marked as ALREADYGONE, so when __sip_autodestruct is called again, we end up starting the cycle over. This patch adds a call to sip_alreadygone(pkt->owner) in retrans_pkt in the case of a BYE that has timed out. This should prevent Asterisk from trying to transmit new BYE messages in the future. Review: https://reviewboard.asterisk.org/r/1077/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@303960 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	0585c53d3f	Fix "sip show user <tab>", so that it actually shows results, instead of just completing the last entry. (closes issue #16675) Reported by: pj git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@303858 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	569f4c6604	Merged revisions 303765 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r303765 \| rmudgett \| 2011-01-25 11:36:50 -0600 (Tue, 25 Jan 2011) \| 40 lines Sending out unnecessary PROCEEDING messages breaks overlap dialing. Issue #16789 was a good idea. Unfortunately, it breaks overlap dialing through Asterisk. There is not enough information available at this point to know if dialing is complete. The ast_exists_extension(), ast_matchmore_extension(), and ast_canmatch_extension() calls are not adequate to detect a dial through extension pattern of "_9!". Workaround is to use the dialplan Proceeding() application early in non-dial through extensions. * Effectively revert issue #16789. * Allow outgoing overlap dialing to hear dialtone and other early media. A PROGRESS "inband-information is now available" message is now sent after the SETUP_ACKNOWLEDGE message for non-digital calls. An AST_CONTROL_PROGRESS is now generated for incoming SETUP_ACKNOWLEDGE messages for non-digital calls. * Handling of the AST_CONTROL_CONGESTION in chan_dahdi/sig_pri was inconsistent with the cause codes. * Added better protection from sending out of sequence messages by combining several flags into a single enum value representing call progress level. * Added diagnostic messages for deferred overlap digits handling corner cases. (closes issue #17085) Reported by: shawkris (closes issue #18509) Reported by: wimpy Patches: issue18509_early_media_v1.8_v3.patch uploaded by rmudgett (license 664) Expanded upon issue18509_early_media_v1.8_v3.patch to include analog and SS7 because of backporting requirements. Tested by: wimpy, rmudgett ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@303769 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jason Parker	6d24696968	Merged revisions 303284 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r303284 \| qwell \| 2011-01-21 15:45:34 -0600 (Fri, 21 Jan 2011) \| 8 lines Reset configuration before parsing users.conf. Some values configured in chan_dahdi.conf were able to leak in to users.conf configuration. This was surprising users, and potentially setting non-sane "defaults". ASTNOW-125 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@303285 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	28cbf8801c	Merged revisions 302311 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r302311 \| mnicholson \| 2011-01-18 15:35:03 -0600 (Tue, 18 Jan 2011) \| 4 lines URI encode the user part of the contact header. ABE-2705 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@302313 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	a16089f243	Merged revisions 293493 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 [^] ........ r293493 \| twilson \| 2010-11-01 09:58:00 -0500 (Mon, 01 Nov 2010) \| 14 lines Only offer codecs both sides support for directmedia When using directmedia, Asterisk needs to limit the codecs offered to just the ones that both sides recognize, otherwise they may end up sending audio that the other side doesn't understand. (closes issue 0017403) Reported by: one47 Patches: sip_codecs_simplified4 uploaded by one47 (license 23) Tested by: one47, falves11 Review: https://reviewboard.asterisk.org/r/967/ [^] ........ Backporting a bugfix that should have been included. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@302049 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	b381052ca0	Don't reject all SUBSCRIBE auth requests When merging another SUBSCRIBE fix from 1.4, some braces were put in the wrong place. This patch fixes that. (closes issue #18597) Reported by: thsgmbh git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@301682 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Leif Madsen	f97b1161de	Fix backwards and broken XML documentation. (closes issue #18547) Reported by: jcovert Patches: xmldoc.c.patch uploaded by jcovert (license 551) chan_iax2.c.doc.patch uploaded by jcovert (license 551) chan_sip.c.patch uploaded by jcovert (license 551) chan_agent.c.patch uploaded by jcovert (license 551) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@300520 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	2722ad135e	Merged revisions 300216 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r300216 \| twilson \| 2011-01-04 11:11:48 -0600 (Tue, 04 Jan 2011) \| 15 lines Don't authenticate SUBSCRIBE re-transmissions This only skips authentication on retransmissions that are already authenticated. A similar method is already used for INVITES. This is the kind of thing we end up having to do when we don't have a transaction layer... (closes issue #18075) Reported by: mdu113 Patches: diff.txt uploaded by twilson (license 396) Tested by: twilson, mdu113 Review: https://reviewboard.asterisk.org/r/1005/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@300298 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	4c916b5474	Merged revisions 299624 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r299624 \| tilghman \| 2010-12-25 04:04:06 -0600 (Sat, 25 Dec 2010) \| 5 lines Move check for extension existence below variable inheritance, due to the possible use of an eswitch. (closes issue #16228) Reported by: jlaguilar ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@299625 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Moises Silva	76abd62c40	do not use progress which is for PRI and SS7, add mfcr2_progress member git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@299533 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Moises Silva	4e1350ed62	Enqueue AST_CONTROL_PROGRESS after AST_CONTROL_RINGING when MFC-R2 calls are accepted (closes issue #18438) Reported by: mariner7 Tested by: moy git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@299530 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	077b8b9956	Merged revisions 299194,299198,299220 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r299194 \| mnicholson \| 2010-12-20 14:45:38 -0600 (Mon, 20 Dec 2010) \| 6 lines Respond as soon as possible with a 202 Accepted to refer requests. This change also plugs a few memory leaks that can occur when parking sip calls. ABE-2656 ........ r299198 \| mnicholson \| 2010-12-20 15:00:44 -0600 (Mon, 20 Dec 2010) \| 2 lines Remove changes to via processing that were not supposed to go into the last commit. ........ r299220 \| mnicholson \| 2010-12-20 15:21:39 -0600 (Mon, 20 Dec 2010) \| 4 lines Use ast_free() instead of free() ABE-2656 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@299242 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tzafrir Cohen	c448bc9800	Typos: recieved => received git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@299003 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	edbec6bfd3	Merged revisions 298193 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r298193 \| rmudgett \| 2010-12-13 10:56:07 -0600 (Mon, 13 Dec 2010) \| 19 lines Outgoing PRI/BRI calls cannot do DTMF triggered transfers. Outgoing PRI/BRI calls cannot do DTMF triggered transfers if a PROCEEDING message is not received. The debug output shows that the DTMF begin event is seen, but the DTMF end event is missing. When the DTMF begin happens, the call is muted so we now have one way audio (until a DTMF end event is somehow seen). * Made set the proceeding flag when the PRI_EVENT_ANSWER event is received. * Made absorb the DTMF begin and DTMF end events if we are overlap dialing and have not seen a PROCEEDING message. * Added a debug message when absorbing a DTMF event. JIRA SWP-2690 JIRA ABE-2697 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@298194 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	1511efcbb3	Merged revisions 297959 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r297959 \| twilson \| 2010-12-09 16:00:30 -0600 (Thu, 09 Dec 2010) \| 14 lines Ignore spurious REGISTER requests If a REGISTER request with a Call-ID matching an existing transaction is received it was possible that the REGISTER request would overwrite the initreq of the private structure. This info is used to generate messages for other responses in the transaction. This patch ignores REGISTER requests that match non-REGISTER transactions. (closes issue #18051) Reported by: eeman Tested by: twilson Review: https://reviewboard.asterisk.org/r/1050/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@297960 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	b6e84113ef	Merged revisions 297603 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r297603 \| jpeeler \| 2010-12-06 15:57:15 -0600 (Mon, 06 Dec 2010) \| 12 lines Improve handling of REGISTER requests with multiple contact headers. The changes here attempt to more strictly follow RFC 3261 section 10.3. Basically the following will now cause a 400 Bad Response to be returned, if: - multiple Contact headers are present with one set to expire all bindings ("*") - wildcard parameter is specified for Contact without Expires header or Expires header is not set to zero. ABE-2442 ABE-2443 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@297605 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Sean Bright	049da7ba8a	The CLI command should not contain <placeholder>s, these are for descriptions. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@297534 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Olle Johansson	5b02a16a61	Merged revisions 297185 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r297185 \| oej \| 2010-12-02 09:37:17 +0100 (Tor, 02 Dec 2010) \| 5 lines If we get a NOTIFY from a non-existing subscription we should answer with 481, not bad event. If we answer 481 the subscription that we don't want will be cancelled. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@297186 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	0ad0a9b85e	Merged revisions 297072 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r297072 \| jpeeler \| 2010-12-01 11:50:09 -0600 (Wed, 01 Dec 2010) \| 23 lines Fix not stopping MOH when transfered local channel queue member is answered. The problem here is only present when local channels are used with the MOH passthru option as well as no optimization (/nm). I will describe the slightly bizarre scenario that was used to test, where phones B and C are queue members: Phone A dials into a queue with two members using local channels and the above options. Phone B answers. Phone A blind transfers phone B into the same queue. Phone A hangs up. Phone C answers, but phone B didn't stop playing MOH. In this scenario, the unhold frame that should have gotten to phone B never arrived due to the masquerade from the blind transfer. This is usually fine since app_queue manages the starting and stopping of MOH. However, with the passthrough option enabled when app_queue attempts to stop MOH it tries to do so on the local channel rather than the real channel. The easiest solution was to just make sure to send an unhold frame during the transfer since it wouldn't make sense to have MOH playing after a transfer anyway. This only modifies SIP transfers, but the other transfers did not seem to be a problem. If DTMF based transfers were a problem it might be okay to add ast_moh_stop to finishup, but I didn't want to have to add that unless required. ABE-2624 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@297073 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	2e9a3b9f28	Missed initializations caused startup errors on Mac OS X (and possibly others, too). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@296950 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Paul Belanger	7553cd7e05	Merged revisions 296670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r296670 \| pabelanger \| 2010-11-29 17:49:39 -0500 (Mon, 29 Nov 2010) \| 5 lines Make sure nothing else is needed before destroying the scheduler. (closes issue #18398) Reported by: pabelanger ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@296671 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	594c3fb180	Merged revisions 296165 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r296165 \| rmudgett \| 2010-11-24 16:41:07 -0600 (Wed, 24 Nov 2010) \| 43 lines Oneway audio to SIP phone from FXS port after FXS port gets a CallWaiting pip. The FXS connected phone has to have CW/CID support to fail, as it will send back a DTMF 'A' or 'D' when it's ready to receive CallerID. A normal phone with no CID never fails. Also the SIP phone does not hear MOH when the CW call is answered. The DTMF end frame is suppressed when the phone acknowledges the CW signal for CID. The problem is the DTMF begin frame needs to be suppressed as well. The DTMF begin frame is causing SIP to start sending the DTMF RTP frames. Since the DTMF end frame is suppressed, SIP will not stop sending those DTMF RTP packets. * Suppress the DTMF begin and end frames when the channel driver is looking for DTMF digits. * Fixed a couple issues caused by not cleaning up the CID spill if you answer the CW call while it is sending the CID spill. * Fixed not sending CW/CID spill to the phone when the call is natively bridged. (Fixed by not using native bridge if CW/CID is possible.) * Suppress received audio when sending CW/CID spills. The other parties involved do not need to hear the CW/CID spills and may be confused if the CW call is for them. (closes issue #18129) Reported by: alecdavis Patches: issue_18129_v1.8_v3.patch uploaded by rmudgett (license 664) Tested by: alecdavis, rmudgett NOTE: * v1.4 does not have the main problem fixed by suppressing the DTMF start frames. The other three items fixed are relevant. * If you really must restore native bridging between analog ports, you need to disable CW/CID either by configuring chan_dahdi.conf callwaitingcallerid=no or dialing *70 before dialing the number to temporarily disable CW. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@296166 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	5aaefe7f08	Merged revisions 295628 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r295628 \| twilson \| 2010-11-19 12:53:36 -0800 (Fri, 19 Nov 2010) \| 8 lines Discard responses with more than one Via This is not a perfect solution as headers that are joined via commas are not detected. This is a parsing issue that to fix "correctly" would necessitate a new SIP parser. Review: https://reviewboard.asterisk.org/r/1019/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@295672 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	ae933f954c	Merged revisions 294821 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r294821 \| rmudgett \| 2010-11-11 20:41:13 -0600 (Thu, 11 Nov 2010) \| 11 lines Asterisk is getting a "No D-channels available!" warning message every 4 seconds. Asterisk is just whining too much with this message: "No D-channels available! Using Primary channel XXX as D-channel anyway!". Filtered the message so it only comes out once if there is no D channel available without an intervening D channel available period. (closes issue #17270) Reported by: jmls ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@294822 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	744ece2574	Merged revisions 294688 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r294688 \| jpeeler \| 2010-11-11 15:12:27 -0600 (Thu, 11 Nov 2010) \| 18 lines Fix problem with qualify option packets for realtime peers never stopping. The option packets not only never stopped, but if a realtime peer was not in the peer list multiple options dialogs could accumulate over time. This scenario has the potential to progress to the point of saturating a link just from options packets. The fix was to ensure that the poke scheduler checks to see if a peer is in the peer list before continuing to poke. The reason a peer must be in the peer list to be able to properly manage an options dialog is because otherwise the call pointer is lost when the peer is regenerated from the database, which is how existing qualify dialogs are detected. (closes issue #16382) (closes issue #17779) Reported by: lftsy Patches: bug16382-3.patch uploaded by jpeeler (license 325) Tested by: zerohalo ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@294733 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	9e8ad57efc	Go off hold when we get an empty reinvite telling us to. (closes issue 0014448) Reported by: frawd (closes issue #17878) Reported by: frawd git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@294242 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	30e2590b1c	Merged revisions 293805 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293805 \| rmudgett \| 2010-11-03 13:23:04 -0500 (Wed, 03 Nov 2010) \| 20 lines Party A in an analog 3-way call would continue to hear ringback after party C answers. All parties are analog FXS ports. 1) A calls B. 2) A flash hooks to call C. 3) A flash hooks to bring C into 3-way call before C answers. (A and B hear ringback) 4) C answers 5) A continues to hear ringback during the 3-way call. (All parties can hear each other.) * Fixed use of wrong variable in dahdi_bridge() that stopped ringback on the wrong subchannel. * Made several debug messages have more information. A similar issue happens if B and C are SIP channels. B continues to hear ringback. For some reason this only affects v1.8 and trunk. * Don't start ringback on the real and 3-way subchannels when creating the 3-way conference. Removing this code is benign on v1.6.2 and earlier. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@293806 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	58c28ab1dc	Merged revisions 293722 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293722 \| jpeeler \| 2010-11-02 18:02:51 -0500 (Tue, 02 Nov 2010) \| 8 lines Add enabled/disabled information for rtautoclear sip show settings output. When setting to zero/"no", the numeric default was shown making it not obvious the disabled setting was respected. (closes issue #18123) Reported by: zerohalo ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@293723 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	78ea9e0ba6	Merged revisions 293639 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293639 \| rmudgett \| 2010-11-02 16:24:13 -0500 (Tue, 02 Nov 2010) \| 6 lines Make warning message have more useful information in it. Change "Unable to get index, and nullok is not asserted" to "Unable to get index for '<channel-name>' on channel <number> (<function>(), line <number>)". ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@293647 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	37b0f8edce	Merged revisions 293416 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293416 \| rmudgett \| 2010-10-29 20:45:49 -0500 (Fri, 29 Oct 2010) \| 1 line Remove some more code that serves no purpose. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@293417 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	56ff91279c	Merged revisions 293339 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293339 \| rmudgett \| 2010-10-29 19:34:12 -0500 (Fri, 29 Oct 2010) \| 1 line Remove some code that serves no purpose. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@293340 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	10892f4424	Merged revisions 292866 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r292866 \| dvossel \| 2010-10-25 14:05:07 -0500 (Mon, 25 Oct 2010) \| 27 lines This patch turns chan_local pvts into astobj2 objects. chan_local does some dangerous things involving deadlock avoidance. tech_pvt functions like hangup and queue_frame are provided with a locked channel upon entry. Those functions are completely safe as long as you don't attempt to give up that channel lock, but that is impossible to guarantee due to the required deadlock avoidance necessary to lock both the tech_pvt and both channels involved. In the past, we have tried to account for this by doing things like setting a "glare" flag that indicates what function should destroy the pvt. This was used in local_hangup and local_queue_frame to decided who should destroy the pvt if they collided in separate threads. I have removed the need to do this by converting all chan_local tech_pvts to astobj2. This means we can ref a pvt before deadlock avoidance and not have to worry about that pvt possibly getting destroyed under us. It also cleans up where we destroy the tech_pvt. The only unlink from the tech_pvt container occurs in local_hangup now, which is where it should occur. Since there still may be thread collisions on some functions like local_hangup after deadlock avoidance, I have added some checks to detect those collisions and exit appropriately. I think this patch is going to solve quite a bit of weirdness we have had with local channels in the past. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@292867 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Leif Madsen	4f361397b9	Update the LDIF file for LDAP. The LDIF file asterisk.ldif was quite a bit out of date from the asterisk.ldap-schema file, so I've now updated that to be in sync. The asterisk.ldif file being out of sync was a problem on my systems where I was doing an ldapadd to import the schema into the LDAP database, and the existing file would cause problems and ERROR messages when registering. Additional documention has been added based on feedback in the issue I'm closing. (closes issue #13861) Reported by: scramatte Patches: ldap-update.txt uploaded by lmadsen (license 10) Tested by: lmadsen, jcovert, suretec, rgenthner git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@292786 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	3c127c29a3	Merged revisions 291643 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r291643 \| rmudgett \| 2010-10-13 18:29:58 -0500 (Wed, 13 Oct 2010) \| 20 lines Deadlock between dahdi_exception() and dahdi_indicate(). There is a deadlock between dahdi_exception() and dahdi_indicate() for analog ports. The call-waiting and three-way-calling feature can experience deadlock if these features are trying to do something and an event from the bridged channel happens at the same time. Deadlock avoidance code added to obtain necessary channel locks before attemting an operation with call-waiting and three-way-calling. (closes issue #16847) Reported by: shin-shoryuken Patches: issue_16847_v1.4.patch uploaded by rmudgett (license 664) issue_16847_v1.6.2.patch uploaded by rmudgett (license 664) issue_16847_v1.8_v2.patch uploaded by rmudgett (license 664) Tested by: alecdavis, rmudgett Review: https://reviewboard.asterisk.org/r/971/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@291655 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago

1 2 3 4 5 ...

6334 Commits (cef5e9d4340f94de8801aaecfb004a080df8a68f)