2485 Commits (cb67f98a5af6b7966fd9d4ddf702a2ce568d99dd)

Author	SHA1	Message	Date
Steve Murphy	8a02ac6f79	These small documentation updates made in response to a query in ... asterisk-users, where a user was using Playback, but needed the features of Background, and had no idea that Background existed, or that it might provide the features he needed. I thought the best way to avert these kinds of queries was to provide "See Also" references in all three of "Background", "Playback", "WaitExten". Perhaps a project to do this with all related apps is in order. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@111391 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	df37925e23	This code change is made just for clarification. It does exactly ... the same thing as before. It just doesn't look as wrong. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@111121 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	453209fd16	Add a lock to the vm_state structure and use the lock around mail_open calls ... to prevent concurrent access of the same mailstream. This, along with trunk's ability to configure TCP timeouts for IMAP storage will help to prevent crashes and hangs when using voicemail with IMAP storage. (closes issue #10487) Reported by: ewilhelmsen git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@111049 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f3274be612	Fix a bug where when calls on the trunk side hang up while on hold, the state ... is not properly reflected. (closes issue #11990, reported by anakaoka, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@110163 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ebb67cf852	Add a missing unlock in the case that memory allocation fails in app_chanspy. ... Thanks to Russell for confirming that this was an issue. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@110083 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	755933863f	Fix one place where the chanspy datastore isn't removed from a channel. ... (issue #12243, reported by atis, patch by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@109763 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	89c3cd6842	This patch makes it so that all queue member status changes are handled through device state ... code. This removes several problems people were seeing where their queue members would get into an "unknown" state. Huge props go to atis on this one since he was the one who found the code section that was causing the problem and proposed the solution. I just wrote what he suggested :) (closes issue #12127) Reported by: atis Patches: 12127v3.patch uploaded by putnopvut (license 60) Tested by: atis, jvandal git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@109713 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	284f74997d	Make sure that we release the lock on the spyee channel if the spyee or spy has hung up ... (closes issue #12232) Reported by: atis git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@109012 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	efa3b46cdf	Fix another issue that was causing crashes in chanspy. This introduces a new ... datastore callback, called chan_fixup(). The concept is exactly like the fixup callback that is used in the channel technology interface. This callback gets called when the owning channel changes due to a masquerade. Before this was introduced, if a masquerade happened on a channel being spyed on, the channel pointer in the datastore became invalid. (closes issue #12187) (reported by, and lots of testing from atis) (props to file for the help with ideas) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108583 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	269d0aa7e8	Fix a couple uses of sprintf. The second one could actually cause an overflow ... of a stack buffer. It's not a security issue though, it only depends on your configuration. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108469 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a169524ff6	(closes issue #12187, reported by atis, fixed by me after some brainstorming ... on the issue with mmichelson) - Update copyright info on app_chanspy. - Fix a race condition that caused app_chanspy to crash. The issue was that the chanspy datastore magic that was used to ensure that spyee channels did not disappear out from under the code did not completely solve the problem. It was actually possible for chanspy to acquire a channel reference out of its datastore to a channel that was in the middle of being destroyed. That was because datastore destruction in ast_channel_free() was done near the end. So, this left the code in app_chanspy accessing a channel that was partially, or completely invalid because it was in the process of being free'd by another thread. The following sort of shows the code path where the race occurred: ============================================================================= Thread 1 (PBX thread for spyee chan) || Thread 2 (chanspy) --------------------------------------||------------------------------------- ast_channel_free() || - remove channel from channel list || - lock/unlock the channel to ensure || that no references retrieved from || the channel list exist. || --------------------------------------||------------------------------------- || channel_spy() - destroy some channel data || - Lock chanspy datastore || - Retrieve reference to channel || - lock channel || - Unlock chanspy datastore --------------------------------------||------------------------------------- - destroy channel datastores || - call chanspy datastore d'tor || which NULL's out the ds' || - Operate on the channel ... reference to the channel || || - free the channel || || || - unlock the channel --------------------------------------||------------------------------------- ============================================================================= git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108135 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	4a8d87fe98	Add a trigger mode that triggers on both read and write. The actual function that returns the combined audio frame though will wait until both sides have fed in audio, or until one side stops (such as the case when you call Wait). ... (closes issue #11945) Reported by: xheliox git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108083 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	48523e3596	Add a newline on a log ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107712 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	d9e83f85a6	Add an additional check for setting conference parameter when using the marked user options. It was possible for it to return to a no listen/no talk state if a masquerade happened. ... (closes issue #12136) Reported by: aragon git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107637 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	d6d14a3694	Fix a minor spelling error. ... (closes issue #12183) Reported by: darrylc git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107582 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	f201a2b11b	backport a fix from trunk ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107472 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	9569d74df5	stop checking for mktime() in the configure script... we don't use it, and the test is buggy under gcc 4.3 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107461 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2bf8f9fca3	Move where unanswered CDRs are dropped to the CDR core, not everything uses app_dial. ... (closes issue #11516) Reported by: ys Patches: branch_1.4_cdr.diff uploaded by ys (license 281) Tested by: anest, jcapp, dartvader git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107016 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a04b584272	Only start the SLA thread if SLA has actually been configured. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106895 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	417e8fc754	Warn the user when a temporary greeting exists ... (Closes issue #11409) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106635 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	56e908b787	Safely use the strncat() function. ... (closes issue #11958) Reported by: norman Patches: 20080209__bug11958.diff.txt uploaded by Corydon76 (license 14) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106552 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	cd703523db	Add a control frame to indicate the source of media has changed. Depending on the underlying technology it may need to change some things. ... (closes issue #12148) Reported by: jcomellas git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106235 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	8bf705f519	If the message file does not exist, just return harmlessly, instead of crashing. ... (Closes issue #12108) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105296 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	837d4676dd	Bump up the size of the uniqueid variable. ... (closes issue #12107) Reported by: asgaroth git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105261 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	c6387c3540	When using autofill, members who are in use should be counted towards the ... number of available members to call if ringinuse is set to yes. Thanks to jmls who brought this issue up on IRC git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105059 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	fdb44349e9	Don't loop around infinitely trying to spy on our own channel, and don't forget to free/detach the datastore upon hangup of the spy. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104787 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	750067bd1a	Fix a problem in ChanSpy where it could get stuck in an infinite loop without ... being able to detect that the calling channel hung up. (closes issue #12076, reported by junky, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104625 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c882e6da6f	Avoid some recursion in the cleanup code for the chanspy datastore ... (closes issue #12076, reported by junky, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104334 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	bc56a84c58	Merge changes from team/russell/smdi-1.4 ... This commit brings in a significant set of changes to the SMDI support in Asterisk. There were a number of bugs in the current implementation, most notably being that it was very likely on busy systems to pop off the wrong message from the SMDI message queue. So, this set of changes fixes the issues discovered as well as introducing some new ways to use the SMDI support which are required to avoid the bugs with grabbing the wrong message off of the queue. This code introduces a new interface to SMDI, with two dialplan functions. First, you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access details in the message using the SMDI_MSG() function. A side benefit of this is that it now supports more than just chan_zap. For example, with this implementation, you can have some FXO lines being terminated on a SIP gateway, but the SMDI link in Asterisk. Another issue with the current implementation is that it is quite common that the station ID that comes in on the SMDI link is not necessarily the same as the Asterisk voicemail box. There are now additional directives in the smdi.conf configuration file which let you map SMDI station IDs to Asterisk voicemail boxes. Yet another issue with the current SMDI support was related to MWI reporting over the SMDI link. The current code could only report a MWI change when the change was made by someone calling into voicemail. If the change was made by some other entity (such as with IMAP storage, or with a web interface of some kind), then the MWI change would never be sent. The SMDI module can now poll for MWI changes if configured to do so. This work was inspired by and primarily done for the University of Pennsylvania. (also related to issue #9260) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104119 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f64df49235	This patch fixes some pretty significant problems with how app_chanspy handles ... pointers to channels that are being spied upon. It was very likely that a crash would occur if the channel being spied upon hung up. This was because the current ast_channel handling _requires_ that the object is locked or else it could disappear at any time (except in the owning channel thread). So, this patch uses some channel datastore magic on the spied upon channel to be able to detect if and when the channel goes away. (closes issue #11877) (patch written by me, but thanks to kpfleming for the idea, and to file for review) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104106 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	5184be27ed	If the destination folder is full, don't delete a message when exiting. ... (closes issue #12065) Reported by: selsky Patch by: (myself) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104094 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	70b222e46f	Clear up confusion when viewing the QUEUE_WAITING_COUNT of a ... "dead" realtime queue. Since from the user's perspective, the queue does exist, we shouldn't tell them we couldn't find the queue. Instead since it is a dead queue, report a 0 waiting count This issue was brought up on IRC by jmls git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103956 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	638ef8c5d2	Change to the configure logic regarding IMAP. Prior to this commit, if you wished to configure ... Asterisk with IMAP support, you would use the --with-imap configure switch in one of the following two ways: --with-imap=/some/directory would look in the directory specified for a UW IMAP source installation --with-imap would assume that you had imap-2004g installed in .. relative to the Asterisk source With this set of changes the two above options still work the same, but there are two new behaviors, too. --with-imap=system will assume that you have -libc-client.so where you store your shared objects and will attempt to find c-client headers in your include path either in the imap or c-client directory. If either of the two original methods of specifying the imap option should fail, then the check for --with-imap =system will be performed in addition. It is only after this "system" check that failure can happen. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103698 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	0d470a0525	Fix build for non-IMAP builds ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103690 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	e70abb4a9e	Fix the new message count if delete=yes when using IMAP storage. ... (closes issue #11406) Reported by: jaroth Patches: deleteflag_v2.patch uploaded by jaroth (license 50) Tested by: jaroth git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103688 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	3e014ecd0b	Refuse to load app_voicemail if res_adsi is not loaded (which is a symbol dependency) ... (closes issue #11760) Reported by: non-poster Patches: 20080114__bug11760.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, non-poster, jamesgolovich git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103556 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0b110bb5e8	If entering a conference with the 'w' option ensure that we can't listen or speak until the marked user appears. ... (closes issue #11835) Reported by: alanmcmillan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103324 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	42463c4bb2	Commit fix for being unable to send voicemail from VoiceMailMain ... Reported by: William F Acker (via the -users mailing list) Patch by: Corydon76 (license 14) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103197 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	cb8ffc789e	Prevent a potential three-thread deadlock. Also added a comment block ... to explicitly state the locking order necessary inside app_queue. (closes issue #11862) Reported by: flujan Patches: 11862.patch uploaded by putnopvut (license 60) Tested by: flujan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103120 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	c9bb4fc12a	Move around some defines to unbreak ODBC storage. ... (closes issue #11932) Reported by: snuffy git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102576 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	5f7afc8678	Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugs ... while I'm in the area. (closes issue #11615) Reported by: jamessan Patches: 20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101942 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	d80ecba23f	Remove a needless (and incorrect) call to feof() after fgets(). ... This would have exited the loop early if you had an authentication file with no newline at the end. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101822 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	aa58033acb	off by one error ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101820 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	552f2e1b4c	Don't overwrite the last character of a line if it's not a newline. This would ... happen if the last line in the file doesn't have a newline. (pointed out by Qwell) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	a4c24a807c	From bugtracker: "fix totalAnalysisTime to handle periods of no channel activity" ... (closes issue #9256) Reported by: cmaj Patches: amd-dont-wait-too-long-for-frames-take3.diff.txt uploaded by cmaj (license 111) Tested by: cmaj, skygreg, ZX81, rjain git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101649 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	2e4650c242	Fix a logic error with regards to autofill. Prior to this change, it was possible ... for a caller to go out of turn if autofill were enabled and callers ahead in the queue were attempting to call a member. This change fixes this. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101216 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	da3e5f571a	Remove a memory leak from updating realtime queues ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101035 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ad19e1c4b6	Fixing an erroneous return value returned when attempting to pause or unpause a queue member ... fails. Fixes BE-366, thanks to John Bigelow for writing the patch. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100973 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	f665fa0556	Don't forget to record the channel so we know whether it is bridged or not later. ... (closes issue #11811) Reported by: slavon git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100934 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	cec60d345d	When using ODBC_STORAGE, make sure we put greeting files into the database like we do with the others. ... Issue #11795 Reported by: dimas Patches: vmgreet.patch uploaded by dimas (license 88) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100672 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago