asterisk

Commit Graph

Author	SHA1	Message	Date
Tilghman Lesher	fbdaeee639	Merged revisions 195839 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r195839 \| tilghman \| 2009-05-20 18:30:05 -0500 (Wed, 20 May 2009) \| 3 lines If a variable had a blank value upon the initial setting, then it would do nothing. Identified by Dmitry Andrianov via private email, fixed by me. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195841 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	07290ca6d4	Merged revisions 195636 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r195636 \| file \| 2009-05-20 14:14:42 -0300 (Wed, 20 May 2009) \| 12 lines Merged revisions 195635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195635 \| file \| 2009-05-20 14:14:00 -0300 (Wed, 20 May 2009) \| 5 lines Fix a bug where the MeetMe option 'D' did not actually prompt for the pin. (closes issue #15050) Reported by: pmhaddad ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195638 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	750ecf4929	Merged revisions 195521 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r195521 \| tilghman \| 2009-05-19 15:16:01 -0500 (Tue, 19 May 2009) \| 14 lines Merged revisions 195520 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195520 \| tilghman \| 2009-05-19 15:12:20 -0500 (Tue, 19 May 2009) \| 7 lines Ensure thread keys are initialized before attempting to access them. (closes issue #14889) Reported by: jaroth Patches: app_voicemail.c.patch uploaded by msirota (license 758) Tested by: msirota, BlargMaN ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195526 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	20cc5ff46e	Recorded merge of revisions 195370 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r195370 \| tilghman \| 2009-05-18 15:52:33 -0500 (Mon, 18 May 2009) \| 15 lines Recorded merge of revisions 195366 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195366 \| tilghman \| 2009-05-18 15:24:13 -0500 (Mon, 18 May 2009) \| 8 lines Add a similar dependency on SMDI for voicemail as already exists for ADSI. (closes issue #14846) Reported by: pj Patches: 20090413__bug14846__1.4.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.0.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.1.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195372 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	512f09a102	Merged revisions 195316 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r195316 \| mmichelson \| 2009-05-18 13:58:26 -0500 (Mon, 18 May 2009) \| 18 lines Fix externalivr's setvariable command so that it properly sets multiple variables. The command had a for loop that was guaranteed to only execute once since the continuation operation of the loop would set the input buffer NULL. I rewrote the loop so that its operation was more obvious, and it would set multiple variables correctly. I also reduced stack space required for the function, constified the input string, and modified the function so that it would not modify the input string while I was at it. (closes issue #15114) Reported by: chris-mac Patches: 15114.patch uploaded by mmichelson (license 60) Tested by: chris-mac ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195318 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Eliel C. Sardanons	2f92da1e7e	Merged revisions 195162 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r195162 \| eliel \| 2009-05-18 10:45:23 -0400 (Mon, 18 May 2009) \| 9 lines Warn about the use of the application WaitExten() within a Macro(). Update applications documentation to warn the user about the use of the WaitExten() application within a Macro(). Recommend the use of Read() instead. (closes issue #14444) Reported by: ewieling ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@195167 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	4000ddaad4	Merged revisions 194434 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r194434 \| file \| 2009-05-14 14:05:33 -0300 (Thu, 14 May 2009) \| 7 lines Fix a bug where the 'T' option to Meetme did not work. (closes issue #15031) Reported by: Stochastic (closes issue #13801) Reported by: justdave ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@194436 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	137917e22b	Merged revisions 194057 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r194057 \| mnicholson \| 2009-05-12 17:32:13 -0500 (Tue, 12 May 2009) \| 22 lines Merged revisions 194028 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194028 \| mnicholson \| 2009-05-12 17:15:45 -0500 (Tue, 12 May 2009) \| 16 lines This change modifies app_queue to properly generate CDR records in failure situations. This involves setting a proper cdr disposition coresponding to the given failure condition and ensuring the proper information is stored in the cdr record. (closes issue #13691) Reported by: dferrer Tested by: mnicholson (closes issue #13637) Reported by: atis Tested by: atis ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@194062 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	ebc0516d9b	Merged revisions 193956 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r193956 \| tilghman \| 2009-05-12 15:40:22 -0500 (Tue, 12 May 2009) \| 13 lines Merged revisions 193955 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193955 \| tilghman \| 2009-05-12 15:39:21 -0500 (Tue, 12 May 2009) \| 6 lines Avoid initializing routines if the authentication fails. Fixes a crash (RR) issue. (closes issue #14508) Reported by: tiziano Patches: 20090221_2_wrongmailbox.diff.txt uploaded by tiziano (license 377) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@193958 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	d786e359c1	Merged revisions 193870 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r193870 \| tilghman \| 2009-05-12 12:29:33 -0500 (Tue, 12 May 2009) \| 2 lines Convert a THREADSTORAGE object into a simple malloc'd object (as suggested by Russell on -dev) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@193872 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	2f8453f0a1	Recorded merge of revisions 193756 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r193756 \| tilghman \| 2009-05-11 17:50:47 -0500 (Mon, 11 May 2009) \| 25 lines Recorded merge of revisions 193755 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193755 \| tilghman \| 2009-05-11 17:48:20 -0500 (Mon, 11 May 2009) \| 18 lines Move 300 bytes around on the stack, to make more room for an extension buffer. This allows more concurrent extensions to be copied for a single voicemail, without creating a possibility of upsetting existing users, where a dialplan could run out of stack space where it had run fine before. Alternatively, we could have allocated off the heap, but that is a larger change and would have increased the chance for instability introduced by this change. This is really solved starting in 1.6.0.11, as the use of an ast_str buffer allows an unlimited number of extensions (up to available memory). We additionally create a new warning message when the buffer length is exceeded, permitting administrators to see an issue after the fact, whereas previously the list was silently truncated. (closes issue #14739) Reported by: p_lindheimer Patches: 20090417__bug14739.diff.txt uploaded by tilghman (license 14) Tested by: p_lindheimer ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@193822 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	e4071c437e	Merged revisions 192430 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192430 \| file \| 2009-05-05 14:46:51 -0300 (Tue, 05 May 2009) \| 12 lines Merged revisions 192429 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192429 \| file \| 2009-05-05 14:43:30 -0300 (Tue, 05 May 2009) \| 5 lines Fix a bug where the followme application would continue trying numbers after the caller hung up. (closes issue #13624) Reported by: sgenyuk ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@192432 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Leif Madsen	a470f54e3d	Resolve grammatical mistakes in the application description in app_forkcdr. (closes issue #14801) Reported by: festr git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@192094 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	e05a147fe1	Fix a crash in app_queue with very long member lists. A user reported via #asterisk that with very long lists of members, a crash occurs in ast_strdupa, so just use a single buffer and ast_copy_string instead of stack allocating copys of each interface name. (Related to revision 191041 in branches/1.4) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@191454 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
TransNexus OSP Development	7f37c0eaab	Merged revisions 190830 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r190830 \| transnexus \| 2009-04-28 17:10:42 +0800 (Tue, 28 Apr 2009) \| 2 lines Updated for OSP Toolkit 3.5. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@190988 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	683b4483fe	Merged revisions 190622 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r190622 \| mmichelson \| 2009-04-27 11:26:14 -0500 (Mon, 27 Apr 2009) \| 3 lines Update warning message to not have pipes and contain all options. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@190624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	16b504cf72	Merged revisions 189516 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r189516 \| twilson \| 2009-04-20 16:29:29 -0500 (Mon, 20 Apr 2009) \| 9 lines Merged revisions 189465 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r189465 \| twilson \| 2009-04-20 16:10:27 -0500 (Mon, 20 Apr 2009) \| 2 lines Update CDR appropriately when AST_CAUSE_NO_ANSWER is set ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@189535 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	c4cbbb01a8	Merged revisions 189495 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r189495 \| twilson \| 2009-04-20 16:24:34 -0500 (Mon, 20 Apr 2009) \| 9 lines Merged revisions 189463 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r189463 \| twilson \| 2009-04-20 16:00:52 -0500 (Mon, 20 Apr 2009) \| 2 lines Don't treat a NOANSWER like a CHANUNAVAIL ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@189534 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	4efd4914f4	Merged revisions 188774 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r188774 \| tilghman \| 2009-04-16 16:03:31 -0500 (Thu, 16 Apr 2009) \| 11 lines Merged revisions 188773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r188773 \| tilghman \| 2009-04-16 16:02:29 -0500 (Thu, 16 Apr 2009) \| 4 lines Umask should not be exported into global namespace. (closes issue #14912) Reported by: jcapp ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@188776 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	e79afd99ea	Merged revisions 188470 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r188470 \| mmichelson \| 2009-04-14 18:28:13 -0500 (Tue, 14 Apr 2009) \| 3 lines Fix a couple of queue member reference leaks. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@188473 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	0511aea0cf	Merged revisions 188032 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r188032 \| mmichelson \| 2009-04-13 09:17:56 -0500 (Mon, 13 Apr 2009) \| 6 lines Set all queue variables on both the caller and member channels. This allows for the variables to be accessed if a member macro is run. Thanks to Grigoriy Puzankin for bringing this up on the -dev list. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@188038 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	7744c20225	Merged revisions 187363 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r187363 \| tilghman \| 2009-04-09 11:39:43 -0500 (Thu, 09 Apr 2009) \| 10 lines Merged revisions 187362 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r187362 \| tilghman \| 2009-04-09 11:38:37 -0500 (Thu, 09 Apr 2009) \| 3 lines Permit zero-length text messages in SIP. (Related to an issue posted to the -users list, subject "AEL2, BASE64_DECODE and hexadecimal") ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@187365 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	644b594597	Merged revisions 186799 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r186799 \| tilghman \| 2009-04-07 17:23:46 -0500 (Tue, 07 Apr 2009) \| 10 lines Merged revisions 186775 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186775 \| tilghman \| 2009-04-07 17:16:50 -0500 (Tue, 07 Apr 2009) \| 3 lines Fix Macro documentation to match current (and intended) behavior. (See -dev mailing list) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@186806 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	dbd39a972c	Merged revisions 186444,186447 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r186444 \| tilghman \| 2009-04-03 14:30:34 -0500 (Fri, 03 Apr 2009) \| 14 lines Merged revisions 186415 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186415 \| tilghman \| 2009-04-03 14:06:58 -0500 (Fri, 03 Apr 2009) \| 7 lines Distinguish in a sent email between simple sends and forwards. (closes issue #11678) Reported by: jamessan Patches: 20090330__bug11678.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, lmadsen ........ ................ r186447 \| tilghman \| 2009-04-03 14:59:55 -0500 (Fri, 03 Apr 2009) \| 9 lines Merged revisions 186445 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186445 \| tilghman \| 2009-04-03 14:56:48 -0500 (Fri, 03 Apr 2009) \| 2 lines Found a conflict in the last commit, due to multiple targets ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@186448 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	de0cfeb6c2	Merged revisions 186286 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r186286 \| mmichelson \| 2009-04-03 09:32:05 -0500 (Fri, 03 Apr 2009) \| 20 lines Fix the ability to retrieve voicemail messages from IMAP. A recent change made interactive vm_states no longer get added to the list of vm_states and instead get stored in thread-local storage. In trunk and all the 1.6.X branches, the problem is that when we search for messages in a voicemail box, we would attempt to update the appropriate vm_state struct by directly searching in the list of vm_states instead of using the get_vm_state_by_imap_user function. This meant we could not find the interactive vm_state that we wanted. (closes issue #14685) Reported by: BlargMaN Patches: 14685.patch uploaded by mmichelson (license 60) Tested by: BlargMaN, qualleyiv, mmichelson ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@186288 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	ec37bd0e63	Merged revisions 185600 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r185600 \| mmichelson \| 2009-03-31 17:02:48 -0500 (Tue, 31 Mar 2009) \| 12 lines Merged revisions 185599 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r185599 \| mmichelson \| 2009-03-31 17:00:01 -0500 (Tue, 31 Mar 2009) \| 6 lines Fix crash that would occur if an empty member was specified in queues.conf. (closes issue #14796) Reported by: pida ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@185602 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	b0267810d3	Merged revisions 185469 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r185469 \| mmichelson \| 2009-03-31 14:46:18 -0500 (Tue, 31 Mar 2009) \| 14 lines Merged revisions 185468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r185468 \| mmichelson \| 2009-03-31 14:45:30 -0500 (Tue, 31 Mar 2009) \| 8 lines Fix Russian voicemail intro to say the word "messages" properly. (closes issue #14736) Reported by: chappell Patches: voicemail_no_messages.diff uploaded by chappell (license 8) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@185471 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	0cf7be26df	Merged revisions 185261 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r185261 \| russell \| 2009-03-31 09:53:45 -0500 (Tue, 31 Mar 2009) \| 5 lines Don't free() an astobj2 object. (closes issue #14672) Reported by: makoto ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@185263 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	9f90c1e617	Merged revisions 185072 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r185072 \| mmichelson \| 2009-03-30 11:26:48 -0500 (Mon, 30 Mar 2009) \| 45 lines Merged revisions 185031 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r185031 \| mmichelson \| 2009-03-30 11:17:35 -0500 (Mon, 30 Mar 2009) \| 39 lines Fix queue weight behavior so that calls in low-weight queues are not inappropriately blocked. (This is copied and pasted from the review request I made for this patch) Asterisk has some odd behavior when queue weights are used. The current logic used when potentially calling a queue member is: If the member we are going to call is part of another queue and _that other queue has any callers in it_ and has a higher weight than the queue we are calling from, then don't try to contact that member. The issue here is what I have marked with underscores. If the higher-weighted queue has any callers in it at all, then the queue member will be unreachable from the lower-weighted queue. This has the potential to be really really bad if using a queue strategy, such as leastrecent or fewestcalls, with the potential to call the same member repeatedly. The fix proposed by garychen on issue 13220 is very simple and, as far as I can see, works well for this situation. With this set of changes, the logic used becomes: If the member we are going to call is part of another queue, the other queue has a higher weight than the queue we are calling from, and the higher weight queue has at least as many callers as available members, then do not try to contact the queue member. If the higher weighted queue has fewer callers than available members, then there is no reason to deny the call to this member since the other queue can afford to spare a member. Since the fix involved writing a generic function for determining the number of available members in the queue, I also modified the is_our_turn function to make use of the new num_available_members function to determine if it is our turn to try calling a member. There is one small behavior change. Before writing this patch, if you had autofill disabled, then if you were the head caller in a queue, you would automatically be told that it was your turn to try calling a member. This did not take into account whether there were actually any queue members available to take the call. Now we actually make sure there is at least one member available to take the call if autofill is disabled. (closes issue #13220) Reported by: garychen Review: http://reviewboard.digium.com/r/202/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@185088 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	d9ff7bad92	Merged revisions 184843 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184843 \| russell \| 2009-03-29 00:52:20 -0500 (Sun, 29 Mar 2009) \| 13 lines Merged revisions 184842 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184842 \| russell \| 2009-03-29 00:51:55 -0500 (Sun, 29 Mar 2009) \| 5 lines Ensure targs variable is fully initialized. (closes issue #14758) Reported by: tim_ringenbach ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184845 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	ec2800dac7	Merged revisions 184726 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r184726 \| russell \| 2009-03-27 13:04:43 -0500 (Fri, 27 Mar 2009) \| 2 lines Use ast_random() instead of rand() to ensure we use the best RNG available. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184728 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	8bde8dba08	Merged revisions 184389 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184389 \| dvossel \| 2009-03-26 16:09:37 -0500 (Thu, 26 Mar 2009) \| 14 lines Merged revisions 184388 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184388 \| dvossel \| 2009-03-26 16:07:32 -0500 (Thu, 26 Mar 2009) \| 8 lines pri loop TestClient/TestServer fails: server SEND DTMF 8 app_test was failing when sending the last DTMF digit, 8, because of the 100ms pause issued after DTMF is sent. During this pause the other side would hang up causing the test to look like it failed. Now the other side waits a second before hanging up. (closes issue #12442) Reported by: tzafrir ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184394 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	429e148ebf	Merged revisions 184339 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r184339 \| russell \| 2009-03-25 16:57:19 -0500 (Wed, 25 Mar 2009) \| 35 lines Improve performance of the ast_event cache functionality. This code comes from svn/asterisk/team/russell/event_performance/. Here is a summary of the changes that have been made, in order of both invasiveness and performance impact, from smallest to largest. 1) Asterisk 1.6.1 introduces some additional logic to be able to handle distributed device state. This functionality comes at a cost. One relatively minor change in this patch is that the extra processing required for distributed device state is now completely bypassed if it's not needed. 2) One of the things that I noticed when profiling this code was that a _lot_ of time was spent doing string comparisons. I changed the way strings are represented in an event to include a hash value at the front. So, before doing a string comparison, we do an integer comparison on the hash. 3) Finally, the code that handles the event cache has been re-written. I tried to do this in a such a way that it had minimal impact on the API. I did have to change one API call, though - ast_event_queue_and_cache(). However, the way it works now is nicer, IMO. Each type of event that can be cached (MWI, device state) has its own hash table and rules for hashing and comparing objects. This by far made the biggest impact on performance. For additional details regarding this code and how it was tested, please see the review request. (closes issue #14738) Reported by: russell Review: http://reviewboard.digium.com/r/205/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184342 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	cf35e2ded1	Merged revisions 184079 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184079 \| mmichelson \| 2009-03-24 17:40:39 -0500 (Tue, 24 Mar 2009) \| 15 lines Merged revisions 184078 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184078 \| mmichelson \| 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) \| 9 lines Change NULL pointer check to be ast_strlen_zero. The 'digit' variable is guaranteed to be non-NULL, so the if statement could never evaluate true. Changing to ast_strlen_zero makes the logic correct. This was found while reviewing ast_channel_ao2 code review. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@184081 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	cad3e27d20	Merged revisions 183436 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r183436 \| dvossel \| 2009-03-19 15:30:39 -0500 (Thu, 19 Mar 2009) \| 13 lines Merged revisions 183386 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r183386 \| dvossel \| 2009-03-19 14:40:07 -0500 (Thu, 19 Mar 2009) \| 6 lines Cleaning up a few things in detect disconnect patch Initialized ast_call_feature in detect_disconnect to avoid accessing uninitialized memory. Cleaned up /param tags in features.h. No longer send dynamic features in ast_feature_detect. issue #11583 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@183438 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	ad6d049f73	Merged revisions 183244 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r183244 \| mmichelson \| 2009-03-19 13:10:34 -0500 (Thu, 19 Mar 2009) \| 16 lines Fix a memory leak associated with queues. For every attempt that app_queue made to place an outbound call to a queue member, we would allocate a queue_end_bridge structure. When the bridge for the call had completed, we would free the structure. Unfortunately not all call attempts actually end up bridged to a member, so we need to be more selective of when to allocate the structure. With this change, the allocation occurs in an area where we can guarantee that the call will be bridged. (closes issue #14680) Reported by: caspy Patches: 14680.patch uploaded by mmichelson (license 60) Tested by: caspy ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@183246 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	88af25b2bd	Merged revisions 183172 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r183172 \| dvossel \| 2009-03-19 11:28:33 -0500 (Thu, 19 Mar 2009) \| 20 lines Merged revisions 183126 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r183126 \| dvossel \| 2009-03-19 11:15:16 -0500 (Thu, 19 Mar 2009) \| 17 lines Allow disconnect feature before a call is bridged feature.conf has a disconnect option. By default this option is set to '', but it could be anything. If a user wishes to disconnect a call before the other side answers, only '' will work, regardless if the disconnect option is set to something else. This is because features are unavailable until bridging takes place. The default disconnect option, '*', was hardcoded in app_dial, which doesn't make any sense from a user perspective since they may expect it to be something different. This patch allows features to be detected from outside of the bridge, but not operated on. In this case, the disconnect feature can be detected before briding and handled outside of features.c. (closes issue #11583) Reported by: sobomax Patches: patch-apps__app_dial.c uploaded by sobomax (license 359) 11583.latest-patch uploaded by murf (license 17) detect_disconnect.diff uploaded by dvossel (license 671) Tested by: sobomax, dvossel Review: http://reviewboard.digium.com/r/195/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@183198 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	baab6e74b9	Merged revisions 182847 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r182847 \| russell \| 2009-03-17 21:28:55 -0500 (Tue, 17 Mar 2009) \| 52 lines Merged revisions 182810 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r182810 \| russell \| 2009-03-17 21:09:13 -0500 (Tue, 17 Mar 2009) \| 44 lines Fix cases where the internal poll() was not being used when it needed to be. We have seen a number of problems caused by poll() not working properly on Mac OSX. If you search around, you'll find a number of references to using select() instead of poll() to work around these issues. In Asterisk, we've had poll.c which implements poll() using select() internally. However, we were still getting reports of problems. vadim investigated a bit and realized that at least on his system, even though we were compiling in poll.o, the system poll() was still being used. So, the primary purpose of this patch is to ensure that we're using the internal poll() when we want it to be used. The changes are: 1) Remove logic for when internal poll should be used from the Makefile. Instead, put it in the configure script. The logic in the configure script is the same as it was in the Makefile. Ideally, we would have a functionality test for the problem, but that's not actually possible, since we would have to be able to run an application on the _target_ system to test poll() behavior. 2) Always include poll.o in the build, but it will be empty if AST_POLL_COMPAT is not defined. 3) Change uses of poll() throughout the source tree to ast_poll(). I feel that it is good practice to give the API call a new name when we are changing its behavior and not using the system version directly in all cases. So, normally, ast_poll() is just redefined to poll(). On systems where AST_POLL_COMPAT is defined, ast_poll() is redefined to ast_internal_poll(). 4) Change poll() in main/poll.c to be ast_internal_poll(). It's worth noting that any code that still uses poll() directly will work fine (if they worked fine before). So, for example, out of tree modules that are using poll() will not stop working or anything. However, for modules to work properly on Mac OSX, ast_poll() needs to be used. (closes issue #13404) Reported by: agalbraith Tested by: russell, vadim http://reviewboard.digium.com/r/198/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@182946 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	2e46983377	Merged revisions 182121 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r182121 \| mmichelson \| 2009-03-13 16:26:20 -0500 (Fri, 13 Mar 2009) \| 6 lines Change faulty comparison used when announcing average hold minutes and seconds (closes issue #14227) Reported by: caspy ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@182123 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	a4948990e2	Merged revisions 181846 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r181846 \| mmichelson \| 2009-03-12 16:43:51 -0500 (Thu, 12 Mar 2009) \| 3 lines Run the macro on the queue member's channel when he answers, not the caller's channel. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@181849 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	4340fb2aa6	Merged revisions 181612 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r181612 \| file \| 2009-03-12 10:24:12 -0300 (Thu, 12 Mar 2009) \| 5 lines Fix crash when sleep and retries argument was not given to RetryDial application. (closes issue #14647) Reported by: sherpya ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@181614 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	7fc00ada3d	Merged revisions 180579 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r180579 \| mmichelson \| 2009-03-06 12:25:44 -0600 (Fri, 06 Mar 2009) \| 9 lines Merged revisions 180567 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180567 \| mmichelson \| 2009-03-06 12:23:09 -0600 (Fri, 06 Mar 2009) \| 2 lines Make compilation succeed in dev-mode when IMAP storage is enabled. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180585 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	37857c3703	Merged revisions 180465 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r180465 \| mmichelson \| 2009-03-05 17:26:58 -0600 (Thu, 05 Mar 2009) \| 22 lines Merged revisions 180464 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180464 \| mmichelson \| 2009-03-05 17:26:11 -0600 (Thu, 05 Mar 2009) \| 16 lines [IMAP] Fix message retrieval issues when identical mailbox names were defined in separate contexts. There was a fix put in a while back so that an X-Asterisk-VM-Context message header was added to stored IMAP voicemails. This would allow for us to differentiate if the same mailbox name was used in multiple contexts. The problem still left was that not all places where messages were retrieved actually attempted to use this header for information when retrieving messages. This commit fixes that so that MWI and message retrieval from VoiceMailMain work as expected. (closes issue #13853) Reported by: vicks1 Patches: 13853_v2.patch uploaded by mmichelson (license 60) Tested by: lmadsen ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180467 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	2876025927	Merged revisions 180383 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r180383 \| mmichelson \| 2009-03-05 13:14:14 -0600 (Thu, 05 Mar 2009) \| 31 lines Merged revisions 180380 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180380 \| mmichelson \| 2009-03-05 12:58:48 -0600 (Thu, 05 Mar 2009) \| 25 lines Fix broken mailbox parsing when searchcontexts option is enabled. When using the searchcontexts option in voicemail.conf, the code made the assumption that all mailbox names defined were unique across all contexts. However, the code did nothing to actually enforce this assumption, nor did it do anything to alert a user that he may have created an ambiguity in his voicemail.conf file by defining the same mailbox name in multiple contexts. With this change, we now will issue a nice long warning if searchcontexts is on and we encounter the same mailbox name in multiple contexts and ignore any duplicates after the first box. Whether searchcontexts is enabled or not, if we come across a duplicate mailbox in the same context, then we will issue a warning and ignore the duplicated mailbox. I have also added a small note to voicemail.conf.sample in the explanation for searchcontexts explaining that you cannot define the same mailbox in multiple contexts if you have enabled the option. (closes issue #14599) Reported by: lmadsen Patches: 14599.patch uploaded by mmichelson (license 60) (with slight modification) Tested by: lmadsen ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180425 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	4b09db51ab	Merged revisions 180120 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r180120 \| file \| 2009-03-04 10:39:28 -0400 (Wed, 04 Mar 2009) \| 7 lines Remove duplicate 'k' and 'K' Dial options. (closes issue #14601) Reported by: alecdavis Patches: app_dial.optionk.diff.txt uploaded by alecdavis (license 585) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180122 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	84b495160a	Merged revisions 180032 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r180032 \| dvossel \| 2009-03-03 17:21:18 -0600 (Tue, 03 Mar 2009) \| 14 lines app_read does not break from prompt loop with user terminated empty string In app.c, ast_app_getdata is called to stream the prompts and receive DTMF input. If ast_app_getdata() receives an empty string caused by the user inputing the end of string character, in this case '#', it should break from the prompt loop and return to app_read, but instead it cycles through all the prompts. I've added a return value for this special case in ast_readstring() which uses an enum I've delcared in apps.h. This enum is now used as a return value for ast_app_getdata(). (closes issue #14279) Reported by: Marquis Patches: fix_app_read.patch uploaded by Marquis (license 32) read-ampersanmd.patch2 uploaded by dvossel (license 671) Tested by: Marquis, dvossel Review: http://reviewboard.digium.com/r/177/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180080 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	e170745b70	Merged revisions 180007 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r180007 \| mmichelson \| 2009-03-03 16:49:07 -0600 (Tue, 03 Mar 2009) \| 22 lines Merged revisions 180006 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180006 \| mmichelson \| 2009-03-03 16:48:18 -0600 (Tue, 03 Mar 2009) \| 17 lines Clarify some documentation of queues.conf.sample It had always been possible to explicitly specify a "blank" value for a sound file in queues.conf and have no sound played back. The problem with this is that it would result in some ugly CLI warnings from file.c. This commit introduces a check when playing a file in app_queue to see if the name of the file is zero-length and return early if that is the case. Also, the ability to specify the blank sound files in queues.conf is now mentioned more clearly in queues.conf.sample (closes issue #14227) Reported by: caspy ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180009 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	01fc3b5542	Merged revisions 179903 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r179903 \| bmd \| 2009-03-03 14:02:20 -0600 (Tue, 03 Mar 2009) \| 1 line fix a leaked channel lock (and future deadlock) when we try to pick up our own channel ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@179905 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	17860dd56c	Merged revisions 179533 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r179533 \| russell \| 2009-03-02 17:36:38 -0600 (Mon, 02 Mar 2009) \| 48 lines Merged revisions 179532 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r179532 \| russell \| 2009-03-02 17:34:13 -0600 (Mon, 02 Mar 2009) \| 40 lines Move ast_waitfor() down to avoid the results of the API call becoming stale. This call to ast_waitfor() was being done way too soon in this section of code. Specifically, there was code in between the call to waitfor and the code that uses the result that puts the channel in autoservice. By putting the channel in autoservice, the previous results of ast_waitfor() become meaningless, as the autoservice thread will do it's own ast_waitfor() and ast_read() on the channel. So, when we came back out of autoservice and eventually hit the block of code that calls ast_read() on the channel, there may not actually be any input on the channel available. Even though the previous call to ast_waitfor() in app_meetme said there was input, the autoservice thread has since serviced the channel for some period of time. This bug manifested itself while dvossel was doing some testing of MeetMe in Asterisk trunk. He was using the timerfd timing module. When the code hit ast_read() erroneously, it determined that it must have been called because of input on the timer fd, as chan->fdno was set to AST_TIMING_FD, since that was the cause of the last legitimate call to ast_read() done by autoservice. In this test, an IAX2 channel was calling into the MeetMe conference. It was _much_ more likely to be seen with an IAX2 channel because of the way audio is handled. Every audio frame that comes in results in a call to ast_queue_frame(), which then uses ast_timer_enable_continuous() to notify the channel thread that a frame is waiting to be handled. So, the chances of ast_waitfor() indicating that a channel needs servicing due to a timer event on an IAX2 event is very high. Finally, it is interesting to note that if a different timing interface was being used, this bug would probably not be noticed. When ast_read() is called and erroneously thinks that there is a timer event to handle, it calls the ast_timer_ack() function. The pthread and dahdi timing modules handle the ack() function being called when there is no event by simply ignoring it. In the case of the timerfd module, it results in a read() on the timer fd that will block forever, as there is no data to read. This caused Asterisk to lock up very quickly. Thanks to dvossel and mmichelson for the fun debugging session. :-) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@179535 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	4633a91d1a	Merged revisions 179254 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r179254 \| mmichelson \| 2009-03-01 17:25:23 -0600 (Sun, 01 Mar 2009) \| 5 lines Swap reversed timevals. This was pointed out by ScribbleJ in #asterisk-dev. Thanks very much, ScribbleJ! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@179256 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago

1 2 3 4 5 ...

3338 Commits (cb1b99ac9cdee13da5447c67b83d4bdbfbc489fb)