asterisk

Commit Graph

Author	SHA1	Message	Date
Russell Bryant	baab6e74b9	Merged revisions 182847 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r182847 \| russell \| 2009-03-17 21:28:55 -0500 (Tue, 17 Mar 2009) \| 52 lines Merged revisions 182810 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r182810 \| russell \| 2009-03-17 21:09:13 -0500 (Tue, 17 Mar 2009) \| 44 lines Fix cases where the internal poll() was not being used when it needed to be. We have seen a number of problems caused by poll() not working properly on Mac OSX. If you search around, you'll find a number of references to using select() instead of poll() to work around these issues. In Asterisk, we've had poll.c which implements poll() using select() internally. However, we were still getting reports of problems. vadim investigated a bit and realized that at least on his system, even though we were compiling in poll.o, the system poll() was still being used. So, the primary purpose of this patch is to ensure that we're using the internal poll() when we want it to be used. The changes are: 1) Remove logic for when internal poll should be used from the Makefile. Instead, put it in the configure script. The logic in the configure script is the same as it was in the Makefile. Ideally, we would have a functionality test for the problem, but that's not actually possible, since we would have to be able to run an application on the _target_ system to test poll() behavior. 2) Always include poll.o in the build, but it will be empty if AST_POLL_COMPAT is not defined. 3) Change uses of poll() throughout the source tree to ast_poll(). I feel that it is good practice to give the API call a new name when we are changing its behavior and not using the system version directly in all cases. So, normally, ast_poll() is just redefined to poll(). On systems where AST_POLL_COMPAT is defined, ast_poll() is redefined to ast_internal_poll(). 4) Change poll() in main/poll.c to be ast_internal_poll(). It's worth noting that any code that still uses poll() directly will work fine (if they worked fine before). So, for example, out of tree modules that are using poll() will not stop working or anything. However, for modules to work properly on Mac OSX, ast_poll() needs to be used. (closes issue #13404) Reported by: agalbraith Tested by: russell, vadim http://reviewboard.digium.com/r/198/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@182946 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	d01749ba43	Merged revisions 140817 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r140817 \| russell \| 2008-09-03 08:26:43 -0500 (Wed, 03 Sep 2008) \| 12 lines Merged revisions 140816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140816 \| russell \| 2008-09-03 08:24:35 -0500 (Wed, 03 Sep 2008) \| 4 lines Don't freak out if the poll emulation receives NULL for the pollfds array (closes issue #13307) Reported by: jcovert ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140819 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	cfc1df4c1a	Whitespace changes only git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105840 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	0a27d8bfe5	merge new_loader_completion branch, including (at least): - restructured build tree and makefiles to eliminate recursion problems - support for embedded modules - support for static builds - simpler cross-compilation support - simpler module/loader interface (no exported symbols) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3	20 years ago

4 Commits (cb12ed99ca2dbf20df024a6cabccbb2194a4108e)