4205 Commits (c9bff6be9b65723e1cc6c42baec8d9045d0b80ef)

Author	SHA1	Message	Date
Jenkins2	c9bff6be9b	Merge "res_pjsip_session: Prevent crash during shutdown." into 13	7 years ago
Richard Mudgett	2c4dde0ed0	res_pjsip_registrar.c: Fix compiler error. ... Need to include signal.h to define pthread_kill() and SIGURG. Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa	7 years ago
Corey Farrell	4c8c0e4c22	res_pjsip_session: Prevent crash during shutdown. ... pjproject does not have a function to reverse pjsip_inv_usage_init. This means we need to ignore any calls to the functions once shutdown is final. ASTERISK-27571 #close Change-Id: Ia550fcba563e2328f03162d79fb185f16b7c9b9d	7 years ago
George Joseph	5b699c812e	res_pjsip_registrar_expire: Refactor into res_pjsip_register ... res_pjsip_registrar_expire remains as an empty module for now. Change-Id: Ib93698938bae548d2199cb542f3692d1a171239f	7 years ago
Sean Bright	b353c90627	res_pjsip: Document tlsv1_1 and tlsv1_2 methods ... Change-Id: I67ed9039bf3f132fb20ee7a750e0aef0f704d7d3	7 years ago
Jenkins2	16f211c647	Merge "res_pjsip: Split type=identify to IP address and SIP header matching priorities" into 13	7 years ago
Jenkins2	d7f5421ea4	Merge "res_stasis_recording: Allow symbolic links in configured recordings dir." into 13	7 years ago
Jenkins2	5ebb32d3e3	Merge "config_transport: Enable TCP_NODELAY on TLS transports" into 13	7 years ago
George Joseph	948b852f48	config_transport: Enable TCP_NODELAY on TLS transports ... We did this for TCP transports already but I'm not sure why we didn't do it for TLS transports. ASTERISK_27474 #not_final_fix Change-Id: I5b1ef4b882f7b859e718236686b7898751dbb262	7 years ago
Corey Farrell	f01bac230d	res_stasis_recording: Allow symbolic links in configured recordings dir. ... If any component of ast_config_AST_RECORDING_DIR is a symbolic link we would incorrectly assume the ARI user was trying to escape the recording path. Create additional check to check the recording directory's realpath, only deny access if both do not match. This is needed by the testsuite when run by 'run-local'. Change-Id: I9145e841865edadcb5f75cead3471ad06bbb56c0	7 years ago
Alexander Traud	f07b0df627	res_config_pgsql: Avoid typecasting an int to unsigned char. ... clang 5.0 warned about this. ASTERISK-27576 Change-Id: If41f400a51973c06cdb9b75462e535b616bfe385	7 years ago
Richard Mudgett	f35960d55b	res_pjsip: Split type=identify to IP address and SIP header matching priorities ... The type=identify endpoint identification method can match by IP address and by SIP header. However, the SIP header matching has limited usefulness because you cannot specify the SIP header matching priority relative to the IP address matching. All the matching happens at the same priority and the order of evaluating the identify sections is indeterminate. e.g., If you had two type=identify sections where one matches by IP address for endpoint alice and the other matches by SIP header for endpoint bob then you couldn't predict which endpoint is matched when a request comes in that matches both. * Extract the SIP header matching criteria into its own "header" endpoint identification method so the user can specify the relative priority of the SIP header and the IP address matching criteria in the global endpoint_identifier_order option. The "ip" endpoint identification method now only matches by IP address. ASTERISK-27491 Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095	7 years ago
Jenkins2	231caefd9b	Merge "res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement." into 13	7 years ago
Jenkins2	60a66b56a5	Merge "res_pjsip.c: Update the endpoint identification documentation." into 13	7 years ago
Jenkins2	d72d6f6223	Merge "res_pjsip.c: Fix ident_to_str() and refactor ident_handler()." into 13	7 years ago
Joshua Colp	7f2d6f51ed	Merge "res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events." into 13	7 years ago
Joshua Colp	a1eb5b06a8	Merge "res_stasis: Reduce RAII_VAR usage." into 13	7 years ago
Richard Mudgett	2e09ed3b18	res_pjsip.c: Update the endpoint identification documentation. ... * Endpoint identify_by documentation. * IP/Header endpoint identifier documentation. Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a	7 years ago
Richard Mudgett	dd6dee7e50	res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement. ... The requirement that "ip" must be in the endpoint identify_by list to allow the type=identify method to identify the endpoint is not necessary. The "ip" identifier method can match one and only one endpoint. To even work, the "ip" identifier method configuration must explicitly specify the identified endpoint. Therefore, why bother configuring the type=identify identifier in the first place? The requirement only adds the potential for configuration errors for no benefit. Even worse, those configuration errors cannot be detected when the configuration loads. The requirement was introduced with the ASTERISK_27206 patch. * Remove the code change that enforces the requiremnt. Listing the "ip" method in the identify_by value is simply documentation. Change-Id: Ia057f92a33fb5d9f51dc5d5692e3d5ee1a6f2c11	7 years ago
Richard Mudgett	96040fa6bb	res_pjsip.c: Fix ident_to_str() and refactor ident_handler(). ... * Extracted sip_endpoint_identifier_type2str() and sip_endpoint_identifier_str2type() to simplify the calling functions. * Fixed pjsip_configuration.c:ident_to_str() building the endpoint's identify_by value string. Change-Id: Ide876768a8d5d828b12052e2a75008b0563fc509	7 years ago
Richard Mudgett	a8a2f39f04	res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events. ... The AMI PJSIPShowEndpoint action could only list one IdentifyDetail AMI event per endpoint. However, there is no reason that multiple type=identify sections cannot identify the same endpoint. * Reworked format_ami_endpoint_identify() to generate as many IdentifyDetail AMI events as there are matching identifiers. Change-Id: Ie146792aef72d78e05416ab5b27bc552a30399db	7 years ago
Jenkins2	637f6216c4	Merge "res_pjsip.c: Fix endpoint identifier registration name search." into 13	7 years ago
Jenkins2	3a8744b59b	Merge "res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation." into 13	7 years ago
Corey Farrell	17480f6ea4	res_stasis: Reduce RAII_VAR usage. ... In addition to being a micro-optimization (RAII_VAR has overhead), this change improves output of REF_DEBUG. Unfortunately when RAII_VAR calls ao2_cleanup it does so from a generated _dtor_varname function. For example this caused _dtor_app to release a reference instead of __stasis_app_unregister. Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5	7 years ago
Jenkins2	7cc614d223	Merge "res_stasis: Fix app_is_subscribed_bridge_id." into 13	7 years ago
Jenkins2	b6b1d73cb5	Merge "General: Avoid implicit conversion to char when changes value to negative." into 13	8 years ago
Corey Farrell	c1acc4f364	res_stasis: Fix app_is_subscribed_bridge_id. ... Instead of searching for bridge_id provided in an argument this function always searched for BRIDGE_ALL first. Rewrite this function to work like the similar functions for channel and endpoint functions. Change-Id: Ib5caca69e11727c5c8a7284a1d00621f40f1e60a	8 years ago
Alexander Traud	da1a9f392a	General: Silence modules on (un)load. ... Some (normally optional) modules created notices, warnings, and even errors in normal situations like (un)load. This cluttered the command-line interface (CLI) on start and while stopping gracefully. However, when an user went for the script './contrib/scripts/install_prereq', those modules get compiled-in because their prerequisites were met at compile time. Furthermore, because of ASTERISK_27475, the former talkative module 'res_curl' is built as side-effect. ASTERISK-27553 Change-Id: I9f105f46d72553994e820679bfde3478a551b281	8 years ago
Alexander Traud	9865e689d2	General: Avoid implicit conversion to char when changes value to negative. ... clang 5.0 warned about this. ASTERISK-27557 Change-Id: I7cceaa88e147cbdf81a3a7beec5c1c20210fa41e	8 years ago
Richard Mudgett	ba57c03740	res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation. ... The ip_identify_apply() did not validate the configuration for simple static configuration errors or deal well with address resolution errors. * Added missing configuration validation checks. * Fixed address resolution error handling. * Demoted an error message to a warning since it does not fail applying the identify object configuration. Change-Id: I8b519607263fe88e8ce964f526a45359fd362b6e	8 years ago
Richard Mudgett	0feca9bc18	res_pjsip.c: Fix endpoint identifier registration name search. ... If an endpoint identifier name in the endpoint_identifier_order list is a prefix to the identifier we are registering, we could install it in the wrong position of the list. Assuming endpoint_identifier_order=username,ip,anonymous then registering the "ip_only" identifier would put the identifier in the wrong position of the priority list. * Fix incorrect strncmp() string prefix matching. Change-Id: Ib8819ec4b811da8a27419fd93528c54d34f01484	8 years ago
Corey Farrell	d73a3a1764	res_pjsip_history: Add missing unlock to CLI command. ... Change-Id: I872060a30543776a176a316309602d924a23eb29	8 years ago
Kevin Harwell	d25a9bc7d3	res_pjsip_session: Check if sequence header is missing ... The pjsip_msg_find_hdr function can return NULL. This patch adds a check when searching for the sequence header to make sure a NULL pointer is never de-referenced. Change-Id: I19af23aeeded65be016be92360e8cb7ffe51fad2	8 years ago
Sean Bright	d2c836d24a	ice: Increase foundation buffer size ... Per RFC 5245, the foundation specified with an ICE candidate can be up to 32 characters but we are only allowing for 31. ASTERISK-27498 #close Reported by: Michele Prà Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf	8 years ago
Kevin Harwell	53799318bc	AST-2017-014: res_pjsip - Missing contact header can cause crash ... Those SIP messages that create dialogs require a contact header to be present. If the contact header was missing from the message it could cause Asterisk to crash. This patch checks to make sure SIP messages that create a dialog contain the contact header. If the message does not and it is required Asterisk now returns a "400 Missing Contact header" response. Also added NULL checks when retrieving the contact header that were missing as a "just in case". ASTERISK-27480 #close Change-Id: I1810db87683fc637a9e3e1384a746037fec20afe	8 years ago
Sean Bright	ce3d56920b	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Corey Farrell	82b6ba976f	Fix Common Typo's. ... Fix instances of: * Retreive * Recieve * other then * different then * Repeated words ("the the", "an an", "and and", etc). * othterwise, teh ASTERISK-24198 #close Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31	8 years ago
Jenkins2	2072057657	Merge "res_rtp_asterisk: Avoid close the rtp/rtcp fd twice." into 13	8 years ago
Aaron An	c38b750810	res_rtp_asterisk: Avoid close the rtp/rtcp fd twice. ... When RTCP-MUX enabled. rtp->s is the same as rtcp->s, check this before close the file descriptor. Close the FD twice will hangs the asterisk under heavy load. ASTERISK-27299 #close Reported-by: Aaron An Tested-by: AaronAn Change-Id: I870a072d73fd207463ac116ef97100addbc0820a	8 years ago
Corey Farrell	d6b2f457d9	Remove constant conditionals (dead-code). ... Some variables are set and never changed, making them constant. This means that code in the 'false' block of the conditional is unreachable. In chan_skinny and res_config_ldap I used preprocessor directive `#if 0` as I'm unsure if the unreachable code could be enabled in the future. Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059	8 years ago
Jenkins2	56a931f64c	Merge "aco: Minimize use of regex." into 13	8 years ago
Jenkins2	e31e3b581b	Merge "res_smdi: Fix shutdown ref." into 13	8 years ago
Jenkins2	ccb563d357	Merge "res_rtp_asterisk.c: Disable packet flood detection for video streams." into 13	8 years ago
Jenkins2	7d230e690c	Merge "res_hep: hepv3_is_loaded() should check if we are enabled" into 13	8 years ago
Jenkins2	2ea359f738	Merge "res_clialiases: Fix completion pass-through." into 13	8 years ago
Jenkins2	1865b3d230	Merge "coverity: Fix warnings in res_smdi" into 13	8 years ago
Corey Farrell	501f4dcdd8	aco: Minimize use of regex. ... Remove nearly all use of regex from ACO users. Still remaining: * app_confbridge has a legitamate use of option name regex. * ast_sorcery_object_fields_register is implemented with regex, all callers use simple prefix based regex. I haven't decided the best way to fix this in both 13/15 and master. Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b	8 years ago
Corey Farrell	8165115faa	res_smdi: Fix shutdown ref. ... When adding shutdown refs for OPTIONAL_API components I accidentally added it to the unload_module function in res_smdi. Move it to load_module. Change-Id: I2b9da38fbc11ef78ea23dbb2df92b684be7f647c	8 years ago
Sean Bright	8338f3ec14	res_hep: hepv3_is_loaded() should check if we are enabled ... res_hep_pjsip.so and res_hep_rtcp.so will still load and do a lot of unnecessary work even if 'enabled' is set to 'no' in hep.conf. Change-Id: I3eddfeea09c6b5bc7c641952ee0ae487fd09b64b	8 years ago
Corey Farrell	85dec2ae4f	res_clialiases: Fix completion pass-through. ... Never ignore contents of line when generating completion options. Change-Id: I74389efdfea154019d3b56a9f381610614c044c8	8 years ago