6000 Commits (bc3219447fca4084786d1789a231cbf566ef0a2b)

Author	SHA1	Message	Date
Corey Farrell	f9f00876dc	stasis_cache_pattern: Remove silly usage of RAII_VAR. ... Change-Id: Ic98a51f555062cd863b6db3f8d76065943a9dea3	8 years ago
Alexander Traud	6226635956	translate: Avoid absolute value on unsigned substraction. ... ast_format_get_sample_rate(.) returns an unsigned type. The difference of a substraction between two unsigned types does not get implicitly converted to a signed type. Therefore, using abs(.) did not make sense. ASTERISK-27549 Change-Id: Ib904d9ee0d46b6fdd1476fbc464fbbf813304017	8 years ago
Jenkins2	16363fbb60	Merge "editline: Avoid comparison between pointer and zero character constant." into 15	8 years ago
Alexander Traud	4a80a94284	editline: Avoid comparison between pointer and zero character constant. ... gcc 7.2 warned about this. ASTERISK-27559 Change-Id: I48960dda9cf0a11b6a9426f775e632363f8caa74	8 years ago
Corey Farrell	e453e883b8	pbx: Prevent execution of NULL pointer. ... pbx_extension_helper has a check for q->swo.exec == NULL but it doesn't actually return so we would still run the function. Fix the return. Move the 'int res' variable into the only scope which uses it. Also fix a copy-paste error in ast_pbx_init which could result in a crash on allocation failure (we exit with a normal error instead). Change-Id: I0693af921fdc7f56b6a72a21fb816ed08b960a69	8 years ago
Joshua Colp	ec5cc52d34	Merge "rtp_engine: Add missing unlock." into 15	8 years ago
Corey Farrell	e0319bde79	rtp_engine: Add missing unlock. ... Change-Id: I380c31a255e060309f4916da11176e0d00813215	8 years ago
Corey Farrell	f92187ed12	aco: Fix NULL dereference in error path. ... Change-Id: Id505167cf0f9414a3c144fa2c1e181a2cf288694	8 years ago
Jenkins2	e8f75fa0c7	Merge "core: Use macros to generate ao2_container callbacks where possible." into 15	8 years ago
Joshua Colp	8f5d5f8fd2	Merge "aco: Add missing aco_option_type_string for OPT_TIMELEN_T." into 15	8 years ago
Tzafrir Cohen	b0f1486cff	cdr: submit: fix logic of test for batch mode ... ASTERISK-27539 #close Change-Id: I33cdf329d2bb4486dcae975c450f6aae94c515f7	8 years ago
Corey Farrell	57833b657a	aco: Add missing aco_option_type_string for OPT_TIMELEN_T. ... ASTERISK-27117 Change-Id: I8f6c34bb30830be9f7a40823723eb4dcaaa91c61	8 years ago
Corey Farrell	ef06ec2225	core: Use macros to generate ao2_container callbacks where possible. ... This uses AO2_STRING_FIELD_HASH_FN and AO2_STRING_FIELD_CMP_FN where possible in the Asterisk core. This removes CMP_STOP from the result of CMP_FN callbacks for the following structure types: * ast_bucket_metadata * ast_bucket_scheme * generic_monitor_instance_list (ccss.c) * ast_bucket_file (media_cache.c) * named_acl Change-Id: Ide4c1449a894bce70dea1fef664dade9b57578f1	8 years ago
Richard Mudgett	cc633e64f8	stasis_channels.c: Misc cleanup. ... * Use current OBJ_SEARCH_xxx defines instead of the deprecated versions. * Fix hash_cb and cmp_cb container functions to correctly use the OBJ_SEARCH_xxx values. * Remove incorrect usage of CMP_STOP. Most uses in the system have no effect. This allows the collapse of channel_role_single_cmp_cb() and channel_role_multi_cmp_cb() into channel_role_cmp_cb(). * Remove unnecessary usage of RAII_VAR(). Change-Id: I02c405518cab22aa2a082b61e2353bf7cd629a70	8 years ago
Jenkins2	5afe5bc320	Merge "manager.c: Update AMI Status event documentation" into 15	8 years ago
George Joseph	ede6c214ab	Merge "cdr: Missing NULL check and unlock." into 15	8 years ago
Richard Mudgett	6d7304495f	manager.c: Update AMI Status event documentation ... The AMI Status event had linkedid listed twice and was missing the effective connected line name and number headers. NOTE: The linkedid and other standard channel snapshot fields in the XML documentation are part of the <channel_snapshot/> XML template defined in doc/appdocsxml.xslt. Change-Id: I004c4c4f9e7b40ef55035c831702721bec82496c	8 years ago
Jenkins2	aee3230c29	Merge "loader: Add volatile to resource_being_loaded." into 15	8 years ago
Corey Farrell	3fd1d1524d	cdr: Missing NULL check and unlock. ... * handle_dial_message: Missing a check for NULL peer. * cdr_generic_register: Missing unlock on allocation failure. cdr_generic_register is fixed by reordering so the new structure is allocated and initialized before locking the list. Change-Id: I5799b99270d1a7a716a555c31ac85f4b00ce8686	8 years ago
Corey Farrell	8ad67dbe5e	loader: Add volatile to resource_being_loaded. ... Some compiler optimizers seem to assume that dlopen will not use __attribute__((constructor)) functions to call back to the program. This was causing resource_being_loaded to be optimized away completely. ASTERISK-27531 #close Tested By: abelbeck Change-Id: If17a3b889e06811a0e7119f0539d052494d6ece9	8 years ago
Richard Mudgett	b53d1ce03e	core: Remove unused/incomplete SDP modules from released branches. ... Change-Id: Icc28fbdc46f58e54a21554e6fe8b078f841b1f86	8 years ago
Sean Bright	b64c02e414	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Jenkins2	b910a00bc1	Merge "Fix Common Typo's." into 15	8 years ago
Joshua Colp	5bd668f0a8	Merge "bridge: Old channel video source not set to NULL after unref." into 15	8 years ago
Corey Farrell	70cd4430a4	Fix Common Typo's. ... Fix instances of: * Retreive * Recieve * other then * different then * Repeated words ("the the", "an an", "and and", etc). * othterwise, teh ASTERISK-24198 #close Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31	8 years ago
Corey Farrell	b18c69edfa	bridge: Old channel video source not set to NULL after unref. ... The bridge holds onto the old channel video source after it's been released. This can lead to use after free errors. ASTERISK-27229 #close Change-Id: Ib2dab61677dd8a21f7ad53cdc9b8ca93297838b3	8 years ago
Corey Farrell	f5e1116255	core: Fix unused variable error in handle_show_sysinfo. ... Apparently in OSX it's possible for OSX to HAVE_SYSCTL but not HAVE_SYSINFO or HAVE_SWAPCTL. In this case freeswap caused an unused variable error. ASTERISK-26563 #close Change-Id: I8ec5b1897b786cc1abaf62264aa75039eea05510	8 years ago
Jenkins2	3280a6ae35	Merge "CLI: Address multiple issues." into 15	8 years ago
Jenkins2	f65ab65261	Merge "bridge: Stop music on hold on adding an arbitrary channel to a bridge" into 15	8 years ago
Jenkins2	4897314ff6	Merge "dns_core: Protect against array index violation." into 15	8 years ago
Jenkins2	9c79984387	Merge "Remove constant conditionals (dead-code)." into 15	8 years ago
Corey Farrell	60213f0351	CLI: Address multiple issues. ... * listen uses the variable `s` for the result from ast_poll() then overwrites it with the result of accept(). Create a separate variable poll_result to avoid confusion since ast_poll does not return a file descriptor. * Resolve fd leak that would occur if setsockopt failed in listen. * Reserve an extra byte while processing completion results from remote daemon. This fixes a bug where completion processing used strstr() on a string that was not '\0' terminated. This was no risk to the Asterisk daemon, the bug was only reachable the remote console process. * Resolve leak in handle_showchan when the channel is not found. * Multiple leaks and a deadlock in pbx_config CLI completion. * Fix leaks in "manager show command". Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9	8 years ago
Jenkins2	6913491b22	Merge "core: Fix multiple trivial issues in the core." into 15	8 years ago
Jenkins2	6e2b4a6904	Merge "main/app: Fix leaks." into 15	8 years ago
Ivan Poddubny	d370af4208	bridge: Stop music on hold on adding an arbitrary channel to a bridge ... When a channel that is on hold gets added to a bridge by the Bridge AMI action or the dialplan application of the same name, music continues to play, causing "robotic sound". This commit adds a call to ast_moh_stop to stop the music. Also, it makes the AMI Park action use the right MOH class when the channel gets parked. Reported by: Zane Conkle ASTERISK-25079 #close Change-Id: I4b129c5a20c15e63968842460ac5a1a85903cf9f	8 years ago
Corey Farrell	09e697c8fa	dns_core: Protect against array index violation. ... Add a check to allocate_dns_record to prevent calling a pointer retrieved from beyond dns_alloc_table. ASTERISK-27495 #close Change-Id: Ie2f6e4991cea46baa12e837bd64cc22b44d322bb	8 years ago
Jenkins2	b89a353652	Merge "rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage." into 15	8 years ago
Corey Farrell	2239e80bf2	Remove constant conditionals (dead-code). ... Some variables are set and never changed, making them constant. This means that code in the 'false' block of the conditional is unreachable. In chan_skinny and res_config_ldap I used preprocessor directive `#if 0` as I'm unsure if the unreachable code could be enabled in the future. Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059	8 years ago
Corey Farrell	1bfa85447f	core: Fix multiple trivial issues in the core. ... * Fix small leaks in from error conditions in sdp.c and translate.c. * Check new file descriptor is less than 0, not less than or equal. Change-Id: Id7782775486175c739e0c4bf3ea5e17e3f452a99	8 years ago
Corey Farrell	7d37a17ce9	main/app: Fix leaks. ... * ast_linear_stream would leak a file descriptor if it failed to allocate lin. * ast_control_tone leaked zone and ts if ast_playtones_start failed. Additionally added whitespace to ast_linear_stream, pulled assignments out of conditionals for improved readability. Change-Id: I6d1a10cf9161b1529d939b9b2d63ea36d395b657	8 years ago
Richard Mudgett	4c1e041074	ast_json_pack(): Use safer json ref mechanism. ... Change-Id: I49204db2e57ae96eee43909c18ed007c09ac817e	8 years ago
Richard Mudgett	0074307c61	rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage. ... Change-Id: I58a22c2ca82e91d7537409b7b3af2d735827a54d	8 years ago
Joshua Colp	d312068ee9	Merge "CLI: Fix 'core set debug channel' completion bug." into 15	8 years ago
Joshua Colp	bac31e55bb	Merge changes from topic 'faster-aco' into 15 ... * changes: aco: Minimize use of regex. aco: Create ways to minimize use of regex.	8 years ago
Jenkins2	a853b3bcff	Merge "CLI: Remove special handling of 'core set verbose' from rasterisk." into 15	8 years ago
Corey Farrell	18c8dda843	CLI: Fix 'core set debug channel' completion bug. ... The completion generator is missing a return so typing "core set debug all off <tab>" causes the command to actually execute. Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b	8 years ago
George Joseph	2fbf4554e4	Merge "loader: Use vector to build apha sorted module lists." into 15	8 years ago
George Joseph	fb6aad5301	Merge "loader: Replace priority heap with vector." into 15	8 years ago
Jenkins2	6b395dd3ed	Merge "cdr: Minor optimizations." into 15	8 years ago
Jenkins2	73404801a6	Merge "loader: Rework of load_dynamic_module." into 15	8 years ago