asterisk

Commit Graph

Author	SHA1	Message	Date
Tilghman Lesher	762fb9c701	Merged revisions 262102 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r262102 \| tilghman \| 2010-05-08 21:14:04 -0500 (Sat, 08 May 2010) \| 5 lines Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS. (closes issue #17309) Reported by: stuarth ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@262103 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	c17dae4625	Merged revisions 261913 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r261913 \| tilghman \| 2010-05-07 15:35:17 -0500 (Fri, 07 May 2010) \| 14 lines Use the detected pthread building flags in every place, instead of hardcoding -lpthread. We nicely detect the right flags on each system for building Asterisk with pthreads, then ignore it for every other build option that requires us to build with pthreads. This caused some items to return a false negative. Also cleanup some minor naming issues that caused "library library" redundancy in the output. (closes issue #17303) Reported by: stuarth Patches: 20100507__issue17303.diff.txt uploaded by tilghman (license 14) Tested by: stuarth ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@261914 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	54a96869c2	Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 \| dvossel \| 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) \| 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 \| dvossel \| 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) \| 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue #17052) Reported by: dvossel Tested by: dvossel (closes issue #16196) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@260053 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	e1becd7513	Merged revisions 257560 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r257560 \| tilghman \| 2010-04-15 16:26:19 -0500 (Thu, 15 Apr 2010) \| 13 lines Merged revisions 257544 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r257544 \| tilghman \| 2010-04-15 16:23:24 -0500 (Thu, 15 Apr 2010) \| 6 lines Allow application options with arguments to contain parentheses, through a variety of escaping techniques. Fixes SWP-1194 (ABE-2143). Review: https://reviewboard.asterisk.org/r/604/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@257592 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	aa6e1a5407	Merged revisions 256370 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r256370 \| tilghman \| 2010-04-06 14:28:42 -0500 (Tue, 06 Apr 2010) \| 2 lines Mac OS X does not support comparing a mutex to its initializer. Create a test for this. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@256371 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	b99bf76241	Merged revisions 255796 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r255796 \| tilghman \| 2010-04-01 13:16:37 -0500 (Thu, 01 Apr 2010) \| 7 lines Fix DEBUG_THREADS build on Darwin. (closes issue #16828) Reported by: oej Patches: 20100331__issue16828.diff.txt uploaded by tilghman (license 14) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@255813 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jason Parker	8c55f67ce5	Fix DEBUG_THREADS issue with out-of-tree modules. Take 2, without ABI breakage this time. Review: https://reviewboard.asterisk.org/r/588/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@254716 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	9110081925	Merged revisions 254553 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r254553 \| mmichelson \| 2010-03-25 12:42:36 -0500 (Thu, 25 Mar 2010) \| 11 lines Merged revisions 254552 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r254552 \| mmichelson \| 2010-03-25 12:33:35 -0500 (Thu, 25 Mar 2010) \| 5 lines Add doxygen for acl.h Review: https://reviewboard.asterisk.org/r/528 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@254554 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Terry Wilson	5954201d07	Revert API change in release branches This re-renames ast_rtp_update_source to ast_rtp_new_source git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@253158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Terry Wilson	e8413489a0	Merged revisions 252089 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r252089 \| twilson \| 2010-03-12 16:04:51 -0600 (Fri, 12 Mar 2010) \| 20 lines Only change the RTP ssrc when we see that it has changed This change basically reverts the change reviewed in https://reviewboard.asterisk.org/r/374/ and instead limits the updating of the RTP synchronization source to only those times when we detect that the other side of the conversation has changed the ssrc. The problem is that SRCUPDATE control frames are sent many times where we don't want a new ssrc, including whenever Asterisk has to send DTMF in a normal bridge. This is also not the first time that this mistake has been made. The initial implementation of the ast_rtp_new_source function also changed the ssrc--and then it was removed because of this same issue. Then, we put it back in again to fix a different issue. This patch attempts to only change the ssrc when we see that the other side of the conversation has changed the ssrc. It also renames some functions to make their purpose more clear. Review: https://reviewboard.asterisk.org/r/540/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@252134 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	03012c2325	Merged revisions 249893 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r249893 \| dvossel \| 2010-03-02 13:08:38 -0600 (Tue, 02 Mar 2010) \| 11 lines fixes adaptive jitterbuffer configuration When configuring the adaptive jitterbuffer, the target_extra value not only could not be set from the configuration, but was not even being set to its proper default. This value is required in order for the adaptive jitterbuffer to work correctly. To resolve this a config option has been added to expose this value to the conf files, and a default value is provided when no config specific value is present. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@249907 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	3414f2d009	Merged revisions 247335 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r247335 \| mmichelson \| 2010-02-17 15:22:40 -0600 (Wed, 17 Feb 2010) \| 20 lines Fix two problems in ast_str functions found while writing a unit test. 1. The documentation for ast_str_set and ast_str_append state that the max_len parameter may be -1 in order to limit the size of the ast_str to its current allocated size. The problem was that the max_len parameter in all cases was a size_t, which is unsigned. Thus a -1 was interpreted as UINT_MAX instead of -1. Changing the max_len parameter to be ssize_t fixed this issue. 2. Once issue 1 was fixed, there was an off-by-one error in the case where we attempted to write a string larger than the current allotted size to a string when -1 was passed as the max_len parameter. When trying to write more than the allotted size, the ast_str's __AST_STR_USED was set to 1 higher than it should have been. Thanks to Tilghman for quickly spotting the offending line of code. Oh, and the unit test that I referenced in the top line of this commit will be added to reviewboard shortly. Sit tight... ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@247338 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	9bff7ba440	Merged revisions 246985 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r246985 \| mmichelson \| 2010-02-16 15:15:38 -0600 (Tue, 16 Feb 2010) \| 3 lines Add some clarifying documentation to the ast_str_set and ast_str_append functions. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@246986 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	f6a9d404fc	Merged revisions 244443 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r244443 \| dvossel \| 2010-02-02 16:27:23 -0600 (Tue, 02 Feb 2010) \| 18 lines fixes crash during T.38 negotiation caused by invalid or missing FaxMaxDatagram field AST-2010-001 (closes issue #16634) Reported by: krn (closes issue #16724) Reported by: barthpbx (closes issue #16517) Reported by: bklang (closes issue #16485) Reported by: elsto ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@244447 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	32aa2dbb4b	Merged revisions 242521 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r242521 \| tilghman \| 2010-01-24 00:40:31 -0600 (Sun, 24 Jan 2010) \| 15 lines Merged revisions 242520 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r242520 \| tilghman \| 2010-01-24 00:33:01 -0600 (Sun, 24 Jan 2010) \| 8 lines Only rebuild bison and flex source files on demand, if bison and flex are detected by the configure script. Changed after discussion on the -dev list about possible unnecessary build failures, due to checkouts/untars causing these special source files to possibly be newer than their resulting C files. This should additionally ensure that nobody need learn about extra Makefile arguments to ensure the proper files get rebuilt when changes are made to these special source files. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@242524 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	fc530550dd	Merged revisions 238635 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r238635 \| dvossel \| 2010-01-08 13:39:30 -0600 (Fri, 08 Jan 2010) \| 22 lines fixes AUDIOHOOK_INHERIT regression During the process of removing an audiohook from one channel and attaching it to another the audiohook's status is updated to DONE and then back to whatever it was previously. Typically updating the status after setting it to DONE is not a good idea because DONE can trigger unrecoverable audiohook destruction events... because of this a conditional check was added to audiohook_update_status to explicitly prevent the audiohook from ever changing after being set to DONE. It was this check that prevented audiohook inherit from work properly though. Now ast_audiohook_move_by_source is treated as a special exception, as the audiohook must be returned to its previous status after attaching it to the new channel. This is only a safe operation because the audiohook's lock is held the entire time, otherwise this could cause trouble. (closes issue #16522) Reported by: corruptor ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@238639 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	106a95a542	Merged revisions 209400 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r209400 \| kpfleming \| 2009-07-28 08:49:46 -0500 (Tue, 28 Jul 2009) \| 3 lines Define side-effect-safe MIN and MAX macros and remove duplicate definitions from various files. (closes issue #16251) Reported by: asgaroth ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@238494 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	900879455b	Merged revisions 237406 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r237406 \| tilghman \| 2010-01-04 12:28:28 -0600 (Mon, 04 Jan 2010) \| 23 lines Merged revisions 237405 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r237405 \| tilghman \| 2010-01-04 12:19:00 -0600 (Mon, 04 Jan 2010) \| 16 lines Add a flag to disable the Background behavior, for AGI users. This is in a section of code that relates to two other issues, namely issue #14011 and issue #14940), one of which was the behavior of Background when called with a context argument that matched the current context. This fix broke FreePBX, however, in a post-Dial situation. Needless to say, this is an extremely difficult collision of several different issues. While the use of an exception flag is ugly, fixing all of the issues linked is rather difficult (although if someone would like to propose a better solution, we're happy to entertain that suggestion). (closes issue #16434) Reported by: rickead2000 Patches: 20091217__issue16434.diff.txt uploaded by tilghman (license 14) 20091222__issue16434__1.6.1.diff.txt uploaded by tilghman (license 14) Tested by: rickead2000 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@237407 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Sean Bright	7302dd7094	Merged revisions 236613 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r236613 \| seanbright \| 2009-12-28 10:22:54 -0500 (Mon, 28 Dec 2009) \| 14 lines Merged revisions 236585 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236585 \| seanbright \| 2009-12-28 10:12:08 -0500 (Mon, 28 Dec 2009) \| 7 lines Try a test compile to see if PTHREAD_ONCE_INIT requires extra braces. There was conditional code (based on build platform) to optioinally wrap PTHREAD_ONCE_INIT in braces that was removed since it is fixed in newer versions of Solaris/OpenSolaris, but I am still running into it on Solaris 10 x86 so add a configure-time check for it. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@236633 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jeff Peeler	78bbfcba3f	Merged revisions 235660 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r235660 \| jpeeler \| 2009-12-18 16:51:37 -0600 (Fri, 18 Dec 2009) \| 55 lines Merged revisions 235635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r235635 \| jpeeler \| 2009-12-18 16:29:51 -0600 (Fri, 18 Dec 2009) \| 48 lines Correct CDR dispositions for BUSY/FAILED This patch is simple in that it reorders the disposition defines so that the fix for issue 12946 works properly (the default CDR disposition was changed to AST_CDR_NOANSWER). Also, the AST_CDR_FLAG_ORIGINATED flag was set in ast_call to ensure all CDR records are written. The side effects of CDR changes are scary, so I'm documenting the test cases performed to attempt to catch any regressions. The following tests were all performed using 1.4 rev 195881 vs head (235571) + patch: A calls B C calls B (busy) Hangup C Hangup A (Both SIP and features) A calls B A blind transfers to C Hangup C (Both SIP and features) A calls B A attended transfers to C Hangup C A calls B A attended transfers to C (SIP) C blind transfers to A (features) Hangup A All of the test scenario CDRs matched. The following tests were performed just with the patch to ensure proper operation (with unanswered=yes): exten =>s,1,Answer exten =>s,n,ResetCDR(w) exten =>s,n,ResetCDR(w) exten =>s,1,ResetCDR(w) exten =>s,n,ResetCDR(w) (closes issue #16180) Reported by: aatef Patches: bug16180.patch uploaded by jpeeler (license 325) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@235662 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	51f23efa2d	Merged revisions 235573 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r235573 \| tilghman \| 2009-12-18 15:19:43 -0600 (Fri, 18 Dec 2009) \| 9 lines Merged revisions 235572 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r235572 \| tilghman \| 2009-12-18 15:18:16 -0600 (Fri, 18 Dec 2009) \| 2 lines Point to the typical missing package, not the cryptic "termcap support". ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@235574 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	886ea54ec5	Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This version of the patch is specific to Asterisk 1.4 and 1.6.0. These versions did not already support module load priority in the module API. This adds a trivial version of this which is just a module flag to include it in a pass before loading "everything". Thanks to mmichelson for the review! (closes issue #16412) Reported by: jiddings Tested by: russell Review: https://reviewboard.asterisk.org/r/445/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@233841 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	bb10b22e34	Merged revisions 231692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r231692 \| kpfleming \| 2009-11-30 15:47:42 -0600 (Mon, 30 Nov 2009) \| 22 lines Another round of UDPTL stack fixes/improvements: 1) Allow users of UDPTL stack to associate a character-string tag with a UDPTL session, so that log/error/debug messages generated by the UDPTL stack can be 'connected' to the endpoint that caused them to be generated. 2) Improve comments (and process) of calculating the far end's maximum IFP size when redundancy mode is in use for error correction. 3) When an IFP larger than the calculated 'far max IFP' size is presented for writing, truncate it rather than putting in the buffer and allowing the buffer to overflow; this will cause the ends to retrain to a lower bit rate that produces IFPs of an appropriate size if possible, and if not possible, the FAX transfer will fail completely. In these cases, it is due to the one endpoint supplying a T38FaxMaxDatagram value that is improperly calculated and is too low to be of use; we have configuration options available to override this behavior. 4) Eliminate use of T38FaxMaxDatagram value in udptl.conf; it is no longer needed. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@231693 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Matthew Nicholson	f9fc028293	Merged revisions 231688 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r231688 \| mnicholson \| 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) \| 15 lines Merged revisions 231614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r231614 \| mnicholson \| 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) \| 8 lines Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list. (closes issue #15625) Reported by: Shagg63 Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/429/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@231691 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	f87c2212d4	Merged revisions 230583 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r230583 \| dvossel \| 2009-11-20 11:26:20 -0600 (Fri, 20 Nov 2009) \| 6 lines audiohook signal trigger on every status change (issue #14618) Review: https://reviewboard.asterisk.org/r/434/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@230587 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Matthew Nicholson	392ca17213	Merged revisions 228858 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r228858 \| mnicholson \| 2009-11-09 08:37:07 -0600 (Mon, 09 Nov 2009) \| 15 lines Merged revisions 228827 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228827 \| mnicholson \| 2009-11-09 08:16:03 -0600 (Mon, 09 Nov 2009) \| 8 lines Perform limited bounds checking when destroying ast_mutex_t structures to make sure we don't try to use negative indices. (closes issue #15588) Reported by: zerohalo Patches: 20090820__issue15588.diff.txt uploaded by tilghman (license 14) Tested by: zerohalo ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@228861 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	69b4362386	Merged revisions 226305 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r226305 \| tilghman \| 2009-10-28 13:04:05 -0500 (Wed, 28 Oct 2009) \| 9 lines Merged revisions 226304 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r226304 \| tilghman \| 2009-10-28 13:02:25 -0500 (Wed, 28 Oct 2009) \| 2 lines Fix documentation (pointed out by TheDavidFactor on #-dev) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@226306 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	b8b4e92f99	Merged revisions 225360 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r225360 \| tilghman \| 2009-10-22 12:11:23 -0500 (Thu, 22 Oct 2009) \| 11 lines Merged revisions 225105 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225105 \| tilghman \| 2009-10-21 11:02:12 -0500 (Wed, 21 Oct 2009) \| 4 lines Fix documentation for ast_softhangup() and correct the misuse thereof. (closes issue #16103) Reported by: majorbloodnok ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@225361 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	ffe8346471	Merged revisions 224932 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r224932 \| russell \| 2009-10-20 22:09:04 -0500 (Tue, 20 Oct 2009) \| 12 lines Merged revisions 224931 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224931 \| russell \| 2009-10-20 21:59:54 -0500 (Tue, 20 Oct 2009) \| 5 lines Isolate frames returned from a DSP instance or codec translator. The reasoning for these changes are the same as what I wrote in the commit message for rev 222878. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@224933 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	f51bc4532e	Merged revisions 222880 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r222880 \| russell \| 2009-10-08 14:52:03 -0500 (Thu, 08 Oct 2009) \| 51 lines Merged revisions 222878 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222878 \| russell \| 2009-10-08 14:45:47 -0500 (Thu, 08 Oct 2009) \| 44 lines Make filestream frame handling safer by isolating frames before returning them. This patch is related to a number of issues on the bug tracker that show crashes related to freeing frames that came from a filestream. A number of fixes have been made over time while trying to figure out these problems, but there re still people seeing the crash. (Note that some of these bug reports include information about other problems. I am specifically addressing the filestream frame crash here.) I'm still not clear on what the exact problem is. However, what is _very_ clear is that we have seen quite a few problems over time related to unexpected behavior when we try to use embedded frames as an optimization. In some cases, this optimization doesn't really provide much due to improvements made in other areas. In this case, the patch modifies filestream handling such that the embedded frame will not be returned. ast_frisolate() is used to ensure that we end up with a completely mallocd frame. In reality, though, we will not actually have to malloc every time. For filestreams, the frame will almost always be allocated and freed in the same thread. That means that the thread local frame cache will be used. So, going this route doesn't hurt. With this patch in place, some people have reported success in not seeing the crash anymore. (SWP-150) (AST-208) (ABE-1834) (issue #15609) Reported by: aragon Patches: filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2) Tested by: aragon, russell (closes issue #15817) Reported by: zerohalo Tested by: zerohalo (closes issue #15845) Reported by: marhbere Review: https://reviewboard.asterisk.org/r/386/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@222881 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	4afafcf938	Merged revisions 222873 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r222873 \| dvossel \| 2009-10-08 14:35:30 -0500 (Thu, 08 Oct 2009) \| 6 lines fixes an ast_netsock_list memory leak. ABE-1998 Review: https://reviewboard.asterisk.org/r/395/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@222876 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	c1f8e9ba70	Merged revisions 222176 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r222176 \| kpfleming \| 2009-10-05 20:24:24 -0500 (Mon, 05 Oct 2009) \| 27 lines Recorded merge of revisions 222152 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222152 \| kpfleming \| 2009-10-05 20:16:36 -0500 (Mon, 05 Oct 2009) \| 20 lines Fix ao2_iterator API to hold references to containers being iterated. See Mantis issue for details of what prompted this change. Additional notes: This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK has become an enum instead of a macro, with a name that fits our naming policy; also, it is now necessary to call ao2_iterator_destroy() on any iterator that has been created. Currently this only releases the reference to the container being iterated, but in the future this could also release other resources used by the iterator, if the iterator implementation changes to use additional resources. (closes issue #15987) Reported by: kpfleming Review: https://reviewboard.asterisk.org/r/383/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@222185 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	225d7ebd12	Merged revisions 221266 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r221266 \| twilson \| 2009-09-30 12:52:30 -0500 (Wed, 30 Sep 2009) \| 32 lines Merged revisions 221086 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221086 \| twilson \| 2009-09-30 09:49:11 -0500 (Wed, 30 Sep 2009) \| 25 lines Change the SSRC by default when our media stream changes Be default, change SSRC when doing an audio stream changes Asterisk doesn't honor marker bit when reinvited to already-bridged RTP streams,resulting in far-end stack discarding packets with "old" timestamps that areactually part of a new stream. This patch sends AST_CONTROL_SRCUPDATE whenever there is a reinvite, unless the 'constantssrc' is set to true in sip.conf. The original issue reported to Digium support detailed the following situation: ITSP <-> Asterisk 1.4.26.2 <-> SIP-based Application Server Call comes in fromITSP, Asterisk dials the app server which sends a re-invite back toAsterisk--not to negotiate to send media directly to the ITSP, but to indicatethat it's changing the stream it's sending to Asterisk. The app servergenerates a new SSRC, sequence numbers, timestamps, and sets the marker bit on the new stream. Asterisk passes through the teimstamp of the new stream, butdoes not reset the SSRC, sequence numbers, or set the marker bit. When the timestamp on the new stream is older than the timestamp on the originalstream, the ITSP (which doesn't know there has been any change) discards the newframes because it thinks they are too old. This patch addresses this by changing the SSRC on a stream update unless constantssrc=true is set in sip.conf. Review: https://reviewboard.asterisk.org/r/374/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@221301 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	83e0d61776	Merged revisions 220586 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r220586 \| tilghman \| 2009-09-26 10:10:28 -0500 (Sat, 26 Sep 2009) \| 2 lines Allow AES to compile, when OpenSSL is not present. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@220587 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	44cc22ffbe	Merged revisions 219139 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r219139 \| mnicholson \| 2009-09-17 10:18:01 -0500 (Thu, 17 Sep 2009) \| 17 lines Merged revisions 219136 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219136 \| mnicholson \| 2009-09-17 09:58:39 -0500 (Thu, 17 Sep 2009) \| 10 lines Prevent a potential race condition and crash when hanging up a channel by removing the channel from the channel list before begining channel tear down. This fix may potentially cause problems with CDR backends that access the channel a CDR is associated with via the channel list. This fix makes the channel unavabile at the time when the CDR backend is invoked. This has been documented in include/asterisk/cdr.h. (closes issue #15316) Reported by: vmarrone Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/362/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@219198 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	254233cdfb	Merged revisions 217074 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r217074 \| kpfleming \| 2009-09-08 11:37:28 -0500 (Tue, 08 Sep 2009) \| 9 lines Ensure that the default autoconf CFLAGS are not used. A recent change to the configure script that allows the user to specify CFLAGS and/or LDFLAGS to the script had the unfortunate side effect of letting autoconf's default CFLAGS (-g -O2) feed in to the rest of the build system, thereby overriding the DONT_OPTIMIZE setting in menuselect. That problem is now corrected. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@217075 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	a02a8d221d	Merged revisions 215955 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r215955 \| dvossel \| 2009-09-03 11:31:54 -0500 (Thu, 03 Sep 2009) \| 6 lines Merge code associated with AST-2009-006 (closes issue #12912) Reported by: rathaus Tested by: tilghman, russell, dvossel, dbrooks ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@216003 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	18abb3f485	Merged revisions 214819 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r214819 \| tilghman \| 2009-08-30 01:43:04 -0500 (Sun, 30 Aug 2009) \| 4 lines If lua is detected with the lua5.1 prefix (or not), adjust the include path accordingly. Based upon feedback to a release announcement on the -users list. See http://lists.digium.com/pipermail/asterisk-users/2009-August/236954.html ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214820 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	a79245005f	Merged revisions 214696 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r214696 \| kpfleming \| 2009-08-28 15:01:21 -0500 (Fri, 28 Aug 2009) \| 9 lines Ensure that CFLAGS and/or LDFLAGS provided to configure script are preserved. Cross-compilation environments want to provide 'defaults' for compiler and linker options, and frequently do this by specifying CFLAGS and LDFLAGS in the environment or as command-line arguments to the configure script. This patch modifies the configure script and Makefile to preserve these settings and ensure they are used in the build process. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214697 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	ef79b9294c	Merged revisions 214518 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214518 \| tilghman \| 2009-08-27 16:46:46 -0500 (Thu, 27 Aug 2009) \| 14 lines Merged revisions 214517 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 \| tilghman \| 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) \| 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue #15714) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214519 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	f2bc664c82	Merged revisions 214466 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214466 \| tilghman \| 2009-08-27 12:28:01 -0500 (Thu, 27 Aug 2009) \| 9 lines Merged revisions 214436 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214436 \| tilghman \| 2009-08-27 11:53:58 -0500 (Thu, 27 Aug 2009) \| 2 lines One more build system change, to make the descriptions look better, if we have better information. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214474 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	40b1547d5d	Merged revisions 214360 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214360 \| tilghman \| 2009-08-27 11:12:03 -0500 (Thu, 27 Aug 2009) \| 10 lines Merged revisions 214357 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214357 \| tilghman \| 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) \| 3 lines Make autoheader descriptions render correctly in our autoconfig.h file. (Figured out while working with issue #14906) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214361 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	4193750fe9	Merged revisions 214152 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r214152 \| tilghman \| 2009-08-25 17:39:51 -0500 (Tue, 25 Aug 2009) \| 4 lines Not all versions of gnu-linux use glibc, which contains iconv. Some (especially embedded systems) don't have iconv at all. (closes issue #15169) Reported by: pprindeville ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@214153 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	740bda5eb6	Merged revisions 213560 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r213560 \| tilghman \| 2009-08-21 11:53:52 -0500 (Fri, 21 Aug 2009) \| 14 lines Merged revisions 213559 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213559 \| tilghman \| 2009-08-21 11:52:53 -0500 (Fri, 21 Aug 2009) \| 7 lines Permit DEBUG_FD_LEAKS to be used with C++ source files. (closes issue #15698) Reported by: slavon Patches: 20090817__issue15698.diff.txt uploaded by tilghman (license 14) Tested by: slavon, tilghman ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@213561 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	7c02c0102a	Merged revisions 210908 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r210908 \| tilghman \| 2009-08-06 16:29:26 -0500 (Thu, 06 Aug 2009) \| 9 lines Allow Gosub to recognize quote delimiters without consuming them. (closes issue #15557) Reported by: rain Patches: 20090723__issue15557.diff.txt uploaded by tilghman (license 14) Tested by: rain Review: https://reviewboard.asterisk.org/r/316/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@210909 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Brooks	fef52dce32	Merged revisions 209554 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r209554 \| dbrooks \| 2009-07-30 11:07:05 -0500 (Thu, 30 Jul 2009) \| 6 lines Fixes numerous spelling errors. Patch submitted by alecdavis. (closes issue #15595) Reported by: alecdavis ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@209555 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Brooks	6d177693e0	Merged revisions 209098 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r209098 \| dbrooks \| 2009-07-27 11:33:50 -0500 (Mon, 27 Jul 2009) \| 6 lines Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize" (closes issue #15571) Reported by: alecdavis ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@209221 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	f43a65fd21	Merged revisions 208548 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r208548 \| kpfleming \| 2009-07-24 10:02:53 -0500 (Fri, 24 Jul 2009) \| 8 lines Resolve a T.38 negotiation issue left over from the udptl-updates merge. The udptl-updates branch that was merged yesterday failed to properly send back T.38 SDP responses with the correct error correction mode, if the incoming SDP from the other end caused us to change error correction modes. This patch corrects that situation. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@208549 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	791d4f0478	Merged revisions 208464 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r208464 \| kpfleming \| 2009-07-23 16:57:24 -0500 (Thu, 23 Jul 2009) \| 46 lines Rework of T.38 negotiation and UDPTL API to address interoperability problems Over the past couple of months, a number of issues with Asterisk negotiating (and successfully completing) T.38 sessions with various endpoints have been found. This patch attempts to address many of them, primarily focused around ensuring that the endpoints' MaxDatagram size is honored, and in addition by ensuring that T.38 session parameter negotiation is performed correctly according to the ITU T.38 Recommendation. The major changes here are: 1) T.38 applications in Asterisk (app_fax) only generate/receive IFP packets, they do not ever work with UDPTL packets. As a result of this, they cannot be allowed to generate packets that would overflow the other endpoints' MaxDatagram size after the UDPTL stack adds any error correction information. With this patch, the application is told the maximum IFP size it can generate, based on a calculation using the far end MaxDatagram size and the active error correction mode on the T.38 session. The same is true for sending our MaxDatagram size to the remote endpoint; it is computed from the value that the application says it can accept (for a single IFP packet) combined with the active error correction mode. 2) All treatment of T.38 session parameters as 'capabilities' in chan_sip has been removed; these parameters are not at all like audio/video stream capabilities. There are strict rules to follow for computing an answer to a T.38 offer, and chan_sip now follows those rules, using the desired parameters from the application (or channel) that wants to accept the T.38 negotiation. 3) chan_sip now stores and forwards ast_control_t38_parameters structures for tracking 'our' and 'their' T.38 session parameters; this greatly simplifies negotiation, especially for pass-through calls. 4) Since T.38 negotiation without specifying parameters or receiving the final negotiated parameters is not very worthwhile, the AST_CONTROL_T38 control frame has been removed. A note has been added to UPGRADE.txt about this removal, since any out-of-tree applications that use it will no longer function properly until they are upgraded to use AST_CONTROL_T38_PARAMETERS. Review: https://reviewboard.asterisk.org/r/310/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@208468 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	b2e3c3e436	Merged revisions 205696 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r205696 \| kpfleming \| 2009-07-09 16:20:23 -0500 (Thu, 09 Jul 2009) \| 16 lines Repair ability of SendFAX/ReceiveFAX to respond to T.38 switchover. Recent changes in T.38 negotiation in Asterisk caused these applications to not respond when the other endpoint initiated a switchover to T.38; this resulted in the T.38 switchover failing, and the FAX attempt to be made using an audio connection, instead of T.38 (which would usually cause the FAX to fail completely). This patch corrects this problem, and the applications will now correctly respond to the T.38 switchover request. In addition, the response will include the appopriate T.38 session parameters based on what the other end offered and what our end is capable of. (closes issue #14849) Reported by: afosorio ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@205697 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago

1 2 3 4 5 ...

1765 Commits (ba3b97d5e0b753e6950cd7305624db8d7685615e)