asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	1ec00d205f	Merge "Revert "Test_cel: Fails when DONT_OPTIMIZE is off"" into 13	7 years ago
Chris Savinovich	3e922adcc1	Revert "Test_cel: Fails when DONT_OPTIMIZE is off" This reverts commit `9b85882f04`. Change-Id: I36cf159abb103502e48d6f8fd70d560d7f0bda56	7 years ago
George Joseph	d496bf2099	Merge "sounds: Sort 'core show sounds' output" into 13	7 years ago
Sungtae Kim	f16d711679	main/cdr: Fixed cdr start overwriting The CDR was overwriting the start time when the call continued the dialplan from the ARI stasis or a Local channel was originated. This change fixes this by no longer reinitializing the CDR when transitioning out of the dialed pending state to the single state. ASTERISK-28181 Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc	7 years ago
George Joseph	1edcff6b03	Merge "Fix deadlock handling subscribe req during res_parking reload" into 13	7 years ago
Sean Bright	e70f8f7c20	sounds: Sort 'core show sounds' output Change-Id: Ib39052a745040f75eb635f15a042da15b20e22ab	7 years ago
Joshua C. Colp	41da4ed8b2	Merge "media_index.c: Refactored so it doesn't cache the index" into 13	7 years ago
George Joseph	66982824bf	media_index.c: Refactored so it doesn't cache the index Testing revealed that the cache added no benefit but that it could consume excessive memory. Two new index related functions were created: ast_sounds_get_index_for_file() and ast_media_index_update_for_file() which restrict index updating to specific sound files. The original ast_sounds_get_index() and ast_media_index_update() calls are still available but since they no longer cache the results internally, developers should re-use an index they may already have instead of calling ast_sounds_get_index() repeatedly. If information for only a single file is needed, ast_sounds_get_index_for_file() should be called instead of ast_sounds_get_index(). The media_index directory scan code was elimininated in favor of using the existing ast_file_read_dirs() function. Since there's no more cache, ast_sounds_index_init now only registers the sounds cli commands instead of generating the initial index and subscribing to stasis format register/unregister messages. ast_sounds_reindex() is now a no-op but left for backwards compatibility. loader.c no longer registers "sounds" as a special reload target. Both the sounds cli commands and the sounds ari resources were refactored to only call ast_sounds_get_index() once per invocation and to use ast_sounds_get_index_for_file() when a specific sound file is requested. Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d	7 years ago
Giuseppe Sucameli	a618d20ca4	Fix deadlock handling subscribe req during res_parking reload Split destroy_hint method to separate hint removal and extension hint state changed callback, the latter now called via stasis. This avoids deadlock between res_parking reload that is removing the parking lot and the related hint and subscribe requests coming for the same parking lot. ASTERISK-28173 Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e	7 years ago
Friendly Automation	b9b095bb2e	Merge "Test_cel: Fails when DONT_OPTIMIZE is off" into 13	7 years ago
Joshua C. Colp	e47e8ff39a	Merge "manager_channels: Fix throwing of HangupHandler manager events" into 13	7 years ago
Joshua C. Colp	2c1ac524b8	Merge "stasis / manager / ari: Better filter messages." into 13	7 years ago
Gerald Schnabel	8791dda672	manager_channels: Fix throwing of HangupHandler manager events The type value extracted from stasis message data in channel_hangup_handler_cb isn't compared against the valid values "run", "pop" and "push". Thus the manager events HangupHandlerPush, HangupHandlerPop and HangupHandlerRun are never thrown. This regression was introduced by ASTERISK_21462. ASTERISK-28252 Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524	7 years ago
Chris-Savinovich	9b85882f04	Test_cel: Fails when DONT_OPTIMIZE is off A bug in GCC causes TEST_CEL to return failure under the following conditions: 1. TEST_FRAMEWORK on 2. DONT_OPTIMIZE off 3. Fedora and Ubuntu 4. GCC 8.2.1 5. Test name: test_cel_dial_pickup 6. There must exist a certain combination of multithreading. The bug affects arithmetic calculations when the optimization level is bigger than O1 and the -fpartial-inline flag is on. Provided these conditions, function ast_str_to_lower() fails to convert to lower case due to said function being of type force_inline. The solution is to remove the "force_inline" type declaration from function ast_str_to_lower() Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7	7 years ago
Valentin Vidic	efde1ab138	channel.c: Fix segfault with Monitor(wav,file,i) If the Monitor is started with the i option the read_stream will be NULL. One code path in channel.c checks if write_stream is set but than uses read_stream instead causing a segfault. ASTERISK-28249 Change-Id: I1bae9126537be54895c7fea2d08dd9488d8cc525	7 years ago
Joshua C. Colp	42922af7b8	stasis / manager / ari: Better filter messages. Previously both AMI and ARI used a default route on their stasis message router to handle some of the messages for publishing out their respective connection. This caused messages to be given to their subscription that could not be formatted into AMI or JSON. This change adds an API call to the stasis message router which allows a default route to be set as well as formatters that the default route is expecting. This allows both AMI and ARI to specify that their default route only wants messages of their given formatter. By doing so stasis can more intelligently filter at publishing time so that they do not receive messages which will not be turned into AMI or JSON. ASTERISK-28244 Change-Id: I65272819a53ce99f869181d1d370da559a7d1703	7 years ago
Sean Bright	28da2948d1	sched: Make sched_settime() return void because it cannot fail Change-Id: I66b8b2b2778f186919d73ae9bf592104b8fb1cd5	7 years ago
mohitdhiman	84a7b4d356	stasis/endpoint: Fix memory leak of channel_ids in ast_endpoint structure. During Bridging of two channels if masquerade operation is performed on a channel (clone channel) which was created with endpoint details (ast_channel_alloc_with_endpoint()) and the original channel which is created without endpoint details (ast_channel_alloc()) then both the channels must exchange their endpoint details or else after masquerade when clone channel is being destroyed the endpoint cleanup callbacks will be destroyed too and after call completion unique_id of original channel will still be there in ast_endpoint structure's channel_ids container. ASTERISK-28197 Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17	7 years ago
George Joseph	e3439d3011	Merge "stasis: Fix ABI between DEVMODE and non-DEVMODE." into 13	7 years ago
Richard Mudgett	b26ec935ec	stasic.c: Fix printf format type mismatches with arguments. An int64_t is not likely the same size as a long. * Changed the int64_t values in the statistics structs to longs so casting is not necessary when generating the formatted CLI output. The offending members did not need to be int64_t anyway as they were only set by an int type variable which was already truncating bits. * Reordered the statistics structs to reduce potential padding bytes. Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962	7 years ago
George Joseph	7f2a953691	Merge "backtrace.c: Fix casting pointer to/from integral type." into 13	7 years ago
Corey Farrell	240f339938	stasis: Fix ABI between DEVMODE and non-DEVMODE. Create compatibility stubs for maximum ABI compatibility. ASTERISK-28212 #close Change-Id: I872c04842ab6b61e9dd6d37e4166bc619aa20626	7 years ago
George Joseph	96f8b19b1f	Revert "stasis_cache: Stop caching stasis subscription change messages" This reverts commit `94a4eea7f6`. This commit caused issues with polling when combined with the revert commit "Revert "app_voicemail: Remove need to subscribe to stasis" ASTERISK-28222 Reported by: abelbeck Change-Id: I0aaab5218a282706dfc6fcbbaeead228d599b99b	7 years ago
Richard Mudgett	a551539048	backtrace.c: Fix casting pointer to/from integral type. The backtrace library bfd.h include file does not get the sizes of pointers and ints right on some platforms. On my old test box the size of bfd_vma is 8 while the size of a pointer is 4. gcc on the box complains of the integer casting to/from pointers size mismatch. * uintptr_t to the rescue by doing an appropriate two stage cast. Change-Id: Icb2621583f50c8728de08a3c824d95fe53cc45d0	7 years ago
Friendly Automation	70a2f51786	Merge "utils: Don't set or clear flags that don't need setting or clearing" into 13	7 years ago
Friendly Automation	ac5c4316ef	Merge "stasis: Add statistics gathering in developer mode." into 13	7 years ago
Friendly Automation	212f2a3aa3	Merge "Use non-blocking socket() and pipe() wrappers" into 13	7 years ago
Joshua C. Colp	e5605232df	stasis: Add statistics gathering in developer mode. This change adds statistics gathering to Stasis topics, subscriptions, and message types. These can be viewed using CLI commands and provide insight into how Stasis is used and how long certain operations take to execute. These are only available when Asterisk is compiled in developer mode and do not have any impact under normal operation. ASTERISK-28117 Change-Id: I94411b53767f89ee01714daaecf0c2f1666e863f	7 years ago
Friendly Automation	a03202e551	Merge "stasis: Allow filtering by formatter" into 13	7 years ago
Sean Bright	b84fd37ef0	Use non-blocking socket() and pipe() wrappers Change-Id: I050ceffe5a133d5add2dab46687209813d58f597	7 years ago
Sean Bright	3f3035680b	utils: Don't set or clear flags that don't need setting or clearing Change-Id: I0e7fb507ac09b15e45e1ff8501ecfca67afa5217	7 years ago
George Joseph	21a5ad0fd9	stasis: Allow filtering by formatter A subscriber can now indicate that it only wants messages that have formatters of a specific type. For instance, manager can indicate that it only wants messages that have a "to_ami" formatter. You can combine this with the existing filter for message type to get only messages with specific formatters or messages of specific types. ASTERISK-28186 Change-Id: Ifdb7a222a73b6b56c6bb9e4ee93dc8a394a5494c	7 years ago
Sean Bright	8c312c54ed	utils: Wrap socket() and pipe() to reduce syscalls Some platforms provide an implementation of socket() and pipe2() that allow the caller to specify that the resulting file descriptors should be non-blocking. Using these allows us to potentially elide 3 calls into 1 by avoiding extraneous calls to fcntl() to set the O_NONBLOCK flag afterwards. In passing, change ast_alertpipe_init() to use pipe2() directly instead of the wrapper if it is available. Change-Id: I3ebe654fb549587537161506c6c950f4ab298bb0	7 years ago
Sean Bright	44c8868fb1	core: Add some documentation to the malloc_trim code This adds documentation to handle_cli_malloc_trim() indicating how it can be useful when debugging OOM conditions. Change-Id: I1936185e78035bf123cd5e097b793a55eeebdc78	7 years ago
Chris-Savinovich	40ab571e0d	core: Merge malloc_trim patch We've had multiple opportunities where Richard Mudgett's malloc_trim patch has been useful. Let's get it pushed up to gerrit and merged. Since malloc_trim is only available in libc, an entry is added to configure.ac to create a definition for HAVE_MALLOC_TRIM. Change-Id: Ia38308c550149d9d6eae4ca414a649957de9700c	7 years ago
Corey Farrell	0a9904e1c6	astobj2: Eliminate usage of legacy ao2_container_alloc routine. Replace usage of ao2_container_alloc with ao2_container_alloc_hash or ao2_container_alloc_list. ao2_container_alloc is now restricted to modules only and is being removed from Asterisk 17. Change-Id: I0907d78bc66efc775672df37c8faad00f2f6c088	7 years ago
Joshua C. Colp	a5a8cba8c7	stasis: Remove stringfields and lock from change message. When a subscribe or unsubscribe occurs a message is published containing this information. This change makes it so that the message no longer uses stringfields or a lock, as both are not really needed for the message. Change-Id: I3f4831931d79f94fd979baf48048738df5dc1632	7 years ago
Joshua Colp	b7b581f209	Merge "stasis: Add internal filtering of messages." into 13	7 years ago
George Joseph	0deaf81bff	backtrace: Refactor ast_bt_get_symbols so it doesn't crash We've been seeing crashes in libbfd when we attempt to generate a stack trace from multiple threads. It turns out that libbfd is NOT thread-safe. It can cache the bfd structure and give it to multiple threads without protecting itself. To get around this, we've added a global mutex around the bfd functions and also have refactored the use of those functions to be more efficient and to provide more information about inlined functions. Also added a few more tests to test_pbx.c. One just calls ast_assert() and the other calls ast_log_backtrace(). Neither are run by default. WARNING: This change necessitated changing the return value of ast_bt_get_symbols() from an array of strings to a VECTOR of strings. However, the use of this function outside Asterisk is not likely. ASTERISK-28140 Change-Id: I79d02862ddaa2423a0809caa4b3b85c128131621	7 years ago
Joshua Colp	d748ed4147	stasis: Add internal filtering of messages. This change adds the ability for subscriptions to indicate which message types they are interested in accepting. By doing so the filtering is done before being dispatched to the subscriber, reducing the amount of work that has to be done. This is optional and if a subscriber does not add message types they wish to accept and set the subscription to selective filtering the previous behavior is preserved and they receive all messages. There is also the ability to explicitly force the reception of all messages for cases such as AMI or ARI where a large number of messages are expected that are then generically converted into a different format. ASTERISK-28103 Change-Id: I99bee23895baa0a117985d51683f7963b77aa190	7 years ago
George Joseph	7e83dc6ce5	Merge "taskprocessor: Prevent race creating new taskprocessor." into 13	7 years ago
Corey Farrell	2f75f1941a	taskprocessor: Prevent race creating new taskprocessor. Task processors are retrieved using a 'get or create' pattern. The singleton container was unlocked between the get and create steps so it's possible that two threads could create task processors with the same name at the same time. Change-Id: Id64fae94a6a1e940ddf38fde622dcd4391635382	7 years ago
Corey Farrell	013d0c50fb	core: Fix handling of restart from remote console. We cannot use need_el_end and SIGURG when restarting. Instead we need to run el_end within the SIGHUP restartnow handler. ASTERISK-28158 Change-Id: Ia852276363c81bdcf1aa29eb4558c5c2fa1218a0	7 years ago
Joshua Colp	a40b6ad471	Merge "core: Ensure that el_end is always run when needed." into 13	7 years ago
Corey Farrell	dc54dc0439	taskprocessor: Do not use separate allocation for stats or name. Merge storage for the stats object and name string into the main allocation for struct ast_taskprocessor. Change-Id: I74fe9a7f357f0e6d63152f163cf5eef6428218e1	7 years ago
Corey Farrell	2301580ba8	core: Ensure that el_end is always run when needed. * Ignore console=yes configuration option in remote console processes. * Use new flag to tell consolethread to run el_end and exit when needed. ASTERISK-28158 Change-Id: I9e23b31d4211417ddc88c6bbfd83ea4c9f3e5438	7 years ago
Richard Mudgett	92f71534fd	logger.c: Fix default console logging when no logger.conf available. Default logging was not setup correctly when there was no logger.conf. This resulted in many expected log messages not actually getting out to the console. Change-Id: I542e61c03b2f630ff5327f9de5641d776c6fa70c	7 years ago
George Joseph	1c33cf5cf1	Merge "astobj2: Eliminate usage of legacy container allocation macros." into 13	7 years ago
George Joseph	ba97d7709d	Merge "lock: Replace __ast_mutex_logger with private log_mutex_error." into 13	7 years ago
Richard Mudgett	d3d938016b	Merge "Fix 'statement' typo throughout code." into 13	7 years ago

1 2 3 4 5 ...

5939 Commits (b2987774588098248830917819586039fcb96882)