135 Commits (ae1aeb930e9117fa8c73f40b7557c9e5aebf38a6)

Author	SHA1	Message	Date
George Joseph	70fa6e6955	bundled-jansson: On OpenSuse Leap libjansson.a was placed in lib64 ... On OpenSuse Leap, libjansson.a is installed in third-party/jansson/dest/lib64 instead of lib (which is where the top-level makeopts looks). This causes a link failure. * Updated jansson/Makefile to add an explicit --libdir to force the installation to third-party/jansson/dest/lib. ASTERISK-28271 Reported by: David Wilcox Change-Id: Ibf8af75e5da13562105fcc39ed898c6ef0b5a5f3	6 years ago
Jean Aunis	d3a6714158	build : Fix cross-compilation errors ... Bundled pjproject and jansson must be configured with the host and build parameters provided to the configure script. Autotools do not permit to check for the existence of local header files, so the control of hrirs.h must not be done when cross-compiling. ASTERISK-28250 Change-Id: If0a76e52a87d4ab82b7d4c72d27d8759ca931880	6 years ago
George Joseph	9c11399be3	pjproject_bundled: Add patch for double free issue in timer heap ... Fixed #2172: Avoid double reference counter decrements in timer in the scenario of race condition between pj_timer_heap_cancel() and pj_timer_heap_poll(). Change-Id: If000e9438c83ac5084b678eb811e902c035bd2d8	6 years ago
Pirmin Walthert	5de36abd5a	pjproject_bundled: check whether UPDATE is supported on outgoing calls ... In ASTERISK-27095 an issue had been fixed because of which chan_pjsip was not trying to send UPDATE messages when connected_line_method was set to invite. However this only solved the issue for incoming INVITES. For outgoing INVITES (important when transferring calls) the options variable needs to be updated at a different place. ASTERISK-28182 #close Reported-by: nappsoft Change-Id: I76cc06da4ca76ddd6dce814a8b97cc66b98aaf29	7 years ago
Corey Farrell	606304eb54	jansson: Upgrade to 2.12. ... This brings in jansson-2.12, removes all patches that were merged upstream. README is created in third-party/jansson/patches to explain how to add patches but also because the patches folder must exist for the build process to succeed. Change-Id: If0f2d541c50997690660c21fb7b03d625a5cdadd	7 years ago
Corey Farrell	3bdf6ac918	pjproject-bundled: Use AST_DEVMODE for conditional compilation. ... We previously allowed resample and g711 codecs to be built when TEST_FRAMEWORK was enabled. This could cause errors if the testsuite was run without this option enabled. Switch the build system to allow those codecs to be built when --enable-dev-mode is used. This removes a chance for strange testsuite errors from use of an inadequate pjsua binary. Change-Id: Iee8a3613cdb711fa7e7d217c5a775a575907ae22	7 years ago
Corey Farrell	1c008c6de5	jansson-bundled: Patch for off-nominal crash. ... pack_string crashed on non-NULL strings returned when s->has_error was true if the string was the result of 's' format without '#', '%' or '+'. Change-Id: Ic125df691d81ba2cbc413e37bdae657b304d20d0	7 years ago
Richard Mudgett	3fe9c41342	bundled pjproject: Remove timer cleanup usage patch. ... This patch is not in the upstream pjproject and does unsafe things with the timer->_timer_id and timer->_grp_lock values in pj_timer_entry_reset() outside of the timer heap lock. pj_timer_entry_reset() is also called for timers that are not about to be rescheduled in a few places. Change-Id: I4fe0b4bc648f7be5903cf4531b94fc87275713c1	7 years ago
Corey Farrell	3337fe85c5	jansson-bundled: Add patches to improve json_pack error reporting. ... Change-Id: I045e420d5e73e60639079246e810da6ae21ae22b	7 years ago
George Joseph	94ef074cc7	Merge "jansson: Backport fixes to bundled, use json_vsprintf if available." into 16	7 years ago
Corey Farrell	ede59966d9	jansson: Backport fixes to bundled, use json_vsprintf if available. ... Use json_vsprintf from versions which contain fix for va_copy leak. Apply fixes from jansson master: * va_copy leak fix. * Avoid potential invalid memory read in json_pack. * Rename variable that shadowed another. Change-Id: I7522e462d2a52f53010ffa1e7d705c666ec35539	7 years ago
Kevin Harwell	755febe497	rtp_engine: rtcp_report_to_json can overflow the ssrc integer value ... When writing an RTCP report to json the code attempts to pack the "ssrc" and "source_ssrc" unsigned integer values as a signed int value type. This of course means if the ssrc's unsigned value is greater than that which can fit into a signed integer value it gets converted to a negative number. Subsequently, the negative value goes out in the json report. This patch now packs the value as a json_int_t, which is the widest integer type available on a given system. This should make it so the value no longer overflows. Note, this was caught by two failing tests hep/rtcp-receiver/ and hep/rtcp-sender. Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0	7 years ago
Richard Mudgett	c008c27c85	pjproject: Update initial 2.8 patches to apply cleanly. ... ASTERISK-28059 Change-Id: I027472f2753391646dde594a709a75f14422db93	7 years ago
Joshua Colp	60258b4ec1	pjproject: Upgrade to 2.8. ... This change brings in PJSIP 2.8, removes all the patches that were merged upstream, and makes a minor change to support a breaking change that was done. ASTERISK-28059 Change-Id: I5097772b11b0f95c3c1f52df6400158666f0a189	7 years ago
Corey Farrell	ecb3b23b07	Build System: Resolve conflict between DESTDIR and bundled jansson. ... If Asterisk is built using a DESTDIR this will cause the bundled jansson to be installed to an unexpected location and we will fail to find it. Change-Id: Id033e2813261e0d45232383d44c6391122169548	7 years ago
Corey Farrell	d61a8791b5	Build System: Improve ccache matching for different menuselect options. ... Changing any Menuselect option in the `Compiler Flags` section causes a full rebuild of the Asterisk source tree. Every enabled option causes a #define to be added to buildopts.h, thus breaking ccache caching for every source file that includes "asterisk.h". In most cases each option only applies to one or two files. Now we only define those options for the specific sources which use them, this causes much better cache matching when working with multiple builds. For example testing code with an without MALLOC_DEBUG will now use just over half the ccache size, only main/astmm.o will have two builds cached instead of every file. Reorder main/Makefile so _ASTCFLAGS set on specific object files are all together, sorted by filename. Stop adding -DMALLOC_DEBUG to CFLAGS of bundled pjproject, this define is no longer used by any header so only serves to break cache. The only code change is a slight adjustment to how main/astmm.c is initialized. Initialization functions always exist so main/asterisk.c can call them unconditionally. Additionally rename the astmm initialization functions so they are not exported. Change-Id: Ie2085237a964f6e1e6fff55ed046e2afff83c027	7 years ago
Joshua Colp	ef029a3224	Merge "pjproject_bundled: Fix for Solaris builds. Do not undef s_addr." into 16	7 years ago
Alexander Traud	04974a0ca2	pjproject_bundled: Fix for Solaris builds. Do not undef s_addr. ... The authors of PJProject undef s_addr because of some issue in Microsoft Windows. However in Oracle Solaris, s_addr is not a structure member, but defined to map to the real structure member. Updates the patch from ASTERISK_20366 ASTERISK-27997 Change-Id: I8223026d4d54e2a46521085fcc94bfa6ebe35b11	7 years ago
Alexander Traud	e9d41572b3	pjproject_bundled: Find shared libraries in root --with-ssl=PATH. ... The script configure from Teluu expects shared libraries (.so) in a subfolder called 'lib', when --with-xyz=PATH is specified. However for OpenSSL, the default location is the root of the source folder = PATH. Furthermore, Asterisk supports both, 'lib' and root. For consistency and because Asterisk is using (only) OpenSSL in PJProject, it is enhanced to support both locations, just like Asterisk. ASTERISK-27995 Change-Id: I8eb916a88b6b8c22e29bb40bee8faaca6c73406f	7 years ago
Torrey Searle	e818925a58	thirdparty/pjproject: fix deadlock in response retransmissions ... The tdata containing the response can be shared by both the dialog object and the tsx object. In order to prevent the race condition between the tsx retransmission and the dialog sending a response, clone the tdata before modifying it for the dialog send response. ASTERISK-27966 #close Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e	7 years ago
Corey Farrell	adf3c569a2	Build System: Silence build of bundled jansson. ... Change-Id: I7392c79c0173057f5378010bf1fe65e300e8fc56	7 years ago
Corey Farrell	5537048d60	Build System: Fix bundled jansson install. ... Update the bundled jansson Makefile to do nothing during Asterisk install, use a target that is not phony to initiate the jansson make and install. Change-Id: I7643cc3d39af9feba8fc0da676b646efc5f8b3bb	7 years ago
Corey Farrell	d2dace81d4	Enable bundling of jansson, require 2.11. ... Change-Id: Ib3111b151d37cbda40768cf2a8a9c6cf6c5c7cbd	7 years ago
Alexander Traud	fe78d374b0	pjproject_bundled: Repair ./configure --with-ssl=PATH. ... Previously, Asterisk did not tell its bundled PJProject about this configure parameter. Therefore, PJProject used the platform provided OpenSSL always. ASTERISK-27880 Change-Id: Iea545aec854dd0e2c061c69bb118a76ce56c5dc6	7 years ago
Joshua Colp	d9596b5090	Merge "res_pjsip: Remove spurious error logging when printing silent headers"	7 years ago
Nick French	0e8976116f	res_pjsip: Remove spurious error logging when printing silent headers ... Asterisk patched the pjproject source to avoid crashing when pjproject sip_msg headers are encountered with NULL vptr's, but the patch also output error messages for some valid headers which simply did not need to be added to the message itself, such as hidden route headers. pjproject has since applied a similar patch to their baseline to avoid crashes, but their version also avoids the spurious error logging. Lets use their patch instead. ASTERISK-27961 #close Change-Id: I2ddbd82c8da10e0dcc9807a48089d1f3c2d6e389	7 years ago
Richard Mudgett	5febc995df	Build: Fix modules getting their optimization setting overridden. ... Asterisk modules that use PJPROJECT services have their compiler optimization and possibly their symbolic debug options overridden by the PJPROJECT configure script selected settings. * We need to filter-out any -O and -g options in PJ_CFLAGS before echoing out the result so the PJPROJECT_INCLUDE variable does not override the Asterisk module settings when using bundled PJPROJECT. NOTE: This patch only has an effect when using bundled PJPROJECT. ASTERISK-27563 Change-Id: If124169735ecf572ad1535cd43bff94cb44d5b30	7 years ago
Alexander Traud	e19080a184	Bundled PJPROJECT: Disable internal connection oriented keep-alive. ... Turn off the periodic sending of CRLNCRLN. Default is on (90 seconds), which conflicts with the global section's keep_alive_interval option in pjsip.conf. patches: pjsip_keep_not_alive.patch submitted by Alexander Traud (License 6520) ASTERISK-27347 Change-Id: I6a197f56e1830d3b7e5ec70f17025840a290b057	7 years ago
George Joseph	880fbff6b7	res_pjsip_session: Add ability to accept multiple sdp answers ... pjproject by default currently will follow media forked during an INVITE on outbound calls if the To tag is different on a subsequent response as that on an earlier response. We handle this correctly. There have been reported cases where the To tag is the same but we still need to follow the media. The pjproject patch in this commit adds the capability to sip_inv and also adds the capability to control it at runtime. The original "different tag" behavior was always controllable at runtime but we never did anything with it and left it to default to TRUE. So, along with the pjproject patch, this commit adds options to both the system and endpoint objects to control the two behaviors, and a small logic change to session_inv_on_media_update in res_pjsip_session to control the behavior at the endpoint level. The default behavior for "different tags" remains the same at TRUE and the default for "same tag" is FALSE. Change-Id: I64d071942b79adb2f0a4e13137389b19404fe3d6 ASTERISK-27936 Reported-by: Ross Beer	7 years ago
George Joseph	48720e7def	pjroject_bundled: Add already-destroyed check to tsx_timer_callback ... There have been cases that when the transaction timer callback is called the tsx is already destroyed. This causes a crash. We now check the tsx state and return if the tsx is already destroyed. Change-Id: If93acd5e48d9ca5bb553f2405d5afc836842fe1c	7 years ago
George Joseph	7c03b2713e	pjproject_bundled: timer: Clean up usage of timer heap ... Added a new pj_timer_entry_reset function that resets a timer_entry for re-use. Changed direct settings of timer_entry fields to use pj_timer_entry_init and pj_timer_entry_reset. Fixed issues where timers were being rescheduled incorrectly. Change-Id: I5b624bfbc5c1429117484b9b24567293002148e6	7 years ago
George Joseph	a87141ddfd	pjproject_bundled: Add patch for pj_atomic crashes ... There have been some crashes in the past where something attempts to use a pj_atomic after it's already been destroyed. This patch tries to prevent it by making sure that pj_atomic_destroy sets its mutex to NULL when it's done. The pj_mutex functions already check for a NULL mutex and just return PJ_EINVAL. Teluu also added some checks to the win32 implementation as well. Change-Id: Id25f70b79fdedf44ead6e6e1763a4417d3b3f825	7 years ago
Jenkins2	fa892d8dfd	Merge "core: Stop using AST_INLINE_API for allocator functions."	7 years ago
Alexander Traud	f697025ae5	BuildSystem: When no download utility is available, display the explanation. ... ./configure --with-pjproject-bundled did not display an explanation, when no download utility like wget, curl, or fetch was installed beforehand, although an explanation existed in code. This happened because the code expected the variable DOWNLOAD_TO_STDOUT to be empty. However, the script ./configure set that variable always. Change-Id: I64c99b76a03525c69471e5055bf124b36a51bbd4	7 years ago
Corey Farrell	4d1c9d8711	core: Stop using AST_INLINE_API for allocator functions. ... This replaces AST_INLINE_API allocators in utils.h with real functions implemented in astmm.c. Associated macro's are also moved from utils.h to astmm.h. Remove menuselect conflicts between MALLOC_DEBUG and DEBUG_CHAOS as they can now be combined. This has multiple benefits: * Simplifies asterisk/utils.h by removing inline functions and use of the logger. * Removal of these inline functions decreases size of Asterisk and module binaries by 1% or more. * Puts memory management functions together with and without MALLOC_DEBUG enabled, simplifying management of the code. * Enables DEBUG_CHAOS for ASTMM_REDIRECT and bundled pjproject. Change-Id: If9df4377f74bdbb627461b27a473123e05525887	7 years ago
Jenkins2	4b7872c9db	Merge "core: Remove ABI effects of MALLOC_DEBUG."	7 years ago
Richard Mudgett	7f4354c10f	res_pjproject.c: Upgrade bundled PJPROJECT to 2.7.2 ... Update patches included in bundled PJPROJECT for the new version. ASTERISK-27730 Change-Id: Id3c8c8ad82126846bcd9768bc3d0a18d89be8944	7 years ago
Richard Mudgett	c711e4076a	core: Remove ABI effects of MALLOC_DEBUG. ... This allows asterisk to be compiled with MALLOC_DEBUG to load modules built without MALLOC_DEBUG. Now pre-compiled third-party modules will still work regardless of MALLOC_DEBUG being enabled or not. Change-Id: Ic07ad80b2c2df894db984cf27b16a69383ce0e10	7 years ago
Kevin Harwell	bd549cf936	Merge "AST-2018-003: Crash with an invalid SDP fmtp attribute"	7 years ago
Kevin Harwell	880c69f00f	AST-2018-003: Crash with an invalid SDP fmtp attribute ... pjproject's fmtp retrieval function failed to catch invalid fmtp attributes. Because of this Asterisk would crash if given an SDP with an invalid fmtp attribute. When retrieving the format this patch now makes sure the fmtp attribute is available. If not available it now returns an error status. ASTERISK-27583 #close Change-Id: I5cebe000ce2d846cae3af33b6d72c416e51caf2f	7 years ago
Kevin Harwell	d3a398cf90	AST-2018-002: Crash with an invalid SDP media format description ... pjproject's media format parsing algorithm failed to catch invalid values. Because of this Asterisk would crash if given an SDP with a invalid media format description. When parsing the media format description this patch now properly parses the value and returns an error status if it can't successfully parse/convert the value. ASTERISK-27582 #close Change-Id: I883b3a4ef85b6972397f7b56bf46c5779c55fdd6	7 years ago
Alexander Traud	b21915bd1c	pjproject_bundled: Disable G.729 from Belledonne Communications. ... When <http://github.com/BelledonneCommunications/bcg729> is installed, PJProject tries to link that. Support for this bcg729 was added with PJProject 2.7. The issue happens, because Teluu enabled that new feature on default. ASTERISK-27584 Reported by: Stuart Henderson Change-Id: I88b6b18ad777bcfe2d8201187b4b90eec0a172a6	7 years ago
George Joseph	f0a3c977d6	pjproject_bundled: Prevent crash on bad outgoing header ... We still need to figure out how a bad header is getting into the outgoing message but this patch to pjproject prevents attempting to print that header and causing a crash. For several users, this crash happens when sending 183 progress messages. ASTERISK-26832 Reported by: Ross Beer, Jan Rozhon Change-Id: Ie5c5a921c890c843587763e7f33f987dfe66bd16	7 years ago
Alexander Traud	cff3add680	BuildSystem: Really do not pass unknown-warning options to the compiler. ... When an older GCC version is called with a too new warning option, GCC exited with an error and Asterisk was not built. Therefore, the configure script tests the installed compiler whether it supports that warning option. If not, Asterisk does not pass it to the installed compiler. However, some compilers (like clang) do not exit (error) but give just a warning in such a case. Because the compiler did not exit, Asterisk passed the unknown-warning option. ASTERISK-27560 Change-Id: Ia9d148e689c173df4e91699113605dab2de36038	8 years ago
Sean Bright	fd0ca1c3f9	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Joshua Colp	0b532367bd	pjsip: Ignore state changes from old transactions. ... When we fail over to a new target we create a new transaction and it becomes the current INVITE transaction. This does not prevent the previous transaction from raising state changes and causing the session to be prematurely disconnected if a transport error occurs immediately. This change backports a fix from PJSIP that eliminates the incorrect state change and reduces when they would be raised in the first place. ASTERISK-27408 Change-Id: Id22d087591782eee31311753d11e7eca4b95ef34	8 years ago
Joshua Colp	e2715d2cd4	pjproject: Clean up disabling of WebRTC support. ... The definition in config_site.h and the argument to the configure script are not necessary to disable WebRTC support. The correct argument, --disable-libwebrtc, is already passed. ASTERISK-26980 Change-Id: I27da2c894f87914956a72710222e17462d8a44bc	8 years ago
Kevin Harwell	db21f7f2e1	pjsip: 183 without To tag does not negotiate media ... If a 183 with sdp response is receive without a To tag the sdp is not negotiated. According to RFC 3261 section 12.1.2 while a To tag is required, the client needs to still be able to handle the missing tag case for backwards compatibility. This patch, accepted by and applied to pjproject, makes it so if an incoming 180/183 with SDP comes in without a To tag it gets appropriately handled. ASTERISK-27442 #close Change-Id: Ic9d6b01e05e8f4874eebbd7adfe05d932025d203	8 years ago
Joshua Colp	d8c6852bdc	Merge "BuildSystem: pjsip_evsub_set_uas_timeout was not used."	8 years ago
Alexander Traud	7397961b02	BuildSystem: pjsip_evsub_set_uas_timeout was not used. ... ASTERISK-27435 Change-Id: Id318a7ae6d7d69b53f911d30bf3eece64852f15c	8 years ago