Commit Graph

73 Commits (a07df230fa12d5576c4ae2e2bc66bb025ff9b41e)

Author SHA1 Message Date
Steve Murphy bfd56d7f25 as per http://lists.digium.com/pipermail/asterisk-users/2008-June/212934.html,
17 years ago
Steve Murphy 0ce3eb0e2a (closes issue #12302)
17 years ago
Steve Murphy 164d8a5e61 In response to 10578, I just ran 1.4 thru valgrind; some of the config leakage I've already fixed, but it doesn't hurt to double check. I found and fixed leaks in res_jabber, cdr_tds, pbx_ael. Nothing major, tho.
18 years ago
Steve Murphy 6addd141d9 Included some verbage in the check_includes func, to inform the user that included contexts that have no match in the AEL, might be OK, as AEL cannot check in the extensions.conf or the in-memory contexts, as they may not be there at the time of the check.
18 years ago
Steve Murphy 4c7393a6a4 closes issue #11086 where a user complains that references to following contexts report a problem; The problem was REALLy that he was referring to empty contexts, which were being ignored. Reporter stated that empty contexts should be OK. I checked it out against extensions.conf, and sure enough, empty contexts ARE ok. So, I removed the restriction from AEL. This, though, highlighted a problem with multiple contexts of the same name. This should be OK, also. So, I added the extend keyword to AEL, and it can preceed the 'context' keyword (mixed with 'abstract', if nec.). This will turn off the warnings in AEL if the same context name is used 2 or more times. Also, I now call ast_context_find_or_create for contexts now, instead of just ast_context_create; I did this because pbx_config does this. The 'extend' keyword thus becomes a statement of intent. AEL can now duplicate the behavior of pbx_config,
18 years ago
Steve Murphy 563c9e74a2 closes issue #10870 ; where a CUT() function call in a switch expr doesn't execute correctly, because the commas in the function args are not converted to vertbars before the func is called. I modified just the switch code to convert the commas to vertbars if there, but if more of these sort of probs are found, I may have to resort to something a little more fundamental. We'll see, I guess.
18 years ago
Steve Murphy ed75fa38e9 closes issue #10834 ; where a null input to a switch statement results in a hangup; since switch is implemented with extensions, and the default case is implemented with a '.', and the '.' matches 1 or more remaining characters, the case where 0 characters exist isn't matched, and the extension isn't matched, and the goto fails, and a hangup occurs. Now, when a default case is generated, it also generates a single fixed extension that will match a null input. That extension just does a goto to the default extension for that switch. I played with an alternate solution, where I just tack an extra char onto all the patterns and the goto, but not the default case's pattern. Then even a null input will still have at least one char in it. But it made me nervous, having that extra char in , even if that's a pretty secret and low-level issue.
18 years ago
Steve Murphy 8bf81e2bac Anything to keep gcc 4.2 happy...
18 years ago
Steve Murphy b7f66e48e8 closes issue #10777 -- by returning a null for the parse tree when there's really nothing there, and making sure we don't try to do checking on a null tree.
18 years ago
Steve Murphy 4cd59ff447 This closes issue #10788 -- The exact same fixes are made here for the first arg in the for(arg1; arg2; arg3) {} statement, as were done for the 3rd arg. It can now be an assignment that will embedded in a Set() app, or a macro call, or an app call.
18 years ago
Steve Murphy eef551c063 This closes issue #10788 -- the 3rd arg in the for statement is now wrapped in Set() only if there's an '=' in that string. Otherwise, if it begins with '&', then a Macro call is generated; otherwise it is made into an app call. A bit more accomodating, keeps the new guys happy, and the guys with ael-1 code should be happy, too
18 years ago
Steve Murphy 7d83255ef8 memset really, really needs to be used here.
18 years ago
Steve Murphy 9020699e0a This patch fixes bug 10411. I added a new regression test, some regression test cleanups
18 years ago
Steve Murphy dc63d79143 this fixes bug 9883, wherein macros were not allowing the includes construct. fixed and tested, looks OK. Now includes can serve as an adjunct to catch.
18 years ago
Steve Murphy b698ff265b Added code to automatically add a default case to switches that don't have one. In some cases, rather than fall thru, it results in a goto with -1 result, which terminates the extension; a sort of dialplan seqfault, sort of. This was required to fix bug reported in 9881
18 years ago
Steve Murphy 48b277a047 continue in for-loop should go to the incrementer, not the test. As per 9435, thanks to marcelbarbulescu
18 years ago
Steve Murphy bd5967ea0c via 9373 (duplicate context in AEL crashes asterisk), kpfleming pointed on asterisk-dev, that DECLINE in this case the proper thing to do. This change now has it doing the proper thing.
18 years ago
Steve Murphy 1f08db56c5 fix for 9373 (duplicate context in AEL crashes asterisk). I turned a duplicate context from a WARNING to an ERROR. Now you get a module load failure, and asterisk just exits. That's better than a crash, right\?
18 years ago
Steve Murphy 6e869d135c The fix for the AEL <<security hole>> (bug 9316) is here...
18 years ago
Steve Murphy 9fab305234 I almost had comma escapes right, but 9184 points out the problem-- the escape is removed by pbx_config, and pbx_ael should also, before sending it down into the pbx engine. Also, you have to insert it back in, if you are generating extensions.conf code from the AEL.
18 years ago
Steve Murphy 96622ddd26 I was surprised that I had not yet downgraded missing goto targets and macro call defs to a warning, in case they are in extensions.conf; I rectified this problem. Also, A goto in a macro to a target in a catch block was not being found; I fixed this too; the cause was that I needed to treat catch statements like an extension in the find_match code.
18 years ago
Steve Murphy 99ce040a80 This fixes 8836, according to dnatural
19 years ago
Steve Murphy eae46d9a28 A fix for 8661, where the CUT func needed to have comma args converted to vertical bars. I hope this change does little harm.
19 years ago
Joshua Colp c71a6b9004 Clean up last commit to better conform to standards.
19 years ago
Steve Murphy dc8dca7807 AEL need not complain about parkedcalls not being found... just confuses users
19 years ago
Kevin P. Fleming ce4b0afb73 apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
19 years ago
Steve Murphy dc04209898 Bug 8128 fixed in this release via these changes
19 years ago
Steve Murphy 25b33fd0c8 This mod fixes a problem pointed out by dgarstang. Many thanks to Doug\!
19 years ago
Steve Murphy c37666252d These changes fix the problems reported in bug 8090
19 years ago
Steve Murphy 73b0ed54b9 This commits a change to return MODULE_LOAD_FAILURE on error, and SUCCESS (instead of 0) when all goes well for bug 8004
19 years ago
Steve Murphy 3836bbd557 If the extensions.ael file not found, or unreadable, we return AST_MODULE_LOAD_DECLINE,
19 years ago
Matthew Fredrickson 33ddb53663 Various updates from PCadach's chan_h323-live branch
19 years ago
Kevin P. Fleming fcb999c01c merge qwell's CLI verbification work
19 years ago
Steve Murphy 51132bbdbf Changes to fix all problems reported in 7804 are included here.
19 years ago
Joshua Colp 7734efb97b Make a warning about an unused function & variable go away on the stand alone AEL build.
19 years ago
Kevin P. Fleming 0a27d8bfe5 merge new_loader_completion branch, including (at least):
19 years ago
Russell Bryant 92bd7f19f7 Merge team/russell/ast_verbose_threadstorage
19 years ago
Steve Murphy 14c12fed9b The contents of branch teams/murf/bug_7598 are being folded in here.
19 years ago
Steve Murphy f67f6b2261 This branch will resolve the bug 7635.
19 years ago
Steve Murphy db0b142b06 committing a fix for colons in goto arguments and suppressing operator messages in globals assignments.
19 years ago
Russell Bryant 73ae55698f merge changes from team/murf/AEL-trunk-fixesonly
19 years ago
Kevin P. Fleming 472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
19 years ago
Tilghman Lesher 9be0f34a3e Bug 7062 - Rename ael2 CLI commands to ael
19 years ago
Luigi Rizzo f4b05f86cc make destroy_pval able to handle a NULL value
19 years ago
Luigi Rizzo aaf99191c8 include/asterisk/ael_structs.h:
19 years ago
Luigi Rizzo d85048d692 fix variable declaration in the middle of a block
19 years ago
Kevin P. Fleming 5f58cc8770 Merge Steve Murphy's (murf) complete re-implementation of AEL, which is now no longer considered experimental :-)
19 years ago
Luigi Rizzo e43bc6634d This rather large commit changes the way modules are loaded.
19 years ago
Kevin P. Fleming f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
19 years ago
Russell Bryant 7298d3feb3 Merged revisions 15658 via svnmerge from
19 years ago