6818 Commits (9deb4c679e23c431a0b31a1a67c5549a9878dffe)

Author	SHA1	Message	Date
Brad Smith	ec2c10689f	main/utils: Simplify the FreeBSD ast_get_tid() handling ... FreeBSD has had kernel threads for 20+ years.	2 years ago
Sean Bright	671b47cfda	rtp_engine.c: Correct sample rate typo for L16/44100. ... Fixes #555	2 years ago
Naveen Albert	874ee6e9aa	manager.c: Fix erroneous reloads in UpdateConfig. ... Currently, a reload will always occur if the Reload header is provided for the UpdateConfig action. However, we should not be doing a reload if the header value has a falsy value, per the documentation, so this makes the reload behavior consistent with the existing documentation. Resolves: #551	2 years ago
Naveen Albert	6fd6f22b2b	logger: Fix linking regression. ... Commit 008731b0a4 caused a regression by resulting in logger.xml being compiled and linked into the asterisk binary in lieu of logger.c on certain platforms if Asterisk was compiled in dev mode. To fix this, we ensure the file has a unique name without the extension. Most existing .xml files have been named differently from any .c files in the same directory or did not pose this issue. channels/pjsip/dialplan_functions.xml does not pose this issue but is also being renamed to adhere to this policy. Resolves: #539	2 years ago
Naveen Albert	67088b256d	func_frame_trace: Add CLI command to dump frame queue. ... This adds a simple CLI command that can be used for analyzing all frames currently queued to a channel. A couple log messages are also adjusted to be more useful in tracing bridging problems. Resolves: #533	2 years ago
George Joseph	c31cd32b82	Revert "core & res_pjsip: Improve topology change handling." ... This reverts commit 315eb551db. Over the past year, we've had several reports of "topology storms" occurring where 2 external facing channels connected by one or more local channels and bridges will get themselves in a state where they continually send each other topology change requests. This usually manifests itself in no-audio calls and a flood of "Exceptionally long queue length" messages. It appears that this commit is the cause so we're reverting it for now until we can determine a more appropriate solution. Resolves: #530	2 years ago
Naveen Albert	bb364fc61f	manager.c: Fix regression due to using wrong free function. ... Commit 424be34563 introduced a regression by calling ast_free on memory allocated by realpath. This causes Asterisk to abort when executing this function. Since the memory is allocated by glibc, it should be freed using ast_std_free. Resolves: #513	2 years ago
Ben Ford	b05d7e8901	manager.c: Prevent path traversal with GetConfig. ... When using AMI GetConfig, it was possible to access files outside of the Asterisk configuration directory by using filenames with ".." and "./" even while live_dangerously was not enabled. This change resolves the full path and ensures we are still in the configuration directory before attempting to access the file.	2 years ago
Naveen Albert	d20c3e2f6f	config_options.c: Fix truncation of option descriptions. ... This increases the format width of option descriptions to avoid needless truncation for longer descriptions. Resolves: #428	2 years ago
Naveen Albert	09bd80c627	manager.c: Improve clarity of "manager show connected". ... Improve the "manager show connected" CLI command to clarify that the last two columns are permissions related, not counts, and use sufficient widths to consistently display these values. ASTERISK-30143 #close Resolves: #482	2 years ago
Naveen Albert	3bb34477d4	general: Fix broken links. ... This fixes a number of broken links throughout the tree, mostly caused by wiki.asterisk.org being replaced with docs.asterisk.org, which should eliminate the need for sporadic fixes as in f28047db36. Resolves: #430	2 years ago
Sean Bright	1d05e34d98	logger.c: Move LOG_GROUP documentation to dedicated XML file. ... The `get_documentation` awk script will only extract the first DOCUMENTATION block that it finds in a given file. This is by design (9bc2127) to prevent AMI event documentation from being pulled in to the core.xml documentation file. Because of this, the `LOG_GROUP` documentation added in 89709e2 was not being properly extracted and was missing fom the resulting XML documentation file. This commit moves the `LOG_GROUP` documentation to a separate `logger.xml` file.	2 years ago
Sean Bright	b437cc3267	config.c: Log #exec include failures. ... If the script referenced by `#exec` does not exist, writes anything to stderr, or exits abnormally or with a non-zero exit status, we log that to Asterisk's error logging channel. Additionally, write out a warning if the script produces no output. Fixes #259	2 years ago
Sean Bright	33213c1979	app.c: Allow ampersands in playback lists to be escaped. ... Any function or application that accepts a `&`-separated list of filenames can now include a literal `&` in a filename by wrapping the entire filename in single quotes, e.g.: ``` exten = _X.,n,Playback('https://example.com/sound.cgi?a=b&c=d'&hello-world) ``` Fixes #172 UpgradeNote: Ampersands in URLs passed to the `Playback()`, `Background()`, `SpeechBackground()`, `Read()`, `Authenticate()`, or `Queue()` applications as filename arguments can now be escaped by single quoting the filename. Additionally, this is also possible when using the `CONFBRIDGE` dialplan function, or configuring various features in `confbridge.conf` and `queues.conf`.	2 years ago
Sean Bright	e2e18b366c	uri.c: Simplify ast_uri_make_host_with_port()	2 years ago
Sean Bright	40a9f5a88c	res_http_websocket.c: Set hostname on client for certificate validation. ... Additionally add a `assert()` to in the TLS client setup code to ensure that hostname is set when it is supposed to be. Fixes #433	2 years ago
Matthew Fredrickson	b5c31b55c9	app_followme.c: Grab reference on nativeformats before using it ... Fixes a crash due to a lack of proper reference on the nativeformats object before passing it into ast_request(). Also found potentially similar use case bugs in app_chanisavail.c, bridge.c, and bridge_basic.c Fixes: #388	2 years ago
Naveen Albert	a6439d3723	logger: Add channel-based filtering. ... This adds the ability to filter console logging by channel or groups of channels. This can be useful on busy systems where an administrator would like to analyze certain calls in detail. A dialplan function is also included for the purpose of assigning a channel to a group (e.g. by tenant, or some other metric). ASTERISK-30483 #close Resolves: #242 UserNote: The console log can now be filtered by channels or groups of channels, using the logger filter CLI commands.	2 years ago
George Joseph	af7e89ebf8	chan_pjsip: Add PJSIPHangup dialplan app and manager action ... See UserNote below. Exposed the existing Hangup AMI action in manager.c so we can use all of it's channel search and AMI protocol handling without duplicating that code in dialplan_functions.c. Added a lookup function to res_pjsip.c that takes in the string represenation of the pjsip_status_code enum and returns the actual status code. I.E. ast_sip_str2rc("DECLINE") returns 603. This allows the caller to specify PJSIPHangup(decline) in the dialplan, just like Hangup(call_rejected). Also extracted the XML documentation to its own file since it was almost as large as the code itself. UserNote: A new dialplan app PJSIPHangup and AMI action allows you to hang up an unanswered incoming PJSIP call with a specific SIP response code in the 400 -> 699 range.	2 years ago
Holger Hans Peter Freyther	9fd2655d5a	stasis: Update the snapshot after setting the redirect ... The previous commit added the caller_rdnis attribute. Make it avialble during a possible ChanngelHangupRequest.	2 years ago
Holger Hans Peter Freyther	da0b1ac1c1	ari: Provide the caller ID RDNIS for the channels ... Provide the caller ID RDNIS when available. This will allow an application to follow the redirect.	2 years ago
Brad Smith	29a3e5660b	main/utils: Implement ast_get_tid() for OpenBSD ... Implement the ast_get_tid() function for OpenBSD. OpenBSD supports getting the TID via getthrid().	2 years ago
Naveen Albert	65f83311b7	core_local: Fix local channel parsing with slashes. ... Currently, trying to call a Local channel with a slash in the extension will fail due to the parsing of characters after such a slash as being dial modifiers. Additionally, core_local is inconsistent and incomplete with its parsing of Local dial strings in that sometimes it uses the first slash and at other times it uses the last. For instance, something like DAHDI/5 or PJSIP/device is a perfectly usable extension in the dialplan, but Local channels in particular prevent these from being called. This creates inconsistent behavior for users, since using a slash in an extension is perfectly acceptable, and using a Goto to accomplish this works fine, but if specified through a Local channel, the parsing prevents this. This fixes this by explicitly parsing options from the last slash in the extension, rather than the first one, which doesn't cause an issue for extensions with slashes. ASTERISK-30013 #close Resolves: #248	2 years ago
Bastian Triller	1cbbf36929	func_json: Fix crashes for some types ... This commit fixes crashes in JSON_DECODE() for types null, true, false and real numbers. In addition it ensures that a path is not deeper than 32 levels. Also allow root object to be an array. Add unit tests for above cases.	2 years ago
Eduardo	ca1ed84820	codec_builtin: Use multiples of 20 for maximum_ms ... Some providers require a multiple of 20 for the maxptime or fail to complete calls, e.g. Vivo in Brazil. To increase compatibility, only multiples of 20 are now used. Resolves: #260	2 years ago
George Joseph	e1050b4add	lock.c: Separate DETECT_DEADLOCKS from DEBUG_THREADS ... Previously, DETECT_DEADLOCKS depended on DEBUG_THREADS. Unfortunately, DEBUG_THREADS adds a lot of lock tracking overhead to all of the lock lifecycle calls whereas DETECT_DEADLOCKS just causes the lock calls to loop over trylock in 200us intervals until the lock is obtained and spits out log messages if it takes more than 5 seconds. From a code perspective, the only reason they were tied together was for logging. So... The ifdefs in lock.c were refactored to allow DETECT_DEADLOCKS to be enabled without also enabling DEBUG_THREADS. Resolves: #321 UserNote: You no longer need to select DEBUG_THREADS to use DETECT_DEADLOCKS. This removes a significant amount of overhead if you just want to detect possible deadlocks vs needing full lock tracing.	2 years ago
George Joseph	fc516f5781	asterisk.c: Use the euid's home directory to read/write cli history ... The CLI .asterisk_history file is read from/written to the directory specified by the HOME environment variable. If the root user starts asterisk with the -U/-G options, or with runuser/rungroup set in asterisk.conf, the asterisk process is started as root but then it calls setuid/setgid to set the new user/group. This does NOT reset the HOME environment variable to the new user's home directory though so it's still left as "/root". In this case, the new user will almost certainly NOT have access to read from or write to the history file. * Added function process_histfile() which calls getpwuid(geteuid()) and uses pw->dir as the home directory instead of the HOME environment variable. * ast_el_read_default_histfile() and ast_el_write_default_histfile() have been modified to use the new process_histfile() function. Resolves: #337	2 years ago
Mike Bradeen	4592f97c36	cel: add publish user event helper ... Add a wrapper function around ast_cel_publish_event that packs event and extras into a blob before publishing Resolves:#330	2 years ago
George Joseph	0e0f99db1d	file.c: Add ability to search custom dir for sounds ... To better co-exist with sounds files that may be managed by packages, custom sound files may now be placed in AST_DATA_DIR/sounds/custom instead of the standard AST_DATA_DIR/sounds/<lang> directory. If the new "sounds_search_custom_dir" option in asterisk.conf is set to "true", asterisk will search the custom directory for sounds files before searching the standard directory. For performance reasons, the "sounds_search_custom_dir" defaults to "false". Resolves: #315 UserNote: A new option "sounds_search_custom_dir" has been added to asterisk.conf that allows asterisk to search AST_DATA_DIR/sounds/custom for sounds files before searching the standard AST_DATA_DIR/sounds/<lang> directory.	2 years ago
George Joseph	42f82d55b0	make_buildopts_h, et. al. Allow adding all cflags to buildopts.h ... The previous behavior of make_buildopts_h was to not add the non-ABI-breaking MENUSELECT_CFLAGS like DETECT_DEADLOCKS, REF_DEBUG, etc. to the buildopts.h file because "it caused ccache to invalidate files and extended compile times". They're only defined by passing them on the gcc command line with '-D' options. In practice, including them in the include file rarely causes any impact because the only time ccache cares is if you actually change an option so the hit occurrs only once after you change it. OK so why would we want to include them? Many IDEs follow the include files to resolve defines and if the options aren't in an include file, it can cause the IDE to mark blocks of "ifdeffed" code as unused when they're really not. So... * Added a new menuselect compile option ADD_CFLAGS_TO_BUILDOPTS_H which tells make_buildopts_h to include the non-ABI-breaking flags in buildopts.h as well as the ABI-breaking ones. The default is disabled to preserve current behavior. As before though, only the ABI-breaking flags appear in AST_BUILDOPTS and only those are used to calculate AST_BUILDOPT_SUM. A new AST_BUILDOPT_ALL define was created to capture all of the flags. * make_version_c was streamlined to use buildopts.h and also to create asterisk_build_opts_all[] and ast_get_build_opts_all(void) * "core show settings" now shows both AST_BUILDOPTS and AST_BUILDOPTS_ALL. UserNote: The "Build Options" entry in the "core show settings" CLI command has been renamed to "ABI related Build Options" and a new entry named "All Build Options" has been added that shows both breaking and non-breaking options.	2 years ago
Naveen Albert	9e6266e008	pbx.c: Fix gcc 12 compiler warning. ... Resolves: #277	2 years ago
Maximilian Fridrich	48e6a482c2	main/refer.c: Fix double free in refer_data_destructor + potential leak ... Resolves: #267	2 years ago
Joshua C. Colp	a75035be55	manager: Tolerate stasis messages with no channel snapshot. ... In some cases I have yet to determine some stasis messages may be created without a channel snapshot. This change adds some tolerance to this scenario, preventing a crash from occurring.	2 years ago
Maximilian Fridrich	51a7b18038	core/ari/pjsip: Add refer mechanism ... This change adds support for refers that are not session based. It includes a refer implementation for the PJSIP technology which results in out-of-dialog REFERs being sent to a PJSIP endpoint. These can be triggered using the new ARI endpoint `/endpoints/refer`. Resolves: #71 UserNote: There is a new ARI endpoint `/endpoints/refer` for referring an endpoint to some URI or endpoint.	2 years ago
Joshua C. Colp	806515597e	audiohook: Unlock channel in mute if no audiohooks present. ... In the case where mute was called on a channel that had no audiohooks the code was not unlocking the channel, resulting in a deadlock. Resolves: #233	2 years ago
Mike Bradeen	a55fd5e471	utils: add lock timestamps for DEBUG_THREADS ... Adds last locked and unlocked timestamps as well as a counter for the number of times the lock has been attempted (vs locked/unlocked) to debug output printed using the DEBUG_THREADS option. Resolves: #110	2 years ago
Jaco Kroon	73326fb4e0	tcptls: when disabling a server port, we should set the accept_fd to -1. ... If we don't set this to -1 if the structure can be potentially re-used later then it's possible that we'll issue a close() on an unrelated file descriptor, breaking asterisk in other interesting ways. I believe this to be an unlikely scenario, but it costs nothing to be safe. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2 years ago
George Joseph	6b4f49c0df	build: Fix a few gcc 13 issues ... * gcc 13 is now catching when a function is declared as returning an enum but defined as returning an int or vice versa. Fixed a few in app.h, loader.c, stasis_message.c. * gcc 13 is also now (incorrectly) complaining of dangling pointers when assigning a pointer to a local char array to a char *. Had to change that to an ast_alloca. Resolves: #155	2 years ago
Ben Ford	cfde21c0c7	AMI: Add CoreShowChannelMap action. ... Adds a new AMI action (CoreShowChannelMap) that takes in a channel name and provides a list of all channels that are connected to that channel, following local channel connections as well. Resolves: #104 UserNote: New AMI action CoreShowChannelMap has been added.	2 years ago
Mike Bradeen	1f337f6034	indications: logging changes ... Increase verbosity to indicate failure due to missing country and to specify default on CLI dump Resolves: #89	2 years ago
Naveen Albert	8b864b12cf	callerid: Allow specifying timezone for date/time. ... The Caller ID generation routine currently is hardcoded to always use the system time zone. This makes it possible to optionally specify any TZ-format time zone. Resolves: #98 ASTERISK-30330	2 years ago
InterLinked1	ad6ff4cbf2	asterisk.c: Fix option warning for remote console. (#103) ... Commit 09e989f972 categorized the T option as not being compatible with remote consoles, but they do affect verbose messages with remote console. This fixes this. Resolves: #102	2 years ago
Sean Bright	d59a8ef59e	xml.c: Process XML Inclusions recursively. (#69) ... If processing an XInclude results in new <xi:include> elements, we need to run XInclude processing again. This continues until no replacement occurs or an error is encountered. There is a separate issue with dynamic strings (ast_str) that will be addressed separately. Resolves: #65	3 years ago
Mike Bradeen	cd48733353	cel: add local optimization begin event (#54) ... The current AST_CEL_LOCAL_OPTIMIZE event is and has been triggered on a local optimization end to serve as a flag indicating the event occurred. This change adds a second AST_CEL_LOCAL_OPTIMIZE_BEGIN event for further detail. Resolves: #52 UpgradeNote: The existing AST_CEL_LOCAL_OPTIMIZE can continue to be used as-is and the AST_CEL_LOCAL_OPTIMIZE_BEGIN event can be ignored if desired. UserNote: The new AST_CEL_LOCAL_OPTIMIZE_BEGIN can be used by itself or in conert with the existing AST_CEL_LOCAL_OPTIMIZE to book-end local channel optimizaion.	3 years ago
InterLinked1	ffb90c4549	say.c: Fix French time playback. (#42) ... ast_waitstream was not called after ast_streamfile, resulting in "o'clock" being skipped in French. Additionally, the minute announcements should be feminine. Reported-by: Danny Lloyd Resolves: #41 ASTERISK-30488	3 years ago
Naveen Albert	0119f3ad48	res_pjsip_stir_shaken: Fix JSON field ordering and disallowed TN characters. ... The current STIR/SHAKEN signing process is inconsistent with the RFCs in a couple ways that can cause interoperability issues. RFC8225 specifies that the keys must be ordered lexicographically, but currently the fields are simply ordered according to the order in which they were added to the JSON object, which is not compliant with the RFC and can cause issues with some carriers. To fix this, we now leverage libjansson's ability to dump a JSON object sorted by key value, yielding the correct field ordering. Additionally, telephone numbers must have any leading + prefix removed and must not contain characters outside of 0-9, *, and # in order to comply with the RFCs. Numbers are now properly formatted as such. ASTERISK-30407 #close Change-Id: Iab76d39447c4b8cf133de85657dba02fda07f9a2	3 years ago
George Joseph	1245e3330b	test.c: Fix counting of tests and add 2 new tests ... The unit test XML output was counting all registered tests as "run" even when only a subset were actually requested to be run and the "failures" attribute was missing. * The "tests" attribute of the "testsuite" element in the output XML now reflects only the tests actually requested to be executed instead of all the tests registered. * The "failures" attribute was added to the "testsuite" element. Also added 2 new unit tests that just pass and fail to be used for CI testing. Change-Id: Ia137814b5aeb0e1a44c75034bd3615c26021da69	3 years ago
Sean Bright	acd1513111	ael: Regenerate lexers and parsers. ... Various changes to ensure that the lexers and parsers can be correctly generated when REBUILD_PARSERS is enabled. Some notes: * Because of the version of flex we are using to generate the lexers (2.5.35) some post-processing in the Makefile is still required. * The generated lexers do not contain the problematic C99 check that was being replaced by the call to sed in the respective Makefiles so it was removed. * Since these files are generated, they will include trailing whitespace in some places. This does not need to be corrected. Change-Id: Ibbd343606fcf5c0d285b1599e6e8e59f514f2e4e	3 years ago
Sean Bright	7dc73c8151	loader.c: Minor module key check simplification. ... Change-Id: I65aefd4434a783096165c179b5f94f2e4810dffe	3 years ago
Mike Bradeen	edd7f1b060	bridge_builtin_features: add beep via touch variable ... Add periodic beep option to one-touch recording by setting the touch variable TOUCH_MONITOR_BEEP or TOUCH_MIXMONITOR_BEEP to the desired interval in seconds. If the interval is less than 5 seconds, a minimum of 5 seconds will be imposed. If the interval is set to an invalid value, it will default to 15 seconds. A new test event PERIODIC_HOOK_ENABLED was added to the func_periodic_hook hook_on function to indicate when a hook is started. This is so we can test that the touch variable starts the hook as expected. ASTERISK-30446 Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661	3 years ago