Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity
31881 Commits
140 Branches
1561 Tags
339 MiB
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '9d6161ee6a'
${ noResults }
Commit Graph

622 Commits (9d6161ee6a269a30fdcb157317eb1709a54bc101)

Author SHA1 Message Date
Steve Murphy 98429d37b2 Based on a note in asterisk-dev by Brian Capouch, I determined I too agressive in not initializing arrays passed to pbx_substitute_variables_xxxx; I reviewed the code (again) and hopefully found every possible spot where substitute_variables is called conditionally, and made sure the char array involved was set to a null string.
18 years ago
Steve Murphy a897556f7f This is the perhaps the biggest, boldest, most daring change I've ever committed to trunk. Forgive me in advance any disruption this may cause, and please, report any problems via the bugtracker. The upside is that this can speed up large dialplans by 20 times (or more). Context, extension, and priority matching are all fairly constant-time searches. I introduce here my hashtables (hashtabs), and a regression for them. I would have used the ast_obj2 tables, but mine are resizeable, and don't need the object destruction capability. The hashtab stuff is well tested and stable. I introduce a data structure, a trie, for extension pattern matching, in which knowledge of all patterns is accumulated, and all matches can be found via a single traversal of the tree. This is per-context. The trie is formed on the first lookup attempt, and stored in the context for future lookups. Destruction routines are in place for hashtabs and the pattern match trie. You can see the contents of the pattern match trie by using the 'dialplan show' cli command when 'core set debug' has been done to put it in debug mode. The pattern tree traversal only traverses those parts of the tree that are interesting. It uses a scoreboard sort of approach to find the best match. The speed of the traversal is more a function of the length of the pattern than the number of patterns in the tree. The tree also contains the CID matching patterns. See the source code comments for details on how everything works. I believe the approach general enough that any issues that might come up involving fine points in the pattern matching algorithm, can be solved by just tweaking things. We shall see. The current pattern matcher is fairly involved, and replicating every nuance of it is difficult. If you find and report problems, I will try to resolve than as quickly as I can. The trie and hashtabs are added to the existing context and exten structs, and none of the old machinery has been removed for the sake of the multitude of functions that use them. In the future, we can (maybe) weed out the linked lists and save some space.
18 years ago
Kevin P. Fleming edc78d6023 improve linked-list macros in two ways:
18 years ago
Joshua Colp f440f8ba48 Fix up some PBX logic that became broken. The code would exit prematurely when it should have been collecting more digits.
18 years ago
Mark Michelson 5a4867543d "show application <foo>" changes for clarity.
18 years ago
Russell Bryant 9bfd82cec2 Merged revisions 88805 via svnmerge from
18 years ago
Luigi Rizzo 08b10da53b Simplify the implementation and the API for stringfields;
18 years ago
Tilghman Lesher e8c781b215 Add pbx_lua as a method of doing extensions
18 years ago
Tilghman Lesher b5c2bcb169 'h' extension doesn't execute past first priority
18 years ago
Tilghman Lesher 90db1316ed Modify WaitExten to include an optional dialtone
18 years ago
Steve Murphy 63f2f04cf4 This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
18 years ago
Joshua Colp 284721fdb1 Drop any more references to type in the Exception dialplan function.
18 years ago
Tilghman Lesher b6ec350910 Optimize pbx_substitute_variables
18 years ago
Jason Parker e985a00a32 Update documentation to give an example of how to use the return status of RaiseException
18 years ago
Mark Michelson e0d13e169c The priority gets incremented after raising an exception, so the priority should be set to 0
18 years ago
Mark Michelson e5f87bbac3 Jumped the gun a bit in the RaiseException app. It would always return -1
18 years ago
Jason Parker ebe4050128 Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense
18 years ago
Jason Parker b0f3e6097e Convert NEW_CLI to AST_CLI.
18 years ago
Tilghman Lesher c0fcb59d38 Merged revisions 85356 via svnmerge from
18 years ago
Joshua Colp 094e9d8397 Don't register the exception function with module information. Since it is in the core there is none and it will explode.
18 years ago
Tilghman Lesher c2f7cc4bd4 Create a universal exception handling extension, "e" (closes issue #9785)
18 years ago
Tilghman Lesher 5139a2f6f7 Add MSet for people who prefer the old, deprecated syntax of Set (Closes issue #10549)
18 years ago
Jason Parker c7a9ec1691 (issue #10724)
18 years ago
Joshua Colp abe84c029f Merged revisions 82514 via svnmerge from
18 years ago
Mark Michelson 3a6e79ad80 Fixes Solaris build warnings
18 years ago
Joshua Colp 56e74f0dde (closes issue #10603)
18 years ago
Tilghman Lesher f8c93488d5 Fix documentation for Set (closes issue #10549)
18 years ago
Steve Murphy 9836efb5fb This commit closes bug 7605, and half-closes 7638. The AEL code has been redistributed/repartitioned to allow code re-use both inside and outside of Asterisk. This commit introduces the utils/conf2ael program, and an external config-file reader, for both normal config files, and for extensions.conf (context, exten, prio); It provides an API for programs outside of asterisk to use to play with the dialplan and config files.
18 years ago
Russell Bryant 668a334f85 Add another big set of doxygen documentation improvements from snuffy.
18 years ago
Joshua Colp 1e4bd7a192 Instead of adding the SOLARIS check to each HAVE_SYSINFO check let's just make the sysinfo autoconf logic a bit pickier about what it considers a usable sysinfo.
18 years ago
Joshua Colp a7aaa0bbc2 Solaris does not have a sysinfo like we know of on Linux.
18 years ago
Russell Bryant 4e0947c5f1 Convert code that checks the _softhangup member of ast_channel directory to use
18 years ago
Tilghman Lesher 55b1ee298e Merge the dialplan_aesthetics branch. Most of this patch simply converts applications
18 years ago
Russell Bryant f1f72312bb (closes issue #10192)
18 years ago
Tilghman Lesher 81bc1d7af5 Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second
18 years ago
Russell Bryant 9ffd55b6f9 Merged revisions 75403 via svnmerge from
18 years ago
Joshua Colp 344e6fd016 Change the function name slightly... just for kpfleming!
18 years ago
Joshua Colp e498488bde For my next trick I will make it so dialplan functions no longer need to call ast_module_user_add and ast_module_user_remove. These are now called in the ast_func_read and ast_func_write functions outside of the module.
18 years ago
Joshua Colp b8cd949cce Applications no longer need to call ast_module_user_add and ast_module_user_remove. This is now taken care of in the pbx_exec function outside of the application.
18 years ago
Steve Murphy 6a4efe5d5a In regards to changes for 9508, expr2 system choking on floating point numbers, I'm adding this update to round out (no pun intended) and make this FP-capable version of the Expr2 stuff interoperate better with previous integer-only usage, by providing Functions syntax, with 20 builtin functions for floating pt to integer conversions, and some general floating point math routines that might commonly be used also. Along with this, I made it so if a function was not a builtin, it will try and find it in the ast_custom_function list, and if found, execute it and collect the results. Thus, you can call system functions like CDR(), CHANNEL(), etc, from within $\[..\] exprs, without having to wrap them in $\{...\} (curly brace) notation. Did a valgrind on the standalone and made sure there's no mem leaks. Looks good. Updated the docs, too.
18 years ago
Russell Bryant d2a85e5f64 After some discussion on the asterisk-dev list, we determined that this approach
18 years ago
Russell Bryant 9aa28d2d3d Add "core dump funcdocs" CLI command
18 years ago
Russell Bryant f1468915c7 change the "core dump appdocs" CLI command to use the new API for creating
18 years ago
Tilghman Lesher 396a37eba8 Fix trunk brokenness; also, optimize application registration
18 years ago
Steve Murphy 2462d5ab4f Cleaning up a small disaster I created earlier
18 years ago
Russell Bryant b179e2155f Convert uses of strdup() to ast_strdup()
18 years ago
Kevin P. Fleming 5fdba27ea2 Merged revisions 69392 via svnmerge from
18 years ago
Jason Parker 63535ada60 Fixes for ast_strlen_zero() janitor project.
18 years ago
Russell Bryant ff4fc97911 Convert pbx.c to use ast_debug() for debug logging.
18 years ago
Russell Bryant 334d8d9dc4 Add channel variable manager event
18 years ago
Tilghman Lesher 9d05ff8ed5 Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes
18 years ago
Russell Bryant b1490716f6 remove a bogus comment that came from copy/paste
18 years ago
Russell Bryant 605368649e Merge major changes to the way device state is passed around Asterisk. The two
18 years ago
Russell Bryant 4b3a3fb14c Add a new API call for creating detached threads. Then, go replace all of the
18 years ago
Steve Murphy a76ff39c0e Merged revisions 64193 via svnmerge from
18 years ago
Steve Murphy 8e90622210 Merged revisions 62738 via svnmerge from
18 years ago
Steve Murphy fe7068a51b Merged revisions 62689 via svnmerge from
18 years ago
Russell Bryant ec0cae93a4 Merged revisions 62171 via svnmerge from
18 years ago
Russell Bryant 0c9ef3221c Merged revisions 61765 via svnmerge from
18 years ago
Dwayne M. Hubbard 2151e532fe changed #if HAVE_SYSINFO to #if defined(HAVE_SYSINFO)
18 years ago
Dwayne M. Hubbard 6a5f3599bb added HAVE_SYSINFO preprocessor directives for portability and general happiness
18 years ago
Dwayne M. Hubbard 62256ee410 added option_minmemfree for use in asterisk.conf to specify the amount of minimum free memory prior to accepting calls. added CLI 'core show sysinfo' to display system information
18 years ago
Steve Murphy ecaf781933 Merged revisions 60989 via svnmerge from
18 years ago
Steve Murphy 09c0d56c5c Merged revisions 59522 via svnmerge from
18 years ago
Steve Murphy 0f11d3c8c3 Merged revisions 59486 via svnmerge from
18 years ago
Tilghman Lesher 433a7a721c Merged revisions 58946 via svnmerge from
18 years ago
Tilghman Lesher 8c4c5d9910 Fix trunk so that it compiles again
18 years ago
Russell Bryant 1cf3a12047 Merged revisions 58931 via svnmerge from
18 years ago
Steve Murphy 96fe5e2286 Merged revisions 57826 via svnmerge from
18 years ago
Joshua Colp 96693aca99 Don't try to do recursive locking/unlocking when it isn't supported.
18 years ago
Steve Murphy 1220306aab Merged revisions 57473 via svnmerge from
18 years ago
Joshua Colp 5bc0d8d324 Minor code cleanup... nothing to write home about.
18 years ago
Joshua Colp e7b03a991e Convert the PBX core to use read/write locks. This yields a nifty performance improvement when it comes to simultaneous calls going through the dialplan. Using murf's test the old mutex based core took an average of 57.3 seconds while the rwlock based core took 31.1 seconds. That's a nifty 26.2 seconds performance improvement. The other good part is that if we do need to switch back then we just have to change the lock/unlock API calls. I converted everywhere that used to touch the mutex locks directly to use them.
18 years ago
Steve Murphy 462f759e67 Merged revisions 57139 via svnmerge from
18 years ago
Joshua Colp 9577a1c65a Merged revisions 56805 via svnmerge from
18 years ago
Tilghman Lesher e5304e54cc Merged revisions 53070 via svnmerge from
19 years ago
Russell Bryant b233892198 Merged revisions 53046 via svnmerge from
19 years ago
Joshua Colp 21b53af31d Cosmetic changes. Make main source files better conform to coding guidelines and standards. (issue #8679 reported by johann8384)
19 years ago
Tilghman Lesher f7dd25f20c Fix bug introduced during constification (reported by tzanger via IRC)
19 years ago
Jason Parker 5d25265403 Merged revisions 51265 via svnmerge from
19 years ago
Kevin P. Fleming 17ea9c930e make the automatic post-answer delay happen only when the answer is 'automatic' (not done by the Answer() dialplan application)
19 years ago
Kevin P. Fleming aa3eea042d Merged revisions 50562 via svnmerge from
19 years ago
Joshua Colp fd06f29945 Merged revisions 50266 via svnmerge from
19 years ago
Jason Parker 5abda34cd9 Merged revisions 49742 via svnmerge from
19 years ago
Kevin P. Fleming cd73a483f1 const-ify some more APIs, and fix rev 49710 from branch-1.4 in a better way here
19 years ago
Kevin P. Fleming 87b9abc892 Merged revisions 49676 via svnmerge from
19 years ago
Kevin P. Fleming adca0ff14b Merged revisions 49006 via svnmerge from
19 years ago
Joshua Colp 77d7b36217 Switch list of global variables to read/write locks.
19 years ago
Joshua Colp 730d68976e Convert alternate dialplan switch list to use read/write locks.
19 years ago
Luigi Rizzo ccebf3511c convert the final clients of ast_build_string to use ast_str_*()
19 years ago
Luigi Rizzo 5ba11f9855 remove the macro LOAD_OH and expand it inline in the only
19 years ago
Luigi Rizzo dd9d56b4c3 make sure that showdialplan sends only one
19 years ago
Luigi Rizzo efbfd6ce65 clean up function manager_show_dialplan_helper()
19 years ago
Olle Johansson 446a06679a Documentation updates
19 years ago
Olle Johansson 3fd07f51f2 Doxygen update
19 years ago
Joshua Colp 0efd51e1d2 This should already be called while locked.
19 years ago
Joshua Colp c5780b19c8 Display CID matching information when using dialplan show. (issue #8279 reported by caio1982)
19 years ago
Steve Murphy 908f176cf3 A fair number of changes for the sake of bug 7506
19 years ago
Tilghman Lesher 10875731ec Merged revisions 47051 via svnmerge from
19 years ago
Joshua Colp 7f7f2fe821 Let's make application/function/hint lists read/write lists... just for kicks
19 years ago
Olle Johansson 692dc8fd80 Issue #3930 - Add manager command for listing dialplan (coded april 2005, in bugtracker since)
19 years ago
Russell Bryant 0ca6a42d7e fix various spelling mistakes in comments (issue #8237, jmls)
19 years ago
Steve Murphy 3d323f5345 As per ToDo list, I have made it so that Wait(), WaitExten(), Congestion(), Busy(), Read(), WaitForRing(), will now either actually handle a floating point argument as advertised, or has been upgraded to accept a floating point [timeout] arg.
19 years ago
Matt O'Gorman ae8cc3e18b bug #8076 check option_debug before printing to debug channel.
19 years ago
Joshua Colp 0dbe81383f Cache the application pointer so we don't have to needlessly search for it over and over. This should yield a suitable performance increase.
19 years ago
Jason Parker 47abf96957 Add BACKGROUNDSTATUS to Background()
19 years ago
Jason Parker 5a45352f3a Merged revisions 43803 via svnmerge from
19 years ago
Tilghman Lesher 2b55678e1f Remove deprecated CLI apps from the core
19 years ago
Tilghman Lesher 4a58847fe2 Remove 1.4 changes from UPGRADE.txt, remove deprecated callerid field, remove deprecated SetGlobalVar app
19 years ago
Matt O'Gorman d0a1a0033d similar patch for verbose vs debug with minor changes
19 years ago
Kevin P. Fleming fcb999c01c merge qwell's CLI verbification work
19 years ago
Kevin P. Fleming c2c4f86c72 merge markster's usersconf branch with some slight changes
19 years ago
BJ Weschke ffd9281db9 Provide a little more protection to make sure that a MOH class is specified when using the 'm' option with WaitExten, and prevent a segfault in the process.
19 years ago
BJ Weschke bbc9c049ab Fix enum indexing problem with m() in WaitExten. Reported by Pavel J, in asterisk-dev.
19 years ago
Steve Murphy a845587805 Another formatting update for PCadach.
19 years ago
Steve Murphy 2ff2b02eae PCadach wanted better formatting of those 'if' conditions for 7859.
19 years ago
Steve Murphy cd8635b9b5 This small tweek will hopefully fix 7859, and silence all possible others
19 years ago
Kevin P. Fleming b281acf0f8 change default setting for autofallthrough
19 years ago
Steve Murphy 299465336a This change fixes bug 7820. Way back in April this bug was reintroduced, it appears, when a bunch of restructuring was done. This code was basically left out during the restructuring. In the case of the failure in 7820, it is trying to match the extension _x. with _x., and failing, because the 'x' should only match 0 thru 9. I **could** upgrade the code so that that N,Z, and X match not only their intended number ranges, but also N,Z,and X respectively. And, moreover, X could also match N and Z, and Z could also match N. I have no idea why this bug took so long to turn up. I have no idea what a more thorough treatment of the code would do to working code, either. So I left it as it ***was***.
19 years ago
Russell Bryant 1ff5a0988d Merged revisions 40994 via svnmerge from
19 years ago
Kevin P. Fleming ca0a1d3842 don't initialize global variables list twice
19 years ago
Kevin P. Fleming 0a27d8bfe5 merge new_loader_completion branch, including (at least):
19 years ago