677 Commits (9aa3d2dd7ff0953d87840e5d0873404caa95186f)

Author	SHA1	Message	Date
Russell Bryant	b11422fe8f	Don't pass an empty string as the device name. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96644 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	8770045be8	Fix the problem of notification of a device state change to a device with a '-' ... in the name. Could probably do with a better fix in trunk, but this bug has been open way too long without a better solution. Reported by: stevedavies Patch by: tilghman (Closes issue #9668) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96575 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	8fded490ce	Avoiding a potentially bad locking situation. ast_merge_contexts_and_delete writelocks the conlock, then ... calls ast_hint_extension, which attempts to readlock the same lock. Recursion with read-write locks is dangerous, so the inner lock needs to be removed. I did this by copying the "guts" of ast_hint_extension into ast_merge_contexts_and_delete (sans the extra lock). (this change is inspired by the locking problems seen in issue #11080, but I have no idea if this is the problematic area experienced by the reporters of that issue) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95577 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	8b3f41409e	Don't report a syntax error when an empty string is passed to ast_get_group. ... Just return 0. (closes issue #11540) Reported by: tzafrir Patches: group_empty.diff uploaded by tzafrir (license 46) -- slightly changed by me git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95024 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	5dc1371bf2	Fixing a typo in a comment. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94977 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c03ccc41f2	Now that the contexts lock is a read/write lock, it should not be locked here ... in ast_hint_state_changed(). This makes it get locked recursively which now causes a deadlock. (closes issue #11080, thanks to callguy for the access to a deadlocked machine) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94831 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	67df6e008d	Use the constant that I really meant to use here ... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94829 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c792659cc7	Change ast_translator_best_choice() to only pay attention to audio formats. ... This fixes a problem where Asterisk claims that a translation path can not be found for channels involving video. (closes issue #11638) Reported by: cwhuang Tested by: cwhuang Patch suggested by cwhuang, with some additional changes by me. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94828 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	eb4d447b78	make this comment explain the situation in an even more explicit fashion ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94824 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	3c3eb75062	Workaround for what is probably a glibc bug (but we'll see this crop up again ... and again, if we don't add the workaround). Reported by: rolek Patch by: tilghman (Closes issue #11601, closes issue #11426) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94808 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e6a8750fe7	Just in case the AST_FLAG_END_DTMF_ONLY flag was already set before starting ... autoservice, remember it and ensure that the channel has the same setting when autoservice gets stopped. (pointed out by d1mas, patched up by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94801 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	52df524ba0	When a channel is in autoservice, mark a flag on the channel that says that ... we only care about the END of a digit. That way, no magic digit emulation stuff will happen when all we're doing is queueing up END frames. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94797 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1deba2c9ed	Don't store DTMF BEGIN frames while a channel is in autoservice. It's just ... going to make ast_read() do a lot of extra work when the channel comes back out of autoservice. (closes issue #11628, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94790 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	540077b7b1	Race: we need to wait to queue a NewChannel event until after the channel is ... inserted into the channel list. The reason is because some manager users immediately queue requests from the channel when they see that event and are confused when Asterisk reports no such channel. (Closes issue #11632) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94767 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	8c7948fd44	Since we are freeing list elements within a list traversal, we need to use the safe ... traversal and remove the item from the list before freeing it. (closes issue 11612, reported by dtyoo) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94468 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5977f8d5be	Convert the contexts lock to a read/write lock to resolve a deadlock. This ... has a nice side benefit of improving performance. :) (closes issue #11609) (closes issue #11080) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94466 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	eac09a0cd0	Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup. ... (closes issue #11599, reported and patched by caio1982, coding guidelines cleanup by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94420 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	2f24e1b1bf	Fix for restart-as-user problem reported via the -dev list ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@94418 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	62fa8dfbfa	Rework deadlock avoidance used in ast_write, since it meant that agent channels which were being monitored ... had one audio file recorded and one empty audio file saved. (closes issue #11529, reported by atis patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@93625 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	6fa23de8ac	Missed a spot.. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@93420 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	7e7db434e4	What was I thinking when I wrote this masterpiece? ... -1 + 1 = 0.. who woulda thunk it?. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@93381 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0a584613d6	Do not try to access information about a lock when printing out a trylock attempt. It is possible for the lock that it references to no longer be valid. This would have caused segfaults or deadlocks. ... (issue #BE-263) (closes issue #11080) Reported by: callguy (closes issue #11100) Reported by: callguy git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@93377 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4965b39719	There are a lot of existing systems that #include non-existent files. So, to ... make the transition to treating this as an error a bit less painless, just issue a huge error message for now. Then, later, we can reinstate the code that treats it as a failure. (Thanks to philippel for the feedback) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@93000 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	65cbfa5d0d	Make application help text a little more clear about the use of extensions in a filename. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@92809 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	8771f23fff	If a typo is found in a config file, we previous continued on with what was already loaded. ... We do not want to do this (see bug below for details). This makes it so that if a [ is found without a ], the entire config will fail, and nothing in it will be loaded. Isue #10690. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@92696 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	7a1b94082c	Fix potential memory leak with the dialed interfaces list if another memory allocation fails. ... (closes issue #11507) Reported by: eliel Patches: global_datastores.c.patch uploaded by eliel (license 64) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@92363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	bff4a0aa3c	Add G729A as another possible payload name for G729. Some devices use this instead of G729, which is perfectly normal since the payload number itself is defined and can't be used by anything else so the name doesn't matter that much. ... (closes issue #11483) Reported by: revolution Patches: rtp.diff uploaded by revolution (license 346) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@92204 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	16a03298e9	We need to make sure we free the input frame if we return a different frame in ast_dsp_process. ... Issue 11273, pointed out by dimas, with a patch by eliel. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91890 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b5463cd8d3	Make the lock protecting each thread's list of locks it currently holds ... recursive. I think that this will fix the situation where some people have said that "core show locks" locks up the CLI. (related to issue #11080) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91830 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ab117fecaa	* Add a bit more of a verbose comment as to why a hangup frame needs to be ... queued up if autoservice gets a NULL return from ast_read(). * Make the process of queueing the hangup frame more efficient by putting the frame where it is going to end up and avoiding some locking and extra memory allocations and freeing. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91777 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	9dbdc103b0	Hangups that happen during autoservice were not processed appropriately. This is ... because a hangup actually causes a NULL frame to be received, not a hangup frame. Queueing a hangup if we receive a NULL frame during autoservice corrects this problem (closes issue #11467, reported by jmls, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91737 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	af01697791	At the end of a call, when we're reporting, RTCP may already be partially torn down, so check for NULL dereference ... Reported by: blitzrage Patch by: tilghman (Closes issue #11450) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91637 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	0522e3d872	Add a new module flag to indicate that a build sum is present. Modules built ... against older Asterisk 1.4 headers will now load properly with just a warning indicating that they are old and may cause problems. (patch by paravoid) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91501 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	6af6d06e75	Fix various in the udptl implementation. It could return empty modem frames, have an incorrect sequence number on packets, and display the wrong sequence number in the debug messages. ... (closes issue #11228) Reported by: Cache Patches: udptl-4.patch uploaded by dimas (license 88) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91450 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	95dce3bbba	Make sure logger is reloaded at general reload in the cli. ... (Discovered during Asterisk training in Portugal) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91366 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a4137c3fbe	Make the lock in the threadstorage debugging code untracked to avoid a deadlock ... on thread destruction. (closes issue #11207) Reported by: ys Patches: threadstorage.c.diff uploaded by ys (license 281) Also fixes an open bug report: (closes issue #11446) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91192 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	82257a7e33	When DEBUG_THREADS is enabled, we only have the details about who is holding ... a lock that we are waiting on for a mutex, not rwlocks. This should fix the problem where people have reported "core show locks" crashing sometimes. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91074 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	644c7a89e7	Make some changes to some additions I made recently for doing channel autoservice ... when looking up extensions. This code was added to handle the case where a dialplan switch was in use that could block for a long time. However, the way that I added it, it did this for all extension lookups. However, lookups in the in-memory tree of extensions should _not_ take long enough to matter. So, move the autoservice stuff to be only around executing a switch. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90967 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	5376122015	If we fail to create a channel after allocating a timing fd, we need to make sure to close it. ... Issue 11454, patch by eliel. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90876 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7b052b78e1	A big one... ... This is the merge of the forward-loop branch. The main change here is that call-forwards can no longer loop. This is accomplished by creating a datastore on the calling channel which has a linked list of all devices dialed. If a forward happens, then the local channel which is created inherits the datastore. If, through this progression of forwards and datastore inheritance, a device is attempted to be dialed a second time, it will simply be skipped and a warning message will be printed to the CLI. After the dialing has been completed, the datastore is detached from the channel and destroyed. This change also introduces some side effects to the code which I shall enumerate here: 1. Datastore inheritance has been backported from trunk into 1.4 2. A large chunk of code has been removed from app_dial. This chunk is the section of code which handles the call forward case after the channel has been requested but before it has been called. This was removed because call-forwarding still works fine without it, it makes the code less error-prone should it need changing, and it made this set of changes much less painful to just have the forwarding handled in one place in each module. 3. Two new files, global_datastores.h and .c have been added. These are necessary since the datastore which is attached to the channel may be created and attached in either app_dial or app_queue, so they need a common place to find the datastore info. This approach was taken in case similar datastores are needed in the future, there will be a common place to add them. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90735 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	bae731053f	Do not create a smoother for G723.1 frames, they need to be left alone to their native 20/24 byte size. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90588 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	b18d1bdd1a	Preserve the indication currently playing on a channel when a masquerade operation happens. (issue #BE-88) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90548 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	763b1ccecc	Clarify the return value on autoservice. Specifically, if you started ... autoservice and autoservice was already on, it would erroneously return an error. Reported by: adiemus Patch by: dimas (Closes issue #11433) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90432 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1f8caa100d	Change the behavior of ao2_link(). Previously, in inherited a reference. ... Now, it automatically increases the reference count to reflect the reference that is now held by the container. This was done to be more consistent with ao2_unlink(), which automatically releases the reference held by the container. It also makes it so it is no longer possible for a pointer to be invalid after ao2_link() returns. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90348 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	2c11f7d18e	Use of "private" as a field name in a header file messes with C++ projects ... Reported by: chewbacca Patch by: casper (Closes issue #11401) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90155 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	2fc83c3db1	This set of changes is to make some callerID handling thread-safe. ... The ast_set_callerid() function needed to lock the channel. Also, the handlers for the CALLERID() dialplan function needed to lock the channel when reading or writing callerid values directly on the channel structure. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90145 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1380790b60	Merge a change from team/russell/chan_refcount ... ... This makes ast_stopstream() thread-safe. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90142 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	fc5429da7c	it is impossible to set permissions for manager accounts created by users.conf (reported internally, patched by me) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90098 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	815d77f1f6	Removing some seemingly pointless code. This sets a channel variable for every priority ... executed in the dialplan if you have debug set to anything non-zero. This seems pointless due to the fact that these channel variables are not referenced anywhere else in the code and their names are esoteric enough that they would not be practical to reference in the dialplan. Plus the fact that this behavior isn't documented anywhere means that the change is not likely to cause any disruption. If anything, this may actually cause a slight performance increase if running with debug on. The motivating influence for this code change is the eventwhencalled option for queues. If set to vars, all channel variables will be output to the manager. These unnecessary channel variables make the output a lot more difficult to deal with. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90059 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d0cd120d47	- update documentation for some of the goto functions to note that they ... handle locking the channel as needed - update ast_explicit_goto() to lock the channel as needed git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89893 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago